irqchip: Add support for Tango interrupt controller
RFC PATCH v2 1/1 irqchip: Add support for Tango interrupt controller
From: Mans Rullgard <[email protected]>
Add support for the interrupt controller used in Sigma Designs SMP86xx (Tango3) and SMP87xx (Tango4) chips.
---
For the arch/arm/mach-tango port, I'm using this driver written by Mans. Version 1 of the patch was submitted two months ago:
http://thread.gmane.org/gmane.linux.kernel/2089471
I've tried to address Marc's remarks.
I kept Mans as the commit author, but I removed his Signed-off-by (because I might have introduced errors that he didn't sign off on). Is that the right thing to do?
I didn't rename tangox to tango inside irq-tango.c because I didn't want to change the code too much, but I'm OK either way.
The matching DT description currently is
intc: interrupt-controller at 6e000 {
compatible = "sigma,smp8642-intc";
reg = <0x6e000 0x400>;
ranges = <0 0x6e000 0x400>;
interrupt-parent = <&gic>;
interrupt-controller;
#address-cells = <1>;
#size-cells = <1>;
irq0: irq0 at 000 {
reg = <0x000 0x100>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
};
irq1: irq1 at 100 {
reg = <0x100 0x100>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
};
irq2: irq2 at 300 {
reg = <0x300 0x100>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
};
};--- drivers/irqchip/Kconfig | 5 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-tango.c | 227 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 233 insertions(+) create mode 100644 drivers/irqchip/irq-tango.c
drivers/irqchip/Kconfig +5 -0
@@ -133,6 +133,11 @@ config ST_IRQCHIP help Enables SysCfg Controlled IRQs on STi based platforms. +config TANGO_IRQ + bool + select IRQ_DOMAIN + select GENERIC_IRQ_CHIP + config TB10X_IRQC bool select IRQ_DOMAIN
drivers/irqchip/Makefile +1 -0
@@ -38,6 +38,7 @@ obj-$(CONFIG_VERSATILE_FPGA_IRQ) += irq-versatile-fpga.o obj-$(CONFIG_ARCH_NSPIRE) += irq-zevio.o obj-$(CONFIG_ARCH_VT8500) += irq-vt8500.o obj-$(CONFIG_ST_IRQCHIP) += irq-st.o +obj-$(CONFIG_TANGO_IRQ) += irq-tango.o obj-$(CONFIG_TB10X_IRQC) += irq-tb10x.o obj-$(CONFIG_XTENSA) += irq-xtensa-pic.o obj-$(CONFIG_XTENSA_MX) += irq-xtensa-mx.o
drivers/irqchip/irq-tango.c new file +227 -0
227 lines not on this page · raw message
drivers/irqchip/irq-tango.c line 194
Quoted 6 lines · Marc Gonzalez
drivers/irqchip/irq-tango.c new file +6
-0+if (of_property_read_u32 (node,"reg" , &ctl)) +panic ("%s: failed to get reg base" , node->name); + + chip =kzalloc (sizeof (*chip),GFP_KERNEL ); + chip->ctl = ctl; + chip->base = base;
I think it might be better to let the OF core convert the "reg" property to a struct resource, then get the offset by subtracting from the base (physical) address. Otherwise it will break badly if someone thinks it's safe to drop "ranges" from the outer node and use absolute addresses in the child nodes (that's how the "reg" property typically behaves).
Anyway, thanks for revisiting this. I never got a straight answer (or any answer for that matter) when I asked which approach would be preferred, and then I had better things to do than keep trying patches until people got happy.
Signature · 1 line
M?ns Rullg?rd
Quoted 5 lines · Marc Gonzalez
For the
arch/arm/mach-tangoport, I'm using this driver written by Mans. Version 1 of the patch was submitted two months ago:
http://thread.gmane.org/gmane.linux.kernel/2089471I've tried to address Marc Zyngier's remarks.
And my patch is incomplete, v3 coming right up.
drivers/irqchip/irq-tango.c: In function 'tangox_irq_init':drivers/irqchip/irq-tango.c:183:6: warning: unused variable 'i' [-Wunused-variable]
int i;
^
drivers/irqchip/irq-tango.c: In function 'tangox_of_irq_init':
drivers/irqchip/irq-tango.c:200:6: warning: 'name' may be used uninitialized in this function [-Wmaybe-uninitialized]
err = irq_alloc_domain_generic_chips(dom, 32, 2, name, handle_level_irq,
^
drivers/irqchip/irq-tango.c:179:14: note: 'name' was declared here
const char *name;
^Regards.
RFC PATCH v3 1/1 irqchip: Add support for Tango interrupt controller
From: Mans Rullgard <[email protected]>
Add support for the interrupt controller used in Sigma Designs SMP86xx (Tango3) and SMP87xx (Tango4) chips.
---
For the arch/arm/mach-tango port, I'm using this driver written by Mans. Version 1 of the patch was submitted two months ago:
http://thread.gmane.org/gmane.linux.kernel/2089471
I've tried to address Marc Zyngier's remarks.
I kept Mans as the commit author, but I removed his Signed-off-by (because I might have introduced errors that he didn't sign off on). Is that the right thing to do?
I didn't rename tangox to tango inside irq-tango.c because I didn't want to change the code too much, but I'm OK either way.
The matching DT description currently is
intc: interrupt-controller at 6e000 {
compatible = "sigma,smp8642-intc";
reg = <0x6e000 0x400>;
ranges = <0 0x6e000 0x400>;
interrupt-parent = <&gic>;
interrupt-controller;
#address-cells = <1>;
#size-cells = <1>;
irq0: irq0 at 000 {
reg = <0x000 0x100>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
};
irq1: irq1 at 100 {
reg = <0x100 0x100>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
};
irq2: irq2 at 300 {
reg = <0x300 0x100>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
};
};--- drivers/irqchip/Kconfig | 5 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-tango.c | 225 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 231 insertions(+) create mode 100644 drivers/irqchip/irq-tango.c
drivers/irqchip/Kconfig +5 -0
@@ -133,6 +133,11 @@ config ST_IRQCHIP help Enables SysCfg Controlled IRQs on STi based platforms. +config TANGO_IRQ + bool + select IRQ_DOMAIN + select GENERIC_IRQ_CHIP + config TB10X_IRQC bool select IRQ_DOMAIN
drivers/irqchip/Makefile +1 -0
@@ -38,6 +38,7 @@ obj-$(CONFIG_VERSATILE_FPGA_IRQ) += irq-versatile-fpga.o obj-$(CONFIG_ARCH_NSPIRE) += irq-zevio.o obj-$(CONFIG_ARCH_VT8500) += irq-vt8500.o obj-$(CONFIG_ST_IRQCHIP) += irq-st.o +obj-$(CONFIG_TANGO_IRQ) += irq-tango.o obj-$(CONFIG_TB10X_IRQC) += irq-tb10x.o obj-$(CONFIG_XTENSA) += irq-xtensa-pic.o obj-$(CONFIG_XTENSA_MX) += irq-xtensa-mx.o
drivers/irqchip/irq-tango.c new file +225 -0
225 lines not on this page · raw message
Quoted 310 lines · Marc Gonzalez
From: Mans Rullgard <[email protected]>
Add support for the interrupt controller used in Sigma Designs SMP86xx (Tango3) and SMP87xx (Tango4) chips.
Signed-off-by Marc Gonzalez <[email protected]>---
For thearch/arm/mach-tangoport, I'm using this driver written by Mans. Version 1 of the patch was submitted two months ago:
http://thread.gmane.org/gmane.linux.kernel/2089471I've tried to address Marc Zyngier's remarks.
I kept Mans as the commit author, but I removed his Signed-off-by (because I might have introduced errors that he didn't sign off on). Is that the right thing to do?
I didn't rename tangox to tango inside
irq-tango.cbecause I didn't want to change the code too much, but I'm OK either way.The matching DT description currently is
intc: interrupt-controller at 6e000 { compatible = "sigma,smp8642-intc"; reg = <0x6e000 0x400>; ranges = <0 0x6e000 0x400>; interrupt-parent = <&gic>; interrupt-controller; #address-cells = <1>; #size-cells = <1>; irq0: irq0 at 000 { reg = <0x000 0x100>; interrupt-controller; #interrupt-cells = <2>; interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; }; irq1: irq1 at 100 { reg = <0x100 0x100>; interrupt-controller; #interrupt-cells = <2>; interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>; }; irq2: irq2 at 300 { reg = <0x300 0x100>; interrupt-controller; #interrupt-cells = <2>; interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>; }; };--- drivers/irqchip/Kconfig | 5 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-tango.c | 225 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 231 insertions(+) create mode 100644 drivers/irqchip/irq-tango.cdrivers/irqchip/Kconfig +5
-0@@ -133,6 +133,11 @@ config ST_IRQCHIP help Enables SysCfg Controlled IRQs on STi based platforms. +config TANGO_IRQ + bool + select IRQ_DOMAIN + select GENERIC_IRQ_CHIP + config TB10X_IRQC bool select IRQ_DOMAINdrivers/irqchip/Makefile +1
-0@@ -38,6 +38,7 @@ obj-$(CONFIG_VERSATILE_FPGA_IRQ) += irq-versatile-fpga.o obj-$(CONFIG_ARCH_NSPIRE) += irq-zevio.o obj-$(CONFIG_ARCH_VT8500) += irq-vt8500.o obj-$(CONFIG_ST_IRQCHIP) += irq-st.o +obj-$(CONFIG_TANGO_IRQ) += irq-tango.o obj-$(CONFIG_TB10X_IRQC) += irq-tb10x.o obj-$(CONFIG_XTENSA) += irq-xtensa-pic.o obj-$(CONFIG_XTENSA_MX) += irq-xtensa-mx.odrivers/irqchip/irq-tango.c new file +215
-0@@ -0,0 +1,225 @@ +/* +* Copyright (C) 2014 Mans Rullgard <[email protected]> +* +* This program is free software; you can redistribute it and/or modify it +* under the terms of the GNU General Public License as published by the +* Free Software Foundation; either version 2 of the License, or (at your +* option) any later version. +*/ + +#include <linux/init.h> +#include <linux/irq.h> +#include <linux/irqchip.h> +#include <linux/irqchip/chained_irq.h> +#include <linux/ioport.h> +#include <linux/io.h> +#include <linux/of_address.h> +#include <linux/of_irq.h> +#include <linux/slab.h> + +#define IRQ0_CTL_BASE 0x0000 +#define IRQ1_CTL_BASE 0x0100 +#define EDGE_CTL_BASE 0x0200 +#define IRQ2_CTL_BASE 0x0300 + +#define IRQ_CTL_HI 0x18 +#define EDGE_CTL_HI 0x20 + +#define IRQ_STATUS 0x00 +#define IRQ_RAWSTAT 0x04 +#define IRQ_EN_SET 0x08 +#define IRQ_EN_CLR 0x0c +#define IRQ_SOFT_SET 0x10 +#define IRQ_SOFT_CLR 0x14 + +#define EDGE_STATUS 0x00 +#define EDGE_RAWSTAT 0x04 +#define EDGE_CFG_RISE 0x08 +#define EDGE_CFG_FALL 0x0c +#define EDGE_CFG_RISE_SET 0x10 +#define EDGE_CFG_RISE_CLR 0x14 +#define EDGE_CFG_FALL_SET 0x18 +#define EDGE_CFG_FALL_CLR 0x1c + +struct tangox_irq_chip { +void __iomem *base; +unsigned long ctl; +}; + +static inline u32 intc_readl (struct tangox_irq_chip *chip,int reg) +{ +return readl_relaxed (chip->base + reg); +} + +static inline void intc_writel (struct tangox_irq_chip *chip,int reg,u32 val) +{ +writel_relaxed (val, chip->base + reg); +} + +static void tangox_dispatch_irqs (struct irq_domain *dom,unsigned int status, +int base) +{ +unsigned int hwirq; +unsigned int virq; + +while (status) { + hwirq =__ffs (status); + virq =irq_find_mapping (dom, base + hwirq); +if (virq)generic_handle_irq (virq); + status &= ~BIT (hwirq); + } +} + +static void tangox_irq_handler (struct irq_desc *desc) +{ +struct irq_domain *dom =irq_desc_get_handler_data (desc); +struct irq_chip *host_chip =irq_desc_get_chip (desc); +struct tangox_irq_chip *chip = dom->host_data; +unsigned int status_lo, status_hi; + +chained_irq_enter (host_chip, desc); + + status_lo =intc_readl (chip, chip->ctl +IRQ_STATUS ); + status_hi =intc_readl (chip, chip->ctl +IRQ_CTL_HI +IRQ_STATUS ); + +tangox_dispatch_irqs (dom, status_lo,0 ); +tangox_dispatch_irqs (dom, status_hi,32 ); + +chained_irq_exit (host_chip, desc); +} + +static int tangox_irq_set_type (struct irq_data *d,unsigned int flow_type) +{ +struct irq_chip_generic *gc =irq_data_get_irq_chip_data (d); +struct tangox_irq_chip *chip = gc->domain->host_data; +struct irq_chip_regs *regs = &gc->chip_types[0 ].regs; + +switch (flow_type &IRQ_TYPE_SENSE_MASK ) { +case IRQ_TYPE_EDGE_RISING : +intc_writel (chip, regs->type +EDGE_CFG_RISE_SET , d->mask); +intc_writel (chip, regs->type +EDGE_CFG_FALL_CLR , d->mask); +break ; + +case IRQ_TYPE_EDGE_FALLING : +intc_writel (chip, regs->type +EDGE_CFG_RISE_CLR , d->mask); +intc_writel (chip, regs->type +EDGE_CFG_FALL_SET , d->mask); +break ; + +case IRQ_TYPE_LEVEL_HIGH : +intc_writel (chip, regs->type +EDGE_CFG_RISE_CLR , d->mask); +intc_writel (chip, regs->type +EDGE_CFG_FALL_CLR , d->mask); +break ; + +case IRQ_TYPE_LEVEL_LOW : +intc_writel (chip, regs->type +EDGE_CFG_RISE_SET , d->mask); +intc_writel (chip, regs->type +EDGE_CFG_FALL_SET , d->mask); +break ; + +default : +pr_err ("Invalid trigger mode %x for IRQ %d\n" , + flow_type, d->irq); +return -EINVAL ; + } + +return irq_setup_alt_chip (d, flow_type); +} + +static void __init tangox_irq_init_chip (struct irq_chip_generic *gc, +unsigned long ctl_offs, +unsigned long edge_offs) +{ +struct tangox_irq_chip *chip = gc->domain->host_data; +struct irq_chip_type *ct = gc->chip_types; +unsigned long ctl_base = chip->ctl + ctl_offs; +unsigned long edge_base =EDGE_CTL_BASE + edge_offs; +int i; + + gc->reg_base = chip->base; + gc->unused =0 ; + +for (i =0 ; i <2 ; i++) { + ct[i].chip.irq_ack = irq_gc_ack_set_bit; + ct[i].chip.irq_mask = irq_gc_mask_disable_reg; + ct[i].chip.irq_mask_ack = irq_gc_mask_disable_reg_and_ack; + ct[i].chip.irq_unmask = irq_gc_unmask_enable_reg; + ct[i].chip.irq_set_type = tangox_irq_set_type; + ct[i].chip.name = gc->domain->name; + + ct[i].regs.enable = ctl_base +IRQ_EN_SET ; + ct[i].regs.disable = ctl_base +IRQ_EN_CLR ; + ct[i].regs.ack = edge_base +EDGE_RAWSTAT ; + ct[i].regs.type = edge_base; + } + + ct[0 ].type =IRQ_TYPE_LEVEL_MASK ; + ct[0 ].handler = handle_level_irq; + + ct[1 ].type =IRQ_TYPE_EDGE_BOTH ; + ct[1 ].handler = handle_edge_irq; + +intc_writel (chip, ct->regs.disable,0xffffffff ); +intc_writel (chip, ct->regs.ack,0xffffffff ); +} + +static void __init tangox_irq_domain_init (struct irq_domain *dom) +{ +struct irq_chip_generic *gc; +int i; + +for (i =0 ; i <2 ; i++) { + gc =irq_get_domain_generic_chip (dom, i *32 ); +tangox_irq_init_chip (gc, i *IRQ_CTL_HI , i *EDGE_CTL_HI ); + } +} + +static int __init tangox_irq_init (void __iomem *base,struct device_node *node) +{ +struct tangox_irq_chip *chip; +struct irq_domain *dom; +u32 ctl; +int irq; +int err; + + irq =irq_of_parse_and_map (node,0 ); +if (!irq) +panic ("%s: failed to get IRQ" , node->name); + +if (of_property_read_u32 (node,"reg" , &ctl)) +panic ("%s: failed to get reg base" , node->name); + + chip =kzalloc (sizeof (*chip),GFP_KERNEL ); + chip->ctl = ctl; + chip->base = base; + + dom =irq_domain_add_linear (node,64 , &irq_generic_chip_ops, chip); +if (!dom) +panic ("%s: failed to create irqdomain" , node->name); + + err =irq_alloc_domain_generic_chips (dom,32 ,2 , node->name, + handle_level_irq,0 ,0 ,0 ); +if (err) +panic ("%s: failed to allocate irqchip" , node->name); + +tangox_irq_domain_init (dom); + +irq_set_chained_handler (irq, tangox_irq_handler); +irq_set_handler_data (irq, dom); + +return 0 ; +} + +static int __init tangox_of_irq_init (struct device_node *node, +struct device_node *parent) +{ +struct device_node *c; +void __iomem *base;
drivers/irqchip/irq-tango.c line 225
Quoted 10 lines
drivers/irqchip/irq-tango.c new file +10
-0+ + base =of_iomap (node,0 ); + +for_each_child_of_node (node, c) +tangox_irq_init (base, c); + +return 0 ; +} + +IRQCHIP_DECLARE (tangox_intc,"sigma,smp8642-intc" , tangox_of_irq_init);
So the whole thing seems sound. For this patch:
But you definitely need another patch documenting the DT bindings.
Thanks,
M.
Signature · 1 line
Jazz is not dead. It just smells funny...
Quoted 6 lines · Marc Zyngier
drivers/irqchip/irq-tango.c line 192
Quoted 6 lines
drivers/irqchip/irq-tango.c new file +6
-0+if (of_property_read_u32 (node,"reg" , &ctl)) +panic ("%s: failed to get reg base" , node->name); + + chip =kzalloc (sizeof (*chip),GFP_KERNEL ); + chip->ctl = ctl; + chip->base = base;
As I said before, this assumes the outer DT node uses a ranges property. Normally reg properties work the same whether they specify an offset within an outer "ranges" or have a full address directly. It would be easy enough to make this work with either, so I don't see any reason not to.
Signature · 1 line
M?ns Rullg?rd
Quoted 14 lines · M?ns Rullg?rd
Quoted 6 lines · Marc Zyngier
drivers/irqchip/irq-tango.c line 192
Quoted 6 lines
drivers/irqchip/irq-tango.c new file +6
-0+if (of_property_read_u32 (node,"reg" , &ctl)) +panic ("%s: failed to get reg base" , node->name); + + chip =kzalloc (sizeof (*chip),GFP_KERNEL ); + chip->ctl = ctl; + chip->base = base;As I said before, this assumes the outer DT node uses a ranges property. Normally reg properties work the same whether they specify an offset within an outer "ranges" or have a full address directly. It would be easy enough to make this work with either, so I don't see any reason not to.
Yup, that is a good point. I guess Marc can address this in the next round, since we need a DT binding anyway.
Thanks,
M.
Signature · 1 line
Jazz is not dead. It just smells funny...
Quoted 16 lines · Marc Zyngier
Quoted 14 lines · M?ns Rullg?rd
Quoted 6 lines · Marc Zyngier
drivers/irqchip/irq-tango.c line 192
Quoted 6 lines
drivers/irqchip/irq-tango.c new file +6
-0+if (of_property_read_u32 (node,"reg" , &ctl)) +panic ("%s: failed to get reg base" , node->name); + + chip =kzalloc (sizeof (*chip),GFP_KERNEL ); + chip->ctl = ctl; + chip->base = base;As I said before, this assumes the outer DT node uses a ranges property. Normally reg properties work the same whether they specify an offset within an outer "ranges" or have a full address directly. It would be easy enough to make this work with either, so I don't see any reason not to.
Quoted 2 lines
Yup, that is a good point. I guess Marc can address this in the next round, since we need a DT binding anyway.
I'd suggest using of_address_to_resource() on both nodes and subtracting the start addresses returned.
Signature · 1 line
M?ns Rullg?rd
Quoted 19 lines · M?ns Rullg?rd
Quoted 17 lines · Marc Zyngier
Quoted 14 lines · M?ns Rullg?rd
Quoted 6 lines · Marc Zyngier
drivers/irqchip/irq-tango.c line 192
Quoted 6 lines
drivers/irqchip/irq-tango.c new file +6
-0+if (of_property_read_u32 (node,"reg" , &ctl)) +panic ("%s: failed to get reg base" , node->name); + + chip =kzalloc (sizeof (*chip),GFP_KERNEL ); + chip->ctl = ctl; + chip->base = base;As I said before, this assumes the outer DT node uses a ranges property. Normally reg properties work the same whether they specify an offset within an outer "ranges" or have a full address directly. It would be easy enough to make this work with either, so I don't see any reason not to.
Quoted 5 lines
Quoted 2 lines
Yup, that is a good point. I guess Marc can address this in the next round, since we need a DT binding anyway.
I'd suggest using
of_address_to_resource()on both nodes and subtracting the start addresses returned.
For my own reference, Marc Zyngier suggested:
"you should use of_iomap to map the child nodes, and not mess with the parent one."
Quoted 24 lines · Marc Gonzalez
Quoted 22 lines · M?ns Rullg?rd
Quoted 19 lines · Marc Zyngier
Quoted 14 lines · M?ns Rullg?rd
Quoted 6 lines · Marc Zyngier
drivers/irqchip/irq-tango.c line 192
Quoted 6 lines
drivers/irqchip/irq-tango.c new file +6
-0+if (of_property_read_u32 (node,"reg" , &ctl)) +panic ("%s: failed to get reg base" , node->name); + + chip =kzalloc (sizeof (*chip),GFP_KERNEL ); + chip->ctl = ctl; + chip->base = base;As I said before, this assumes the outer DT node uses a ranges property. Normally reg properties work the same whether they specify an offset within an outer "ranges" or have a full address directly. It would be easy enough to make this work with either, so I don't see any reason not to.
Yup, that is a good point. I guess Marc can address this in the next round, since we need a DT binding anyway.
Quoted 6 lines
Quoted 2 lines
I'd suggest using
of_address_to_resource()on both nodes and subtracting the start addresses returned.For my own reference, Marc Zyngier suggested:
"you should useof_iomapto map the child nodes, and not mess with the parent one."
That's going to get very messy since the generic irqchip code needs all the registers as offsets from a common base address.
Signature · 1 line
M?ns Rullg?rd
Quoted 29 lines · M?ns Rullg?rd
Quoted 27 lines · Marc Gonzalez
Quoted 24 lines · M?ns Rullg?rd
Quoted 17 lines · Marc Zyngier
Quoted 14 lines · M?ns Rullg?rd
Quoted 6 lines · Marc Zyngier
Review
Quoted 6 lines
(quoted diff) +6
-0+ if (of_property_read_u32(node, "reg", &ctl)) + panic("%s: failed to get reg base", node->name); + + chip = kzalloc(sizeof(*chip), GFP_KERNEL); + chip->ctl = ctl; + chip->base = base;As I said before, this assumes the outer DT node uses a ranges property. Normally reg properties work the same whether they specify an offset within an outer "ranges" or have a full address directly. It would be easy enough to make this work with either, so I don't see any reason not to.
Quoted 2 lines
Yup, that is a good point. I guess Marc can address this in the next round, since we need a DT binding anyway.
I'd suggest using
of_address_to_resource()on both nodes and subtracting the start addresses returned.
Quoted 6 lines
Quoted 3 lines
For my own reference, Marc Zyngier suggested:
"you should useof_iomapto map the child nodes, and not mess with the parent one."That's going to get very messy since the generic irqchip code needs all the registers as offsets from a common base address.
The two suggestions are over my head at the moment.
Do you want to submit v4 and have Marc Z take a look?
Regards.
Quoted 35 lines · Marc Gonzalez
Quoted 33 lines · M?ns Rullg?rd
Quoted 30 lines · Marc Gonzalez
Quoted 19 lines · M?ns Rullg?rd
Quoted 17 lines · Marc Zyngier
Quoted 14 lines · M?ns Rullg?rd
Quoted 6 lines · Marc Zyngier
Review
Quoted 6 lines
(quoted diff) +6
-0+ if (of_property_read_u32(node, "reg", &ctl)) + panic("%s: failed to get reg base", node->name); + + chip = kzalloc(sizeof(*chip), GFP_KERNEL); + chip->ctl = ctl; + chip->base = base;As I said before, this assumes the outer DT node uses a ranges property. Normally reg properties work the same whether they specify an offset within an outer "ranges" or have a full address directly. It would be easy enough to make this work with either, so I don't see any reason not to.
Quoted 5 lines
Quoted 2 lines
Yup, that is a good point. I guess Marc can address this in the next round, since we need a DT binding anyway.
I'd suggest using
of_address_to_resource()on both nodes and subtracting the start addresses returned.For my own reference, Marc Zyngier suggested:
"you should useof_iomapto map the child nodes, and not mess with the parent one."
Quoted 6 lines
Quoted 2 lines
That's going to get very messy since the generic irqchip code needs all the registers as offsets from a common base address.
The two suggestions are over my head at the moment.
Do you want to submit v4 and have Marc Z take a look?
Done. If this isn't acceptable either, I'm out of ideas that don't end up being far uglier than anything suggested so far.
Signature · 1 line
M?ns Rullg?rd
Quoted 40 lines · M?ns Rullg?rd
Quoted 38 lines · Marc Gonzalez
Quoted 35 lines · M?ns Rullg?rd
Quoted 24 lines · Marc Gonzalez
Quoted 22 lines · M?ns Rullg?rd
Quoted 19 lines · Marc Zyngier
Quoted 14 lines · M?ns Rullg?rd
Quoted 6 lines · Marc Zyngier
Review
Quoted 6 lines
(quoted diff) +6
-0+ if (of_property_read_u32(node, "reg", &ctl)) + panic("%s: failed to get reg base", node->name); + + chip = kzalloc(sizeof(*chip), GFP_KERNEL); + chip->ctl = ctl; + chip->base = base;As I said before, this assumes the outer DT node uses a ranges property. Normally reg properties work the same whether they specify an offset within an outer "ranges" or have a full address directly. It would be easy enough to make this work with either, so I don't see any reason not to.
Yup, that is a good point. I guess Marc can address this in the next round, since we need a DT binding anyway.
Quoted 6 lines
Quoted 2 lines
I'd suggest using
of_address_to_resource()on both nodes and subtracting the start addresses returned.For my own reference, Marc Zyngier suggested:
"you should useof_iomapto map the child nodes, and not mess with the parent one."That's going to get very messy since the generic irqchip code needs all the registers as offsets from a common base address.
Quoted 6 lines
Quoted 3 lines
The two suggestions are over my head at the moment.
Do you want to submit v4 and have Marc Z take a look?
Done. If this isn't acceptable either, I'm out of ideas that don't end up being far uglier than anything suggested so far.
With your latest patch, can I drop the ranges property?
Regards.
Quoted 42 lines · Marc Gonzalez
Quoted 40 lines · M?ns Rullg?rd
Quoted 38 lines · Marc Gonzalez
Quoted 35 lines · M?ns Rullg?rd
Quoted 24 lines · Marc Gonzalez
Quoted 22 lines · M?ns Rullg?rd
Quoted 19 lines · Marc Zyngier
Quoted 14 lines · M?ns Rullg?rd
Quoted 6 lines · Marc Zyngier
Review
Quoted 6 lines
(quoted diff) +6
-0+ if (of_property_read_u32(node, "reg", &ctl)) + panic("%s: failed to get reg base", node->name); + + chip = kzalloc(sizeof(*chip), GFP_KERNEL); + chip->ctl = ctl; + chip->base = base;As I said before, this assumes the outer DT node uses a ranges property. Normally reg properties work the same whether they specify an offset within an outer "ranges" or have a full address directly. It would be easy enough to make this work with either, so I don't see any reason not to.
Yup, that is a good point. I guess Marc can address this in the next round, since we need a DT binding anyway.
Quoted 6 lines
Quoted 2 lines
I'd suggest using
of_address_to_resource()on both nodes and subtracting the start addresses returned.For my own reference, Marc Zyngier suggested:
"you should useof_iomapto map the child nodes, and not mess with the parent one."That's going to get very messy since the generic irqchip code needs all the registers as offsets from a common base address.
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
The two suggestions are over my head at the moment.
Do you want to submit v4 and have Marc Z take a look?
Done. If this isn't acceptable either, I'm out of ideas that don't end up being far uglier than anything suggested so far.
With your latest patch, can I drop the ranges property?
Why would you want to do that?
Signature · 1 line
M?ns Rullg?rd
Quoted 46 lines · M?ns Rullg?rd
Quoted 44 lines · Marc Gonzalez
Quoted 42 lines · M?ns Rullg?rd
Quoted 40 lines · Marc Gonzalez
Quoted 29 lines · M?ns Rullg?rd
Quoted 27 lines · Marc Gonzalez
Quoted 24 lines · M?ns Rullg?rd
Quoted 17 lines · Marc Zyngier
Quoted 14 lines · M?ns Rullg?rd
Quoted 6 lines · Marc Zyngier
Review
Quoted 6 lines
(quoted diff) +6
-0+ if (of_property_read_u32(node, "reg", &ctl)) + panic("%s: failed to get reg base", node->name); + + chip = kzalloc(sizeof(*chip), GFP_KERNEL); + chip->ctl = ctl; + chip->base = base;As I said before, this assumes the outer DT node uses a ranges property. Normally reg properties work the same whether they specify an offset within an outer "ranges" or have a full address directly. It would be easy enough to make this work with either, so I don't see any reason not to.
Quoted 2 lines
Yup, that is a good point. I guess Marc can address this in the next round, since we need a DT binding anyway.
I'd suggest using
of_address_to_resource()on both nodes and subtracting the start addresses returned.Quoted 6 lines
Quoted 3 lines
For my own reference, Marc Zyngier suggested:
"you should useof_iomapto map the child nodes, and not mess with the parent one."That's going to get very messy since the generic irqchip code needs all the registers as offsets from a common base address.
The two suggestions are over my head at the moment.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Do you want to submit v4 and have Marc Z take a look?
Done. If this isn't acceptable either, I'm out of ideas that don't end up being far uglier than anything suggested so far.
With your latest patch, can I drop the ranges property?
Why would you want to do that?
<confused> I thought that was the whole point of the v4 improvement?
Quoted 49 lines · Marc Gonzalez
Quoted 48 lines · M?ns Rullg?rd
Quoted 46 lines · Marc Gonzalez
Quoted 44 lines · M?ns Rullg?rd
Quoted 41 lines · Marc Gonzalez
Quoted 29 lines · M?ns Rullg?rd
Quoted 27 lines · Marc Gonzalez
Quoted 24 lines · M?ns Rullg?rd
Quoted 17 lines · Marc Zyngier
Quoted 14 lines · M?ns Rullg?rd
Quoted 6 lines · Marc Zyngier
Review
Quoted 6 lines
(quoted diff) +6
-0+ if (of_property_read_u32(node, "reg", &ctl)) + panic("%s: failed to get reg base", node->name); + + chip = kzalloc(sizeof(*chip), GFP_KERNEL); + chip->ctl = ctl; + chip->base = base;As I said before, this assumes the outer DT node uses a ranges property. Normally reg properties work the same whether they specify an offset within an outer "ranges" or have a full address directly. It would be easy enough to make this work with either, so I don't see any reason not to.
Quoted 2 lines
Yup, that is a good point. I guess Marc can address this in the next round, since we need a DT binding anyway.
I'd suggest using
of_address_to_resource()on both nodes and subtracting the start addresses returned.Quoted 6 lines
Quoted 3 lines
For my own reference, Marc Zyngier suggested:
"you should useof_iomapto map the child nodes, and not mess with the parent one."That's going to get very messy since the generic irqchip code needs all the registers as offsets from a common base address.
The two suggestions are over my head at the moment.
Do you want to submit v4 and have Marc Z take a look?
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Done. If this isn't acceptable either, I'm out of ideas that don't end up being far uglier than anything suggested so far.
With your latest patch, can I drop the ranges property?
Why would you want to do that?
<confused> I thought that was the whole point of the v4 improvement?
The point was to make it work right *if* someone were to do that even though having it there better reflects what the hardware actually looks like.
Signature · 1 line
M?ns Rullg?rd
Quoted 8 lines · M?ns Rullg?rd
Quoted 6 lines · Marc Gonzalez
Quoted 4 lines · M?ns Rullg?rd
Quoted 1 line · Marc Gonzalez
With your latest patch, can I drop the ranges property?
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Why would you want to do that?
<confused> I thought that was the whole point of the v4 improvement?
The point was to make it work right *if* someone were to do that even though having it there better reflects what the hardware actually looks like.
That's the part I'm struggling to understand. Who other than you or me would write a device tree from scratch for this interrupt controller?
Quoted 12 lines · Marc Gonzalez
Quoted 10 lines · M?ns Rullg?rd
Quoted 8 lines · Marc Gonzalez
Quoted 5 lines · M?ns Rullg?rd
Quoted 1 line · Marc Gonzalez
With your latest patch, can I drop the ranges property?
Why would you want to do that?
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
<confused> I thought that was the whole point of the v4 improvement?
The point was to make it work right *if* someone were to do that even though having it there better reflects what the hardware actually looks like.
That's the part I'm struggling to understand. Who other than you or me would write a device tree from scratch for this interrupt controller?
I wouldn't discount the possibility.
Signature · 1 line
M?ns Rullg?rd
Quoted 14 lines · M?ns Rullg?rd
Quoted 6 lines · Marc Zyngier
drivers/irqchip/irq-tango.c line 192
Quoted 6 lines
drivers/irqchip/irq-tango.c new file +6
-0+if (of_property_read_u32 (node,"reg" , &ctl)) +panic ("%s: failed to get reg base" , node->name); + + chip =kzalloc (sizeof (*chip),GFP_KERNEL ); + chip->ctl = ctl; + chip->base = base;As I said before, this assumes the outer DT node uses a ranges property. Normally reg properties work the same whether they specify an offset within an outer "ranges" or have a full address directly. It would be easy enough to make this work with either, so I don't see any reason not to.
IIRC, I was told very early in the review process that the ranges prop was mandatory. Lemme look for it... It was Arnd:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/444131/focus=444207
Quoted 10 lines
You are missing a ranges property that describes what address space these addresses are in.
'ranges;' would be wrong here, as the interrupt controller is not a bus. If you have no ranges property, the bus is interpreted as having its own address space with no relation to the parent bus (e.g. an I2C bus uses addresses that are not memory mapped).
Just list the addresses that are actually decoded by child devices here.
Did I misunderstand?
Regards.
Quoted 30 lines · Marc Gonzalez
Quoted 14 lines · M?ns Rullg?rd
Quoted 6 lines · Marc Zyngier
drivers/irqchip/irq-tango.c line 192
Quoted 6 lines
drivers/irqchip/irq-tango.c new file +6
-0+if (of_property_read_u32 (node,"reg" , &ctl)) +panic ("%s: failed to get reg base" , node->name); + + chip =kzalloc (sizeof (*chip),GFP_KERNEL ); + chip->ctl = ctl; + chip->base = base;As I said before, this assumes the outer DT node uses a ranges property. Normally reg properties work the same whether they specify an offset within an outer "ranges" or have a full address directly. It would be easy enough to make this work with either, so I don't see any reason not to.
IIRC, I was told very early in the review process that the ranges prop was mandatory. Lemme look for it... It was Arnd:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/444131/focus=444207
Quoted 8 lines
You are missing a ranges property that describes what address space these addresses are in.
'ranges;' would be wrong here, as the interrupt controller is not a bus. If you have no ranges property, the bus is interpreted as having its own address space with no relation to the parent bus (e.g. an I2C bus uses addresses that are not memory mapped).
Quoted 4 lines
Quoted 2 lines
Just list the addresses that are actually decoded by child devices here.
Did I misunderstand?
It's still possible to create such a device tree, and that will fail in very hard to debug ways. Better to be a bit robust.
Signature · 1 line
M?ns Rullg?rd
Quoted 17 lines · Marc Gonzalez
Quoted 14 lines · M?ns Rullg?rd
Quoted 6 lines · Marc Zyngier
drivers/irqchip/irq-tango.c line 192
Quoted 6 lines
drivers/irqchip/irq-tango.c new file +6
-0+if (of_property_read_u32 (node,"reg" , &ctl)) +panic ("%s: failed to get reg base" , node->name); + + chip =kzalloc (sizeof (*chip),GFP_KERNEL ); + chip->ctl = ctl; + chip->base = base;As I said before, this assumes the outer DT node uses a ranges property. Normally reg properties work the same whether they specify an offset within an outer "ranges" or have a full address directly. It would be easy enough to make this work with either, so I don't see any reason not to.
Quoted 4 lines
IIRC, I was told very early in the review process that the ranges prop was mandatory. Lemme look for it... It was Arnd:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/444131/focus=444207
I believe Arnd's point was that you need _a_ ranges property, rather than specifically requiring an idmap/empty ranges property.
As Marc pointed out, you can use of_iomap on the child nodes to map the portions described by the reg properties, which will handle any ranges-based translation automatically.
When you put together the binding document, please point out that the ranges property is necessary.
Thanks,
Mark.
Quoted 21 lines · Mark Rutland
Quoted 20 lines · Marc Gonzalez
Quoted 14 lines · M?ns Rullg?rd
Quoted 6 lines · Marc Zyngier
drivers/irqchip/irq-tango.c line 192
Quoted 6 lines
drivers/irqchip/irq-tango.c new file +6
-0+if (of_property_read_u32 (node,"reg" , &ctl)) +panic ("%s: failed to get reg base" , node->name); + + chip =kzalloc (sizeof (*chip),GFP_KERNEL ); + chip->ctl = ctl; + chip->base = base;As I said before, this assumes the outer DT node uses a ranges property. Normally reg properties work the same whether they specify an offset within an outer "ranges" or have a full address directly. It would be easy enough to make this work with either, so I don't see any reason not to.
IIRC, I was told very early in the review process that the ranges prop was mandatory. Lemme look for it... It was Arnd:
Quoted 8 lines
I believe Arnd's point was that you need _a_ ranges property, rather than specifically requiring an idmap/empty ranges property.
As Marc pointed out, you can use
of_iomapon the child nodes to map the portions described by the reg properties, which will handle any ranges-based translation automatically.
No, that's going to get ugly because the generic irqchip needs a single base address and some of the registers are shared (not part of the range specified in the child nodes).
Signature · 1 line
M?ns Rullg?rd
Quoted 2 lines · Mark Rutland
When you put together the binding document, please point out that the ranges property is necessary.
I don't quite understand.
Can I write the node without a ranges property, and the driver would still function correctly?
Regards.
Quoted 9 lines · Marc Gonzalez
Quoted 2 lines · Mark Rutland
When you put together the binding document, please point out that the ranges property is necessary.
I don't quite understand.
Can I write the node without a ranges property, and the driver would still function correctly?
Not the one you posted.
Signature · 1 line
M?ns Rullg?rd