Skip to contentSkip to conversation

iwlwifi: dvm: cannot turn off wifi LED

Bug 110551 Hubert Tarasiuk 2 participants 2 messages Jan 24, 2016 2 messages not in the archive Networking drivers (wireless)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]/

A message that is not in the archive (sent off-list or not yet received): [email protected]/

#2 lore raw

Attached is the patch for bug 110551.

W dniu 24.01.2016 o 11:16, [email protected] pisze:

Quoted 9 lines

https://bugzilla.kernel.org/show_bug.cgi?id=110551

--- Comment #13 from Emmanuel Grumbach <[email protected]> ---
https://bugzilla.kernel.org/attachment.cgi?id=201271

This one seems to have a fix for the module param as well.
I would much prefer you to send the patch to the wireless mailing list rather than attaching it to this bugzilla.

From 40e783a5464e43722d87b5cb0c3d3899f3f7417e Mon Sep 17 00:00:00 2001
From: Hubert Tarasiuk <[email protected]>
Date: Mon, 4 Jan 2016 23:45:18 +0100
Subject: [PATCH] iwlwifi: dvm: handle zero brightness for wifi LED

This fixes bug 110551 with regard to sysfs.

Misleading behaviour when 'led_mode=3' is passed to iwlwifi is still to be fixed (either by changing the option description or by making the LED permanently dark in such case).

---
 drivers/net/wireless/iwlwifi/dvm/led.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/net/wireless/iwlwifi/dvm/led.c +4 -1
index ca4d669..218617a 100644
@@ -154,11 +154,14 @@ static void iwl_led_brightness_set(struct led_classdev *led_cdev,
 {
 	struct iwl_priv *priv = container_of(led_cdev, struct iwl_priv, led);
 	unsigned long on = 0;
+	unsigned long off = 0;
 
 	if (brightness > 0)
 		on = IWL_LED_SOLID;
+	else
+		off = IWL_LED_SOLID;
 
-	iwl_led_cmd(priv, on, 0);
+	iwl_led_cmd(priv, on, off);
 }
 
 static int iwl_led_blink_set(struct led_classdev *led_cdev,
Signature · 1 line
2.7.0
#3 lore raw
Quoted 12 lines · Hubert Tarasiuk

Attached is the patch for bug 110551.

W dniu 24.01.2016 o 11:16, [email protected] pisze:

Quoted 9 lines

https://bugzilla.kernel.org/show_bug.cgi?id=110551

--- Comment #13 from Emmanuel Grumbach <[email protected]> ---
https://bugzilla.kernel.org/attachment.cgi?id=201271

This one seems to have a fix for the module param as well.
I would much prefer you to send the patch to the wireless mailing list rather than attaching it to this bugzilla.

The better way is send the patches with git-send-email tool.