Skip to contentSkip to conversation

part: Drop duplication declaration of block_dev_desc_t

PATCH In review Simon Glass 4 participants 4 messages Jan 21, 2016 – Jan 25, 2016

lore
Share & tools
lore

Simon Glass

author
#0 lore raw

PATCH 1/1 part: Drop duplication declaration of block_dev_desc_t

This is already defined in ide.h, which part.h includes. So we don't need the duplicate typedef. At least with my old blackfin gcc 4.3.5 tool chain, this causes an error.

Signed-off-by Simon Glass <[email protected]>

---

 include/part.h | 2 --
 1 file changed, 2 deletions(-)
include/part.h +0 -2
index 4d00e22..dc23949 100644
@@ -10,8 +10,6 @@
 #include <ide.h>
 #include <common.h>
 
-typedef struct block_dev_desc block_dev_desc_t;
-
 struct block_dev_desc {
 	int		if_type;	/* type of the interface */
 	int		dev;		/* device number */
Signature · 1 line
2.7.0.rc3.207.g0ac5344
#1 lore raw

PATCH 1/1 part: Drop duplication declaration of block_dev_desc_t

Quoted 10 lines · Simon Glass

This is already defined in ide.h, which part.h includes. So we don't need the duplicate typedef. At least with my old blackfin gcc 4.3.5 tool chain, this causes an error.

Signed-off-by Simon Glass <[email protected]>

---

 include/part.h | 2 --
 1 file changed, 2 deletions(-)
Reviewed-by Bin Meng <[email protected]>
#2 lore raw

PATCH 1/1 part: Drop duplication declaration of block_dev_desc_t

In reply to Simon Glass
Quoted 5 lines · Simon Glass

This is already defined in ide.h, which part.h includes. So we don't need the duplicate typedef. At least with my old blackfin gcc 4.3.5 tool chain, this causes an error.

Signed-off-by Simon Glass <[email protected]>
Reviewed-by Andreas Bie?mann <[email protected]>

This fixes buildman breakage for avr32

Quoted 19 lines

---

 include/part.h | 2 --
 1 file changed, 2 deletions(-)
include/part.h +0 -2
index 4d00e22..dc23949 100644
@@ -10,8 +10,6 @@
 #include <ide.h>
 #include <common.h>
 
-typedef struct block_dev_desc block_dev_desc_t;
-
 struct block_dev_desc {
 	int		if_type;	/* type of the interface */
 	int		dev;		/* device number */
#3 lore raw
In reply to Simon Glass
Quoted 7 lines · Simon Glass

This is already defined in ide.h, which part.h includes. So we don't need the duplicate typedef. At least with my old blackfin gcc 4.3.5 tool chain, this causes an error.

Signed-off-by Simon Glass <[email protected]>
Reviewed-by Bin Meng <[email protected]>
Reviewed-by Andreas Bie?mann <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160125/6ade9941/attachment.sig>