Skip to contentSkip to conversation

bluetooth: core: use managed version of led_trigger_register in LED trigger

PATCH In review Heiner Kallweit 2 participants 2 messages Jan 25, 2016 – Jan 29, 2016

Subsystems (2)
Bluetooth drivers Bluetooth
lore
Share & tools
lore

Heiner Kallweit

author
#0 lore raw

PATCH 1/1 bluetooth: core: use managed version of led_trigger_register in LED trigger

Recently a managed version of led_trigger_register was introduced. Using devm_led_trigger_register allows to simplify the LED trigger code.

Signed-off-by Heiner Kallweit <[email protected]>
---
 net/bluetooth/hci_core.c | 2 --
 net/bluetooth/leds.c     | 8 +-------
 net/bluetooth/leds.h     | 2 --
 3 files changed, 1 insertion(+), 11 deletions(-)
net/bluetooth/hci_core.c +0 -2
index 06f603a..541760f 100644
@@ -3134,8 +3134,6 @@ void hci_unregister_dev(struct hci_dev *hdev)
 
 	id = hdev->id;
 
-	hci_leds_exit(hdev);
-
 	write_lock(&hci_dev_list_lock);
 	list_del(&hdev->list);
 	write_unlock(&hci_dev_list_lock);
net/bluetooth/leds.c +1 -7
index ded7c88..8319c84 100644
@@ -55,7 +55,7 @@ static struct led_trigger *led_allocate_basic(struct hci_dev *hdev,
 	if (!htrig->led_trigger.name)
 		goto err_alloc;
 
-	if (led_trigger_register(&htrig->led_trigger))
+	if (devm_led_trigger_register(&hdev->dev, &htrig->led_trigger))
 		goto err_register;
 
 	return &htrig->led_trigger;

@@ -72,9 +72,3 @@ void hci_leds_init(struct hci_dev *hdev)
 	/* initialize power_led */
 	hdev->power_led = led_allocate_basic(hdev, power_activate, "power");
 }
-
-void hci_leds_exit(struct hci_dev *hdev)
-{
-	if (hdev->power_led)
-		led_trigger_unregister(hdev->power_led);
-}
net/bluetooth/leds.h +0 -2
index 068261a..a9c4d6e 100644
@@ -9,10 +9,8 @@
 #if IS_ENABLED(CONFIG_BT_LEDS)
 void hci_leds_update_powered(struct hci_dev *hdev, bool enabled);
 void hci_leds_init(struct hci_dev *hdev);
-void hci_leds_exit(struct hci_dev *hdev);
 #else
 static inline void hci_leds_update_powered(struct hci_dev *hdev,
 					   bool enabled) {}
 static inline void hci_leds_init(struct hci_dev *hdev) {}
-static inline void hci_leds_exit(struct hci_dev *hdev) {}
 #endif
Signature · 1 line
2.7.0
maintainer
#1 lore raw

Hi Heiner,

Quoted 9 lines

Recently a managed version of led_trigger_register was introduced. Using devm_led_trigger_register allows to simplify the LED trigger code.

Signed-off-by Heiner Kallweit <[email protected]>

---

net/bluetooth/hci_core.c | 2 --
net/bluetooth/leds.c     | 8 +-------
net/bluetooth/leds.h     | 2 --
3 files changed, 1 insertion(+), 11 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel