Skip to contentSkip to conversation

Use of deleted Kconfig option B43_PCMCIA

DISCUSSION Andreas Ziegler 3 participants 3 messages Jan 26, 2016 – May 13, 2016

lore
Share & tools
lore
#0 lore raw

Hi Rafa?,

your commit 399500da18f7 ("ssb: pick PCMCIA host code support from b43 driver") removed the Kconfig option B43_PCMCIA from Kconfig, but left one reference to it in b43/main.c, inside the b43_print_driverinfo() function.

Can this #ifdef be removed, should it be replaced with an #ifdef using CONFIG_SSB_PCMCIAHOST instead or should we do something entirely different?

Best regards,

Andreas

#1 lore raw
Quoted 7 lines · Andreas Ziegler

your commit 399500da18f7 ("ssb: pick PCMCIA host code support from b43 driver") removed the Kconfig option B43_PCMCIA from Kconfig, but left one reference to it in b43/main.c, inside the b43_print_driverinfo() function.

Can this #ifdef be removed, should it be replaced with an #ifdef using CONFIG_SSB_PCMCIAHOST instead or should we do something entirely different?

We even got patch for this, but it wasn't submitted correctly (didn't go to linux-wireless):
https://lkml.org/lkml/2015/11/2/154

Signature · 1 line
Rafa?
#2 lore raw

(Adding linux-wireless)

Quoted 6 lines · Rafa? Mi?ecki
Quoted 5 lines · Andreas Ziegler

your commit 399500da18f7 ("ssb: pick PCMCIA host code support from b43 driver") removed the Kconfig option B43_PCMCIA from Kconfig, but left one reference to it in b43/main.c, inside the b43_print_driverinfo() function.

Quoted 6 lines
Quoted 2 lines

Can this #ifdef be removed, should it be replaced with an #ifdef using CONFIG_SSB_PCMCIAHOST instead or should we do something entirely different?

We even got patch for this, but it wasn't submitted correctly (didn't go to linux-wireless):
https://lkml.org/lkml/2015/11/2/154

Nobody resubmitted that patch?

Signature · 1 line
Kalle Valo