ARM: tegra: Enable high speed UARTs of the Jetson TK1
Subsystems (2)
v2 cover ARM: tegra: Enable high speed UARTs of the Jetson TK1
Hi everyone,
this one enables the high speed UARTs of the Jetson TK1 (and corrects a not noteworthy typo). Those additional UARTs are exposed on the expansion connector of the TK1.
So far, they were only enabled in NVidia's official BSP.
Ralf
Ralf Ramsauer (2):
ARM: tegra: Fixed typo
ARM: tegra: Add high speed UARTs to Jetson TK1 device tree
arch/arm/boot/dts/tegra114.dtsi | 2 +- arch/arm/boot/dts/tegra124-jetson-tk1.dts | 26 ++++++++++++++++++++++++++ arch/arm/boot/dts/tegra124.dtsi | 2 +- arch/arm/boot/dts/tegra20.dtsi | 2 +- arch/arm/boot/dts/tegra30.dtsi | 2 +- 5 files changed, 30 insertions(+), 4 deletions(-)
Signature · 1 line
2.4.10
PATCH v2 1/2 ARM: tegra: Fixed typo
--- arch/arm/boot/dts/tegra114.dtsi | 2 +- arch/arm/boot/dts/tegra124.dtsi | 2 +- arch/arm/boot/dts/tegra20.dtsi | 2 +- arch/arm/boot/dts/tegra30.dtsi | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/tegra114.dtsi +1 -1
@@ -256,7 +256,7 @@ * driver and APB DMA based serial driver for higher baudrate * and performace. To enable the 8250 based driver, the compatible * is "nvidia,tegra114-uart", "nvidia,tegra20-uart" and to enable - * the APB DMA based serial driver, the comptible is + * the APB DMA based serial driver, the compatible is * "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart". */ uarta: serial at 70006000 {
arch/arm/boot/dts/tegra124.dtsi +1 -1
@@ -322,7 +322,7 @@ * driver and APB DMA based serial driver for higher baudrate * and performace. To enable the 8250 based driver, the compatible * is "nvidia,tegra124-uart", "nvidia,tegra20-uart" and to enable - * the APB DMA based serial driver, the comptible is + * the APB DMA based serial driver, the compatible is * "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart". */ uarta: serial at 0,70006000 {
arch/arm/boot/dts/tegra20.dtsi +1 -1
@@ -309,7 +309,7 @@ * driver and APB DMA based serial driver for higher baudrate * and performace. To enable the 8250 based driver, the compatible * is "nvidia,tegra20-uart" and to enable the APB DMA based serial - * driver, the comptible is "nvidia,tegra20-hsuart". + * driver, the compatible is "nvidia,tegra20-hsuart". */ uarta: serial at 70006000 { compatible = "nvidia,tegra20-uart";
arch/arm/boot/dts/tegra30.dtsi +1 -1
@@ -371,7 +371,7 @@ * driver and APB DMA based serial driver for higher baudrate * and performace. To enable the 8250 based driver, the compatible * is "nvidia,tegra30-uart", "nvidia,tegra20-uart" and to enable - * the APB DMA based serial driver, the comptible is + * the APB DMA based serial driver, the compatible is * "nvidia,tegra30-hsuart", "nvidia,tegra20-hsuart". */ uarta: serial at 70006000 {
Signature · 1 line
2.4.10
PATCH v2 1/2 ARM: tegra: Fixed typo
Hey Ralf, thanks for following up with patches as we discussed in private!
Small nit: you will want to use the active form ("Fix typo" instead of "Fixed typo") in your commit messages.
It would also be nice if the commit title was a little more precise about where the typo has been corrected.
Quoted 67 lines · Ralf Ramsauer
Signed-off-by Ralf Ramsauer <[email protected]>--- arch/arm/boot/dts/tegra114.dtsi | 2 +- arch/arm/boot/dts/tegra124.dtsi | 2 +- arch/arm/boot/dts/tegra20.dtsi | 2 +- arch/arm/boot/dts/tegra30.dtsi | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)arch/arm/boot/dts/tegra114.dtsi +1
-1@@ -256,7 +256,7 @@ * driver and APB DMA based serial driver for higher baudrate * and performace. To enable the 8250 based driver, the compatible * is "nvidia,tegra114-uart", "nvidia,tegra20-uart" and to enable - * the APB DMA based serial driver, the comptible is + * the APB DMA based serial driver, the compatible is * "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart". */ uarta: serial at 70006000 {arch/arm/boot/dts/tegra124.dtsi +1
-1@@ -322,7 +322,7 @@ * driver and APB DMA based serial driver for higher baudrate * and performace. To enable the 8250 based driver, the compatible * is "nvidia,tegra124-uart", "nvidia,tegra20-uart" and to enable - * the APB DMA based serial driver, the comptible is + * the APB DMA based serial driver, the compatible is * "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart". */ uarta: serial at 0,70006000 {arch/arm/boot/dts/tegra20.dtsi +1
-1@@ -309,7 +309,7 @@ * driver and APB DMA based serial driver for higher baudrate * and performace. To enable the 8250 based driver, the compatible * is "nvidia,tegra20-uart" and to enable the APB DMA based serial - * driver, the comptible is "nvidia,tegra20-hsuart". + * driver, the compatible is "nvidia,tegra20-hsuart". */ uarta: serial at 70006000 { compatible = "nvidia,tegra20-uart";arch/arm/boot/dts/tegra30.dtsi +1
-2@@ -371,7 +371,7 @@ * driver and APB DMA based serial driver for higher baudrate * and performace. To enable the 8250 based driver, the compatible * is "nvidia,tegra30-uart", "nvidia,tegra20-uart" and to enable - * the APB DMA based serial driver, the comptible is + * the APB DMA based serial driver, the compatible is * "nvidia,tegra30-hsuart", "nvidia,tegra20-hsuart". */ uarta: serial at 70006000 { --2.4.10
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v2 1/2 ARM: tegra: Fixed typo
Quoted 4 lines · Alexandre Courbot
Hey Ralf, thanks for following up with patches as we discussed in private!
Small nit: you will want to use the active form ("Fix typo" instead of "Fixed typo") in your commit messages.
So even my language skills got improved ;-)
Quoted 3 lines
It would also be nice if the commit title was a little more precise about where the typo has been corrected.
Uhm - as this is be pretty small non-diff-related change... Is it necessary to send a v3 or would it also be okay to let the maintainer amend the subject?
(to sth.: like "ARM: tegra: Fix the same C&P typo in several dts includes")
Ralf
Quoted 70 lines
Quoted 67 lines · Ralf Ramsauer
Signed-off-by Ralf Ramsauer <[email protected]>--- arch/arm/boot/dts/tegra114.dtsi | 2 +- arch/arm/boot/dts/tegra124.dtsi | 2 +- arch/arm/boot/dts/tegra20.dtsi | 2 +- arch/arm/boot/dts/tegra30.dtsi | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)arch/arm/boot/dts/tegra114.dtsi +1
-1@@ -256,7 +256,7 @@ * driver and APB DMA based serial driver for higher baudrate * and performace. To enable the 8250 based driver, the compatible * is "nvidia,tegra114-uart", "nvidia,tegra20-uart" and to enable - * the APB DMA based serial driver, the comptible is + * the APB DMA based serial driver, the compatible is * "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart". */ uarta: serial at 70006000 {arch/arm/boot/dts/tegra124.dtsi +1
-1@@ -322,7 +322,7 @@ * driver and APB DMA based serial driver for higher baudrate * and performace. To enable the 8250 based driver, the compatible * is "nvidia,tegra124-uart", "nvidia,tegra20-uart" and to enable - * the APB DMA based serial driver, the comptible is + * the APB DMA based serial driver, the compatible is * "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart". */ uarta: serial at 0,70006000 {arch/arm/boot/dts/tegra20.dtsi +1
-1@@ -309,7 +309,7 @@ * driver and APB DMA based serial driver for higher baudrate * and performace. To enable the 8250 based driver, the compatible * is "nvidia,tegra20-uart" and to enable the APB DMA based serial - * driver, the comptible is "nvidia,tegra20-hsuart". + * driver, the compatible is "nvidia,tegra20-hsuart". */ uarta: serial at 70006000 { compatible = "nvidia,tegra20-uart";arch/arm/boot/dts/tegra30.dtsi +1
-2@@ -371,7 +371,7 @@ * driver and APB DMA based serial driver for higher baudrate * and performace. To enable the 8250 based driver, the compatible * is "nvidia,tegra30-uart", "nvidia,tegra20-uart" and to enable - * the APB DMA based serial driver, the comptible is + * the APB DMA based serial driver, the compatible is * "nvidia,tegra30-hsuart", "nvidia,tegra20-hsuart". */ uarta: serial at 70006000 { --2.4.10
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 2 lines
Ralf Ramsauer GPG: 0x8F10049B
PATCH v2 1/2 ARM: tegra: Fixed typo
Quoted 6 lines · Ralf Ramsauer
Quoted 4 lines · Alexandre Courbot
Hey Ralf, thanks for following up with patches as we discussed in private!
Small nit: you will want to use the active form ("Fix typo" instead of "Fixed typo") in your commit messages.
So even my language skills got improved ;-)
This is grammatically correct, but using imperative form is the convention in the kernel. As per Documentation/SubmittingPatches:
Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour.
Quoted 6 lines
Quoted 2 lines
It would also be nice if the commit title was a little more precise about where the typo has been corrected.
Uhm - as this is be pretty small non-diff-related change... Is it necessary to send a v3 or would it also be okay to let the maintainer amend the subject?
(to sth.: like "ARM: tegra: Fix the same C&P typo in several dts includes")
Let's see what Thierry says about this.
PATCH v2 1/2 ARM: tegra: Fixed typo
Quoted 16 lines · Alexandre Courbot
Quoted 6 lines · Ralf Ramsauer
Quoted 4 lines · Alexandre Courbot
Hey Ralf, thanks for following up with patches as we discussed in private!
Small nit: you will want to use the active form ("Fix typo" instead of "Fixed typo") in your commit messages.
So even my language skills got improved ;-)
This is grammatically correct, but using imperative form is the convention in the kernel. As per
Documentation/SubmittingPatches:Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour.
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
It would also be nice if the commit title was a little more precise about where the typo has been corrected.
Uhm - as this is be pretty small non-diff-related change... Is it necessary to send a v3 or would it also be okay to let the maintainer amend the subject?
(to sth.: like "ARM: tegra: Fix the same C&P typo in several dts includes")Let's see what Thierry says about this.
I've changed this when applying and also added a full commit message. Doing so might arguably be a little overkill, but in doing so I realized that the same typo was there in the Tegra132 and Tegra210 DTS includes, so I fixed those up in a separate patch while at it. I made it a separate patch because the arm-soc maintainers want arch/arm and arch/arm64 changes to come in via separate branches. I did add a Suggested-by for Ralf since he spotted the original typo, I hope that's okay with everyone.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160127/24bc8ead/attachment-0001.sig>
PATCH v2 2/2 ARM: tegra: Add high speed UARTs to Jetson TK1 device tree
In reply to Ralf RamsauerThis patch enables the APB DMA high speed UARTs of the Jetson TK1. So far, they were only enabled in NVidia's official BSP.
Those additional UARTs are exposed on the expansion connector J3A2:
UART1:
Pin 41: BR_UART1_TXD
Pin 44: BR_UART1_RXD
UART2:
Pin 65: UART2_RXD
Pin 68: UART2_TXD
Pin 71: UART2_CTS_L
Pin 74: UART2_RTS_L
--- arch/arm/boot/dts/tegra124-jetson-tk1.dts | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
arch/arm/boot/dts/tegra124-jetson-tk1.dts +26 -0
@@ -12,7 +12,11 @@ aliases { rtc0 = "/i2c at 0,7000d000/pmic at 40"; rtc1 = "/rtc at 0,7000e000"; + + /* This order keeps the mapping DB9 connector <-> ttyS0 */ serial0 = &uartd; + serial1 = &uarta; + serial2 = &uartb; }; memory {
@@ -1367,6 +1371,28 @@ }; }; + /* + * First high speed UART, exposed on the expansion connector J3A2 + * Pin 41: BR_UART1_TXD + * Pin 44: BR_UART1_RXD + */ + serial at 0,70006000 { + compatible = "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart"; + status = "okay"; + }; + + /* + * Second high speed UART, exposed on the expansion connector J3A2 + * Pin 65: UART2_RXD + * Pin 68: UART2_TXD + * Pin 71: UART2_CTS_L + * Pin 74: UART2_RTS_L + */ + serial at 0,70006040 { + compatible = "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart"; + status = "okay"; + }; + /* DB9 serial port */ serial at 0,70006300 { status = "okay";
Signature · 1 line
2.4.10
PATCH v2 2/2 ARM: tegra: Add high speed UARTs to Jetson TK1 device tree
Quoted 6 lines · Ralf Ramsauer
This patch enables the APB DMA high speed UARTs of the Jetson TK1. So far, they were only enabled in NVidia's official BSP.
Those additional UARTs are exposed on the expansion connector J3A2:
UART1:
Quoted 8 lines
Pin 41: BR_UART1_TXD Pin 44: BR_UART1_RXDUART2:
Pin 65: UART2_RXD Pin 68: UART2_TXD Pin 71: UART2_CTS_L Pin 74: UART2_RTS_L
The series,
As an aside, this is perfectly OK, but I wonder why you chose to use compatible=nvidia,tegra124-hsuart rather than compatible=nvidia,tegra124-uart. The -hsuart driver has had less testing upstream, whereas the regular -uart driver is heavily used for the main serial console. I assume you tested the new driver when enabling the ports:-)
PATCH v2 2/2 ARM: tegra: Add high speed UARTs to Jetson TK1 device tree
Quoted 20 lines · Stephen Warren
Quoted 6 lines · Ralf Ramsauer
This patch enables the APB DMA high speed UARTs of the Jetson TK1. So far, they were only enabled in NVidia's official BSP.
Those additional UARTs are exposed on the expansion connector J3A2:
UART1:
Quoted 8 lines
Pin 41: BR_UART1_TXD Pin 44: BR_UART1_RXDUART2:
Pin 65: UART2_RXD Pin 68: UART2_TXD Pin 71: UART2_CTS_L Pin 74: UART2_RTS_LThe series,
Acked-by Stephen Warren <[email protected]>
Quoted 6 lines
As an aside, this is perfectly OK, but I wonder why you chose to use compatible=nvidia,tegra124-hsuart rather than compatible=nvidia,tegra124-uart. The -hsuart driver has had less testing upstream, whereas the regular -uart driver is heavily used for the main serial console. I assume you tested the new driver when enabling the ports:-)
Let me explain it, this is how I found the typos :-)
tegra124.dtsi states:
/*
* There are two serial driver i.e. 8250 based simple serial
* driver and APB DMA based serial driver for higher baudrate
* and performace. To enable the 8250 based driver, the compatible
* is "nvidia,tegra124-uart", "nvidia,tegra20-uart" and to enable
* the APB DMA based serial driver, the compatible is
* "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart". */
There's nothing written about the upstream stability of the hsuart driver. So I didn't even try to use the non-hs uart driver. Nevertheless I successfully tested both additional uarts using the hsuart driver against 4.5-rc1 and some uart-speaking device.
Ralf
Signature · 2 lines
Ralf Ramsauer GPG: 0x8F10049B
Thierry Reding
AppliedPATCH v2 2/2 ARM: tegra: Add high speed UARTs to Jetson TK1 device tree
In reply to Ralf RamsauerQuoted 15 lines · Ralf Ramsauer
This patch enables the APB DMA high speed UARTs of the Jetson TK1. So far, they were only enabled in NVidia's official BSP.
Those additional UARTs are exposed on the expansion connector J3A2:
UART1:
Pin 41:BR_UART1_TXD
Pin 44:BR_UART1_RXDUART2:
Pin 65:UART2_RXD
Pin 68:UART2_TXD
Pin 71:UART2_CTS_L
Pin 74:UART2_RTS_L
Quoted 4 lines
Signed-off-by Ralf Ramsauer <[email protected]>--- arch/arm/boot/dts/tegra124-jetson-tk1.dts | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
Applied, thanks.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160127/a428cfe9/attachment-0001.sig>