imx: MX6DQ{P}/DL:SABRESD Fix bmode eMMC failure

PATCH Superseded Peng Fan 3 participants 3 messages Jan 29, 2016

lore

Share & tools

lore

Peng Fan

author

2016-01-29 02:39 UTC #0 lore raw

PATCH 1/1 imx: MX6DQ{P}/DL:SABRESD Fix bmode eMMC failure

From: Ye Li <[email protected]>

The BOOTCFG value used by bmode for SABRESD eMMC boot are actually for SD card. Fixed the value to correct one.

The issue was fixed in 2014.04 u-boot, but that patch seems missed during porting to 2015.04.

Signed-off-by Ye Li <[email protected]>

Signed-off-by Peng Fan <[email protected]>

Cc Stefano Babic <[email protected]>

Cc Fabio Estevam <[email protected]>

---
 board/freescale/mx6sabresd/mx6sabresd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

board/freescale/mx6sabresd/mx6sabresd.c +1 -1

index d20953d..42f89ab 100644
@@ -638,7 +638,7 @@ static const struct boot_mode board_boot_modes[] = {
 	{"sd2",	 MAKE_CFGVAL(0x40, 0x28, 0x00, 0x00)},
 	{"sd3",	 MAKE_CFGVAL(0x40, 0x30, 0x00, 0x00)},
 	/* 8 bit bus width */
-	{"emmc", MAKE_CFGVAL(0x40, 0x38, 0x00, 0x00)},
+	{"emmc", MAKE_CFGVAL(0x60, 0x58, 0x00, 0x00)},
 	{NULL,	 0},
 };
 #endif

Signature · 1 line

2.6.2

Fabio Estevam

2016-01-29 09:24 UTC #1 lore raw

PATCH 1/1 imx: MX6DQ{P}/DL:SABRESD Fix bmode eMMC failure

Hi Peng,

Quoted 7 lines · Peng Fan

From: Ye Li <[email protected]>
The BOOTCFG value used by bmode for SABRESD eMMC boot are actually for SD card. Fixed the value to correct one.
The issue was fixed in 2014.04 u-boot, but that patch seems missed during porting to 2015.04.

I would remove this last sentence as it applies to NXP U-boot release, right?

Otherwise the patch looks good.

Stefano Babic

2016-01-29 09:30 UTC #2 lore raw

PATCH 1/1 imx: MX6DQ{P}/DL:SABRESD Fix bmode eMMC failure

In reply to Peng Fan

Quoted 22 lines · Peng Fan

From: Ye Li <[email protected]>
The BOOTCFG value used by bmode for SABRESD eMMC boot are actually for SD card. Fixed the value to correct one.
The issue was fixed in 2014.04 u-boot, but that patch seems missed during porting to 2015.04.
Signed-off-by Ye Li <[email protected]>
Signed-off-by Peng Fan <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Fabio Estevam <[email protected]>
---
 board/freescale/mx6sabresd/mx6sabresd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/mx6sabresd/mx6sabresd.c +0 -0
index d20953d..42f89ab 100644

board/freescale/mx6sabresd/mx6sabresd.c static const struct boot_mode board_boot_modes[] = { · line 644

Quoted 8 lines

board/freescale/mx6sabresd/mx6sabresd.c +1 -1

@@ -638,7 +638,7 @@ static const struct boot_mode board_boot_modes[] = {
 	{"sd2",	 MAKE_CFGVAL(0x40, 0x28, 0x00, 0x00)},
 	{"sd3",	 MAKE_CFGVAL(0x40, 0x30, 0x00, 0x00)},
 	/* 8 bit bus width */
-	{"emmc", MAKE_CFGVAL(0x40, 0x38, 0x00, 0x00)},
+	{"emmc", MAKE_CFGVAL(0x60, 0x58, 0x00, 0x00)},
 	{NULL,	 0},
 };
 #endif

Reviewed-by Stefano Babic <[email protected]>

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================