mx6slevk: Fix the reset delay for the the LAN8720 PHY
PATCH 1/1 mx6slevk: Fix the reset delay for the the LAN8720 PHY
From: Fabio Estevam <[email protected]>
Since commit 59370f3fcd1350 ("net: phy: delay only if reset handler is registered") Ethernet is no longer functional.
This commit does not have an issue in itself, but it revelead a problem with the Ethernet initialization.
According to the LAN8720 datasheet tpurstd (time that reset line should stay asserted) is 25ms.
So do as suggested in order to have Ethernet working again.
--- board/freescale/mx6slevk/mx6slevk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/mx6slevk/mx6slevk.c +1 -1
@@ -156,7 +156,7 @@ static void setup_iomux_fec(void)/* Reset LAN8720 PHY */ gpio_direction_output (ETH_PHY_RESET ,0 ); -udelay (1000 ); +udelay (25000 );gpio_set_value (ETH_PHY_RESET ,1 ); }
Signature · 1 line
1.9.1
PATCH 1/1 mx6slevk: Fix the reset delay for the the LAN8720 PHY
Quoted 23 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Since commit
59370f3fcd1350("net: phy: delay only if reset handler is registered") Ethernet is no longer functional.This commit does not have an issue in itself, but it revelead a problem with the Ethernet initialization.
According to the LAN8720 datasheet tpurstd (time that reset line should stay asserted) is 25ms.
So do as suggested in order to have Ethernet working again.
Signed-off-by Fabio Estevam <[email protected]>--- board/freescale/mx6slevk/mx6slevk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)board/freescale/mx6slevk/mx6slevk.c +0
-0
board/freescale/mx6slevk/mx6slevk.c static void setup_iomux_fec(void) · line 161
Quoted 7 lines
board/freescale/mx6slevk/mx6slevk.c +1
-1@@ -156,7 +156,7 @@ static void setup_iomux_fec(void)/* Reset LAN8720 PHY */ gpio_direction_output (ETH_PHY_RESET ,0 ); -udelay (1000 ); +udelay (25000 );gpio_set_value (ETH_PHY_RESET ,1 ); }
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================