Skip to contentSkip to conversation

exynos: Set CNTFRQ

PATCH Superseded Alexander Graf 4 participants 7 messages Feb 1, 2016 – Apr 14, 2016 Arm Samsung Exynos

lore
Share & tools
lore

Alexander Graf

author
#0 lore raw

PATCH 1/1 exynos: Set CNTFRQ

Commit 73a1cb27 moved the check whether we should set the architected timer frequency from CONFIG_SYS_CLK_FREQ to CONFIG_TIMER_CLK_FREQ, but did not update all users of it.

The one where I (finally) realized why KVM didn't work is the Arndale board, so this patch adds the respective define to it.

Signed-off-by Alexander Graf <[email protected]>
Fixes 73a1cb27
---
 include/configs/exynos-common.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/exynos-common.h +1 -0
index 852829c..c4e731f 100644
@@ -31,6 +31,7 @@
 
 /* input clock of PLL: 24MHz input clock */
 #define CONFIG_SYS_CLK_FREQ		24000000
+#define CONFIG_TIMER_CLK_FREQ		24000000
 
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_CMDLINE_TAG
Signature · 1 line
2.6.2
#1 lore raw

PATCH 1/1 exynos: Set CNTFRQ

+Minkyu

Quoted 28 lines · Alexander Graf

Commit 73a1cb27 moved the check whether we should set the architected timer frequency from CONFIG_SYS_CLK_FREQ to CONFIG_TIMER_CLK_FREQ, but did not update all users of it.

The one where I (finally) realized why KVM didn't work is the Arndale board, so this patch adds the respective define to it.

Signed-off-by Alexander Graf <[email protected]>
Fixes 73a1cb27
---
 include/configs/exynos-common.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/exynos-common.h +1 -1
index 852829c..c4e731f 100644
@@ -31,6 +31,7 @@
 
 /* input clock of PLL: 24MHz input clock */
 #define CONFIG_SYS_CLK_FREQ            24000000
+#define CONFIG_TIMER_CLK_FREQ          24000000
 
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_CMDLINE_TAG
--

2.6.2

#2 lore raw

PATCH 1/1 exynos: Set CNTFRQ

In reply to Alexander Graf

Dear Alexander Graf,

Quoted 18 lines · Alexander Graf

Commit 73a1cb27 moved the check whether we should set the architected timer frequency from CONFIG_SYS_CLK_FREQ to CONFIG_TIMER_CLK_FREQ, but did not update all users of it.

The one where I (finally) realized why KVM didn't work is the Arndale board, so this patch adds the respective define to it.

Signed-off-by Alexander Graf <[email protected]>
Fixes 73a1cb27
---
 include/configs/exynos-common.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/exynos-common.h +0 -0
index 852829c..c4e731f 100644

include/configs/exynos-common.h line 34

Quoted 4 lines
include/configs/exynos-common.h +1 -0
@@ -31,6 +31,7 @@
 
 /* input clock of PLL: 24MHz input clock */
 #define CONFIG_SYS_CLK_FREQ		24000000
+#define CONFIG_TIMER_CLK_FREQ		24000000

patch looks good but,
Please make sure that it doesn't have a different value with system clock, always. (If you expected it)

#define CONFIG_TIMER_CLK_FREQ CONFIG_SYS_CLK_FREQ

include/configs/exynos-common.h

Quoted 4 lines
include/configs/exynos-common.h +0 -0
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_CMDLINE_TAG

Thanks,
Minkyu Kang.

author
#3 lore raw

PATCH v2 1/1 exynos: Set CNTFRQ

Commit 73a1cb27 moved the check whether we should set the architected timer frequency from CONFIG_SYS_CLK_FREQ to CONFIG_TIMER_CLK_FREQ, but did not update all users of it.

The one where I (finally) realized why KVM didn't work is the Arndale board, so this patch adds the respective define to it.

Signed-off-by Alexander Graf <[email protected]>
Fixes 73a1cb27

---

v1 -> v2:

- Map to CONFIG_SYS_CLK_FREQ instead of redefining to the same number

---
 include/configs/exynos-common.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/exynos-common.h +1 -0
index 852829c..b61f889 100644
@@ -31,6 +31,7 @@
 
 /* input clock of PLL: 24MHz input clock */
 #define CONFIG_SYS_CLK_FREQ		24000000
+#define CONFIG_TIMER_CLK_FREQ		CONFIG_SYS_CLK_FREQ
 
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_CMDLINE_TAG
Signature · 1 line
1.8.5.6
#4 lore raw

PATCH v2 1/1 exynos: Set CNTFRQ

Quoted 25 lines · Alexander Graf

Commit 73a1cb27 moved the check whether we should set the architected timer frequency from CONFIG_SYS_CLK_FREQ to CONFIG_TIMER_CLK_FREQ, but did not update all users of it.

The one where I (finally) realized why KVM didn't work is the Arndale board, so this patch adds the respective define to it.

Signed-off-by Alexander Graf <[email protected]>
Fixes 73a1cb27

---

v1 -> v2:

- Map to CONFIG_SYS_CLK_FREQ instead of redefining to the same number

---
 include/configs/exynos-common.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/exynos-common.h +0 -0
index 852829c..b61f889 100644

include/configs/exynos-common.h line 37

Quoted 7 lines
include/configs/exynos-common.h +1 -0
@@ -31,6 +31,7 @@
 
 /* input clock of PLL: 24MHz input clock */
 #define CONFIG_SYS_CLK_FREQ		24000000
+#define CONFIG_TIMER_CLK_FREQ		CONFIG_SYS_CLK_FREQ
 
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_CMDLINE_TAG

This makes sense.

Xiubo,

Can you take another look to make sure nothing else is missed?

York

#5 lore raw

PATCH v2 1/1 exynos: Set CNTFRQ

In reply to Alexander Graf
Quoted 25 lines · Alexander Graf

Commit 73a1cb27 moved the check whether we should set the architected timer frequency from CONFIG_SYS_CLK_FREQ to CONFIG_TIMER_CLK_FREQ, but did not update all users of it.

The one where I (finally) realized why KVM didn't work is the Arndale board, so this patch adds the respective define to it.

Signed-off-by Alexander Graf <[email protected]>
Fixes 73a1cb27

---

v1 -> v2:

- Map to CONFIG_SYS_CLK_FREQ instead of redefining to the same number

---
 include/configs/exynos-common.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/exynos-common.h +0 -0
index 852829c..b61f889 100644

include/configs/exynos-common.h line 37

Quoted 7 lines
include/configs/exynos-common.h +1 -0
@@ -31,6 +31,7 @@
 
 /* input clock of PLL: 24MHz input clock */
 #define CONFIG_SYS_CLK_FREQ		24000000
+#define CONFIG_TIMER_CLK_FREQ		CONFIG_SYS_CLK_FREQ
 
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_CMDLINE_TAG
Reviewed-by York Sun <[email protected]>
#6 lore raw

PATCH v2 1/1 exynos: Set CNTFRQ

Quoted 30 lines · york sun
Quoted 29 lines · Alexander Graf

Commit 73a1cb27 moved the check whether we should set the architected timer frequency from CONFIG_SYS_CLK_FREQ to CONFIG_TIMER_CLK_FREQ, but did not update all users of it.

The one where I (finally) realized why KVM didn't work is the Arndale board, so this patch adds the respective define to it.

Signed-off-by Alexander Graf <[email protected]>
Fixes 73a1cb27

---

v1 -> v2:

- Map to CONFIG_SYS_CLK_FREQ instead of redefining to the same number

---
 include/configs/exynos-common.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/exynos-common.h +1 -0
index 852829c..b61f889 100644
@@ -31,6 +31,7 @@
 
 /* input clock of PLL: 24MHz input clock */
 #define CONFIG_SYS_CLK_FREQ		24000000
+#define CONFIG_TIMER_CLK_FREQ		CONFIG_SYS_CLK_FREQ
Quoted 7 lines

include/configs/exynos-common.h line 37

Quoted 3 lines
include/configs/exynos-common.h +0 -0
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_CMDLINE_TAG
Reviewed-by York Sun <[email protected]>

Applied to u-boot-samsung.

Thanks,
Minkyu Kang.