Skip to contentSkip to conversation

arm64: mm: dump: Use VA_START directly instead of private LOWEST_ADDR

PATCH New Kefeng Wang 3 participants 4 messages Jan 30, 2016 – Feb 15, 2016 arm64

lore
Share & tools
lore

Kefeng Wang

author
#0 lore raw

PATCH 1/1 arm64: mm: dump: Use VA_START directly instead of private LOWEST_ADDR

Use VA_START macro in asm/memory.h instead of private LOWEST_ADDR definition in dump.c.

Signed-off-by Kefeng Wang <[email protected]>
---
 arch/arm64/mm/dump.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
arch/arm64/mm/dump.c +1 -3
index 0adbebb..b3c62b1 100644
@@ -27,8 +27,6 @@
 #include <asm/pgtable.h>
 #include <asm/pgtable-hwdef.h>
 
-#define LOWEST_ADDR	(UL(0xffffffffffffffff) << VA_BITS)
-
 struct addr_marker {
 	unsigned long start_address;
 	const char *name;

@@ -316,7 +314,7 @@ static int ptdump_show(struct seq_file *m, void *v)
 		.marker = address_markers,
 	};
 
-	walk_pgd(&st, &init_mm, LOWEST_ADDR);
+	walk_pgd(&st, &init_mm, VA_START);
 
 	note_page(&st, 0, 0, 0);
 	return 0;
Signature · 1 line
2.6.0.GIT
reviewer
#1 lore raw

PATCH 1/1 arm64: mm: dump: Use VA_START directly instead of private LOWEST_ADDR

Quoted 4 lines · Kefeng Wang

Use VA_START macro in asm/memory.h instead of private LOWEST_ADDR definition in dump.c.

Signed-off-by Kefeng Wang <[email protected]>

FWIW:

Acked-by Mark Rutland <[email protected]>

Mark.

Quoted 35 lines
---
 arch/arm64/mm/dump.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
arch/arm64/mm/dump.c +1 -3
index 0adbebb..b3c62b1 100644
@@ -27,8 +27,6 @@
 #include <asm/pgtable.h>
 #include <asm/pgtable-hwdef.h>
 
-#define LOWEST_ADDR	(UL(0xffffffffffffffff) << VA_BITS)
-
 struct addr_marker {
 	unsigned long start_address;
 	const char *name;

@@ -316,7 +314,7 @@ static int ptdump_show(struct seq_file *m, void *v)
 		.marker = address_markers,
 	};
 
-	walk_pgd(&st, &init_mm, LOWEST_ADDR);
+	walk_pgd(&st, &init_mm, VA_START);
 
 	note_page(&st, 0, 0, 0);
 	return 0;
Signature · 7 lines
2.6.0.GIT


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author
#2 lore raw

PATCH 1/1 arm64: mm: dump: Use VA_START directly instead of private LOWEST_ADDR

Hi Catalin and Will, ping...

Quoted 50 lines · Mark Rutland
Quoted 4 lines · Kefeng Wang

Use VA_START macro in asm/memory.h instead of private LOWEST_ADDR definition in dump.c.

Signed-off-by Kefeng Wang <[email protected]>

FWIW:

Acked-by Mark Rutland <[email protected]>

Mark.

Quoted 35 lines
---
 arch/arm64/mm/dump.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
arch/arm64/mm/dump.c +1 -3
index 0adbebb..b3c62b1 100644
@@ -27,8 +27,6 @@
 #include <asm/pgtable.h>
 #include <asm/pgtable-hwdef.h>
 
-#define LOWEST_ADDR	(UL(0xffffffffffffffff) << VA_BITS)
-
 struct addr_marker {
 	unsigned long start_address;
 	const char *name;

@@ -316,7 +314,7 @@ static int ptdump_show(struct seq_file *m, void *v)
 		.marker = address_markers,
 	};
 
-	walk_pgd(&st, &init_mm, LOWEST_ADDR);
+	walk_pgd(&st, &init_mm, VA_START);
 
 	note_page(&st, 0, 0, 0);
 	return 0;
Signature · 7 lines
2.6.0.GIT


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

.

maintainer
#3 lore raw

PATCH 1/1 arm64: mm: dump: Use VA_START directly instead of private LOWEST_ADDR

Quoted 6 lines · Kefeng Wang
Quoted 5 lines · Mark Rutland
Quoted 4 lines · Kefeng Wang

Use VA_START macro in asm/memory.h instead of private LOWEST_ADDR definition in dump.c.

Signed-off-by Kefeng Wang <[email protected]>

I'll merge this patch for 4.6 but we currently have some issues with the arm64 for-next/core branch, so I'm not pushing any more patches out until we figure out what's going on (or I may just start with a clean branch again, removing some big changes in there).

Signature · 1 line
Catalin