Skip to contentSkip to conversation

owfs: new package

PATCH Superseded Arnout Vandecappelle (Essensium/Mind) 2 participants 3 messages Feb 22, 2016

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Arnout Vandecappelle (Essensium/Mind)

author
#0 lore raw

PATCH 1/1 owfs: new package

All modules are always enabled when their dependencies are satisfied.

tcl doesn't work because the tclConfig.sh installed by our tcl package is wrong: it adds -I/usr/include.

perl doesn't work out of the box, I didn't investigate.

Signed-off-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
---
 package/Config.in                                  |  1 +
 .../0001-configure.ac-check-for-localtime_r.patch  | 48 +++++++++++++++
 package/owfs/Config.in                             | 16 +++++
 package/owfs/owfs.hash                             |  4 ++
 package/owfs/owfs.mk                               | 69 ++++++++++++++++++++++
 5 files changed, 138 insertions(+)
 create mode 100644 package/owfs/0001-configure.ac-check-for-localtime_r.patch
 create mode 100644 package/owfs/Config.in
 create mode 100644 package/owfs/owfs.hash
 create mode 100644 package/owfs/owfs.mk
package/Config.in +1 -0
index dc68184..70b0ee5 100644
@@ -984,6 +984,7 @@ menu "Hardware handling"
 	source "package/mtdev/Config.in"
 	source "package/ne10/Config.in"
 	source "package/neardal/Config.in"
+	source "package/owfs/Config.in"
 	source "package/pcsc-lite/Config.in"
 	source "package/tslib/Config.in"
 	source "package/urg/Config.in"
package/owfs/0001-configure.ac-check-for-localtime_r.patch new file +48 -0

48 lines not on this page · raw message

package/owfs/Config.in new file +16 -0
new file mode 100644
index 0000000..802d1e4
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_OWFS
+	bool "owfs"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	help
+	  OWFS is an easy way to use the powerful 1-wire system of
+	  Dallas/Maxim.
+
+	  OWFS is a simple and flexible program to monitor and control
+	  the physical environment. You can write scripts to read
+	  temperature, flash lights, write to an LCD, log and graph,
+	  etc.
+
+	  http://owfs.org/
+
+comment "owfs needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
package/owfs/owfs.hash new file +4 -0
new file mode 100644
index 0000000..3991eec
@@ -0,0 +1,4 @@
+# From https://sourceforge.net/projects/owfs/files/owfs/3.1p1/
+sha1  80892ca3e72fef2979b8f0a04db15fd24a2cbda6  owfs-3.1p1.tar.gz
+# Locally calculated
+sha256  e69421ae534565c1f8530a2447f583401f4d0d4b1cf3cb8cf399a57133ed7f81  owfs-3.1p1.tar.gz
package/owfs/owfs.mk new file +69 -0

69 lines not on this page · raw message

Signature · 1 line
2.7.0
#1 lore raw

PATCH 1/1 owfs: new package

Arnout,

Quoted 9 lines · Arnout Vandecappelle (Essensium/Mind)
package/owfs/0001-configure.ac-check-for-localtime_r.patch new file +3 -0
new file mode 100644
index 0000000..bdaab4f
@@ -0,0 +1,48 @@
+From dd7c906a7e548ccb7b9c101221531d6b203f701f Mon Sep 17 00:00:00 2001
+From: "Arnout Vandecappelle (Essensium/Mind)" <[email protected]>
+Date: Sun, 21 Feb 2016 17:02:06 +0100

package/owfs/0001-configure.ac-check-for-localtime_r.patch line 13

Quoted 10 lines
package/owfs/0001-configure.ac-check-for-localtime_r.patch new file +10 -0
+Subject: [PATCH] configure.ac: check for localtime_r
+
+HAVE_LOCALTIME_R is used in module/owftpd/src/c/file_list.c, so it
+should be checked for.
+
+Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]>
+---
+ configure.ac                   | 2 +-
+ module/swig/python/setup.py.in | 7 -------
+ 2 files changed, 1 insertion(+), 8 deletions(-)

Your description explains perfectly well the change in configure.ac, but does not explain the change done in setup.py.in. Shouldn't it be part of a separate patch, with a proper description ?

The rest of the patch looks good.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 owfs: new package

Quoted 21 lines · Thomas Petazzoni

Arnout,

Review

Quoted 1 line · Arnout Vandecappelle (Essensium/Mind)
(quoted diff) +0 -0

b/package/owfs/0001-configure.ac-check-for-localtime_r.patch

Quoted 14 lines

new file mode 100644
index 0000000..bdaab4f

package/owfs/0001-configure.ac-check-for-localtime_r.patch new file +9 -0
@@ -0,0 +1,48 @@
+From dd7c906a7e548ccb7b9c101221531d6b203f701f Mon Sep 17 00:00:00 2001
+From: "Arnout Vandecappelle (Essensium/Mind)" <[email protected]>
+Date: Sun, 21 Feb 2016 17:02:06 +0100
+Subject: [PATCH] configure.ac: check for localtime_r
+
+HAVE_LOCALTIME_R is used in module/owftpd/src/c/file_list.c, so it
+should be checked for.
+
+Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Quoted 8 lines

package/owfs/0001-configure.ac-check-for-localtime_r.patch line 13

Quoted 4 lines
package/owfs/0001-configure.ac-check-for-localtime_r.patch new file +4 -0
+---
+ configure.ac                   | 2 +-
+ module/swig/python/setup.py.in | 7 -------
+ 2 files changed, 1 insertion(+), 8 deletions(-)

Your description explains perfectly well the change in configure.ac, but does not explain the change done in setup.py.in. Shouldn't it be part of a separate patch, with a proper description ?

Oops, that's a leftover from my failed attempt to get python3 to work.

Regards,
Arnout

Quoted 7 lines

The rest of the patch looks good.

Thanks!

Thomas

Signature · 6 lines
Arnout Vandecappelle arnout dot vandecappelle at essensium dot com
Senior Embedded Software Architect . . . . . . +32-478-010353 (mobile)
Essensium, Mind division . . . . . . . . . . . . . . http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium . . . . . BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF