Skip to contentSkip to conversation

submodule--helper: fix 'dubious bitfield' sparse warnings

PATCH In review Ramsay Jones 2 participants 2 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 submodule--helper: fix 'dubious bitfield' sparse warnings

---

Hi Stefan,

If you need to re-roll (err, one of your) 'sb/submodule-parallel-update' branches, could you please squash this into the relevant patch. (ie. "git submodule update: have a dedicated helper for cloning", 23-02-2016).

Thanks!

ATB,
Ramsay Jones

 builtin/submodule--helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
builtin/submodule--helper.c +2 -2
index f8cdce9..482a3cc 100644
@@ -563,7 +563,7 @@ struct submodule_update_clone {
 	/* index into 'list', the list of submodules to look into for cloning */
 	int current;
 	struct module_list list;
-	int warn_if_uninitialized : 1;
+	unsigned int warn_if_uninitialized : 1;
 	/* update parameter passed via commandline*/
 	struct submodule_update_strategy update;
 	/* configuration parameters which are passed on to the children */
@@ -575,7 +575,7 @@ struct submodule_update_clone {
 	/* lines to be output */
 	struct string_list projectlines;
 	/* If we want to stop as fast as possible and return an error */
-	int quickstop : 1;
+	unsigned int quickstop : 1;
 };
 #define SUBMODULE_UPDATE_CLONE_INIT {0, MODULE_LIST_INIT, 0, \
 	SUBMODULE_UPDATE_STRATEGY_INIT, 0, NULL, NULL, NULL, NULL, \
Signature · 1 line
2.7.0
#1 lore raw
Quoted 11 lines · Ramsay Jones

---

Hi Stefan,

If you need to re-roll (err, one of your) 'sb/submodule-parallel-update' branches, could you please squash this into the relevant patch. (ie. "git submodule update: have a dedicated helper for cloning", 23-02-2016).

Thanks!

It's part of v17 already.

Thanks,
Stefan

Quoted 35 lines

ATB,
Ramsay Jones

 builtin/submodule--helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
builtin/submodule--helper.c +2 -3
index f8cdce9..482a3cc 100644
@@ -563,7 +563,7 @@ struct submodule_update_clone {
        /* index into 'list', the list of submodules to look into for cloning */
        int current;
        struct module_list list;
-       int warn_if_uninitialized : 1;
+       unsigned int warn_if_uninitialized : 1;
        /* update parameter passed via commandline*/
        struct submodule_update_strategy update;
        /* configuration parameters which are passed on to the children */
@@ -575,7 +575,7 @@ struct submodule_update_clone {
        /* lines to be output */
        struct string_list projectlines;
        /* If we want to stop as fast as possible and return an error */
-       int quickstop : 1;
+       unsigned int quickstop : 1;
 };
 #define SUBMODULE_UPDATE_CLONE_INIT {0, MODULE_LIST_INIT, 0, \
        SUBMODULE_UPDATE_STRATEGY_INIT, 0, NULL, NULL, NULL, NULL, \
--

2.7.0
--
To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html