systemd feature selection

systemd v228 requires lz4 >= 125

Signed-off-by Gabe Evans <[email protected]>

---
 package/lz4/lz4.hash |  2 ++
 package/lz4/lz4.mk   | 19 ++++++++++++-------
 2 files changed, 14 insertions(+), 7 deletions(-)
 create mode 100644 package/lz4/lz4.hash

package/lz4/lz4.hash new file +2 -0

new file mode 100644
index 0000000..1281284
@@ -0,0 +1,2 @@
+# sha256 locally computed
+sha256 9d4d00614d6b9dec3114b33d1224b6262b99ace24434c53487a0c8fd0b18cfed  lz4-r131.tar.gz

package/lz4/lz4.mk +0 -0

index 38e10d8..dbb2221 100644
@@ -4,37 +4,42 @@
 #

package/lz4/lz4.mk +10 -6

+
 ifeq ($(BR2_STATIC_LIBS),y)
 define LZ4_DISABLE_SHARED
-	$(SED) '/SHARED/d' $(@D)/Makefile
+	$(SED) '/SHARED/d' $(@D)/lib/Makefile
 endef
 LZ4_POST_PATCH_HOOKS += LZ4_DISABLE_SHARED
 endif
 
 define HOST_LZ4_BUILD_CMDS
-	$(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D)
+	$(MAKE) $(HOST_CONFIGURE_OPTS) $(LZ4_MAKE_OPTS) -C $(@D)
 endef
 
 define HOST_LZ4_INSTALL_CMDS
-	$(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D) install DESTDIR=$(HOST_DIR)
+	$(MAKE) $(HOST_CONFIGURE_OPTS) $(LZ4_MAKE_OPTS) DESTDIR=$(HOST_DIR) \
+		install -C $(@D)
 endef
 
 define LZ4_BUILD_CMDS
-	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) liblz4
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) $(LZ4_MAKE_OPTS) -C $(@D)/lib
 endef
 
 define LZ4_INSTALL_STAGING_CMDS
-	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) install DESTDIR=$(STAGING_DIR)
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) $(LZ4_MAKE_OPTS) DESTDIR=$(STAGING_DIR) \
+		install -C $(@D)
 endef
 
 define LZ4_INSTALL_TARGET_CMDS
-	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) install DESTDIR=$(TARGET_DIR)
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) $(LZ4_MAKE_OPTS) DESTDIR=$(TARGET_DIR) \
+		install -C $(@D)/lib
 endef
 
 $(eval $(generic-package))

Hi Gabe,

I'm not going to review all of the series yet, just a few of them. The
patches
which are pretty independent (like this one) you can resend individually. Only
when you resend the later ones you need to send the entire series.

Quoted 15 lines

systemd v228 requires lz4 >= 125

Signed-off-by Gabe Evans <[email protected]>

---
 package/lz4/lz4.hash |  2 ++
 package/lz4/lz4.mk   | 19 ++++++++++++-------
 2 files changed, 14 insertions(+), 7 deletions(-)
 create mode 100644 package/lz4/lz4.hash

package/lz4/lz4.hash new file +0 -0

new file mode 100644
index 0000000..1281284

package/lz4/lz4.hash line 2

Quoted 2 lines

package/lz4/lz4.hash new file +2 -0

@@ -0,0 +1,2 @@
+# sha256 locally computed
+sha256

9d4d00614d6b9dec3114b33d1224b6262b99ace24434c53487a0c8fd0b18cfed lz4-r131.tar.gz

package/lz4/lz4.mk line 5

Quoted 7 lines

package/lz4/lz4.mk +0 -0

index 38e10d8..dbb2221 100644
@@ -4,37 +4,42 @@
 #
 

################################################################################

package/lz4/lz4.mk line 13

Quoted 9 lines

package/lz4/lz4.mk +2 -1

-LZ4_VERSION = r123
+LZ4_VERSION = r131
 LZ4_SITE = $(call github,Cyan4973,lz4,$(LZ4_VERSION))
 LZ4_INSTALL_STAGING = YES
 LZ4_LICENSE = BSD-2c
 LZ4_LICENSE_FILES = LICENSE
 
+LZ4_MAKE_OPTS = PREFIX=/usr

I'd prefer to have

LZ4_MAKE_OPTS = $(TARGET_CONFIGURE_OPTS) PREFIX=/usr HOST_LZ4_MAKE_OPTS = $(HOST_CONFIGURE_OPTS) PREFIX=/usr

However, is the PREFIX useful during the build? If it's only needed at
install
time, then I would just pass it there, like we do with DESTDIR already.

Regards,
Arnout

Quoted 7 lines

package/lz4/lz4.mk +2 -1

+
 ifeq ($(BR2_STATIC_LIBS),y)
 define LZ4_DISABLE_SHARED
-     $(SED) '/SHARED/d' $(@D)/Makefile
+     $(SED) '/SHARED/d' $(@D)/lib/Makefile
 endef
 LZ4_POST_PATCH_HOOKS += LZ4_DISABLE_SHARED

package/lz4/lz4.mk

Quoted 10 lines

package/lz4/lz4.mk +2 -2

 endif
 
 define HOST_LZ4_BUILD_CMDS
-     $(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D)
+     $(MAKE) $(HOST_CONFIGURE_OPTS) $(LZ4_MAKE_OPTS) -C $(@D)
 endef
 
 define HOST_LZ4_INSTALL_CMDS
-     $(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D) install DESTDIR=$(HOST_DIR)
+     $(MAKE) $(HOST_CONFIGURE_OPTS) $(LZ4_MAKE_OPTS)

DESTDIR=$(HOST_DIR) \

package/lz4/lz4.mk

Quoted 10 lines

package/lz4/lz4.mk +2 -2

+             install -C $(@D)
 endef
 
 define LZ4_BUILD_CMDS
-     $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) liblz4
+     $(MAKE) $(TARGET_CONFIGURE_OPTS) $(LZ4_MAKE_OPTS) -C $(@D)/lib
 endef
 
 define LZ4_INSTALL_STAGING_CMDS
-     $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) install

DESTDIR=$(STAGING_DIR)

package/lz4/lz4.mk line 35

Quoted 1 line

package/lz4/lz4.mk +1 -0

+     $(MAKE) $(TARGET_CONFIGURE_OPTS) $(LZ4_MAKE_OPTS)

DESTDIR=$(STAGING_DIR) \

package/lz4/lz4.mk

Quoted 5 lines

package/lz4/lz4.mk +1 -1

+             install -C $(@D)
 endef
 
 define LZ4_INSTALL_TARGET_CMDS
-     $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) install

DESTDIR=$(TARGET_DIR)

package/lz4/lz4.mk line 40

Quoted 1 line

package/lz4/lz4.mk +1 -0

+     $(MAKE) $(TARGET_CONFIGURE_OPTS) $(LZ4_MAKE_OPTS)

DESTDIR=$(TARGET_DIR) \

package/lz4/lz4.mk

Quoted 5 lines

package/lz4/lz4.mk +1 -0

+             install -C $(@D)/lib
 endef
 
 $(eval $(generic-package))
 

--

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

Hi Arnout,

On Thu, Feb 25, 2016 at 3:44 PM Arnout Vandecappelle <[email protected] <mailto:[email protected]>> wrote:

Hi Gabe,

I'm not going to review all of the series yet, just a few of them. The
patches
which are pretty independent (like this one) you can resend individually. Only when you resend the later ones you need to send the entire series.

Thanks for having a look. I wasn't sure what to do with this one since it's needed for patch #4 (add --enable/disable-lz4) to work.

systemd v228 requires lz4 >= 125

Signed-off-by Gabe Evans <[email protected]>

---
 package/lz4/lz4.hash |  2 ++
 package/lz4/lz4.mk   | 19 ++++++++++++-------
 2 files changed, 14 insertions(+), 7 deletions(-)
 create mode 100644 package/lz4/lz4.hash

The option was a bit misleading since it only selected additional libraries without --enable/disabling any features. Including all of them here would add a lot of bloat so instead, it is replaced with notes detailing which features each library enables.

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/Config.in  | 11 +++--------
 package/systemd/systemd.mk | 16 ++++++++++------
 2 files changed, 13 insertions(+), 14 deletions(-)

package/systemd/Config.in +0 -0

index f7fc3bb..1972b1d 100644

package/systemd/Config.in +0 -7

-	bool "enable all extras"
-	select BR2_PACKAGE_XZ
-	select BR2_PACKAGE_LIBGCRYPT
-	help
-	  Enable extra features for Systemd: journal compression and
-	  signing.
-
 config BR2_PACKAGE_SYSTEMD_KDBUS
 	bool "enable kdbus support"
 	help

package/systemd/systemd.mk +10 -6

index 05121cf..7a1baf5 100644
@@ -76,16 +76,20 @@ else
 SYSTEMD_CONF_OPTS += --disable-kdbus
 endif
 
-ifeq ($(BR2_PACKAGE_SYSTEMD_ALL_EXTRAS),y)
-SYSTEMD_DEPENDENCIES += xz libgcrypt
+ifeq ($(BR2_PACKAGE_XZ),y)
+SYSTEMD_DEPENDENCIES += xz
+SYSTEMD_CONF_OPTS += --enable-xz
+else
+SYSTEMD_CONF_OPTS += --disable-xz
+endif
+
+ifeq ($(BR2_PACKAGE_LIBGCRYPT),y)
+SYSTEMD_DEPENDENCIES += libgcrypt
 SYSTEMD_CONF_OPTS += \
-	--enable-xz \
 	--enable-gcrypt	\
 	--with-libgcrypt-prefix=$(STAGING_DIR)/usr
 else
-SYSTEMD_CONF_OPTS += \
-	--disable-xz \
-	--disable-gcrypt
+SYSTEMD_CONF_OPTS += --disable-gcrypt
 endif
 
 ifeq ($(BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY),y)

The option was a bit misleading since it only selected additional libraries without --enable/disabling any features. Including all of them here would add a lot of bloat so instead, it is replaced with notes detailing which features each library enables.

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/Config.in  | 11 +++--------
 package/systemd/systemd.mk | 16 ++++++++++------
 2 files changed, 13 insertions(+), 14 deletions(-)

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/systemd.mk | 7 +++++++
 1 file changed, 7 insertions(+)

package/systemd/systemd.mk +7 -0

index 7a1baf5..ac211c8 100644
@@ -76,6 +76,13 @@ else
 SYSTEMD_CONF_OPTS += --disable-kdbus
 endif
 
+ifeq ($(BR2_PACKAGE_BZIP2),y)
+SYSTEMD_DEPENDENCIES += bzip2
+SYSTEMD_CONF_OPTS += --enable-bzip2
+else
+SYSTEMD_CONF_OPTS += --disable-bzip2
+endif
+
 ifeq ($(BR2_PACKAGE_XZ),y)
 SYSTEMD_DEPENDENCIES += xz
 SYSTEMD_CONF_OPTS += --enable-xz

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/systemd.mk | 7 +++++++
 1 file changed, 7 insertions(+)

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/Config.in  | 3 ++-
 package/systemd/systemd.mk | 7 +++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

package/systemd/Config.in +2 -1

index 1972b1d..9de6e11 100644
@@ -56,7 +56,8 @@ config BR2_PACKAGE_SYSTEMD
 	  The selection of other packages will enable some features:
 
 	  - acl package will add support for multi-seat.
-	  - xz package will add compression support in journal and coredump.
+	  - xz and/or lz4 packages will add compression support in journal
+	    and coredump.
 	  - libgcrypt package will add support for journal sealing and resolved
 	    DNSSEC verification.
 

package/systemd/systemd.mk +7 -0

index ac211c8..9f15f24 100644
@@ -83,6 +83,13 @@ else
 SYSTEMD_CONF_OPTS += --disable-bzip2
 endif
 
+ifeq ($(BR2_PACKAGE_LZ4),y)
+SYSTEMD_DEPENDENCIES += lz4
+SYSTEMD_CONF_OPTS += --enable-lz4
+else
+SYSTEMD_CONF_OPTS += --disable-lz4
+endif
+
 ifeq ($(BR2_PACKAGE_XZ),y)
 SYSTEMD_DEPENDENCIES += xz
 SYSTEMD_CONF_OPTS += --enable-xz

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/Config.in  | 3 ++-
 package/systemd/systemd.mk | 7 +++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Dear Gabe Evans,

Quoted 5 lines · Gabe Evans

Signed-off-by Gabe Evans <[email protected]>

---
package/systemd/Config.in | 3 ++-
package/systemd/systemd.mk | 7 +++++++

2 files changed, 9 insertions(+), 1 deletion(-)

Applied to master, thanks.

Quoted 9 lines

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Dear Gabe Evans,

Quoted 5 lines · Gabe Evans

Signed-off-by Gabe Evans <[email protected]>

---
package/systemd/Config.in | 3 ++-
package/systemd/systemd.mk | 7 +++++++

2 files changed, 9 insertions(+), 1 deletion(-)

Quoted 1 line

Applied to master, thanks.

Seems like you applied it to next instead?

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/systemd.mk | 7 +++++++
 1 file changed, 7 insertions(+)

package/systemd/systemd.mk +7 -0

index 9f15f24..29c764e 100644
@@ -97,6 +97,13 @@ else
 SYSTEMD_CONF_OPTS += --disable-xz
 endif
 
+ifeq ($(BR2_PACKAGE_ZLIB),y)
+SYSTEMD_DEPENDENCIES += zlib
+SYSTEMD_CONF_OPTS += --enable-zlib
+else
+SYSTEMD_CONF_OPTS += --disable-zlib
+endif
+
 ifeq ($(BR2_PACKAGE_LIBGCRYPT),y)
 SYSTEMD_DEPENDENCIES += libgcrypt
 SYSTEMD_CONF_OPTS += \

Quoted 1 line · Gabe Evans

Signed-off-by Gabe Evans <[email protected]>

Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Again, for master.

I wonder: what is zlib used for? Also for compressed journal? If so, why
didn't
you update the help text?

Regards,
Arnout

Quoted 13 lines

---
 package/systemd/systemd.mk | 7 +++++++
 1 file changed, 7 insertions(+)

package/systemd/systemd.mk +0 -0

index 9f15f24..29c764e 100644
@@ -97,6 +97,13 @@ else
 SYSTEMD_CONF_OPTS += --disable-xz
 endif
 

package/systemd/systemd.mk else · line 109

Quoted 10 lines

package/systemd/systemd.mk +7 -0

+ifeq ($(BR2_PACKAGE_ZLIB),y)
+SYSTEMD_DEPENDENCIES += zlib
+SYSTEMD_CONF_OPTS += --enable-zlib
+else
+SYSTEMD_CONF_OPTS += --disable-zlib
+endif
+
 ifeq ($(BR2_PACKAGE_LIBGCRYPT),y)
 SYSTEMD_DEPENDENCIES += libgcrypt
 SYSTEMD_CONF_OPTS += \

--

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/systemd.mk | 7 +++++++
 1 file changed, 7 insertions(+)

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/Config.in  | 1 +
 package/systemd/systemd.mk | 7 +++++++
 2 files changed, 8 insertions(+)

package/systemd/Config.in +1 -0

index 9de6e11..6edfba1 100644
@@ -58,6 +58,7 @@ config BR2_PACKAGE_SYSTEMD
 	  - acl package will add support for multi-seat.
 	  - xz and/or lz4 packages will add compression support in journal
 	    and coredump.
+	  - libcurl package will add support for systemd-journal-upload.
 	  - libgcrypt package will add support for journal sealing and resolved
 	    DNSSEC verification.
 

package/systemd/systemd.mk +7 -0

index 29c764e..18e0c5c 100644
@@ -104,6 +104,13 @@ else
 SYSTEMD_CONF_OPTS += --disable-zlib
 endif
 
+ifeq ($(BR2_PACKAGE_LIBCURL),y)
+SYSTEMD_DEPENDENCIES += libcurl
+SYSTEMD_CONF_OPTS += --enable-libcurl
+else
+SYSTEMD_CONF_OPTS += --disable-libcurl
+endif
+
 ifeq ($(BR2_PACKAGE_LIBGCRYPT),y)
 SYSTEMD_DEPENDENCIES += libgcrypt
 SYSTEMD_CONF_OPTS += \

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/Config.in  | 1 +
 package/systemd/systemd.mk | 7 +++++++
 2 files changed, 8 insertions(+)

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/systemd.mk | 1 +
 1 file changed, 1 insertion(+)

package/systemd/systemd.mk +1 -0

index 18e0c5c..639b8a5 100644
@@ -122,6 +122,7 @@ endif
 
 ifeq ($(BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY),y)
 SYSTEMD_DEPENDENCIES += libmicrohttpd
+SYSTEMD_CONF_OPTS += --enable-microhttpd
 else
 SYSTEMD_CONF_OPTS += --disable-microhttpd
 endif

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/systemd.mk | 1 +
 1 file changed, 1 insertion(+)

systemd-timesyncd can function without systemd-networkd.

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/Config.in | 1 -
 1 file changed, 1 deletion(-)

package/systemd/Config.in +0 -0

index 6edfba1..5d6759d 100644

Quoted 2 lines

config BR2_PACKAGE_SYSTEMD_TIMESYNCD
bool "enable SNTP client"

SNTP?

package/systemd/Config.in config BR2_PACKAGE_SYSTEMD_NETWORKD · line 103

Quoted 4 lines

package/systemd/Config.in +0 -1

-	depends on BR2_PACKAGE_SYSTEMD_NETWORKD
 	help
 	  systemd-timesyncd is a service that may be used to synchronize the
 	  local system clock with a Network Time Protocol Server.

Server -> server?

systemd-timesyncd can function without systemd-networkd.

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/Config.in | 1 -
 1 file changed, 1 deletion(-)

Dear Gabe Evans,

On Thu, 25 Feb 2016 21:55:18 +0000, Gabe Evans wrote:

package/systemd/Config.in config BR2_PACKAGE_SYSTEMD_TIMESYNCD

Quoted 3 lines

package/systemd/Config.in +3 -0

+config BR2_PACKAGE_SYSTEMD_NTP_SERVERS
+     string "default NTP servers"
+     default "0.pool.ntp.org 1.pool.ntp.org 2.pool.ntp.org

3.pool.ntp.org"

Does this really needs to be a compile time definition? Can't this be specified in some configuration file? If so, then I believe it would be nicer.

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/Config.in  | 8 ++++++++
 package/systemd/systemd.mk | 6 ++++++
 2 files changed, 14 insertions(+)

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/Config.in  | 8 ++++++++
 package/systemd/systemd.mk | 6 ++++++
 2 files changed, 14 insertions(+)

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/Config.in  | 9 +++++++++
 package/systemd/systemd.mk | 6 ++++++
 2 files changed, 15 insertions(+)

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/Config.in  | 9 +++++++++
 package/systemd/systemd.mk | 6 ++++++
 2 files changed, 15 insertions(+)

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/Config.in  | 9 +++++++++
 package/systemd/systemd.mk | 6 ++++++
 2 files changed, 15 insertions(+)

package/systemd/Config.in +0 -0

index 2ebd825..2f89b0e 100644
@@ -118,6 +118,15 @@ config BR2_PACKAGE_SYSTEMD_QUOTACHECK
 

Dear Gabe Evans,

Quoted 14 lines · Gabe Evans

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/Config.in  | 9 +++++++++
 package/systemd/systemd.mk | 6 ++++++
 2 files changed, 15 insertions(+)

package/systemd/Config.in +0 -0

index 2ebd825..2f89b0e 100644
@@ -118,6 +118,15 @@ config BR2_PACKAGE_SYSTEMD_QUOTACHECK
 
 	  http://www.freedesktop.org/software/systemd/man/systemd-quotacheck.service.html
 

package/systemd/Config.in config BR2_PACKAGE_SYSTEMD_QUOTACHECK · line 128

Quoted 8 lines

package/systemd/Config.in +8 -0

+config BR2_PACKAGE_SYSTEMD_TMPFILES
+	bool "enable tmpfiles support"
+	help
+	  systemd-tmpfiles creates, deletes, and cleans up volatile and temporary
+	  files and directories, based on the configuration file format and location
+	  specified in tmpfiles.d(5).
+
+	  http://www.freedesktop.org/software/systemd/man/systemd-tmpfiles.html

Can this really be made optional? We have other packages that rely on the tmpfiles.d feature:

package/audit/audit.mk: mkdir -p $(TARGET_DIR)/usr/lib/tmpfiles.d
package/audit/audit.mk: $(INSTALL) -D -m 644 package/audit/audit_tmpfiles.conf \
package/audit/audit.mk:         $(TARGET_DIR)/usr/lib/tmpfiles.d/audit.conf
package/avahi/avahi.mk: $(INSTALL) -D -m 644 package/avahi/avahi_tmpfiles.conf \
package/avahi/avahi.mk:         $(TARGET_DIR)/usr/lib/tmpfiles.d/avahi.conf
package/dhcp/dhcp.mk:           $(TARGET_DIR)/usr/lib/tmpfiles.d/dhcpd.conf
package/dhcp/dhcp.mk:           $(TARGET_DIR)/usr/lib/tmpfiles.d/dhcpd.conf
package/nfs-utils/nfs-utils.mk: $(INSTALL) -D -m 0644 package/nfs-utils/nfs-utils_tmpfiles.conf \
package/nfs-utils/nfs-utils.mk:         $(TARGET_DIR)/usr/lib/tmpfiles.d/nfs-utils.conf

Maxime, what do you think?

Thanks!

Thomas

Quoted 17 lines · Thomas Petazzoni

Dear Gabe Evans,

Quoted 14 lines · Gabe Evans

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/Config.in  | 9 +++++++++
 package/systemd/systemd.mk | 6 ++++++
 2 files changed, 15 insertions(+)

package/systemd/Config.in +0 -0

index 2ebd825..2f89b0e 100644
@@ -118,6 +118,15 @@ config BR2_PACKAGE_SYSTEMD_QUOTACHECK
 
       http://www.freedesktop.org/software/systemd/man/systemd-quotacheck.service.html
 

Quoted 11 lines

package/systemd/Config.in config BR2_PACKAGE_SYSTEMD_QUOTACHECK · line 128

Quoted 8 lines

package/systemd/Config.in +8 -0

+config BR2_PACKAGE_SYSTEMD_TMPFILES
+    bool "enable tmpfiles support"
+    help
+      systemd-tmpfiles creates, deletes, and cleans up volatile and temporary
+      files and directories, based on the configuration file format and location
+      specified in tmpfiles.d(5).
+
+      http://www.freedesktop.org/software/systemd/man/systemd-tmpfiles.html

Can this really be made optional? We have other packages that rely on the tmpfiles.d feature:

Well, this is a bit similar to installing init scripts in /etc/init.d: that
assumes that it's a system with our /etc/init.d/rcS and an inittab that runs it.

However, it is essential that all (or many) of these systemd tools default y,
to mimic the current situation. I think for the ones that you committed up to now there is no harm in defaulting to no, but this one, random-seed, logind, hostnamed, and hwdb should definitely default y IMHO.

Regards,
Arnout

Quoted 12 lines

package/audit/audit.mk: mkdir -p $(TARGET_DIR)/usr/lib/tmpfiles.d
package/audit/audit.mk: $(INSTALL) -D -m 644 package/audit/audit_tmpfiles.conf \
package/audit/audit.mk:         $(TARGET_DIR)/usr/lib/tmpfiles.d/audit.conf
package/avahi/avahi.mk: $(INSTALL) -D -m 644 package/avahi/avahi_tmpfiles.conf \
package/avahi/avahi.mk:         $(TARGET_DIR)/usr/lib/tmpfiles.d/avahi.conf
package/dhcp/dhcp.mk:           $(TARGET_DIR)/usr/lib/tmpfiles.d/dhcpd.conf
package/dhcp/dhcp.mk:           $(TARGET_DIR)/usr/lib/tmpfiles.d/dhcpd.conf
package/nfs-utils/nfs-utils.mk: $(INSTALL) -D -m 0644 package/nfs-utils/nfs-utils_tmpfiles.conf \
package/nfs-utils/nfs-utils.mk:         $(TARGET_DIR)/usr/lib/tmpfiles.d/nfs-utils.conf

Maxime, what do you think?

Quoted 5 lines

Thanks!

Thomas

--

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Hi Arnout, Thomas, Gabe, all

Quoted 10 lines · Arnout Vandecappelle

Quoted 9 lines · Thomas Petazzoni

Dear Gabe Evans,

Quoted 6 lines · Gabe Evans

Signed-off-by Gabe Evans <[email protected]>

---
 package/systemd/Config.in  | 9 +++++++++
 package/systemd/systemd.mk | 6 ++++++
 2 files changed, 15 insertions(+)

Quoted 7 lines

Quoted 7 lines

package/systemd/Config.in config BR2_PACKAGE_SYSTEMD_QUOTACHECK · line 119

Quoted 7 lines

package/systemd/Config.in +0 -0

index 2ebd825..2f89b0e 100644
@@ -118,6 +118,15 @@ config BR2_PACKAGE_SYSTEMD_QUOTACHECK
 
 

http://www.freedesktop.org/software/systemd/man/systemd-quotacheck.service.html

Quoted 5 lines

Quoted 5 lines

package/systemd/Config.in config BR2_PACKAGE_SYSTEMD_QUOTACHECK

Quoted 5 lines

package/systemd/Config.in +4 -0

+config BR2_PACKAGE_SYSTEMD_TMPFILES
+    bool "enable tmpfiles support"
+    help
+      systemd-tmpfiles creates, deletes, and cleans up volatile and

temporary

Quoted 1 line

Quoted 1 line

package/systemd/Config.in config BR2_PACKAGE_SYSTEMD_QUOTACHECK · line 124

Quoted 1 line

package/systemd/Config.in +1 -0

+      files and directories, based on the configuration file format

and location

Quoted 3 lines

Quoted 3 lines

package/systemd/Config.in config BR2_PACKAGE_SYSTEMD_QUOTACHECK · line 129

Quoted 3 lines

package/systemd/Config.in +3 -0

+      specified in tmpfiles.d(5).
+
+

http://www.freedesktop.org/software/systemd/man/systemd-tmpfiles.html

Quoted 5 lines

Quoted 3 lines

Can this really be made optional? We have other packages that rely on the tmpfiles.d feature:

Well, this is a bit similar to installing init scripts in /etc/init.d:

that

Quoted 1 line

assumes that it's a system with our /etc/init.d/rcS and an inittab that

runs it.
Indeed, note that this will causes program to fail to start and/or behave in-appropriately (especially with a RO system).

Quoted 2 lines

However, it is essential that all (or many) of these systemd tools

default y,

Quoted 1 line

to mimic the current situation. I think for the ones that you committed

up to

Quoted 1 line

now there is no harm in defaulting to no, but this one, random-seed,

logind,

Quoted 1 line

hostnamed, and hwdb should definitely default y IMHO.

random-seed could default to n without a problem I think. I agree with you for the other.

Quoted 7 lines

Regards,
Arnout

Quoted 3 lines

package/audit/audit.mk: mkdir -p $(TARGET_DIR)/usr/lib/tmpfiles.d package/audit/audit.mk: $(INSTALL) -D -m 644

package/audit/audit_tmpfiles.conf \

Quoted 1 line

Quoted 1 line

package/audit/audit.mk:

$(TARGET_DIR)/usr/lib/tmpfiles.d/audit.conf

Quoted 1 line

Quoted 1 line

package/avahi/avahi.mk: $(INSTALL) -D -m 644

package/avahi/avahi_tmpfiles.conf \

Quoted 1 line

Quoted 1 line

package/avahi/avahi.mk:

$(TARGET_DIR)/usr/lib/tmpfiles.d/avahi.conf

Quoted 1 line

Quoted 1 line

package/dhcp/dhcp.mk:

$(TARGET_DIR)/usr/lib/tmpfiles.d/dhcpd.conf

Quoted 1 line

Quoted 1 line

package/dhcp/dhcp.mk:

$(TARGET_DIR)/usr/lib/tmpfiles.d/dhcpd.conf

Quoted 1 line

Quoted 1 line

package/nfs-utils/nfs-utils.mk: $(INSTALL) -D -m 0644

package/nfs-utils/nfs-utils_tmpfiles.conf \

Quoted 1 line

Quoted 1 line

package/nfs-utils/nfs-utils.mk:

$(TARGET_DIR)/usr/lib/tmpfiles.d/nfs-utils.conf

Quoted 2 lines

Quoted 2 lines

Maxime, what do you think?

Also, Gabe, if you want there's many more flags that you could enable/disable, I was planning to make a proper patch instead of the ugly one I have in my tree, but I currently add theses flags to systemd, that are a bit more than your selection, some of them are maybe redundant or even useless, it's a list of flags that follows me for a long time. But it drastically helped (along with the one you introduced) in reducing the bloat of systemd.

I will give your series a spin as it's really interesting for me to replace my dirty patch :)

--disable-acl
--disable-apparmor
--disable-audit
--disable-chkconfig
--disable-compat-libs
--disable-coverage
--disable-dbus
--disable-efi
--disable-elfutils
--disable-gcrypt
--disable-gnutls
--disable-gtk-doc
--disable-gtk-doc-html
--disable-gtk-doc-pdf
--disable-gudev
--disable-ima
--disable-kdbus
--disable-ldconfig
--disable-libcryptsetup
--disable-libcurl
--disable-libidn
--disable-manpages
--disable-multi-seat-x
--disable-myhostname
--disable-networkd
--disable-nls
--disable-pam
--disable-python-devel
--disable-qrencode
--disable-resolved
--disable-seccomp
--disable-selinux
--disable-smack
--disable-terminal
--disable-tests
--disable-utmp
--disable-xattr
--disable-xkbcommon
--enable-blkid

Quoted 18 lines

Quoted 5 lines

Thanks!

Thomas

--

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

I've made improvements to the systemd package to allow more fine-grained selection of tools and services. With these additions, it's possible to reduce the install footprint by about 60% (~12 MB).

Thanks,
Gabe

Gabe Evans (32):
package/lz4: bump version to r131 package/systemd: remove BR2_PACKAGE_SYSTEMD_ALL_EXTRAS package/systemd: add --enable/disable-bzip2 package/systemd: add --enable/disable-lz4 package/systemd: add --enable/disable-zlib package/systemd: add --enable/disable-libcurl package/systemd: explicitly --enable/disable-microhttpd package/systemd: remove networkd depends from timesyncd package/systemd: add support for specifying NTP servers package/systemd: add optional support for binfmt package/systemd: add optional support for vconsole package/systemd: add optional support for bootchart package/systemd: add optional support for quotacheck package/systemd: add optional support for tmpfiles package/systemd: add optional support for sysusers package/systemd: add optional support for firstboot package/systemd: add optional support for random-seed package/systemd: add optional support for backlight package/systemd: add optional support for rfkill package/systemd: add optional support for logind package/systemd: add optional support for machined package/systemd: add optional support for importd package/systemd: add optional support for hostnamed package/systemd: add optional support for timedated package/systemd: add optional support for localed package/systemd: add optional support for coredump package/systemd: add optional support for polkit package/systemd: add optional support for hwdb package/systemd: add optional support for hibernation package/systemd: use 'menuconfig' package/systemd: only create 'systemd-journal' group package/systemd: remove unnecessary make opts

 package/lz4/lz4.hash       |   2 +
 package/lz4/lz4.mk         |  19 ++--
 package/systemd/Config.in  | 210 ++++++++++++++++++++++++++++++++++++++++++---
 package/systemd/systemd.mk | 180 +++++++++++++++++++++++++++++++++++---
 4 files changed, 379 insertions(+), 32 deletions(-)
 create mode 100644 package/lz4/lz4.hash

Signature · 6 lines

1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Gabe, All,

On 2016-02-25 21:55 +0000, Gabe Evans spake thusly:

Quoted 3 lines

I've made improvements to the systemd package to allow more fine-grained selection of tools and services. With these additions, it's possible to reduce the install footprint by about 60% (~12 MB).

Soem of those patches have already been applied. However, some of them are still pending. Sorry it takes so long to review the rest of your series.

FYI, I'm during some heavy-lifting [0] in the way we are handling a systemd-based system in Buildroot, and I plan on looking at the rest of your series when I wrapped my head around systemd.

[0] https://git.buildroot.org/~ymorin/git/buildroot/log/?h=yem/systemd-skeleton

In the meantime, it would be really great if you could rebase the rest of your series on top of the latest master and repost it. Please add me in Cc: (at least on the cover-letter, or even on each patch).

Thanks!

Regards,
Yann E. MORIN.

Quoted 44 lines

Thanks,
Gabe

Gabe Evans (32):
package/lz4: bump version to r131 package/systemd: remove BR2_PACKAGE_SYSTEMD_ALL_EXTRAS package/systemd: add --enable/disable-bzip2 package/systemd: add --enable/disable-lz4 package/systemd: add --enable/disable-zlib package/systemd: add --enable/disable-libcurl package/systemd: explicitly --enable/disable-microhttpd package/systemd: remove networkd depends from timesyncd package/systemd: add support for specifying NTP servers package/systemd: add optional support for binfmt package/systemd: add optional support for vconsole package/systemd: add optional support for bootchart package/systemd: add optional support for quotacheck package/systemd: add optional support for tmpfiles package/systemd: add optional support for sysusers package/systemd: add optional support for firstboot package/systemd: add optional support for random-seed package/systemd: add optional support for backlight package/systemd: add optional support for rfkill package/systemd: add optional support for logind package/systemd: add optional support for machined package/systemd: add optional support for importd package/systemd: add optional support for hostnamed package/systemd: add optional support for timedated package/systemd: add optional support for localed package/systemd: add optional support for coredump package/systemd: add optional support for polkit package/systemd: add optional support for hwdb package/systemd: add optional support for hibernation package/systemd: use 'menuconfig' package/systemd: only create 'systemd-journal' group package/systemd: remove unnecessary make opts

 package/lz4/lz4.hash       |   2 +
 package/lz4/lz4.mk         |  19 ++--
 package/systemd/Config.in  | 210 ++++++++++++++++++++++++++++++++++++++++++---
 package/systemd/systemd.mk | 180 +++++++++++++++++++++++++++++++++++---
 4 files changed, 379 insertions(+), 32 deletions(-)
 create mode 100644 package/lz4/lz4.hash

Quoted 7 lines

--
1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

--
.-----------------.--------------------.------------------.--------------------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |

'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Hi all,

Your series has been marked as Changes Requested as there is a few issues, I will add some patch over your series and repost it.

Thanks for your work !

Quoted 5 lines · Yann E. MORIN

Gabe, All,

On 2016-02-25 21:55 +0000, Gabe Evans spake thusly:

Quoted 2 lines

I've made improvements to the systemd package to allow more fine-grained selection of tools and services. With these additions, it's possible to

reduce

Quoted 11 lines

Quoted 1 line

the install footprint by about 60% (~12 MB).

Soem of those patches have already been applied. However, some of them are still pending. Sorry it takes so long to review the rest of your series.

FYI, I'm during some heavy-lifting [0] in the way we are handling a systemd-based system in Buildroot, and I plan on looking at the rest of your series when I wrapped my head around systemd.

[0]

https://git.buildroot.org/~ymorin/git/buildroot/log/?h=yem/systemd-skeleton

Quoted 50 lines

In the meantime, it would be really great if you could rebase the rest of your series on top of the latest master and repost it. Please add me in Cc: (at least on the cover-letter, or even on each patch).

Thanks!

Regards,
Yann E. MORIN.

Quoted 40 lines

Thanks,
Gabe

Gabe Evans (32):
package/lz4: bump version to r131 package/systemd: remove BR2_PACKAGE_SYSTEMD_ALL_EXTRAS package/systemd: add --enable/disable-bzip2 package/systemd: add --enable/disable-lz4 package/systemd: add --enable/disable-zlib package/systemd: add --enable/disable-libcurl package/systemd: explicitly --enable/disable-microhttpd package/systemd: remove networkd depends from timesyncd package/systemd: add support for specifying NTP servers package/systemd: add optional support for binfmt package/systemd: add optional support for vconsole package/systemd: add optional support for bootchart package/systemd: add optional support for quotacheck package/systemd: add optional support for tmpfiles package/systemd: add optional support for sysusers package/systemd: add optional support for firstboot package/systemd: add optional support for random-seed package/systemd: add optional support for backlight package/systemd: add optional support for rfkill package/systemd: add optional support for logind package/systemd: add optional support for machined package/systemd: add optional support for importd package/systemd: add optional support for hostnamed package/systemd: add optional support for timedated package/systemd: add optional support for localed package/systemd: add optional support for coredump package/systemd: add optional support for polkit package/systemd: add optional support for hwdb package/systemd: add optional support for hibernation package/systemd: use 'menuconfig' package/systemd: only create 'systemd-journal' group package/systemd: remove unnecessary make opts

 package/lz4/lz4.hash       |   2 +
 package/lz4/lz4.mk         |  19 ++--
 package/systemd/Config.in  | 210

++++++++++++++++++++++++++++++++++++++++++---

Quoted 1 line

Quoted 1 line

 package/systemd/systemd.mk | 180

+++++++++++++++++++++++++++++++++++---

Quoted 6 lines

Quoted 6 lines

 4 files changed, 379 insertions(+), 32 deletions(-)
 create mode 100644 package/lz4/lz4.hash

--
1.9.1

Quoted 7 lines

Quoted 4 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

--

.-----------------.--------------------.------------------.--------------------.

Quoted 1 line

| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics'

conspiracy: |

Quoted 1 line

| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___

       |

Quoted 1 line

| +33 223 225 172 `------------.-------: X AGAINST | \e/ There

is no |

Quoted 1 line

| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v

conspiracy. |

Quoted 1 line

'------------------------------^-------^------------------^--------------------'

Quoted 4 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot