Skip to contentSkip to conversation

coreboot: fix "make default_payload.elf"

PATCH In review Antonello Dettori 2 participants 2 messages Feb 26, 2016 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 coreboot: fix "make default_payload.elf"

When building grub as a payload for coreboot the compiling stops at this line:
"rm: cannot remove 'default_payload.elf': No such file or directory" (Full log <http://pastebin.com/vwjycq82>)
It seems like it's trying to delete default_payload.elf before it is even created without any apparent reason or explanation.

Tested, "make default_payload.elf" now works and the final executable works as expected.

---

 Makefile.am | 1 -
 1 file changed, 1 deletion(-)
Makefile.am +0 -1
index 288e621..82154d8 100644
@@ -410,7 +410,6 @@ bootcheck: $(BOOTCHECKS)
 
 if COND_i386_coreboot
 default_payload.elf: grub-mkstandalone grub-mkimage FORCE
-    rm $@
     pkgdatadir=. ./grub-mkstandalone --grub-mkimage=./grub-mkimage -O 

i386-coreboot -o $@ --modules='ahci pata ehci uhci ohci usb_keyboard usbms part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs' --install-modules='ls linux search configfile normal cbtime cbls memrw iorw minicmd lsmmap lspci halt reboot hexdump pcidump regexp setpci lsacpi chain test serial multiboot cbmemc linux16 gzio echo help syslinuxcfg xnu $(shell cat grub-core/fs.lst) password_pbkdf2 $(EXTRA_PAYLOAD_MODULES)' --fonts= --themes= --locales= -d grub-core/ /boot/grub/grub.cfg=$(srcdir)/coreboot.cfg
endif

#1 lore raw

Reason for this RM is to avoid stale for in case of failure. I fixed RM invocation

Quoted 41 lines · Antonello Dettori

When building grub as a payload for coreboot the compiling stops at this line:
"rm: cannot remove 'default_payload.elf': No such file or directory" (Full log <http://pastebin.com/vwjycq82>)
It seems like it's trying to delete default_payload.elf before it is even created without any apparent reason or explanation.

Tested, "make default_payload.elf" now works and the final executable works as expected.

---

 Makefile.am | 1 -
 1 file changed, 1 deletion(-)
Makefile.am +0 -1
index 288e621..82154d8 100644
@@ -410,7 +410,6 @@ bootcheck: $(BOOTCHECKS)
 
 if COND_i386_coreboot
 default_payload.elf: grub-mkstandalone grub-mkimage FORCE
-    rm $@
     pkgdatadir=. ./grub-mkstandalone --grub-mkimage=./grub-mkimage -O

i386-coreboot -o $@ --modules='ahci pata ehci uhci ohci usb_keyboard usbms part_msdos ext2 fat at_keyboard part_gpt usbserial_usbdebug cbfs' --install-modules='ls linux search configfile normal cbtime cbls memrw iorw minicmd lsmmap lspci halt reboot hexdump pcidump regexp setpci lsacpi chain test serial multiboot cbmemc linux16 gzio echo help syslinuxcfg xnu $(shell cat grub-core/fs.lst) password_pbkdf2 $(EXTRA_PAYLOAD_MODULES)' --fonts= --themes= --locales= -d grub-core/ /boot/grub/grub.cfg=$(srcdir)/coreboot.cfg
endif
_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel