SubmittingPatches : WIP tag in patches
PATCH 1/1 SubmittingPatches : WIP tag in patches
--- Documentation/SubmittingPatches | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
(quoted diff) +0 -0
b/Documentation/SubmittingPatches
index 98fc4cc..b2c7664 100644
Documentation/SubmittingPatches +0 -0
@@ -168,7 +168,9 @@ the closing bracket to mark the nature of the patch
is also
encouraged. E.g. [PATCH/RFC] is often used when the patch is not ready to be applied but it is for discussion, [PATCH v2], [PATCH v3] etc. are often seen when you are sending an update to
-what you have previously sent.
+what you have previously sent. [PATCH/WIP] is often used when some +work is yet left to be done on the patch but you want to get the +review on the completed part of the patch.
"git format-patch" command follows the best current practice to format the body of an e-mail message. At the beginning of the
Signature · 1 line
2.1.4
Quoted 1 line · Pranit Bauva
---
Missing sign-off.
Review
Quoted 8 lines
(quoted diff) +0
-0@@ -168,7 +168,9 @@ the closing bracket to mark the nature of the patchis also
encouraged. E.g. [PATCH/RFC] is often used when the patch is not ready to be applied but it is for discussion, [PATCH v2], [PATCH v3] etc. are often seen when you are sending an update to(quoted diff) +1
-1-what you have previously sent. +what you have previously sent. [PATCH/WIP] is often used when some
Perhaps: /is often/can be/
Review
Quoted 2 lines
(quoted diff) +2
-0+work is yet left to be done on the patch but you want to get the +review on the completed part of the patch.
Maybe: s/review/feedback/
Quoted 4 lines
"git format-patch" command follows the best current practice to format the body of an e-mail message. At the beginning of the
--
2.1.4
Eric Sunshine:
Quoted 5 lines · Pranit Bauva
Quoted 1 line
---
Missing sign-off.
I have to inoculate the habit of signing off every time.
Quoted 11 lines
Review
Quoted 8 lines
(quoted diff) +0
-0@@ -168,7 +168,9 @@ the closing bracket to mark the nature of the patchis also
encouraged. E.g. [PATCH/RFC] is often used when the patch is not ready to be applied but it is for discussion, [PATCH v2], [PATCH v3] etc. are often seen when you are sending an update to(quoted diff) +1
-1-what you have previously sent. +what you have previously sent. [PATCH/WIP] is often used when somePerhaps: /is often/can be/
Quoted 9 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+work is yet left to be done on the patch but you want to get the +review on the completed part of the patch.Maybe: s/review/feedback/
Quoted 4 lines
"git format-patch" command follows the best current practice to format the body of an e-mail message. At the beginning of the
--
2.1.4
I have done the required changes, now I should send another email with tag [PATCH v2] right?
Quoted 1 line · Pranit Bauva
I have to inoculate the habit of signing off every time.
There is this in git-config(1); hope that helps.
format.signOff
A boolean value which lets you enable the -s/--signoff option of format-patch by default. Note: Adding the Signed-off-by: line to a patch should be a conscious act and means that you certify you have the rights to submit this work under the same open source license. Please see the SubmittingPatches document for further discussion.
Stefan
Quoted 22 lines · Pranit Bauva
Eric Sunshine:
Quoted 3 lines · Pranit Bauva
Quoted 1 line
---
Missing sign-off.
I have to inoculate the habit of signing off every time.
Quoted 16 lines
Review
Quoted 8 lines
(quoted diff) +0
-0@@ -168,7 +168,9 @@ the closing bracket to mark the nature of the patchis also
encouraged. E.g. [PATCH/RFC] is often used when the patch is not ready to be applied but it is for discussion, [PATCH v2], [PATCH v3] etc. are often seen when you are sending an update to(quoted diff) +1
-1-what you have previously sent. +what you have previously sent. [PATCH/WIP] is often used when somePerhaps: /is often/can be/
Review
Quoted 2 lines
(quoted diff) +2
-0+work is yet left to be done on the patch but you want to get the +review on the completed part of the patch.Maybe: s/review/feedback/
Quoted 7 lines
Quoted 4 lines
Quoted 4 lines
"git format-patch" command follows the best current practice to format the body of an e-mail message. At the beginning of the
--
2.1.4I have done the required changes, now I should send another email with tag [PATCH v2] right?
Yes, you can do that, or wait a bit longer for feedback from other reviewers.
It's also a good idea in the commentary section to say what changed between v1 and v2, and, as an aid to reviewers, provide a link like this[1] to the previous version.
[1]: http://thread.gmane.org/gmane.comp.version-control.git/287544