Skip to contentSkip to conversation

usb: ehci: Fix warning on aarch64

PATCH New Marek Vasut 2 participants 3 messages Feb 26, 2016

Subsystems (2)
USB USB ehci driver
lore
Share & tools
lore

Marek Vasut

author
#0 lore raw

PATCH 1/1 usb: ehci: Fix warning on aarch64

Fix the following warning on aarch64 introduced by using p2v/v2p functions in the code:

In file included from ./arch/arm/include/asm/byteorder.h:29:0,
from include/compiler.h:125,
from include/image.h:19,
from include/common.h:88,
from drivers/usb/host/ehci-hcd.c:10:
drivers/usb/host/ehci-hcd.c: In function ?ehci_td_buffer?:
drivers/usb/host/ehci-hcd.c:250:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

   td->qt_buffer[idx] = cpu_to_hc32(virt_to_phys((void *)addr));
                                                 ^
include/linux/byteorder/little_endian.h:34:51: note: in definition of macro ?__cpu_to_le32?
 #define __cpu_to_le32(x) ((__force __le32)(__u32)(x))
                                                   ^

drivers/usb/host/ehci-hcd.c:250:24: note: in expansion of macro ?cpu_to_hc32?
td->qt_buffer[idx] = cpu_to_hc32(virt_to_phys((void *)addr));

Signed-off-by Marek Vasut <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Tom Rini <[email protected]>
---
 drivers/usb/host/ehci-hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/host/ehci-hcd.c +1 -1
index 8f259be..0113c6c 100644
@@ -237,7 +237,7 @@ static int ehci_shutdown(struct ehci_ctrl *ctrl)
 static int ehci_td_buffer(struct qTD *td, void *buf, size_t sz)
 {
 	uint32_t delta, next;
-	uint32_t addr = (unsigned long)buf;
+	unsigned long addr = (unsigned long)buf;
 	int idx;
 
 	if (addr != ALIGN(addr, ARCH_DMA_MINALIGN))
Signature · 1 line
2.7.0
#1 lore raw

PATCH 1/1 usb: ehci: Fix warning on aarch64

Quoted 15 lines · Marek Vasut

Fix the following warning on aarch64 introduced by using p2v/v2p functions in the code:

In file included from ./arch/arm/include/asm/byteorder.h:29:0,
from include/compiler.h:125,
from include/image.h:19,
from include/common.h:88,
from drivers/usb/host/ehci-hcd.c:10:
drivers/usb/host/ehci-hcd.c: In function ?ehci_td_buffer?:
drivers/usb/host/ehci-hcd.c:250:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

   td->qt_buffer[idx] = cpu_to_hc32(virt_to_phys((void *)addr));
                                                 ^
include/linux/byteorder/little_endian.h:34:51: note: in definition of macro ?__cpu_to_le32?
 #define __cpu_to_le32(x) ((__force __le32)(__u32)(x))
                                                   ^
Quoted 6 lines

drivers/usb/host/ehci-hcd.c:250:24: note: in expansion of macro ?cpu_to_hc32?
td->qt_buffer[idx] = cpu_to_hc32(virt_to_phys((void *)addr));

Signed-off-by Marek Vasut <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Tom Rini <[email protected]>
Reviewed-by Tom Rini <[email protected]>
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160226/e54c5ce2/attachment.sig>
author
#2 lore raw

PATCH 1/1 usb: ehci: Fix warning on aarch64

Quoted 20 lines · Tom Rini
Quoted 18 lines · Marek Vasut

Fix the following warning on aarch64 introduced by using p2v/v2p functions in the code:

In file included from ./arch/arm/include/asm/byteorder.h:29:0,
from include/compiler.h:125,
from include/image.h:19,
from include/common.h:88,
from drivers/usb/host/ehci-hcd.c:10:
drivers/usb/host/ehci-hcd.c: In function ?ehci_td_buffer?:
drivers/usb/host/ehci-hcd.c:250:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

   td->qt_buffer[idx] = cpu_to_hc32(virt_to_phys((void *)addr));
                                                 ^
include/linux/byteorder/little_endian.h:34:51: note: in definition of macro ?__cpu_to_le32?
 #define __cpu_to_le32(x) ((__force __le32)(__u32)(x))
                                                   ^

drivers/usb/host/ehci-hcd.c:250:24: note: in expansion of macro ?cpu_to_hc32?
td->qt_buffer[idx] = cpu_to_hc32(virt_to_phys((void *)addr));

Quoted 5 lines
Quoted 3 lines
Signed-off-by Marek Vasut <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Tom Rini <[email protected]>
Reviewed-by Tom Rini <[email protected]>

In that case, applied, thanks!

Signature · 2 lines
Best regards,
Marek Vasut