Skip to contentSkip to conversation

package/ffmpeg: Fix i486 compilation with gcc5

PATCH New Bernd Kuhls 3 participants 3 messages Feb 27, 2016 – Mar 2, 2016

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH 1/1 package/ffmpeg: Fix i486 compilation with gcc5

Fixes

In file included from libpostproc/postprocess.c:539:0:
libpostproc/postprocess_template.c: In function 'postProcess_MMX':
libpostproc/postprocess_template.c:3184:5: error: 'asm' operand has impossible constraints

     __asm__ volatile(
     ^
libpostproc/postprocess_template.c:3101:5: error: 'asm' operand has impossible constraints
     __asm__ volatile(
     ^

using this defconfig:

BR2_x86_i486=y
BR2_PACKAGE_FFMPEG=y
BR2_PACKAGE_FFMPEG_GPL=y
BR2_PACKAGE_FFMPEG_POSTPROC=y

This is a follow-up patch for
https://git.busybox.net/buildroot/commit/?id=bfb8df2ad9b164b421d25294c6882c8b61dc59a5

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/ffmpeg/ffmpeg.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/ffmpeg/ffmpeg.mk +1 -1
index ddfac20..183d003 100644
@@ -352,7 +352,7 @@ ifeq ($(BR2_X86_CPU_HAS_MMX),y)
 FFMPEG_CONF_OPTS += --enable-yasm
 FFMPEG_DEPENDENCIES += host-yasm
 else
-ifeq ($(BR2_x86_i586),y)
+ifeq ($(BR2_x86_i486)$(BR2_x86_i586),y)
 # Needed to work around a bug with gcc 5.x:
 # error: 'asm' operand has impossible constraints
 FFMPEG_CONF_OPTS += --disable-inline-asm
Signature · 1 line
2.7.0
#1 lore raw

PATCH 1/1 package/ffmpeg: Fix i486 compilation with gcc5

Quoted 30 lines · Bernd Kuhls

Fixes

In file included from libpostproc/postprocess.c:539:0:
libpostproc/postprocess_template.c: In function 'postProcess_MMX':
libpostproc/postprocess_template.c:3184:5: error: 'asm' operand has impossible constraints

     __asm__ volatile(
     ^
libpostproc/postprocess_template.c:3101:5: error: 'asm' operand has impossible constraints
     __asm__ volatile(
     ^

using this defconfig:

BR2_x86_i486=y
BR2_PACKAGE_FFMPEG=y
BR2_PACKAGE_FFMPEG_GPL=y
BR2_PACKAGE_FFMPEG_POSTPROC=y

This is a follow-up patch for
https://git.busybox.net/buildroot/commit/?id=bfb8df2ad9b164b421d25294c6882c8b61dc59a5

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/ffmpeg/ffmpeg.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/ffmpeg/ffmpeg.mk +0 -0
index ddfac20..183d003 100644

package/ffmpeg/ffmpeg.mk ifeq ($(BR2_X86_CPU_HAS_MMX),y) · line 355

Quoted 5 lines
package/ffmpeg/ffmpeg.mk +1 -1
@@ -352,7 +352,7 @@ ifeq ($(BR2_X86_CPU_HAS_MMX),y)
 FFMPEG_CONF_OPTS += --enable-yasm
 FFMPEG_DEPENDENCIES += host-yasm
 else
-ifeq ($(BR2_x86_i586),y)
+ifeq ($(BR2_x86_i486)$(BR2_x86_i586),y)

What about BR2_x86_x1000? It's more or less identical to i586 so probably same
story. And i686? i386?

Regards,
Arnout

Quoted 4 lines
package/ffmpeg/ffmpeg.mk +0 -0
 # Needed to work around a bug with gcc 5.x:
 # error: 'asm' operand has impossible constraints
 FFMPEG_CONF_OPTS += --disable-inline-asm
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#2 lore raw

PATCH 1/1 package/ffmpeg: Fix i486 compilation with gcc5

In reply to Bernd Kuhls

Dear Bernd Kuhls,

Quoted 10 lines · Bernd Kuhls

Fixes

In file included from libpostproc/postprocess.c:539:0:
libpostproc/postprocess_template.c: In function 'postProcess_MMX':
libpostproc/postprocess_template.c:3184:5: error: 'asm' operand has impossible constraints

     __asm__ volatile(
     ^
libpostproc/postprocess_template.c:3101:5: error: 'asm' operand has impossible constraints
     __asm__ volatile(
     ^
Quoted 6 lines

using this defconfig:

BR2_x86_i486=y
BR2_PACKAGE_FFMPEG=y
BR2_PACKAGE_FFMPEG_GPL=y
BR2_PACKAGE_FFMPEG_POSTPROC=y

This defconfig is not using gcc 5: we still default to gcc 4.9.

So are you sure the problem is specific to gcc5 ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com