media.h: use hex values for the range offsets, move connectors base up.
Subsystems (2)
PATCH 1/1 media.h: use hex values for the range offsets, move connectors base up.
Make the base offset hexadecimal to simplify debugging since the base addresses are hex too.
The offsets for connectors is also changed to start after the 'reserved' range 0x10000-0x2ffff.
include/uapi/linux/media.h +15 -15
@@ -66,17 +66,17 @@ struct media_device_info {/* * DVB entities */ -#define MEDIA_ENT_F_DTV_DEMOD (MEDIA_ENT_F_BASE + 1) -#define MEDIA_ENT_F_TS_DEMUX (MEDIA_ENT_F_BASE + 2) -#define MEDIA_ENT_F_DTV_CA (MEDIA_ENT_F_BASE + 3) -#define MEDIA_ENT_F_DTV_NET_DECAP (MEDIA_ENT_F_BASE + 4) +#define MEDIA_ENT_F_DTV_DEMOD (MEDIA_ENT_F_BASE + 0x00001) +#define MEDIA_ENT_F_TS_DEMUX (MEDIA_ENT_F_BASE + 0x00002) +#define MEDIA_ENT_F_DTV_CA (MEDIA_ENT_F_BASE + 0x00003) +#define MEDIA_ENT_F_DTV_NET_DECAP (MEDIA_ENT_F_BASE + 0x00004)/* * I/O entities */ -#define MEDIA_ENT_F_IO_DTV (MEDIA_ENT_F_BASE + 1001) -#define MEDIA_ENT_F_IO_VBI (MEDIA_ENT_F_BASE + 1002) -#define MEDIA_ENT_F_IO_SWRADIO (MEDIA_ENT_F_BASE + 1003) +#define MEDIA_ENT_F_IO_DTV (MEDIA_ENT_F_BASE + 0x01001) +#define MEDIA_ENT_F_IO_VBI (MEDIA_ENT_F_BASE + 0x01002) +#define MEDIA_ENT_F_IO_SWRADIO (MEDIA_ENT_F_BASE + 0x01003)/* * Analog TV IF-PLL decoders
@@ -84,23 +84,23 @@ struct media_device_info {* It is a responsibility of the master/bridge drivers to create links * for MEDIA_ENT_F_IF_VID_DECODER and MEDIA_ENT_F_IF_AUD_DECODER. */ -#define MEDIA_ENT_F_IF_VID_DECODER (MEDIA_ENT_F_BASE + 2001) -#define MEDIA_ENT_F_IF_AUD_DECODER (MEDIA_ENT_F_BASE + 2002) +#define MEDIA_ENT_F_IF_VID_DECODER (MEDIA_ENT_F_BASE + 0x02001) +#define MEDIA_ENT_F_IF_AUD_DECODER (MEDIA_ENT_F_BASE + 0x02002)/* * Audio Entity Functions */ -#define MEDIA_ENT_F_AUDIO_CAPTURE (MEDIA_ENT_F_BASE + 3000) -#define MEDIA_ENT_F_AUDIO_PLAYBACK (MEDIA_ENT_F_BASE + 3001) -#define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 3002) +#define MEDIA_ENT_F_AUDIO_CAPTURE (MEDIA_ENT_F_BASE + 0x03000) +#define MEDIA_ENT_F_AUDIO_PLAYBACK (MEDIA_ENT_F_BASE + 0x03001) +#define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 0x03002)/* * Connectors */ /* It is a responsibility of the entity drivers to add connectors and links */ -#define MEDIA_ENT_F_CONN_RF (MEDIA_ENT_F_BASE + 10001) -#define MEDIA_ENT_F_CONN_SVIDEO (MEDIA_ENT_F_BASE + 10002) -#define MEDIA_ENT_F_CONN_COMPOSITE (MEDIA_ENT_F_BASE + 10003) +#define MEDIA_ENT_F_CONN_RF (MEDIA_ENT_F_BASE + 0x30001) +#define MEDIA_ENT_F_CONN_SVIDEO (MEDIA_ENT_F_BASE + 0x30002) +#define MEDIA_ENT_F_CONN_COMPOSITE (MEDIA_ENT_F_BASE + 0x30003)/* * Don't touch on those. The ranges MEDIA_ENT_F_OLD_BASE and
Laurent Pinchart
maintainerHi Hans,
Thank you for the patch.
Quoted 2 lines · On Monday 29 February 2016 09:02:47 Hans Verkuil wrote:
Make the base offset hexadecimal to simplify debugging since the base addresses are hex too.
This is much better, it will help debugging.
Before applying the patch, though, I wonder whether 4096 functions by categories isn't a bit overkill. Have you given that any thought, or did you select 1000/0x1000 just for convenience ?
Quoted 66 lines
The offsets for connectors is also changed to start after the 'reserved' range 0x10000-0x2ffff.
Signed-off-by Hans Verkuil <[email protected]>include/uapi/linux/media.h +15
-14@@ -66,17 +66,17 @@ struct media_device_info {/* * DVB entities */ -#define MEDIA_ENT_F_DTV_DEMOD (MEDIA_ENT_F_BASE + 1) -#define MEDIA_ENT_F_TS_DEMUX (MEDIA_ENT_F_BASE + 2) -#define MEDIA_ENT_F_DTV_CA (MEDIA_ENT_F_BASE + 3) -#define MEDIA_ENT_F_DTV_NET_DECAP (MEDIA_ENT_F_BASE + 4) +#define MEDIA_ENT_F_DTV_DEMOD (MEDIA_ENT_F_BASE + 0x00001) +#define MEDIA_ENT_F_TS_DEMUX (MEDIA_ENT_F_BASE + 0x00002) +#define MEDIA_ENT_F_DTV_CA (MEDIA_ENT_F_BASE + 0x00003) +#define MEDIA_ENT_F_DTV_NET_DECAP (MEDIA_ENT_F_BASE + 0x00004)/* * I/O entities */ -#define MEDIA_ENT_F_IO_DTV (MEDIA_ENT_F_BASE + 1001) -#define MEDIA_ENT_F_IO_VBI (MEDIA_ENT_F_BASE + 1002) -#define MEDIA_ENT_F_IO_SWRADIO (MEDIA_ENT_F_BASE + 1003) +#define MEDIA_ENT_F_IO_DTV (MEDIA_ENT_F_BASE + 0x01001) +#define MEDIA_ENT_F_IO_VBI (MEDIA_ENT_F_BASE + 0x01002) +#define MEDIA_ENT_F_IO_SWRADIO (MEDIA_ENT_F_BASE + 0x01003)/* * Analog TV IF-PLL decoders @@ -84,23 +84,23 @@ struct media_device_info {* It is a responsibility of the master/bridge drivers to create links * for MEDIA_ENT_F_IF_VID_DECODER and MEDIA_ENT_F_IF_AUD_DECODER. */ -#define MEDIA_ENT_F_IF_VID_DECODER (MEDIA_ENT_F_BASE + 2001) -#define MEDIA_ENT_F_IF_AUD_DECODER (MEDIA_ENT_F_BASE + 2002) +#define MEDIA_ENT_F_IF_VID_DECODER (MEDIA_ENT_F_BASE + 0x02001) +#define MEDIA_ENT_F_IF_AUD_DECODER (MEDIA_ENT_F_BASE + 0x02002)/* * Audio Entity Functions */ -#define MEDIA_ENT_F_AUDIO_CAPTURE (MEDIA_ENT_F_BASE + 3000) -#define MEDIA_ENT_F_AUDIO_PLAYBACK (MEDIA_ENT_F_BASE + 3001) -#define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 3002) +#define MEDIA_ENT_F_AUDIO_CAPTURE (MEDIA_ENT_F_BASE + 0x03000) +#define MEDIA_ENT_F_AUDIO_PLAYBACK (MEDIA_ENT_F_BASE + 0x03001) +#define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 0x03002)/* * Connectors */ /* It is a responsibility of the entity drivers to add connectors and links */ -#define MEDIA_ENT_F_CONN_RF (MEDIA_ENT_F_BASE + 10001) -#define MEDIA_ENT_F_CONN_SVIDEO (MEDIA_ENT_F_BASE + 10002) -#define MEDIA_ENT_F_CONN_COMPOSITE (MEDIA_ENT_F_BASE + 10003) +#define MEDIA_ENT_F_CONN_RF (MEDIA_ENT_F_BASE + 0x30001) +#define MEDIA_ENT_F_CONN_SVIDEO (MEDIA_ENT_F_BASE + 0x30002) +#define MEDIA_ENT_F_CONN_COMPOSITE (MEDIA_ENT_F_BASE + 0x30003)/* * Don't touch on those. The ranges MEDIA_ENT_F_OLD_BASE and
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 5 lines · Laurent Pinchart
Hi Hans,
Thank you for the patch.
On Monday 29 February 2016 09:02:47 Hans Verkuil wrote:
Quoted 8 lines
Quoted 2 lines
Make the base offset hexadecimal to simplify debugging since the base addresses are hex too.
This is much better, it will help debugging.
Before applying the patch, though, I wonder whether 4096 functions by categories isn't a bit overkill. Have you given that any thought, or did you select 1000/0x1000 just for convenience ?
Convenience. It's overkill, yes, but we have 32 bits to play with, so no need to restrict ourselves unnecessary.
It's also easy to read the hex value and quickly see which range it is.
Regards,
Hans
Quoted 68 lines
Quoted 67 lines
The offsets for connectors is also changed to start after the 'reserved' range 0x10000-0x2ffff.
Signed-off-by Hans Verkuil <[email protected]>include/uapi/linux/media.h +15
-14@@ -66,17 +66,17 @@ struct media_device_info {/* * DVB entities */ -#define MEDIA_ENT_F_DTV_DEMOD (MEDIA_ENT_F_BASE + 1) -#define MEDIA_ENT_F_TS_DEMUX (MEDIA_ENT_F_BASE + 2) -#define MEDIA_ENT_F_DTV_CA (MEDIA_ENT_F_BASE + 3) -#define MEDIA_ENT_F_DTV_NET_DECAP (MEDIA_ENT_F_BASE + 4) +#define MEDIA_ENT_F_DTV_DEMOD (MEDIA_ENT_F_BASE + 0x00001) +#define MEDIA_ENT_F_TS_DEMUX (MEDIA_ENT_F_BASE + 0x00002) +#define MEDIA_ENT_F_DTV_CA (MEDIA_ENT_F_BASE + 0x00003) +#define MEDIA_ENT_F_DTV_NET_DECAP (MEDIA_ENT_F_BASE + 0x00004)/* * I/O entities */ -#define MEDIA_ENT_F_IO_DTV (MEDIA_ENT_F_BASE + 1001) -#define MEDIA_ENT_F_IO_VBI (MEDIA_ENT_F_BASE + 1002) -#define MEDIA_ENT_F_IO_SWRADIO (MEDIA_ENT_F_BASE + 1003) +#define MEDIA_ENT_F_IO_DTV (MEDIA_ENT_F_BASE + 0x01001) +#define MEDIA_ENT_F_IO_VBI (MEDIA_ENT_F_BASE + 0x01002) +#define MEDIA_ENT_F_IO_SWRADIO (MEDIA_ENT_F_BASE + 0x01003)/* * Analog TV IF-PLL decoders @@ -84,23 +84,23 @@ struct media_device_info {* It is a responsibility of the master/bridge drivers to create links * for MEDIA_ENT_F_IF_VID_DECODER and MEDIA_ENT_F_IF_AUD_DECODER. */ -#define MEDIA_ENT_F_IF_VID_DECODER (MEDIA_ENT_F_BASE + 2001) -#define MEDIA_ENT_F_IF_AUD_DECODER (MEDIA_ENT_F_BASE + 2002) +#define MEDIA_ENT_F_IF_VID_DECODER (MEDIA_ENT_F_BASE + 0x02001) +#define MEDIA_ENT_F_IF_AUD_DECODER (MEDIA_ENT_F_BASE + 0x02002)/* * Audio Entity Functions */ -#define MEDIA_ENT_F_AUDIO_CAPTURE (MEDIA_ENT_F_BASE + 3000) -#define MEDIA_ENT_F_AUDIO_PLAYBACK (MEDIA_ENT_F_BASE + 3001) -#define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 3002) +#define MEDIA_ENT_F_AUDIO_CAPTURE (MEDIA_ENT_F_BASE + 0x03000) +#define MEDIA_ENT_F_AUDIO_PLAYBACK (MEDIA_ENT_F_BASE + 0x03001) +#define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 0x03002)/* * Connectors */ /* It is a responsibility of the entity drivers to add connectors and links */ -#define MEDIA_ENT_F_CONN_RF (MEDIA_ENT_F_BASE + 10001) -#define MEDIA_ENT_F_CONN_SVIDEO (MEDIA_ENT_F_BASE + 10002) -#define MEDIA_ENT_F_CONN_COMPOSITE (MEDIA_ENT_F_BASE + 10003) +#define MEDIA_ENT_F_CONN_RF (MEDIA_ENT_F_BASE + 0x30001) +#define MEDIA_ENT_F_CONN_SVIDEO (MEDIA_ENT_F_BASE + 0x30002) +#define MEDIA_ENT_F_CONN_COMPOSITE (MEDIA_ENT_F_BASE + 0x30003)/* * Don't touch on those. The ranges MEDIA_ENT_F_OLD_BASE and
Hi Hans,
Quoted 7 lines · Hans Verkuil
Make the base offset hexadecimal to simplify debugging since the base addresses are hex too.
The offsets for connectors is also changed to start after the 'reserved' range 0x10000-0x2ffff.
Signed-off-by Hans Verkuil <[email protected]>
Signature · 2 lines
Sakari Ailus e-mail: [email protected] XMPP: [email protected]
Laurent Pinchart
maintainerHi Hans,
Thank you for the patch.
Quoted 43 lines · On Monday 29 February 2016 09:02:47 Hans Verkuil wrote:
Make the base offset hexadecimal to simplify debugging since the base addresses are hex too.
The offsets for connectors is also changed to start after the 'reserved' range 0x10000-0x2ffff.
Signed-off-by Hans Verkuil <[email protected]>include/uapi/linux/media.h +7
-9@@ -66,17 +66,17 @@ struct media_device_info {/* * DVB entities */ -#define MEDIA_ENT_F_DTV_DEMOD (MEDIA_ENT_F_BASE + 1) -#define MEDIA_ENT_F_TS_DEMUX (MEDIA_ENT_F_BASE + 2) -#define MEDIA_ENT_F_DTV_CA (MEDIA_ENT_F_BASE + 3) -#define MEDIA_ENT_F_DTV_NET_DECAP (MEDIA_ENT_F_BASE + 4) +#define MEDIA_ENT_F_DTV_DEMOD (MEDIA_ENT_F_BASE + 0x00001) +#define MEDIA_ENT_F_TS_DEMUX (MEDIA_ENT_F_BASE + 0x00002) +#define MEDIA_ENT_F_DTV_CA (MEDIA_ENT_F_BASE + 0x00003) +#define MEDIA_ENT_F_DTV_NET_DECAP (MEDIA_ENT_F_BASE + 0x00004)/* * I/O entities */ -#define MEDIA_ENT_F_IO_DTV (MEDIA_ENT_F_BASE + 1001) -#define MEDIA_ENT_F_IO_VBI (MEDIA_ENT_F_BASE + 1002) -#define MEDIA_ENT_F_IO_SWRADIO (MEDIA_ENT_F_BASE + 1003) +#define MEDIA_ENT_F_IO_DTV (MEDIA_ENT_F_BASE + 0x01001) +#define MEDIA_ENT_F_IO_VBI (MEDIA_ENT_F_BASE + 0x01002) +#define MEDIA_ENT_F_IO_SWRADIO (MEDIA_ENT_F_BASE + 0x01003)/* * Analog TV IF-PLL decoders @@ -84,23 +84,23 @@ struct media_device_info {* It is a responsibility of the master/bridge drivers to create links * for MEDIA_ENT_F_IF_VID_DECODER and MEDIA_ENT_F_IF_AUD_DECODER. */ -#define MEDIA_ENT_F_IF_VID_DECODER (MEDIA_ENT_F_BASE + 2001) -#define MEDIA_ENT_F_IF_AUD_DECODER (MEDIA_ENT_F_BASE + 2002)
include/uapi/linux/media.h struct media_device_info { · line 93
Quoted 10 lines
include/uapi/linux/media.h +3
-3+#define MEDIA_ENT_F_IF_VID_DECODER (MEDIA_ENT_F_BASE + 0x02001) +#define MEDIA_ENT_F_IF_AUD_DECODER (MEDIA_ENT_F_BASE + 0x02002)/* * Audio Entity Functions */ -#define MEDIA_ENT_F_AUDIO_CAPTURE (MEDIA_ENT_F_BASE + 3000) -#define MEDIA_ENT_F_AUDIO_PLAYBACK (MEDIA_ENT_F_BASE + 3001) -#define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 3002) +#define MEDIA_ENT_F_AUDIO_CAPTURE (MEDIA_ENT_F_BASE + 0x03000)
Why does this one start at 0x*000 while the others start at 0x*0001 ? I know that the problem predates your patch.
include/uapi/linux/media.h struct media_device_info { · line 101
Quoted 11 lines
include/uapi/linux/media.h +3
-2+#define MEDIA_ENT_F_AUDIO_PLAYBACK (MEDIA_ENT_F_BASE + 0x03001) +#define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 0x03002)/* * Connectors */ /* It is a responsibility of the entity drivers to add connectors and links */ -#define MEDIA_ENT_F_CONN_RF (MEDIA_ENT_F_BASE + 10001) -#define MEDIA_ENT_F_CONN_SVIDEO (MEDIA_ENT_F_BASE + 10002) -#define MEDIA_ENT_F_CONN_COMPOSITE (MEDIA_ENT_F_BASE + 10003) +#define MEDIA_ENT_F_CONN_RF (MEDIA_ENT_F_BASE + 0x30001)
Anything wrong with 0x4xxx ?
Quoted 9 lines
include/uapi/linux/media.h +2
-1+#define MEDIA_ENT_F_CONN_SVIDEO (MEDIA_ENT_F_BASE + 0x30002) +#define MEDIA_ENT_F_CONN_COMPOSITE (MEDIA_ENT_F_BASE + 0x30003)/* * Don't touch on those. The ranges MEDIA_ENT_F_OLD_BASE and -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 51 lines · Laurent Pinchart
Hi Hans,
Thank you for the patch.
Quoted 46 lines · On Monday 29 February 2016 09:02:47 Hans Verkuil wrote:
Make the base offset hexadecimal to simplify debugging since the base addresses are hex too.
The offsets for connectors is also changed to start after the 'reserved' range 0x10000-0x2ffff.
Signed-off-by Hans Verkuil <[email protected]>include/uapi/linux/media.h +9
-9@@ -66,17 +66,17 @@ struct media_device_info {/* * DVB entities */ -#define MEDIA_ENT_F_DTV_DEMOD (MEDIA_ENT_F_BASE + 1) -#define MEDIA_ENT_F_TS_DEMUX (MEDIA_ENT_F_BASE + 2) -#define MEDIA_ENT_F_DTV_CA (MEDIA_ENT_F_BASE + 3) -#define MEDIA_ENT_F_DTV_NET_DECAP (MEDIA_ENT_F_BASE + 4) +#define MEDIA_ENT_F_DTV_DEMOD (MEDIA_ENT_F_BASE + 0x00001) +#define MEDIA_ENT_F_TS_DEMUX (MEDIA_ENT_F_BASE + 0x00002) +#define MEDIA_ENT_F_DTV_CA (MEDIA_ENT_F_BASE + 0x00003) +#define MEDIA_ENT_F_DTV_NET_DECAP (MEDIA_ENT_F_BASE + 0x00004)/* * I/O entities */ -#define MEDIA_ENT_F_IO_DTV (MEDIA_ENT_F_BASE + 1001) -#define MEDIA_ENT_F_IO_VBI (MEDIA_ENT_F_BASE + 1002) -#define MEDIA_ENT_F_IO_SWRADIO (MEDIA_ENT_F_BASE + 1003) +#define MEDIA_ENT_F_IO_DTV (MEDIA_ENT_F_BASE + 0x01001) +#define MEDIA_ENT_F_IO_VBI (MEDIA_ENT_F_BASE + 0x01002) +#define MEDIA_ENT_F_IO_SWRADIO (MEDIA_ENT_F_BASE + 0x01003)/* * Analog TV IF-PLL decoders @@ -84,23 +84,23 @@ struct media_device_info {* It is a responsibility of the master/bridge drivers to create links * for MEDIA_ENT_F_IF_VID_DECODER and MEDIA_ENT_F_IF_AUD_DECODER. */ -#define MEDIA_ENT_F_IF_VID_DECODER (MEDIA_ENT_F_BASE + 2001) -#define MEDIA_ENT_F_IF_AUD_DECODER (MEDIA_ENT_F_BASE + 2002) +#define MEDIA_ENT_F_IF_VID_DECODER (MEDIA_ENT_F_BASE + 0x02001) +#define MEDIA_ENT_F_IF_AUD_DECODER (MEDIA_ENT_F_BASE + 0x02002)
Quoted 10 lines
include/uapi/linux/media.h struct media_device_info { · line 93
Quoted 7 lines
include/uapi/linux/media.h +1
-3/* * Audio Entity Functions */ -#define MEDIA_ENT_F_AUDIO_CAPTURE (MEDIA_ENT_F_BASE + 3000) -#define MEDIA_ENT_F_AUDIO_PLAYBACK (MEDIA_ENT_F_BASE + 3001) -#define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 3002) +#define MEDIA_ENT_F_AUDIO_CAPTURE (MEDIA_ENT_F_BASE + 0x03000)Why does this one start at 0x*000 while the others start at 0x*0001 ? I know that the problem predates your patch.
I hadn't noticed. It is my personal preference not to start with 0. But it is not needed in this case, at least not today.
I think starting with 1 will help if we ever want to do AND operations on the ID. Then it is nice that the lower 16 bits can't be 0 for valid IDs.
Quoted 4 lines
Quoted 4 lines
include/uapi/linux/media.h +2
-0+#define MEDIA_ENT_F_AUDIO_PLAYBACK (MEDIA_ENT_F_BASE + 0x03001) +#define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 0x03002)
Quoted 10 lines
include/uapi/linux/media.h struct media_device_info { · line 101
Quoted 8 lines
include/uapi/linux/media.h +1
-2/* * Connectors */ /* It is a responsibility of the entity drivers to add connectors and links */ -#define MEDIA_ENT_F_CONN_RF (MEDIA_ENT_F_BASE + 10001) -#define MEDIA_ENT_F_CONN_SVIDEO (MEDIA_ENT_F_BASE + 10002) -#define MEDIA_ENT_F_CONN_COMPOSITE (MEDIA_ENT_F_BASE + 10003) +#define MEDIA_ENT_F_CONN_RF (MEDIA_ENT_F_BASE + 0x30001)Anything wrong with 0x4xxx ?
Possibly overkill, but Sakari preferred to make more generous use of the 32 bit space. And since there may potentially be a lot of connector types I thought I gave it plenty of space. Of course, if we ever need that many, then something is seriously wrong...
Regards,
Hans
Quoted 11 lines
Quoted 10 lines
include/uapi/linux/media.h +2
-1+#define MEDIA_ENT_F_CONN_SVIDEO (MEDIA_ENT_F_BASE + 0x30002) +#define MEDIA_ENT_F_CONN_COMPOSITE (MEDIA_ENT_F_BASE + 0x30003)/* * Don't touch on those. The ranges MEDIA_ENT_F_OLD_BASE and -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Laurent Pinchart
maintainerHi Hans,
Quoted 70 lines · On Thursday 03 March 2016 11:03:02 Hans Verkuil wrote:
Quoted 61 lines · Laurent Pinchart
Quoted 60 lines · On Monday 29 February 2016 09:02:47 Hans Verkuil wrote:
Make the base offset hexadecimal to simplify debugging since the base addresses are hex too.
The offsets for connectors is also changed to start after the 'reserved' range 0x10000-0x2ffff.
Signed-off-by Hans Verkuil <[email protected]>include/uapi/linux/media.h +9
-9@@ -66,17 +66,17 @@ struct media_device_info {/* * DVB entities */ -#define MEDIA_ENT_F_DTV_DEMOD (MEDIA_ENT_F_BASE + 1) -#define MEDIA_ENT_F_TS_DEMUX (MEDIA_ENT_F_BASE + 2) -#define MEDIA_ENT_F_DTV_CA (MEDIA_ENT_F_BASE + 3) -#define MEDIA_ENT_F_DTV_NET_DECAP (MEDIA_ENT_F_BASE + 4) +#define MEDIA_ENT_F_DTV_DEMOD (MEDIA_ENT_F_BASE + 0x00001) +#define MEDIA_ENT_F_TS_DEMUX (MEDIA_ENT_F_BASE + 0x00002) +#define MEDIA_ENT_F_DTV_CA (MEDIA_ENT_F_BASE + 0x00003) +#define MEDIA_ENT_F_DTV_NET_DECAP (MEDIA_ENT_F_BASE + 0x00004)/* * I/O entities */ -#define MEDIA_ENT_F_IO_DTV (MEDIA_ENT_F_BASE + 1001) -#define MEDIA_ENT_F_IO_VBI (MEDIA_ENT_F_BASE + 1002) -#define MEDIA_ENT_F_IO_SWRADIO (MEDIA_ENT_F_BASE + 1003) +#define MEDIA_ENT_F_IO_DTV (MEDIA_ENT_F_BASE + 0x01001) +#define MEDIA_ENT_F_IO_VBI (MEDIA_ENT_F_BASE + 0x01002) +#define MEDIA_ENT_F_IO_SWRADIO (MEDIA_ENT_F_BASE + 0x01003)/* * Analog TV IF-PLL decoders @@ -84,23 +84,23 @@ struct media_device_info {* It is a responsibility of the master/bridge drivers to create links * for MEDIA_ENT_F_IF_VID_DECODER and MEDIA_ENT_F_IF_AUD_DECODER. */ -#define MEDIA_ENT_F_IF_VID_DECODER (MEDIA_ENT_F_BASE + 2001) -#define MEDIA_ENT_F_IF_AUD_DECODER (MEDIA_ENT_F_BASE + 2002) +#define MEDIA_ENT_F_IF_VID_DECODER (MEDIA_ENT_F_BASE + 0x02001) +#define MEDIA_ENT_F_IF_AUD_DECODER (MEDIA_ENT_F_BASE + 0x02002)/* * Audio Entity Functions */ Quoted 7 lines
include/uapi/linux/media.h struct media_device_info { · line 93
Quoted 4 lines
include/uapi/linux/media.h +1
-3-#define MEDIA_ENT_F_AUDIO_CAPTURE (MEDIA_ENT_F_BASE + 3000) -#define MEDIA_ENT_F_AUDIO_PLAYBACK (MEDIA_ENT_F_BASE + 3001) -#define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 3002) +#define MEDIA_ENT_F_AUDIO_CAPTURE (MEDIA_ENT_F_BASE + 0x03000)Why does this one start at 0x*000 while the others start at 0x*0001 ? I know that the problem predates your patch.
Quoted 6 lines
I hadn't noticed. It is my personal preference not to start with 0. But it is not needed in this case, at least not today.
I think starting with 1 will help if we ever want to do AND operations on the ID. Then it is nice that the lower 16 bits can't be 0 for valid IDs.
I'm fine starting at 1, would you like to resubmit this patch to change that ?
Quoted 18 lines
Quoted 11 lines
Quoted 11 lines
include/uapi/linux/media.h +2
-0+#define MEDIA_ENT_F_AUDIO_PLAYBACK (MEDIA_ENT_F_BASE + 0x03001) +#define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 0x03002)/* * Connectors */ /* It is a responsibility of the entity drivers to add connectors and links
Quoted 6 lines
include/uapi/linux/media.h struct media_device_info { · line 101
Quoted 4 lines
*/ -#define
MEDIA_ENT_F_CONN_RF(MEDIA_ENT_F_BASE+ 10001)include/uapi/linux/media.h +1
-2-#define MEDIA_ENT_F_CONN_SVIDEO (MEDIA_ENT_F_BASE + 10002) -#define MEDIA_ENT_F_CONN_COMPOSITE (MEDIA_ENT_F_BASE + 10003) +#define MEDIA_ENT_F_CONN_RF (MEDIA_ENT_F_BASE + 0x30001)Anything wrong with 0x4xxx ?
Quoted 4 lines
Possibly overkill, but Sakari preferred to make more generous use of the 32 bit space. And since there may potentially be a lot of connector types I thought I gave it plenty of space. Of course, if we ever need that many, then something is seriously wrong...
And you'd need space *after* the existing connector IDs, not before. Using 0x30000 instead of 0x4000 has the effect of reserving plenty of space for audio functions, not for connectors. I think 0x4000 should be fine.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
include/uapi/linux/media.h +2
-0+#define MEDIA_ENT_F_CONN_SVIDEO (MEDIA_ENT_F_BASE + 0x30002) +#define MEDIA_ENT_F_CONN_COMPOSITE (MEDIA_ENT_F_BASE + 0x30003)/* * Don't touch on those. The ranges MEDIA_ENT_F_OLD_BASE and
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 100 lines · Laurent Pinchart
Hi Hans,
Quoted 70 lines · On Thursday 03 March 2016 11:03:02 Hans Verkuil wrote:
Quoted 61 lines · Laurent Pinchart
Quoted 60 lines · On Monday 29 February 2016 09:02:47 Hans Verkuil wrote:
Make the base offset hexadecimal to simplify debugging since the base addresses are hex too.
The offsets for connectors is also changed to start after the 'reserved' range 0x10000-0x2ffff.
Signed-off-by Hans Verkuil <[email protected]>include/uapi/linux/media.h +9
-9@@ -66,17 +66,17 @@ struct media_device_info {/* * DVB entities */ -#define MEDIA_ENT_F_DTV_DEMOD (MEDIA_ENT_F_BASE + 1) -#define MEDIA_ENT_F_TS_DEMUX (MEDIA_ENT_F_BASE + 2) -#define MEDIA_ENT_F_DTV_CA (MEDIA_ENT_F_BASE + 3) -#define MEDIA_ENT_F_DTV_NET_DECAP (MEDIA_ENT_F_BASE + 4) +#define MEDIA_ENT_F_DTV_DEMOD (MEDIA_ENT_F_BASE + 0x00001) +#define MEDIA_ENT_F_TS_DEMUX (MEDIA_ENT_F_BASE + 0x00002) +#define MEDIA_ENT_F_DTV_CA (MEDIA_ENT_F_BASE + 0x00003) +#define MEDIA_ENT_F_DTV_NET_DECAP (MEDIA_ENT_F_BASE + 0x00004)/* * I/O entities */ -#define MEDIA_ENT_F_IO_DTV (MEDIA_ENT_F_BASE + 1001) -#define MEDIA_ENT_F_IO_VBI (MEDIA_ENT_F_BASE + 1002) -#define MEDIA_ENT_F_IO_SWRADIO (MEDIA_ENT_F_BASE + 1003) +#define MEDIA_ENT_F_IO_DTV (MEDIA_ENT_F_BASE + 0x01001) +#define MEDIA_ENT_F_IO_VBI (MEDIA_ENT_F_BASE + 0x01002) +#define MEDIA_ENT_F_IO_SWRADIO (MEDIA_ENT_F_BASE + 0x01003)/* * Analog TV IF-PLL decoders @@ -84,23 +84,23 @@ struct media_device_info {* It is a responsibility of the master/bridge drivers to create links * for MEDIA_ENT_F_IF_VID_DECODER and MEDIA_ENT_F_IF_AUD_DECODER. */ -#define MEDIA_ENT_F_IF_VID_DECODER (MEDIA_ENT_F_BASE + 2001) -#define MEDIA_ENT_F_IF_AUD_DECODER (MEDIA_ENT_F_BASE + 2002) +#define MEDIA_ENT_F_IF_VID_DECODER (MEDIA_ENT_F_BASE + 0x02001) +#define MEDIA_ENT_F_IF_AUD_DECODER (MEDIA_ENT_F_BASE + 0x02002)/* * Audio Entity Functions */ Quoted 7 lines
include/uapi/linux/media.h struct media_device_info { · line 93
Quoted 4 lines
include/uapi/linux/media.h +1
-3-#define MEDIA_ENT_F_AUDIO_CAPTURE (MEDIA_ENT_F_BASE + 3000) -#define MEDIA_ENT_F_AUDIO_PLAYBACK (MEDIA_ENT_F_BASE + 3001) -#define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 3002) +#define MEDIA_ENT_F_AUDIO_CAPTURE (MEDIA_ENT_F_BASE + 0x03000)Why does this one start at 0x*000 while the others start at 0x*0001 ? I know that the problem predates your patch.
Quoted 6 lines
I hadn't noticed. It is my personal preference not to start with 0. But it is not needed in this case, at least not today.
I think starting with 1 will help if we ever want to do AND operations on the ID. Then it is nice that the lower 16 bits can't be 0 for valid IDs.
I'm fine starting at 1, would you like to resubmit this patch to change that ?
Quoted 18 lines
Quoted 17 lines
Quoted 12 lines
include/uapi/linux/media.h +2
-0+#define MEDIA_ENT_F_AUDIO_PLAYBACK (MEDIA_ENT_F_BASE + 0x03001) +#define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 0x03002)/* * Connectors */ /* It is a responsibility of the entity drivers to add connectors and links
*/ -#define
MEDIA_ENT_F_CONN_RF(MEDIA_ENT_F_BASE+ 10001)include/uapi/linux/media.h struct media_device_info { · line 101
Quoted 3 lines
include/uapi/linux/media.h +1
-2-#define MEDIA_ENT_F_CONN_SVIDEO (MEDIA_ENT_F_BASE + 10002) -#define MEDIA_ENT_F_CONN_COMPOSITE (MEDIA_ENT_F_BASE + 10003) +#define MEDIA_ENT_F_CONN_RF (MEDIA_ENT_F_BASE + 0x30001)Anything wrong with 0x4xxx ?
Quoted 8 lines
Quoted 4 lines
Possibly overkill, but Sakari preferred to make more generous use of the 32 bit space. And since there may potentially be a lot of connector types I thought I gave it plenty of space. Of course, if we ever need that many, then something is seriously wrong...
And you'd need space *after* the existing connector IDs, not before. Using
0x30000instead of0x4000has the effect of reserving plenty of space for audio functions, not for connectors. I think0x4000should be fine.
Huh? Connectors start at 0x30000, audio entities are 0x03000. I think you got confused by that. Connectors can now go from 0x30000-0xffffffff :-) Definitely more space than 0x4000-0xffff.
Regards,
Hans
Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
include/uapi/linux/media.h +2
-0+#define MEDIA_ENT_F_CONN_SVIDEO (MEDIA_ENT_F_BASE + 0x30002) +#define MEDIA_ENT_F_CONN_COMPOSITE (MEDIA_ENT_F_BASE + 0x30003)/* * Don't touch on those. The ranges MEDIA_ENT_F_OLD_BASE and
Laurent Pinchart
maintainerHi Hans,
Quoted 94 lines · On Thursday 03 March 2016 11:18:30 Hans Verkuil wrote:
Quoted 93 lines · Laurent Pinchart
Quoted 59 lines · On Thursday 03 March 2016 11:03:02 Hans Verkuil wrote:
Quoted 47 lines · Laurent Pinchart
Quoted 46 lines · On Monday 29 February 2016 09:02:47 Hans Verkuil wrote:
Make the base offset hexadecimal to simplify debugging since the base addresses are hex too.
The offsets for connectors is also changed to start after the 'reserved' range 0x10000-0x2ffff.
Signed-off-by Hans Verkuil <[email protected]>include/uapi/linux/media.h +9
-9@@ -66,17 +66,17 @@ struct media_device_info {/* * DVB entities */ -#define MEDIA_ENT_F_DTV_DEMOD (MEDIA_ENT_F_BASE + 1) -#define MEDIA_ENT_F_TS_DEMUX (MEDIA_ENT_F_BASE + 2) -#define MEDIA_ENT_F_DTV_CA (MEDIA_ENT_F_BASE + 3) -#define MEDIA_ENT_F_DTV_NET_DECAP (MEDIA_ENT_F_BASE + 4) +#define MEDIA_ENT_F_DTV_DEMOD (MEDIA_ENT_F_BASE + 0x00001) +#define MEDIA_ENT_F_TS_DEMUX (MEDIA_ENT_F_BASE + 0x00002) +#define MEDIA_ENT_F_DTV_CA (MEDIA_ENT_F_BASE + 0x00003) +#define MEDIA_ENT_F_DTV_NET_DECAP (MEDIA_ENT_F_BASE + 0x00004)/* * I/O entities */ -#define MEDIA_ENT_F_IO_DTV (MEDIA_ENT_F_BASE + 1001) -#define MEDIA_ENT_F_IO_VBI (MEDIA_ENT_F_BASE + 1002) -#define MEDIA_ENT_F_IO_SWRADIO (MEDIA_ENT_F_BASE + 1003) +#define MEDIA_ENT_F_IO_DTV (MEDIA_ENT_F_BASE + 0x01001) +#define MEDIA_ENT_F_IO_VBI (MEDIA_ENT_F_BASE + 0x01002) +#define MEDIA_ENT_F_IO_SWRADIO (MEDIA_ENT_F_BASE + 0x01003)/* * Analog TV IF-PLL decoders @@ -84,23 +84,23 @@ struct media_device_info {* It is a responsibility of the master/bridge drivers to create links * for MEDIA_ENT_F_IF_VID_DECODER and MEDIA_ENT_F_IF_AUD_DECODER. */ -#define MEDIA_ENT_F_IF_VID_DECODER (MEDIA_ENT_F_BASE + 2001) -#define MEDIA_ENT_F_IF_AUD_DECODER (MEDIA_ENT_F_BASE + 2002) +#define MEDIA_ENT_F_IF_VID_DECODER (MEDIA_ENT_F_BASE + 0x02001) +#define MEDIA_ENT_F_IF_AUD_DECODER (MEDIA_ENT_F_BASE + 0x02002)Quoted 10 lines
include/uapi/linux/media.h struct media_device_info { · line 93
Quoted 7 lines
include/uapi/linux/media.h +1
-3/* * Audio Entity Functions */ -#define MEDIA_ENT_F_AUDIO_CAPTURE (MEDIA_ENT_F_BASE + 3000) -#define MEDIA_ENT_F_AUDIO_PLAYBACK (MEDIA_ENT_F_BASE + 3001) -#define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 3002) +#define MEDIA_ENT_F_AUDIO_CAPTURE (MEDIA_ENT_F_BASE + 0x03000)Why does this one start at 0x*000 while the others start at 0x*0001 ? I know that the problem predates your patch.
Quoted 6 lines
I hadn't noticed. It is my personal preference not to start with 0. But it is not needed in this case, at least not today.
I think starting with 1 will help if we ever want to do AND operations on the ID. Then it is nice that the lower 16 bits can't be 0 for valid IDs.
I'm fine starting at 1, would you like to resubmit this patch to change that ?
Quoted 22 lines
Quoted 11 lines
Quoted 11 lines
include/uapi/linux/media.h +2
-0+#define MEDIA_ENT_F_AUDIO_PLAYBACK (MEDIA_ENT_F_BASE + 0x03001) +#define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 0x03002)/* * Connectors */ /* It is a responsibility of the entity drivers to add connectors and links Quoted 6 lines
include/uapi/linux/media.h struct media_device_info { · line 101
Quoted 4 lines
include/uapi/linux/media.h +1
-2*/ -#define MEDIA_ENT_F_CONN_RF (MEDIA_ENT_F_BASE + 10001) -#define MEDIA_ENT_F_CONN_SVIDEO (MEDIA_ENT_F_BASE + 10002) -#define MEDIA_ENT_F_CONN_COMPOSITE (MEDIA_ENT_F_BASE + 10003) +#define MEDIA_ENT_F_CONN_RF (MEDIA_ENT_F_BASE + 0x30001)Anything wrong with 0x4xxx ?
Possibly overkill, but Sakari preferred to make more generous use of the 32 bit space. And since there may potentially be a lot of connector types I thought I gave it plenty of space. Of course, if we ever need that many, then something is seriously wrong...
Quoted 7 lines
Quoted 3 lines
And you'd need space *after* the existing connector IDs, not before. Using
0x30000instead of0x4000has the effect of reserving plenty of space for audio functions, not for connectors. I think0x4000should be fine.Huh? Connectors start at
0x30000, audio entities are0x03000. I think you got confused by that. Connectors can now go from 0x30000-0xffffffff :-) Definitely more space than 0x4000-0xffff.
But less than 0x4000-0xffffffff :-) There's no information about how the range is supposed to be split. And 4096 connector functions should be more than enough.
On a side note, writing "connector functions" really doesn't feel right. We're not there yet, this API isn't correct.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
include/uapi/linux/media.h +2
-0+#define MEDIA_ENT_F_CONN_SVIDEO (MEDIA_ENT_F_BASE + 0x30002) +#define MEDIA_ENT_F_CONN_COMPOSITE (MEDIA_ENT_F_BASE + 0x30003)/* * Don't touch on those. The ranges MEDIA_ENT_F_OLD_BASE and
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 101 lines · Laurent Pinchart
Hi Hans,
Quoted 98 lines · On Thursday 03 March 2016 11:18:30 Hans Verkuil wrote:
Quoted 96 lines · Laurent Pinchart
Quoted 59 lines · On Thursday 03 March 2016 11:03:02 Hans Verkuil wrote:
Quoted 47 lines · Laurent Pinchart
Quoted 46 lines · On Monday 29 February 2016 09:02:47 Hans Verkuil wrote:
Make the base offset hexadecimal to simplify debugging since the base addresses are hex too.
The offsets for connectors is also changed to start after the 'reserved' range 0x10000-0x2ffff.
Signed-off-by Hans Verkuil <[email protected]>include/uapi/linux/media.h +9
-9@@ -66,17 +66,17 @@ struct media_device_info {/* * DVB entities */ -#define MEDIA_ENT_F_DTV_DEMOD (MEDIA_ENT_F_BASE + 1) -#define MEDIA_ENT_F_TS_DEMUX (MEDIA_ENT_F_BASE + 2) -#define MEDIA_ENT_F_DTV_CA (MEDIA_ENT_F_BASE + 3) -#define MEDIA_ENT_F_DTV_NET_DECAP (MEDIA_ENT_F_BASE + 4) +#define MEDIA_ENT_F_DTV_DEMOD (MEDIA_ENT_F_BASE + 0x00001) +#define MEDIA_ENT_F_TS_DEMUX (MEDIA_ENT_F_BASE + 0x00002) +#define MEDIA_ENT_F_DTV_CA (MEDIA_ENT_F_BASE + 0x00003) +#define MEDIA_ENT_F_DTV_NET_DECAP (MEDIA_ENT_F_BASE + 0x00004)/* * I/O entities */ -#define MEDIA_ENT_F_IO_DTV (MEDIA_ENT_F_BASE + 1001) -#define MEDIA_ENT_F_IO_VBI (MEDIA_ENT_F_BASE + 1002) -#define MEDIA_ENT_F_IO_SWRADIO (MEDIA_ENT_F_BASE + 1003) +#define MEDIA_ENT_F_IO_DTV (MEDIA_ENT_F_BASE + 0x01001) +#define MEDIA_ENT_F_IO_VBI (MEDIA_ENT_F_BASE + 0x01002) +#define MEDIA_ENT_F_IO_SWRADIO (MEDIA_ENT_F_BASE + 0x01003)/* * Analog TV IF-PLL decoders @@ -84,23 +84,23 @@ struct media_device_info {* It is a responsibility of the master/bridge drivers to create links * for MEDIA_ENT_F_IF_VID_DECODER and MEDIA_ENT_F_IF_AUD_DECODER. */ -#define MEDIA_ENT_F_IF_VID_DECODER (MEDIA_ENT_F_BASE + 2001) -#define MEDIA_ENT_F_IF_AUD_DECODER (MEDIA_ENT_F_BASE + 2002) +#define MEDIA_ENT_F_IF_VID_DECODER (MEDIA_ENT_F_BASE + 0x02001) +#define MEDIA_ENT_F_IF_AUD_DECODER (MEDIA_ENT_F_BASE + 0x02002)Quoted 10 lines
include/uapi/linux/media.h struct media_device_info { · line 93
Quoted 7 lines
include/uapi/linux/media.h +1
-3/* * Audio Entity Functions */ -#define MEDIA_ENT_F_AUDIO_CAPTURE (MEDIA_ENT_F_BASE + 3000) -#define MEDIA_ENT_F_AUDIO_PLAYBACK (MEDIA_ENT_F_BASE + 3001) -#define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 3002) +#define MEDIA_ENT_F_AUDIO_CAPTURE (MEDIA_ENT_F_BASE + 0x03000)Why does this one start at 0x*000 while the others start at 0x*0001 ? I know that the problem predates your patch.
Quoted 6 lines
I hadn't noticed. It is my personal preference not to start with 0. But it is not needed in this case, at least not today.
I think starting with 1 will help if we ever want to do AND operations on the ID. Then it is nice that the lower 16 bits can't be 0 for valid IDs.
I'm fine starting at 1, would you like to resubmit this patch to change that ?
Quoted 18 lines
Quoted 11 lines
Quoted 11 lines
include/uapi/linux/media.h +2
-0+#define MEDIA_ENT_F_AUDIO_PLAYBACK (MEDIA_ENT_F_BASE + 0x03001) +#define MEDIA_ENT_F_AUDIO_MIXER (MEDIA_ENT_F_BASE + 0x03002)/* * Connectors */ /* It is a responsibility of the entity drivers to add connectors and links Quoted 6 lines
include/uapi/linux/media.h struct media_device_info { · line 101
Quoted 4 lines
include/uapi/linux/media.h +1
-2*/ -#define MEDIA_ENT_F_CONN_RF (MEDIA_ENT_F_BASE + 10001) -#define MEDIA_ENT_F_CONN_SVIDEO (MEDIA_ENT_F_BASE + 10002) -#define MEDIA_ENT_F_CONN_COMPOSITE (MEDIA_ENT_F_BASE + 10003) +#define MEDIA_ENT_F_CONN_RF (MEDIA_ENT_F_BASE + 0x30001)Anything wrong with 0x4xxx ?
Quoted 4 lines
Possibly overkill, but Sakari preferred to make more generous use of the 32 bit space. And since there may potentially be a lot of connector types I thought I gave it plenty of space. Of course, if we ever need that many, then something is seriously wrong...
And you'd need space *after* the existing connector IDs, not before. Using
0x30000instead of0x4000has the effect of reserving plenty of space for audio functions, not for connectors. I think0x4000should be fine.
Quoted 7 lines
Quoted 3 lines
Huh? Connectors start at
0x30000, audio entities are0x03000. I think you got confused by that. Connectors can now go from 0x30000-0xffffffff :-) Definitely more space than 0x4000-0xffff.But less than 0x4000-0xffffffff :-) There's no information about how the range is supposed to be split. And 4096 connector functions should be more than enough.
The range 0x10000-0x2ffff is blocked due to the old MCv1 defines. Hmm, that could be stated more clearly in the code.
Regards,
Hans
Quoted 10 lines
On a side note, writing "connector functions" really doesn't feel right. We're not there yet, this API isn't correct.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
include/uapi/linux/media.h +2
-0+#define MEDIA_ENT_F_CONN_SVIDEO (MEDIA_ENT_F_BASE + 0x30002) +#define MEDIA_ENT_F_CONN_COMPOSITE (MEDIA_ENT_F_BASE + 0x30003)/* * Don't touch on those. The ranges MEDIA_ENT_F_OLD_BASE and