Bump libasplib and change source to original maintainer
PATCH 1/1 Bump libasplib and change source to original maintainer
Since maintainer of kodi-adsp maintainer forked asplib from original source (https://github.com/AchimTuran/asplib)
and did not maintain it, asplib became obsolete.
New version does not depend on cpuinfo.h and builds on other platforms too (e.g. arm and aarch64)
--- .../0001-Fix-linux-detection-with-buildroot.patch | 31 ---------------------- package/libasplib/Config.in | 8 +----- package/libasplib/libasplib.hash | 2 +- package/libasplib/libasplib.mk | 4 +-- 4 files changed, 4 insertions(+), 41 deletions(-) delete mode 100644 package/libasplib/0001-Fix-linux-detection-with-buildroot.patch
package/libasplib/0001-Fix-linux-detection-with-buildroot.patch deleted +0 -31
@@ -1,31 +0,0 @@ -From 1dc4480e5157e7ac8eb0364446787128f0a156aa Mon Sep 17 00:00:00 2001 -From: Bernd Kuhls <[email protected]> -Date: Sun, 20 Dec 2015 22:25:52 +0100 -Subject: [PATCH 1/1] Fix linux detection with buildroot - -Inspired by -http://lists.busybox.net/pipermail/buildroot/2015-July/133312.html - -Patch sent upstream: https://github.com/kodi-adsp/asplib/pull/2 - -Signed-off-by: Bernd Kuhls <[email protected]> ---- - asplib_utils/os/asplib_base_os.h | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/asplib_utils/os/asplib_base_os.h b/asplib_utils/os/asplib_base_os.h -index a2d3b98..9a90b54 100644 ---- a/asplib_utils/os/asplib_base_os.h -+++ b/asplib_utils/os/asplib_base_os.h -@@ -27,7 +27,7 @@ - #define TARGET_WINDOWS - #endif - #include "windows/windows_definitions.h" --#elif defined(__gnu_linux__) -+#elif (defined(__gnu_linux__) || defined(__linux__)) - #if !defined(TARGET_WINDOWS) - #define TARGET_LINUX - #endif --- -2.6.4 -
package/libasplib/Config.in +1 -7
@@ -1,14 +1,8 @@ config BR2_PACKAGE_LIBASPLIB bool "libasplib" depends on BR2_INSTALL_LIBSTDCPP - # needs <cpuid.h> from the compiler - depends on BR2_i386 || BR2_x86_64 help asplib (Achim's Signal Processing LIBrary), is a small and lightweight C++ library for digital signal processing. - https://github.com/kodi-adsp/asplib - -comment "asplib needs a toolchain w/ C++" - depends on !BR2_INSTALL_LIBSTDCPP - depends on BR2_i386 || BR2_x86_64 + https://github.com/AchimTuran/asplib
package/libasplib/libasplib.hash +1 -1
@@ -1,2 +1,2 @@ # Locally calculated -sha256 8979cbd1620dde0603f596d2d05d300355f07e42637bb41ecd564541fa1332f4 libasplib-2fac1bf34efd210b95949fddcbd4a12d287d3e82.tar.gz +sha256 ccc2718c79a8d684317cc1987ede88b198e1602df47d0f18f03d474eda00af9c libasplib-f7219142e790a329b002a94f3db943abcb183739.tar.gz
package/libasplib/libasplib.mk +2 -2
@@ -4,8 +4,8 @@ # ################################################################################ -LIBASPLIB_VERSION = 2fac1bf34efd210b95949fddcbd4a12d287d3e82 -LIBASPLIB_SITE = $(call github,kodi-adsp,asplib,$(LIBASPLIB_VERSION)) +LIBASPLIB_VERSION = f7219142e790a329b002a94f3db943abcb183739 +LIBASPLIB_SITE = $(call github,AchimTuran,asplib,$(LIBASPLIB_VERSION)) LIBASPLIB_LICENSE = GPLv3+ LIBASPLIB_LICENSE_FILES = LICENSE LIBASPLIB_INSTALL_STAGING = YES
Signature · 1 line
1.9.1
PATCH 1/1 Bump libasplib and change source to original maintainer
Dear Stanislav Vlasic,
Thanks for your contribution! I have a few comments/questions.
First, the commit title should always have the following format:
<package>: <description>
So in your case, it should be:
libasplib: bump version and change source location
(or something like that)
Quoted 3 lines · Stanislav Vlasic
Since maintainer of kodi-adsp maintainer forked asplib from original source (https://github.com/AchimTuran/asplib)
and did not maintain it, asplib became obsolete.
Do we still need a separate libasplib package then? Are you using libasplib for your project, outside of Kodi?
package/libasplib/Config.in line 3
Quoted 8 lines
package/libasplib/Config.in +0
-0@@ -1,14 +1,8 @@ config BR2_PACKAGE_LIBASPLIB bool "libasplib" depends on BR2_INSTALL_LIBSTDCPP
You still have a C++ dependency.
package/libasplib/Config.in line 14
Quoted 11 lines
package/libasplib/Config.in +0
-7- # needs <cpuid.h> from the compiler - depends on BR2_i386 || BR2_x86_64 help asplib (Achim's Signal Processing LIBrary), is a small and lightweight C++ library for digital signal processing. - https://github.com/kodi-adsp/asplib - -comment "asplib needs a toolchain w/ C++" - depends on !BR2_INSTALL_LIBSTDCPP - depends on BR2_i386 || BR2_x86_64
So why are you removing the comment about this dependency?
Other than that, looks good. Could you fix the minor issues above, and resubmit an updated version?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 Bump libasplib and change source to original maintainer
Hi,
Quoted 12 lines · Thomas Petazzoni
Dear Stanislav Vlasic,
Thanks for your contribution! I have a few comments/questions.
First, the commit title should always have the following format:
<package>: <description>
So in your case, it should be:
libasplib: bump version and change source location
Quoted 8 lines
(or something like that)
Quoted 3 lines · Stanislav Vlasic
Since maintainer of kodi-adsp maintainer forked asplib from original source (https://github.com/AchimTuran/asplib)
and did not maintain it, asplib became obsolete.Do we still need a separate libasplib package then? Are you using libasplib for your project, outside of Kodi?
Yes, libadsplib is still required for Biquad filter addon for Kodi's AudioDSP-System.
Quoted 17 lines
package/libasplib/Config.in line 3
Quoted 8 lines
package/libasplib/Config.in +0
-0@@ -1,14 +1,8 @@ config BR2_PACKAGE_LIBASPLIB bool "libasplib" depends on BR2_INSTALL_LIBSTDCPPYou still have a C++ dependency.
Quoted 6 lines
package/libasplib/Config.in +0
-2- # needs <cpuid.h> from the compiler - depends on BR2_i386 || BR2_x86_64 help asplib (Achim's Signal Processing LIBrary), is a small and lightweight C++ library for digital signal processing.
Quoted 7 lines
package/libasplib/Config.in line 14
Quoted 5 lines
package/libasplib/Config.in +0
-5- https://github.com/kodi-adsp/asplib - -comment "asplib needs a toolchain w/ C++" - depends on !BR2_INSTALL_LIBSTDCPP - depends on BR2_i386 || BR2_x86_64So why are you removing the comment about this dependency?
Well, that happens when you're trying to make some work in 4am... :)
Quoted 2 lines
Other than that, looks good. Could you fix the minor issues above, and resubmit an updated version?
I'll resubmit patch, no problem.
Quoted 4 lines
Thanks!
Thomas
Stanislav