Skip to contentSkip to conversation

sox: disable SSP when using MIPS Codescape toolchains

PATCH New Vicente Olivert Riera 3 participants 7 messages Feb 29, 2016 – Mar 1, 2016

lore
Share & tools
lore

Vicente Olivert Riera

author
#0 lore raw

PATCH 1/1 sox: disable SSP when using MIPS Codescape toolchains

MIPS Codescape toolchains don't support stack-smashing protection despite of using glibc, therefore we see failures like this one:

mips-img-linux-gnu/bin/ld: cannot find -lssp

Fixes:
http://autobuild.buildroot.net/results/957/95721f7b88c46a20202fb02e408817097df965c3/

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/sox/sox.mk | 6 ++++++
 1 file changed, 6 insertions(+)
package/sox/sox.mk +6 -0
index f4d1608..61f5220 100644
@@ -13,6 +13,12 @@ SOX_CONF_OPTS = --with-distro="Buildroot" --without-ffmpeg --disable-gomp \
 SOX_LICENSE = GPLv2+ (sox binary), LGPLv2.1+ (libraries)
 SOX_LICENSE_FILES = LICENSE.GPL LICENSE.LGPL
 
+# MIPS Codescape toolchains don't support stack-smashing protection
+# despite of using glibc.
+ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_IMG_MIPS)$(BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_MTI_MIPS),y)
+SOX_CONF_OPTS += --disable-stack-protector
+endif
+
 ifeq ($(BR2_PACKAGE_ALSA_LIB_PCM),y)
 SOX_DEPENDENCIES += alsa-lib
 else
Signature · 1 line
2.4.10
#1 lore raw

PATCH 1/1 sox: disable SSP when using MIPS Codescape toolchains

Vicente,

package/sox/sox.mk SOX_CONF_OPTS = --with-distro="Buildroot" --without-ffmpeg --disable-gomp \ · line 20

Quoted 13 lines · Vicente Olivert Riera
package/sox/sox.mk +5 -0
index f4d1608..61f5220 100644
@@ -13,6 +13,12 @@ SOX_CONF_OPTS = --with-distro="Buildroot" --without-ffmpeg --disable-gomp \
 SOX_LICENSE = GPLv2+ (sox binary), LGPLv2.1+ (libraries)
 SOX_LICENSE_FILES = LICENSE.GPL LICENSE.LGPL
 
+# MIPS Codescape toolchains don't support stack-smashing protection
+# despite of using glibc.
+ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_IMG_MIPS)$(BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_MTI_MIPS),y)
+SOX_CONF_OPTS += --disable-stack-protector
+endif

Shouldn't we instead change BR2_TOOLCHAIN_HAS_SSP so that it is defined to false for those toolchains? This way:

1/ The existing BR2_TOOLCHAIN_HAS_SSP tests would do the right thing
for the Codescape toolchains.

2/ The additional test you are adding would also be useful for other
non-SSP capable toolchains.

That being said, we're very close to 2016.02, so I'm not sure this will get into 2016.02. If the folks releasing the Codescape toolchain release soon a version which has a properly working SSP implementation, then we could simply forget about this problem until they make this release. If of course such a new toolchain version is not planned in the near future, we would need to fix the problem.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 sox: disable SSP when using MIPS Codescape toolchains

Hi Thomas,

Quoted 12 lines · Thomas Petazzoni

Vicente,

Quoted 8 lines · Vicente Olivert Riera
package/sox/sox.mk +0 -0
index f4d1608..61f5220 100644
@@ -13,6 +13,12 @@ SOX_CONF_OPTS = --with-distro="Buildroot" --without-ffmpeg --disable-gomp \
 SOX_LICENSE = GPLv2+ (sox binary), LGPLv2.1+ (libraries)
 SOX_LICENSE_FILES = LICENSE.GPL LICENSE.LGPL
Quoted 8 lines

package/sox/sox.mk SOX_CONF_OPTS = --with-distro="Buildroot" --without-ffmpeg --disable-gomp \ · line 20

Quoted 5 lines
package/sox/sox.mk +5 -0
+# MIPS Codescape toolchains don't support stack-smashing protection
+# despite of using glibc.
+ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_IMG_MIPS)$(BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_MTI_MIPS),y)
+SOX_CONF_OPTS += --disable-stack-protector
+endif

Shouldn't we instead change BR2_TOOLCHAIN_HAS_SSP so that it is defined to false for those toolchains?

Uhm..., how would you do that? BR2_TOOLCHAIN_HAS_SSP is selected by BR2_TOOLCHAIN_USES_GLIBC. We would need to do changes in the toolchain infra in order to not define it in that place, and define it individually for every toolchain. Is that what you mean?

Regards,

Vincent.

Quoted 19 lines

This way:

1/ The existing BR2_TOOLCHAIN_HAS_SSP tests would do the right thing
for the Codescape toolchains.

2/ The additional test you are adding would also be useful for other
non-SSP capable toolchains.

That being said, we're very close to 2016.02, so I'm not sure this will get into 2016.02. If the folks releasing the Codescape toolchain release soon a version which has a properly working SSP implementation, then we could simply forget about this problem until they make this release. If of course such a new toolchain version is not planned in the near future, we would need to fix the problem.

Best regards,

Thomas

#3 lore raw

PATCH 1/1 sox: disable SSP when using MIPS Codescape toolchains

Hello,

Quoted 4 lines · Vicente Olivert Riera

Uhm..., how would you do that? BR2_TOOLCHAIN_HAS_SSP is selected by BR2_TOOLCHAIN_USES_GLIBC. We would need to do changes in the toolchain infra in order to not define it in that place, and define it individually for every toolchain. Is that what you mean?

Yes, this is what I mean. It is indeed more work, but looks cleaner IMO.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 sox: disable SSP when using MIPS Codescape toolchains

Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello,

Quoted 4 lines · Vicente Olivert Riera

Uhm..., how would you do that? BR2_TOOLCHAIN_HAS_SSP is selected by BR2_TOOLCHAIN_USES_GLIBC. We would need to do changes in the toolchain infra in order to not define it in that place, and define it individually for every toolchain. Is that what you mean?

Yes, this is what I mean. It is indeed more work, but looks cleaner IMO.

Agreed. This kind of toolchains are probably quite rare. If we want to keep the number of changes to a minimum we could perhaps handle them using a negative symbol:

config BR2_TOOLCHAIN_WITHOUT_SSP
bool

..

config BR2_TOOLCHAIN_USES_GLIBC
..
select BR2_TOOLCHAIN_HAS_SSP if !BR2_TOOLCHAIN_WITHOUT_SSP

And then select BR2_TOOLCHAIN_WITHOUT_SSP from the affected external toolchains.

But it's quite ugly.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 1/1 sox: disable SSP when using MIPS Codescape toolchains

In reply to Vicente Olivert Riera
Quoted 20 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

MIPS Codescape toolchains don't support stack-smashing protection despite of using glibc, therefore we see failures like this one:

mips-img-linux-gnu/bin/ld: cannot find -lssp

Fixes:
http://autobuild.buildroot.net/results/957/95721f7b88c46a20202fb02e408817097df965c3/

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/sox/sox.mk | 6 ++++++
 1 file changed, 6 insertions(+)
package/sox/sox.mk +0 -0
index f4d1608..61f5220 100644

package/sox/sox.mk SOX_CONF_OPTS = --with-distro="Buildroot" --without-ffmpeg --disable-gomp \ · line 20

Quoted 8 lines
package/sox/sox.mk +5 -0
@@ -13,6 +13,12 @@ SOX_CONF_OPTS = --with-distro="Buildroot" --without-ffmpeg --disable-gomp \
 SOX_LICENSE = GPLv2+ (sox binary), LGPLv2.1+ (libraries)
 SOX_LICENSE_FILES = LICENSE.GPL LICENSE.LGPL
 
+# MIPS Codescape toolchains don't support stack-smashing protection
+# despite of using glibc.
+ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_IMG_MIPS)$(BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_MTI_MIPS),y)
+SOX_CONF_OPTS += --disable-stack-protector
+endif

Committed, thanks (for 2016.02). Please consider generalizing it like Thomas suggested for the 2016.05 cycle.

Signature · 1 line
Bye, Peter Korsgaard
author
#6 lore raw

PATCH 1/1 sox: disable SSP when using MIPS Codescape toolchains

Hi Peter,

Quoted 23 lines · Peter Korsgaard
Quoted 22 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

MIPS Codescape toolchains don't support stack-smashing protection despite of using glibc, therefore we see failures like this one:

mips-img-linux-gnu/bin/ld: cannot find -lssp

Fixes:
http://autobuild.buildroot.net/results/957/95721f7b88c46a20202fb02e408817097df965c3/

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/sox/sox.mk | 6 ++++++
 1 file changed, 6 insertions(+)
package/sox/sox.mk +0 -0
index f4d1608..61f5220 100644
@@ -13,6 +13,12 @@ SOX_CONF_OPTS = --with-distro="Buildroot" --without-ffmpeg --disable-gomp \
 SOX_LICENSE = GPLv2+ (sox binary), LGPLv2.1+ (libraries)
 SOX_LICENSE_FILES = LICENSE.GPL LICENSE.LGPL
Quoted 9 lines

package/sox/sox.mk SOX_CONF_OPTS = --with-distro="Buildroot" --without-ffmpeg --disable-gomp \ · line 20

Quoted 5 lines
package/sox/sox.mk +5 -0
+# MIPS Codescape toolchains don't support stack-smashing protection
+# despite of using glibc.
+ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_IMG_MIPS)$(BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_MTI_MIPS),y)
+SOX_CONF_OPTS += --disable-stack-protector
+endif

Committed, thanks (for 2016.02). Please consider generalizing it like Thomas suggested for the 2016.05 cycle.

Sure, I will do it.

Thanks,

Vincent.