libcap-ng: bump to version 0.7.7
PATCH 1/1 libcap-ng: bump to version 0.7.7
Also disable optimization when compiling for nios2 to prevent a compiler bug.
Fixes:
http://autobuild.buildroot.net/results/3afc4c006a74fd7512dace90b5f884bf7be4cc58/
http://autobuild.buildroot.net/results/2c53f611a705506ca86fedb0f1129df1d315632c/
http://autobuild.buildroot.net/results/c3d9477688b55987591b5b5efed5ee65499aa0e6/
http://autobuild.buildroot.net/results/052ff24f3985b652c11ac390f342e9ad3d862431/
...
--- package/libcap-ng/Config.in | 1 - package/libcap-ng/libcap-ng.hash | 2 +- package/libcap-ng/libcap-ng.mk | 7 ++++++- 3 files changed, 7 insertions(+), 3 deletions(-)
package/libcap-ng/Config.in +0 -1
@@ -1,6 +1,5 @@ config BR2_PACKAGE_LIBCAP_NG bool "libcap-ng" - depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII # triggers compiler bug help The libcap-ng library is intended to make programming with posix capabilities much easier than the traditional libcap
package/libcap-ng/libcap-ng.hash +1 -1
@@ -1,2 +1,2 @@ # Locally calculated -sha256 48a2083276f9820cb92dcb05d001b30733bcbf48c14c230303cac3cd08b45b6b libcap-ng-0.7.4.tar.gz +sha256 615549ce39b333f6b78baee0c0b4ef18bc726c6bf1cca123dfd89dd963f6d06b libcap-ng-0.7.7.tar.gz
package/libcap-ng/libcap-ng.mk +6 -1
@@ -4,7 +4,7 @@ # ################################################################################ -LIBCAP_NG_VERSION = 0.7.4 +LIBCAP_NG_VERSION = 0.7.7 LIBCAP_NG_SITE = http://people.redhat.com/sgrubb/libcap-ng LIBCAP_NG_LICENSE = GPLv2+ LGPLv2.1+ LIBCAP_NG_LICENSE_FILES = COPYING COPYING.LIB
@@ -13,4 +13,9 @@ LIBCAP_NG_INSTALL_STAGING = YES LIBCAP_NG_CONF_ENV = ac_cv_prog_swig_found=no LIBCAP_NG_CONF_OPTS = --without-python +# disable optimization when compiling for nios2 to prevent a compiler bug +#ifeq ($(BR2_nios2),y) +#LIBCAP_NG_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -O0" +#endif + $(eval $(autotools-package))
Signature · 1 line
1.9.1
PATCH 1/1 libcap-ng: bump to version 0.7.7
Hi Sergio,
Le 05/03/2016 00:00, Sergio Prado a ?crit :
Quoted 2 lines
Also disable optimization when compiling for nios2 to prevent a compiler bug.
The bump and the nios2 fix must be two separate patches.
Quoted 6 lines
Fixes:
http://autobuild.buildroot.net/results/3afc4c006a74fd7512dace90b5f884bf7be4cc58/
http://autobuild.buildroot.net/results/2c53f611a705506ca86fedb0f1129df1d315632c/
http://autobuild.buildroot.net/results/c3d9477688b55987591b5b5efed5ee65499aa0e6/
http://autobuild.buildroot.net/results/052ff24f3985b652c11ac390f342e9ad3d862431/
Also the compiler bug is due to an issue with gcc <= 5.2. All theses build issues are trigged by br-nios2-full-2015.11-rc1-71-g90d1299.tar.bz2 toolchain which is based on gcc 4.9.
I propose to add an exception in the autobuilder script:
http://patchwork.ozlabs.org/patch/582313/
Also see:
http://lists.busybox.net/pipermail/buildroot/2015-December/146308.html
Best regards,
Romain
PATCH 1/1 libcap-ng: bump to version 0.7.7
Hi Romain,
Thanks for reviewing the patch.
2016-03-04 20:13 GMT-03:00 Romain Naour <[email protected]>:
Quoted 8 lines
Hi Sergio,
Le 05/03/2016 00:00, Sergio Prado a ?crit :
Quoted 2 lines
Also disable optimization when compiling for nios2 to prevent a compiler bug.
The bump and the nios2 fix must be two separate patches.
Right.
Quoted 2 lines
Quoted 2 lines
Fixes:
http://autobuild.buildroot.net/results/3afc4c006a74fd7512dace90b5f884bf7be4cc58/
Quoted 1 line
Quoted 1 line
http://autobuild.buildroot.net/results/2c53f611a705506ca86fedb0f1129df1d315632c/
Quoted 1 line
Quoted 1 line
http://autobuild.buildroot.net/results/c3d9477688b55987591b5b5efed5ee65499aa0e6/
Quoted 1 line
Quoted 1 line
http://autobuild.buildroot.net/results/052ff24f3985b652c11ac390f342e9ad3d862431/
Quoted 3 lines
Also the compiler bug is due to an issue with gcc <= 5.2. All theses build issues are trigged by br-nios2-full-2015.11-rc1-71-g90d1299.tar.bz2
toolchain
Quoted 7 lines
which is based on gcc 4.9.
I propose to add an exception in the autobuilder script:
http://patchwork.ozlabs.org/patch/582313/Also see:
http://lists.busybox.net/pipermail/buildroot/2015-December/146308.html
Adding an exception in the autobuilder will not fix the problem in production, right? The user that wants to use this package with NIOS2 and GCC <= 5.2 will still catch this problem. Working around the problem disabling GCC optimizations fixes in all cases. What do you think?
Quoted 4 lines
Best regards,
Romain
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160304/ee2eaf52/attachment.html>
PATCH 1/1 libcap-ng: bump to version 0.7.7
Hello Sergio,
Le 05/03/2016 00:48, Sergio Prado a ?crit :
Quoted 3 lines
Hi Romain,
Thanks for reviewing the patch.
You're welcome !
Quoted 27 lines
2016-03-04 20:13 GMT-03:00 Romain Naour <[email protected] <mailto:[email protected]>>:
Quoted 8 lines
Hi Sergio,
Le 05/03/2016 00:00, Sergio Prado a ?crit :
Quoted 2 lines
Also disable optimization when compiling for nios2 to prevent a compiler bug.
The bump and the nios2 fix must be two separate patches.
Right.
Quoted 13 lines
Quoted 5 lines
Fixes:
http://autobuild.buildroot.net/results/3afc4c006a74fd7512dace90b5f884bf7be4cc58/
http://autobuild.buildroot.net/results/2c53f611a705506ca86fedb0f1129df1d315632c/
http://autobuild.buildroot.net/results/c3d9477688b55987591b5b5efed5ee65499aa0e6/
http://autobuild.buildroot.net/results/052ff24f3985b652c11ac390f342e9ad3d862431/Also the compiler bug is due to an issue with gcc <= 5.2. All theses build issues are trigged by br-nios2-full-2015.11-rc1-71-g90d1299.tar.bz2 toolchain which is based on gcc 4.9.
I propose to add an exception in the autobuilder script:
http://patchwork.ozlabs.org/patch/582313/
Quoted 7 lines
Quoted 2 lines
Also see:
http://lists.busybox.net/pipermail/buildroot/2015-December/146308.htmlAdding an exception in the autobuilder will not fix the problem in production, right? The user that wants to use this package with NIOS2 and GCC <= 5.2 will still catch this problem. Working around the problem disabling GCC optimizations fixes in all cases. What do you think?
I think we need to backport the patch [1] to gcc 4.9.3 but we still need to add an exception in the autobuilder until the nios2 toolchain is rebuild.
Can you test this patch please:
http://patchwork.ozlabs.org/patch/592357/
Since other version of gcc are not available for nios2, we don't need to backport this patch.
Thanks for looking at nios2 build failure.
Best regards,
Romain
[1]
https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=3e326557585ffde323867375539f04643fcad29a
Quoted 5 lines
Quoted 5 lines
Best regards,
Romain
PATCH 1/1 libcap-ng: bump to version 0.7.7
In reply to Sergio PradoDear Sergio Prado,
Quoted 10 lines · Sergio Prado
Also disable optimization when compiling for nios2 to prevent a compiler bug.
Fixes:
http://autobuild.buildroot.net/results/3afc4c006a74fd7512dace90b5f884bf7be4cc58/
http://autobuild.buildroot.net/results/2c53f611a705506ca86fedb0f1129df1d315632c/
http://autobuild.buildroot.net/results/c3d9477688b55987591b5b5efed5ee65499aa0e6/
http://autobuild.buildroot.net/results/052ff24f3985b652c11ac390f342e9ad3d862431/
...
Quoted 6 lines
Signed-off-by Sergio Prado <[email protected]>--- package/libcap-ng/Config.in | 1 - package/libcap-ng/libcap-ng.hash | 2 +- package/libcap-ng/libcap-ng.mk | 7 ++++++- 3 files changed, 7 insertions(+), 3 deletions(-)
I've removed the nios2 related bits (following the feedback from Romain Naour), and applied to master.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com