usb: dwc2: disable erroneous overcurrent condition

PATCH New dinguyen at opensource.altera.com 2 participants 2 messages Mar 5, 2016 USB

lore

Share & tools

lore

dinguyen at opensource.altera.com

author

2016-03-05 00:57 UTC #0 lore raw

PATCH v2 1/1 usb: dwc2: disable erroneous overcurrent condition

From: Dinh Nguyen <[email protected]>

For the case where an external VBUS is used, we should enable the external VBUS comparator in the driver. This would prevent an unnecessary overcurrent error which would then disable the host port.

The overcurrent condition was happening on the SoCFPGA Cyclone5 devkit, thus USB was not working on the devkit. This patch fixes that problem.

Signed-off-by Dinh Nguyen <[email protected]>

---
v2: consolidate bit OR into a single line

---
 drivers/usb/host/dwc2.c |    4 +++-
 drivers/usb/host/dwc2.h |    2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)

drivers/usb/host/dwc2.c +3 -1

index c6727c3..b2f4bc6 100644
@@ -263,7 +263,9 @@ static void dwc_otg_core_init(struct dwc2_core_regs *regs)
 
 	/* Program the ULPI External VBUS bit if needed */
 #ifdef CONFIG_DWC2_PHY_ULPI_EXT_VBUS
-	usbcfg |= DWC2_GUSBCFG_ULPI_EXT_VBUS_DRV;
+	usbcfg |= (DWC2_GUSBCFG_ULPI_EXT_VBUS_DRV |
+		   DWC2_GUSBCFG_ULPI_INT_VBUS_INDICATOR |
+		   DWC2_GUSBCFG_INDICATOR_PASSTHROUGH);
 #else
 	usbcfg &= ~DWC2_GUSBCFG_ULPI_EXT_VBUS_DRV;
 #endif

drivers/usb/host/dwc2.h +2 -0

index 594757b..4482dc6 100644
@@ -152,6 +152,8 @@ struct dwc2_core_regs {
 #define DWC2_GUSBCFG_ULPI_INT_VBUS_INDICATOR_OFFSET	21
 #define DWC2_GUSBCFG_TERM_SEL_DL_PULSE			(1 << 22)
 #define DWC2_GUSBCFG_TERM_SEL_DL_PULSE_OFFSET		22
+#define DWC2_GUSBCFG_INDICATOR_PASSTHROUGH		(1 << 24)
+#define DWC2_GUSBCFG_INDICATOR_PASSTHROUGH_OFFSET	24
 #define DWC2_GUSBCFG_IC_USB_CAP				(1 << 26)
 #define DWC2_GUSBCFG_IC_USB_CAP_OFFSET			26
 #define DWC2_GUSBCFG_IC_TRAFFIC_PULL_REMOVE		(1 << 27)

Signature · 1 line

1.7.9.5

Marek Vasut

Applied

2016-03-05 01:22 UTC #1 lore raw

PATCH v2 1/1 usb: dwc2: disable erroneous overcurrent condition

Quoted 6 lines · dinguyen at opensource.altera.com

From: Dinh Nguyen <[email protected]>
For the case where an external VBUS is used, we should enable the external VBUS comparator in the driver. This would prevent an unnecessary overcurrent error which would then disable the host port.

Quoted 6 lines

The overcurrent condition was happening on the SoCFPGA Cyclone5 devkit, thus USB was not working on the devkit. This patch fixes that problem.
Signed-off-by Dinh Nguyen <[email protected]>
---
v2: consolidate bit OR into a single line

Applied, thanks!

Best regards,
Marek Vasut