Skip to contentSkip to conversation

arm64: dts: Add tmu node for exynos7

PATCH Applied Alim Akhtar 2 participants 4 messages Feb 26, 2016 – Mar 29, 2016

Subsystems (2)
Device tree bindings Arm Samsung Exynos
lore
Share & tools
lore

Alim Akhtar

author reviewer
#0 lore raw

PATCH v2 1/1 arm64: dts: Add tmu node for exynos7

This patch adds tmu node, related temprature sensor and triping point data for Atlas cpu core found on exynos7 SoC.

Signed-off-by Alim Akhtar <[email protected]>

---
Changes since v1:
* Addressed krzysztof's review comments.

 .../boot/dts/exynos/exynos7-tmu-sensor-conf.dtsi   |   25 +++++++++
 .../arm64/boot/dts/exynos/exynos7-trip-points.dtsi |   54 ++++++++++++++++++++
 arch/arm64/boot/dts/exynos/exynos7.dtsi            |   20 ++++++++
 3 files changed, 99 insertions(+)
 create mode 100644 arch/arm64/boot/dts/exynos/exynos7-tmu-sensor-conf.dtsi
 create mode 100644 arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi
arch/arm64/boot/dts/exynos/exynos7-tmu-sensor-conf.dtsi new file +25 -0
new file mode 100644
index 0000000..1d6dcf2
@@ -0,0 +1,25 @@
+/*
+ * Device tree sources for Exynos7 TMU sensor configuration
+ *
+ * Copyright (c) 2016 Samsung Electronics Co., Ltd.
+ *		http://www.samsung.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ */
+
+#include <dt-bindings/thermal/thermal_exynos.h>
+
+#thermal-sensor-cells = <0>;
+samsung,tmu_gain = <9>;
+samsung,tmu_reference_voltage = <17>;
+samsung,tmu_noise_cancel_mode = <4>;
+samsung,tmu_efuse_value = <75>;
+samsung,tmu_min_efuse_value = <15>;
+samsung,tmu_max_efuse_value = <100>;
+samsung,tmu_first_point_trim = <25>;
+samsung,tmu_second_point_trim = <85>;
+samsung,tmu_default_temp_offset = <50>;
+samsung,tmu_cal_type = <TYPE_ONE_POINT_TRIMMING>;
arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi new file +54 -0

54 lines not on this page · raw message

arch/arm64/boot/dts/exynos/exynos7.dtsi +20 -0
index c662f98..19de742 100644
@@ -27,6 +27,7 @@
 		pinctrl6 = &pinctrl_fsys0;
 		pinctrl7 = &pinctrl_fsys1;
 		pinctrl8 = &pinctrl_bus1;
+		tmuctrl0 = &tmuctrl_0;
 	};
 
 	cpus {

@@ -538,6 +539,25 @@
 			clocks = <&clock_peric0 PCLK_PWM>;
 			clock-names = "timers";
 		};
+
+		tmuctrl_0: tmu@10060000 {
+			compatible = "samsung,exynos7-tmu";
+			reg = <0x10060000 0x200>;
+			interrupts = <0 108 0>;
+			clocks = <&clock_peris PCLK_TMU>,
+				 <&clock_peris SCLK_TMU>;
+			clock-names = "tmu_apbif", "tmu_sclk";
+			#include "exynos7-tmu-sensor-conf.dtsi"
+		};
+
+		thermal-zones {
+			atlas_thermal: cluster0-thermal {
+				polling-delay-passive = <0>; /* milliseconds */
+				polling-delay = <0>; /* milliseconds */
+				thermal-sensors = <&tmuctrl_0>;
+				#include "exynos7-trip-points.dtsi"
+			};
+		};
 	};
 };
Signature · 1 line
1.7.10.4
Reviewed-by on v2 1/1
#1 lore raw
Quoted 8 lines · Alim Akhtar

This patch adds tmu node, related temprature sensor and triping point data for Atlas cpu core found on exynos7 SoC.

Signed-off-by Alim Akhtar <[email protected]>

---
Changes since v1:
* Addressed krzysztof's review comments.

Quoted 7 lines
 .../boot/dts/exynos/exynos7-tmu-sensor-conf.dtsi   |   25 +++++++++
 .../arm64/boot/dts/exynos/exynos7-trip-points.dtsi |   54 ++++++++++++++++++++
 arch/arm64/boot/dts/exynos/exynos7.dtsi            |   20 ++++++++
 3 files changed, 99 insertions(+)
 create mode 100644 arch/arm64/boot/dts/exynos/exynos7-tmu-sensor-conf.dtsi
 create mode 100644 arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi

Looks good to me.

Reviewed-by Krzysztof Kozlowski <[email protected]>

I don't have anything in DTS queue for v4.6 and it is late so I'll apply this for v4.7 after upcoming merge window.

Best regards,
Krzysztof

author reviewer
#2 lore raw

Hi Krzysztof,

Quoted 17 lines · Krzysztof Kozlowski
Quoted 8 lines · Alim Akhtar

This patch adds tmu node, related temprature sensor and triping point data for Atlas cpu core found on exynos7 SoC.

Signed-off-by Alim Akhtar <[email protected]>

---
Changes since v1:
* Addressed krzysztof's review comments.

Quoted 7 lines
  .../boot/dts/exynos/exynos7-tmu-sensor-conf.dtsi   |   25 +++++++++
  .../arm64/boot/dts/exynos/exynos7-trip-points.dtsi |   54 ++++++++++++++++++++
  arch/arm64/boot/dts/exynos/exynos7.dtsi            |   20 ++++++++
  3 files changed, 99 insertions(+)

create mode 100644 arch/arm64/boot/dts/exynos/exynos7-tmu-sensor-conf.dtsi create mode 100644 arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi

Quoted 3 lines

Looks good to me.

Reviewed-by Krzysztof Kozlowski <[email protected]>

Thanks!

Quoted 3 lines

I don't have anything in DTS queue for v4.6 and it is late so I'll apply this for v4.7 after upcoming merge window.

I am ok with this patch going for v4.7.

Quoted 5 lines

Best regards,
Krzysztof

Applied
#3 lore raw
Quoted 20 lines · Alim Akhtar

Hi Krzysztof,

Quoted 17 lines · Krzysztof Kozlowski
Quoted 16 lines · Alim Akhtar

This patch adds tmu node, related temprature sensor and triping point data for Atlas cpu core found on exynos7 SoC.

Signed-off-by Alim Akhtar <[email protected]>

---
Changes since v1:
* Addressed krzysztof's review comments.

  .../boot/dts/exynos/exynos7-tmu-sensor-conf.dtsi   |   25 +++++++++
  .../arm64/boot/dts/exynos/exynos7-trip-points.dtsi |   54
++++++++++++++++++++
  arch/arm64/boot/dts/exynos/exynos7.dtsi            |   20 ++++++++
  3 files changed, 99 insertions(+)

create mode 100644
arch/arm64/boot/dts/exynos/exynos7-tmu-sensor-conf.dtsi
create mode 100644 arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi

Queued for v4.7. Thanks.

Best regards,
Krzysztof