busybox: use md5 as default password algorithm
PATCH 1/1 busybox: use md5 as default password algorithm
DES is terribly outdated and a security vulnerability.
--- package/busybox/busybox.config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/busybox/busybox.config +1 -1
@@ -496,7 +496,7 @@ CONFIG_PASSWD=y CONFIG_FEATURE_PASSWD_WEAK_CHECK=y # CONFIG_CRYPTPW is not set # CONFIG_CHPASSWD is not set -CONFIG_FEATURE_DEFAULT_PASSWD_ALGO="des" +CONFIG_FEATURE_DEFAULT_PASSWD_ALGO="md5" CONFIG_SU=y CONFIG_FEATURE_SU_SYSLOG=y CONFIG_FEATURE_SU_CHECKS_SHELLS=y
Signature · 1 line
2.4.10
PATCH 1/1 busybox: use md5 as default password algorithm
Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Gustavo" == Gustavo Zacarias <[email protected]> writes:
DES is terribly outdated and a security vulnerability.
Signed-off-by Gustavo Zacarias <[email protected]>--- package/busybox/busybox.config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/busybox/busybox.config +0
-0
package/busybox/busybox.config CONFIG_PASSWD=y · line 499
Quoted 5 lines
package/busybox/busybox.config +1
-1@@ -496,7 +496,7 @@ CONFIG_PASSWD=y CONFIG_FEATURE_PASSWD_WEAK_CHECK=y # CONFIG_CRYPTPW is not set # CONFIG_CHPASSWD is not set -CONFIG_FEATURE_DEFAULT_PASSWD_ALGO="des" +CONFIG_FEATURE_DEFAULT_PASSWD_ALGO="md5"
So this is what is used when you change password through the busybox passwd applet or create a new user, right?
Shouldn't we instead tweak this based on BR2_TARGET_GENERIC_PASSWD_*?
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 busybox: use md5 as default password algorithm
Quoted 4 lines · Peter Korsgaard
So this is what is used when you change password through the busybox passwd applet or create a new user, right?
Shouldn't we instead tweak this based on BR2_TARGET_GENERIC_PASSWD_*?
Yes.
This is the lowest-common which is guaranteed to work on all scenarios, once we decide/switch to sha256 as default we can update it here, but i wouldn't defer this until then.
Regards.
PATCH 1/1 busybox: use md5 as default password algorithm
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Gustavo" == Gustavo Zacarias <[email protected]> writes:
Quoted 3 lines · Peter Korsgaard
So this is what is used when you change password through the busybox passwd applet or create a new user, right?
Quoted 6 lines
Quoted 1 line
Shouldn't we instead tweak this based on BR2_TARGET_GENERIC_PASSWD_*?
Yes.
This is the lowest-common which is guaranteed to work on all scenarios, once we decide/switch to sha256 as default we can update it here, but i wouldn't defer this until then.
Ehh, yes - But if you have enabled E.G BR2_TARGET_GENERIC_PASSWD_SHA512 then that is what the busybox passwd applet should use. Having it do md5 instead of des is still wrong.
Signature · 2 lines
Venlig hilsen, Peter Korsgaard
PATCH 1/1 busybox: use md5 as default password algorithm
Quoted 8 lines · Peter Korsgaard
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Gustavo" == Gustavo Zacarias <[email protected]> writes:
Quoted 4 lines · Peter Korsgaard
So this is what is used when you change password through the busybox passwd applet or create a new user, right?
Shouldn't we instead tweak this based on BR2_TARGET_GENERIC_PASSWD_*?
Quoted 8 lines
Quoted 4 lines
Yes.
This is the lowest-common which is guaranteed to work on all scenarios, once we decide/switch to sha256 as default we can update it here, but i wouldn't defer this until then.Ehh, yes - But if you have enabled E.G
BR2_TARGET_GENERIC_PASSWD_SHA512then that is what the busybox passwd applet should use. Having it do md5 instead of des is still wrong.
Peter, you yourself said that we should limit the amount of KCONFIG_* fixups
we do. And there is no other way to make it depend on the BR2_TARGET_GENERIC_PASSWD_* choice.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Thomas Petazzoni
AppliedPATCH 1/1 busybox: use md5 as default password algorithm
In reply to Gustavo ZacariasHello,
Quoted 6 lines · Gustavo Zacarias
DES is terribly outdated and a security vulnerability.
Signed-off-by Gustavo Zacarias <[email protected]>--- package/busybox/busybox.config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
I've (obviously) read the discussion with Peter, but I believe the issue he is raising is different. We already have our Busybox configuration default to "des", which is not consistent with the algo choice made by the user in the Buildroot configuration. So switching to "md5" is not making things any worse from that perspective.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 busybox: use md5 as default password algorithm
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
Hi,
Quoted 5 lines
I've (obviously) read the discussion with Peter, but I believe the issue he is raising is different. We already have our Busybox configuration default to "des", which is not consistent with the algo choice made by the user in the Buildroot configuration. So switching to "md5" is not making things any worse from that perspective.
True. It would be good if we could make busybox default to the algorithm we've selected in buildroot, but that can be done later.
Signature · 1 line
Bye, Peter Korsgaard