Skip to contentSkip to conversation

Staging: rtl8192e: Fix warning exceeding characters per line

PATCH In review Adonis Settouf 2 participants 2 messages Mar 12, 2016 – Mar 22, 2016 1 message not in the archive Staging

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Adonis Settouf

author
#1 lore raw

PATCH 1/1 Staging: rtl8192e: Fix warning exceeding characters per line

This patch fixes the checkpatch.pl warning regarding the exceeding 80 characters on line 36. This patch add a newline after function statement on line 52

Signed-off-by Adonis Settouf <[email protected]>
---
 drivers/staging/rtl8192e/dot11d.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/dot11d.h +3 -2
index 735a199..5cffc8f 100644
@@ -30,8 +30,8 @@ enum dot11d_state {
 };
 
 /**
- * struct rt_dot11d_info * @CountryIeLen: value greater than 0 if @CountryIeBuf contains
- *		  valid country information element.
+ * struct rt_dot11d_info * @CountryIeLen: value greater than 0 if
+ * @CountryIeBuf contains valid country information element.
  * @channel_map: holds channel values
  *		0 - invalid,
  *		1 - valid (active scan),

@@ -78,6 +78,7 @@ static inline void RESET_CIE_WATCHDOG(struct rtllib_device *__pIeeeDev)
 {
 	GET_CIE_WATCHDOG(__pIeeeDev) = 0;
 }
+
 #define UPDATE_CIE_WATCHDOG(__pIeeeDev) (++GET_CIE_WATCHDOG(__pIeeeDev))
 
 void dot11d_init(struct rtllib_device *dev);
Signature · 1 line
2.1.4
maintainer
#2 lore raw
Quoted 3 lines · Adonis Settouf

This patch fixes the checkpatch.pl warning regarding the exceeding 80 characters on line 36. This patch add a newline after function statement on line 52

You did 2 different things in the same patch, that should be 2 patches.

Quoted 11 lines
Signed-off-by Adonis Settouf <[email protected]>
---
 drivers/staging/rtl8192e/dot11d.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/dot11d.h +0 -0
index 735a199..5cffc8f 100644

drivers/staging/rtl8192e/dot11d.h enum dot11d_state { · line 34

Quoted 7 lines
drivers/staging/rtl8192e/dot11d.h +2 -2
@@ -30,8 +30,8 @@ enum dot11d_state {
 };
 
 /**
- * struct rt_dot11d_info * @CountryIeLen: value greater than 0 if @CountryIeBuf contains
- *		  valid country information element.
+ * struct rt_dot11d_info * @CountryIeLen: value greater than 0 if
+ * @CountryIeBuf contains valid country information element.

You forgot to indent like the rest of this comment block did :(