Skip to contentSkip to conversation

ti: k2g: increase phy autoneg timeout

PATCH In review Vitaly Andrianov 2 participants 5 messages Mar 11, 2016 – Mar 23, 2016

lore
Share & tools
lore

Vitaly Andrianov

author
#0 lore raw

PATCH 1/1 ti: k2g: increase phy autoneg timeout

After power cycle of a K2G EVM dhcp fails due to a auto-negotiation timeout. This commit increases the timeout to fix the issue.

Signed-off-by Vitaly Andrianov <[email protected]>

---

 board/ti/ks2_evm/board.c  | 2 +-
 include/configs/k2g_evm.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
board/ti/ks2_evm/board.c +1 -1
index 73f0f27..a2c7542 100644
@@ -7,8 +7,8 @@
  * SPDX-License-Identifier:     GPL-2.0+
  */
 
-#include "board.h"
 #include <common.h>
+#include "board.h"
 #include <spl.h>
 #include <exports.h>
 #include <fdt_support.h>
include/configs/k2g_evm.h +1 -0
index d67d091..805f75e 100644
@@ -52,6 +52,7 @@
 #define CONFIG_KSNET_NETCP_V1_5
 #define CONFIG_KSNET_CPSW_NUM_PORTS	2
 #define CONFIG_PHY_MICREL
+#define PHY_ANEG_TIMEOUT	10000 /* PHY needs longer aneg time */
 
 /* MMC/SD */
 #define CONFIG_MMC
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ti: k2g: increase phy autoneg timeout

Quoted 15 lines · Vitaly Andrianov

After power cycle of a K2G EVM dhcp fails due to a auto-negotiation timeout. This commit increases the timeout to fix the issue.

Signed-off-by Vitaly Andrianov <[email protected]>

---

 board/ti/ks2_evm/board.c  | 2 +-
 include/configs/k2g_evm.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
board/ti/ks2_evm/board.c +0 -0
index 73f0f27..a2c7542 100644

board/ti/ks2_evm/board.c line 14

Quoted 9 lines
board/ti/ks2_evm/board.c +1 -1
@@ -7,8 +7,8 @@
  * SPDX-License-Identifier:     GPL-2.0+
  */
 
-#include "board.h"
 #include <common.h>
+#include "board.h"
 #include <spl.h>
 #include <exports.h>
 #include <fdt_support.h>

Spurious change?

Reviewed-by Tom Rini <[email protected]>

for the rest tho.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160311/84fd336c/attachment.sig>
author
#2 lore raw

PATCH 1/1 ti: k2g: increase phy autoneg timeout

Quoted 29 lines · Tom Rini
Quoted 15 lines · Vitaly Andrianov

After power cycle of a K2G EVM dhcp fails due to a auto-negotiation timeout. This commit increases the timeout to fix the issue.

Signed-off-by Vitaly Andrianov <[email protected]>

---

  board/ti/ks2_evm/board.c  | 2 +-
  include/configs/k2g_evm.h | 1 +
  2 files changed, 2 insertions(+), 1 deletion(-)
board/ti/ks2_evm/board.c +0 -0
index 73f0f27..a2c7542 100644

board/ti/ks2_evm/board.c line 14

Quoted 9 lines
board/ti/ks2_evm/board.c +1 -1
@@ -7,8 +7,8 @@
   * SPDX-License-Identifier:     GPL-2.0+
   */
 
-#include "board.h"
  #include <common.h>
+#include "board.h"
  #include <spl.h>
  #include <exports.h>
  #include <fdt_support.h>

Spurious change?

Quoted 4 lines
Reviewed-by Tom Rini <[email protected]>

for the rest tho.

Without this change it gives compilation warning:

In file included from include/config.h:5:0,

                   from include/common.h:18,
                   from board/ti/ks2_evm/board.c:11:

include/configs/k2g_evm.h:55:0: warning: "PHY_ANEG_TIMEOUT" redefined
#define PHY_ANEG_TIMEOUT 10000 /* PHY needs longer aneg time */ ^
In file included from ./arch/arm/include/asm/ti-common/keystone_net.h:14:0,

                   from board/ti/ks2_evm/board.h:13,
                   from board/ti/ks2_evm/board.c:10:

include/phy.h:36:0: note: this is the location of the previous definition
#define PHY_ANEG_TIMEOUT 4000

#3 lore raw

PATCH 1/1 ti: k2g: increase phy autoneg timeout

Quoted 39 lines · Vitaly Andrianov
Quoted 29 lines · Tom Rini
Quoted 15 lines · Vitaly Andrianov

After power cycle of a K2G EVM dhcp fails due to a auto-negotiation timeout. This commit increases the timeout to fix the issue.

Signed-off-by Vitaly Andrianov <[email protected]>

---

 board/ti/ks2_evm/board.c  | 2 +-
 include/configs/k2g_evm.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
board/ti/ks2_evm/board.c +0 -0
index 73f0f27..a2c7542 100644

board/ti/ks2_evm/board.c line 14

Quoted 9 lines
board/ti/ks2_evm/board.c +1 -1
@@ -7,8 +7,8 @@
  * SPDX-License-Identifier:     GPL-2.0+
  */
 
-#include "board.h"
 #include <common.h>
+#include "board.h"
 #include <spl.h>
 #include <exports.h>
 #include <fdt_support.h>

Spurious change?

Quoted 4 lines
Reviewed-by Tom Rini <[email protected]>

for the rest tho.

Without this change it gives compilation warning:

In file included from include/config.h:5:0,

                  from include/common.h:18,
                  from board/ti/ks2_evm/board.c:11:
Quoted 8 lines

include/configs/k2g_evm.h:55:0: warning: "PHY_ANEG_TIMEOUT" redefined
#define PHY_ANEG_TIMEOUT 10000 /* PHY needs longer aneg time */ ^
In file included from ./arch/arm/include/asm/ti-common/keystone_net.h:14:0,

                  from board/ti/ks2_evm/board.h:13,
                  from board/ti/ks2_evm/board.c:10:

include/phy.h:36:0: note: this is the location of the previous definition
#define PHY_ANEG_TIMEOUT 4000

Ah, OK, thanks for explaining then.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160314/231bc515/attachment.sig>
#4 lore raw
In reply to Vitaly Andrianov
Quoted 5 lines · Vitaly Andrianov

After power cycle of a K2G EVM dhcp fails due to a auto-negotiation timeout. This commit increases the timeout to fix the issue.

Signed-off-by Vitaly Andrianov <[email protected]>
Reviewed-by Tom Rini <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160322/1f213fd1/attachment.sig>