Avoid that long log lines are truncated

PATCH In review Bart Van Assche 4 participants 5 messages Mar 14, 2016 SCSI

Share & tools

Bart Van Assche

author

2016-03-14 14:20 UTC #0 lore raw

PATCH 1/1 Avoid that long log lines are truncated

While testing the latest version of the SRP initiator and target drivers I encountered the following message in the kernel log:

sd 16:0:0:0: Warning! Received an indication that the LUN assignments on this target have changed. The Linux SCSI layer does not automatical

This is a truncated message. Avoid that such truncation happens by increasing the SCSI_LOG_BUFSIZE constant.

Fixes ded85c193a39 (scsi: Implement per-cpu logging buffer)

Signed-off-by Bart Van Assche <[email protected]>

Cc Hannes Reinecke <[email protected]>

Cc Christoph Hellwig <[email protected]>

Cc Robert Elliott <[email protected]>

Cc Ewan D. Milne <[email protected]>

Cc <[email protected]> # v4.0+

---
 include/scsi/scsi_dbg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/scsi/scsi_dbg.h +1 -1

index 56710e0..05d36eb 100644
@@ -5,7 +5,7 @@ struct scsi_cmnd;
 struct scsi_device;
 struct scsi_sense_hdr;
 
-#define SCSI_LOG_BUFSIZE 128
+#define SCSI_LOG_BUFSIZE 256
 
 extern void scsi_print_command(struct scsi_cmnd *);
 extern size_t __scsi_format_command(char *, size_t,

Signature · 1 line

2.7.2

Johannes Thumshirn

Reviewed-by on v1 1/1

2016-03-14 14:32 UTC #1 lore raw

Quoted 10 lines · Bart Van Assche

While testing the latest version of the SRP initiator and target drivers I encountered the following message in the kernel log:
sd 16:0:0:0: Warning! Received an indication that the LUN assignments on this target have changed. The Linux SCSI layer does not automatical
This is a truncated message. Avoid that such truncation happens by increasing the SCSI_LOG_BUFSIZE constant.
Fixes ded85c193a39 (scsi: Implement per-cpu logging buffer)
Signed-off-by Bart Van Assche <[email protected]>

Reviewed-by Johannes Thumshirn <[email protected]>

Signature · 10 lines

Johannes Thumshirn                                          Storage
[email protected]                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Hannes Reinecke

Reviewed-by on v1 1/1

2016-03-14 14:36 UTC #2 lore raw

In reply to Bart Van Assche

Quoted 25 lines · Bart Van Assche

While testing the latest version of the SRP initiator and target drivers I encountered the following message in the kernel log:
sd 16:0:0:0: Warning! Received an indication that the LUN assignments on this target have changed. The Linux SCSI layer does not automatical
This is a truncated message. Avoid that such truncation happens by increasing the SCSI_LOG_BUFSIZE constant.
Fixes ded85c193a39 (scsi: Implement per-cpu logging buffer)
Signed-off-by Bart Van Assche <[email protected]>
Cc Hannes Reinecke <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Robert Elliott <[email protected]>
Cc Ewan D. Milne <[email protected]>
Cc <[email protected]> # v4.0+
---
 include/scsi/scsi_dbg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/scsi/scsi_dbg.h +0 -0
index 56710e0..05d36eb 100644

include/scsi/scsi_dbg.h struct scsi_cmnd; · line 11

Quoted 8 lines

include/scsi/scsi_dbg.h +1 -1

@@ -5,7 +5,7 @@ struct scsi_cmnd;
 struct scsi_device;
 struct scsi_sense_hdr;
 
-#define SCSI_LOG_BUFSIZE 128
+#define SCSI_LOG_BUFSIZE 256
 
 extern void scsi_print_command(struct scsi_cmnd *);
 extern size_t __scsi_format_command(char *, size_t,

Reviewed-by Hannes Reinecke <[email protected]>

Cheers,

Hannes

Signature · 9 lines

Dr. Hannes Reinecke		   Teamlead Storage & Networking
[email protected]			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Ewan Milne

Reviewed-by on v1 1/1

2016-03-14 14:38 UTC #3 lore raw

In reply to Bart Van Assche

Quoted 24 lines · Bart Van Assche

While testing the latest version of the SRP initiator and target drivers I encountered the following message in the kernel log:
sd 16:0:0:0: Warning! Received an indication that the LUN assignments on this target have changed. The Linux SCSI layer does not automatical
This is a truncated message. Avoid that such truncation happens by increasing the SCSI_LOG_BUFSIZE constant.
Fixes ded85c193a39 (scsi: Implement per-cpu logging buffer)
Signed-off-by Bart Van Assche <[email protected]>
Cc Hannes Reinecke <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Robert Elliott <[email protected]>
Cc Ewan D. Milne <[email protected]>
Cc <[email protected]> # v4.0+
---
 include/scsi/scsi_dbg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/scsi/scsi_dbg.h +0 -0
index 56710e0..05d36eb 100644

include/scsi/scsi_dbg.h struct scsi_cmnd; · line 11

Quoted 8 lines

include/scsi/scsi_dbg.h +1 -1

@@ -5,7 +5,7 @@ struct scsi_cmnd;
 struct scsi_device;
 struct scsi_sense_hdr;
 
-#define SCSI_LOG_BUFSIZE 128
+#define SCSI_LOG_BUFSIZE 256
 
 extern void scsi_print_command(struct scsi_cmnd *);
 extern size_t __scsi_format_command(char *, size_t,

Hmm. Perhaps we should make the message less verbose instead? It looks like if we increase SCSI_LOG_BUFSIZE then we get fewer per-message buffers unless we also increase SCSI_LOG_SPOOLSIZE.

Reviewed-by Ewan D. Milne <[email protected]>

Hannes Reinecke

2016-03-14 14:45 UTC #4 lore raw

Quoted 31 lines · Ewan Milne

Quoted 30 lines · Bart Van Assche
While testing the latest version of the SRP initiator and target drivers I encountered the following message in the kernel log:
sd 16:0:0:0: Warning! Received an indication that the LUN assignments on this target have changed. The Linux SCSI layer does not automatical
This is a truncated message. Avoid that such truncation happens by increasing the SCSI_LOG_BUFSIZE constant.
Fixes ded85c193a39 (scsi: Implement per-cpu logging buffer)
Signed-off-by Bart Van Assche <[email protected]>
Cc Hannes Reinecke <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Robert Elliott <[email protected]>
Cc Ewan D. Milne <[email protected]>
Cc <[email protected]> # v4.0+
---
 include/scsi/scsi_dbg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/scsi/scsi_dbg.h +1 -1
index 56710e0..05d36eb 100644
@@ -5,7 +5,7 @@ struct scsi_cmnd;
 struct scsi_device;
 struct scsi_sense_hdr;
 
-#define SCSI_LOG_BUFSIZE 128
+#define SCSI_LOG_BUFSIZE 256
 

Quoted 7 lines

include/scsi/scsi_dbg.h struct scsi_cmnd; · line 11
Quoted 2 lines
include/scsi/scsi_dbg.h +0 -0
 extern void scsi_print_command(struct scsi_cmnd *);
 extern size_t __scsi_format_command(char *, size_t,
Hmm. Perhaps we should make the message less verbose instead? It looks like if we increase SCSI_LOG_BUFSIZE then we get fewer per-message buffers unless we also increase SCSI_LOG_SPOOLSIZE.

Or just shorten the message itself.
It's really annoying having these really long messages showing up in the system log ...

Cheers,

Hannes

Signature · 9 lines

Dr. Hannes Reinecke		   Teamlead Storage & Networking
[email protected]			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html