Skip to contentSkip to conversation

Fix multipe typos "choosen" instead of "chosen" in dts/code

PATCH New Alexander Merkle 4 participants 13 messages Mar 17, 2016 – Mar 27, 2016 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

cover Fix multipe typos "choosen" instead of "chosen" in dts/code

The dts files for NXP/Freescale Vybrid series were broken. Fixed some other typos in comments & printfs to.

Alexander Merkle (3):
Fix typo in chosen parameter in vf610-twr.dts
Fix typo in chosen parameter of pcm052.dts
Fix typo choosen in comments and printf logs

 arch/arm/dts/pcm052.dts                 | 2 +-
 arch/arm/dts/vf610-twr.dts              | 2 +-
 common/menu.c                           | 2 +-
 drivers/ddr/fsl/lc_common_dimm_params.c | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)
Signature · 1 line
2.7.0
#1 lore raw

PATCH 1/3 Fix typo in chosen parameter in vf610-twr.dts

Fix typo "choosen" instead of "chosen" in vf610-twr.dts. Fixes boot process and terminal output for Vybrid series.

---

 arch/arm/dts/vf610-twr.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/vf610-twr.dts +1 -1
index a4ccbcb..237aa8d 100644
@@ -11,7 +11,7 @@
 	model = "VF610 Tower Board";
 	compatible = "fsl,vf610-twr", "fsl,vf610";
 
-	choosen {
+	chosen {
 		stdout-path = &uart1;
 	};
 
Signature · 1 line
2.7.0
#2 lore raw

PATCH 1/3 Fix typo in chosen parameter in vf610-twr.dts

Quoted 9 lines · Alexander Merkle

Fix typo "choosen" instead of "chosen" in vf610-twr.dts. Fixes boot process and terminal output for Vybrid series.

---

 arch/arm/dts/vf610-twr.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
#3 lore raw

PATCH 1/3 Fix typo in chosen parameter in vf610-twr.dts

In reply to Alexander Merkle
Quoted 5 lines · Alexander Merkle

Fix typo "choosen" instead of "chosen" in vf610-twr.dts. Fixes boot process and terminal output for Vybrid series.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160327/552e44a9/attachment.sig>
#4 lore raw

PATCH 2/3 Fix typo in chosen parameter of pcm052.dts

In reply to Alexander Merkle

Fix typo "choosen" instead of "chosen" in pcm052.dts. Not tested but should fix boot process and terminal output.

---

 arch/arm/dts/pcm052.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/pcm052.dts +1 -1
index 0475f1f..0985587 100644
@@ -11,7 +11,7 @@
 	model = "Phytec phyCORE-Vybrid";
 	compatible = "phytec,pcm052", "fsl,vf610";
 
-	choosen {
+	chosen {
 		stdout-path = &uart1;
 	};
 
Signature · 1 line
2.7.0
#5 lore raw

PATCH 2/3 Fix typo in chosen parameter of pcm052.dts

Quoted 9 lines · Alexander Merkle

Fix typo "choosen" instead of "chosen" in pcm052.dts. Not tested but should fix boot process and terminal output.

---

 arch/arm/dts/pcm052.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
#6 lore raw

PATCH 2/3 Fix typo in chosen parameter of pcm052.dts

In reply to Alexander Merkle
Quoted 5 lines · Alexander Merkle

Fix typo "choosen" instead of "chosen" in pcm052.dts. Not tested but should fix boot process and terminal output.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160327/d0f57b64/attachment.sig>
#7 lore raw

PATCH 3/3 Fix typo choosen in comments and printf logs

In reply to Alexander Merkle

Minor change: chosen is written with one "o".
No code change here, only comment & printf.

---

 common/menu.c                           | 2 +-
 drivers/ddr/fsl/lc_common_dimm_params.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
common/menu.c +1 -1
index eda96d6..c53030f 100644
@@ -350,7 +350,7 @@ int menu_item_add(struct menu *m, char *item_key, void *item_data)
  * make it obvious what the key for each entry is.
  *
  * item_choice - If not NULL, will be called when asking the user to choose an
- * item. Returns a key string corresponding to the choosen item or NULL if
+ * item. Returns a key string corresponding to the chosen item or NULL if
  * no item has been selected.
  *
  * item_choice_data - Will be passed as the argument to the item_choice function
drivers/ddr/fsl/lc_common_dimm_params.c +2 -2
index 47ad4e5..850c8f6 100644
@@ -60,8 +60,8 @@ compute_cas_latency(const unsigned int ctrl_num,
 	 * 18ns for all DDR4 speed grades.
 	 */
 	if (caslat_actual * mclk_ps > taamax) {
-		printf("The choosen cas latency %d is too large\n",
-			caslat_actual);
+		printf("The chosen cas latency %d is too large\n",
+		       caslat_actual);
 	}
 	outpdimm->lowest_common_spd_caslat = caslat_actual;
 	debug("lowest_common_spd_caslat is 0x%x\n", caslat_actual);
Signature · 1 line
2.7.0
#8 lore raw

PATCH 3/3 Fix typo choosen in comments and printf logs

Quoted 10 lines · Alexander Merkle

Minor change: chosen is written with one "o".
No code change here, only comment & printf.

---

 common/menu.c                           | 2 +-
 drivers/ddr/fsl/lc_common_dimm_params.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
#9 lore raw

PATCH 3/3 Fix typo choosen in comments and printf logs

In reply to Alexander Merkle
Quoted 5 lines · Alexander Merkle

Minor change: chosen is written with one "o".
No code change here, only comment & printf.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160327/c4019ed4/attachment.sig>
#10 lore raw

cover Fix multipe typos "choosen" instead of "chosen" in dts/code

In reply to Alexander Merkle
Quoted 3 lines · Alexander Merkle

The dts files for NXP/Freescale Vybrid series were broken. Fixed some other typos in comments & printfs to.

I guess this is not typo the node name is 'chosen'. Some documentation is here[1].

[1]
http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/chosen.txt

Quoted 13 lines

Alexander Merkle (3):
Fix typo in chosen parameter in vf610-twr.dts
Fix typo in chosen parameter of pcm052.dts
Fix typo choosen in comments and printf logs

  arch/arm/dts/pcm052.dts                 | 2 +-
  arch/arm/dts/vf610-twr.dts              | 2 +-
  common/menu.c                           | 2 +-
  drivers/ddr/fsl/lc_common_dimm_params.c | 4 ++--
  4 files changed, 5 insertions(+), 5 deletions(-)
Signature · 2 lines
Best regards,
Bhuvan
#11 lore raw

cover Fix multipe typos "choosen" instead of "chosen" in dts/code

Hi,

may be the subject is misleading. The DTS/DTB entry should be named
"chosen"
but it was "choosen" with "oo" in the git master. Have a look to the commits.

arch/arm/dts/vf610-twr.dts +1 -1
index a4ccbcb..237aa8d 100644
@@ -11,7 +11,7 @@
  	model = "VF610 Tower Board";
  	compatible = "fsl,vf610-twr", "fsl,vf610";
 
-	choosen {
+	chosen {
  		stdout-path = &uart1;
  	};
 

Regards,

Alex

Alexander Merkle
System Engineer
Lauterbach GmbH
Altlaufstra?e 40
85635 Hoehenkirchen-Siegertsbrunn
Germany
Tel +49 8102 9876-147
mailto:alexander.merkle at lauterbach.com
http://www.lauterbach.com

Quoted 26 lines · Bhuvanchandra DV
Quoted 3 lines · Alexander Merkle

The dts files for NXP/Freescale Vybrid series were broken. Fixed some other typos in comments & printfs to.

I guess this is not typo the node name is 'chosen'. Some documentation is here[1].

[1]
http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/chosen.txt

Quoted 13 lines

Alexander Merkle (3):
Fix typo in chosen parameter in vf610-twr.dts
Fix typo in chosen parameter of pcm052.dts
Fix typo choosen in comments and printf logs

  arch/arm/dts/pcm052.dts                 | 2 +-
  arch/arm/dts/vf610-twr.dts              | 2 +-
  common/menu.c                           | 2 +-
  drivers/ddr/fsl/lc_common_dimm_params.c | 4 ++--
  4 files changed, 5 insertions(+), 5 deletions(-)
#12 lore raw

cover Fix multipe typos "choosen" instead of "chosen" in dts/code

Quoted 6 lines · Alexander Merkle

Hi,

may be the subject is misleading. The DTS/DTB entry should be named
"chosen"
but it was "choosen" with "oo" in the git master. Have a look to the commits.

My bad! got it.

Quoted 56 lines
arch/arm/dts/vf610-twr.dts +1 -1
index a4ccbcb..237aa8d 100644
@@ -11,7 +11,7 @@
      model = "VF610 Tower Board";
      compatible = "fsl,vf610-twr", "fsl,vf610";
 
-    choosen {
+    chosen {
          stdout-path = &uart1;
      };
 

Regards,

Alex

Alexander Merkle
System Engineer
Lauterbach GmbH
Altlaufstra?e 40
85635 Hoehenkirchen-Siegertsbrunn
Germany
Tel +49 8102 9876-147
mailto:alexander.merkle at lauterbach.com
http://www.lauterbach.com

Quoted 27 lines · Bhuvanchandra DV
Quoted 3 lines · Alexander Merkle

The dts files for NXP/Freescale Vybrid series were broken. Fixed some other typos in comments & printfs to.

I guess this is not typo the node name is 'chosen'. Some documentation is here[1].

[1]
http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/chosen.txt

Quoted 13 lines

Alexander Merkle (3):
Fix typo in chosen parameter in vf610-twr.dts
Fix typo in chosen parameter of pcm052.dts
Fix typo choosen in comments and printf logs

  arch/arm/dts/pcm052.dts                 | 2 +-
  arch/arm/dts/vf610-twr.dts              | 2 +-
  common/menu.c                           | 2 +-
  drivers/ddr/fsl/lc_common_dimm_params.c | 4 ++--
  4 files changed, 5 insertions(+), 5 deletions(-)
Signature · 2 lines
Best regards,
Bhuvan