ARM: dts: dra7xx: Fix compatible string for PCF8575 chip

PATCH In review Ben Hutchings 5 participants 9 messages Mar 16, 2016 – Apr 13, 2016 7 messages not in the archive Device tree bindings

lore

Share & tools

lore

Ben Hutchings

author

2016-03-16 16:52 UTC #0 lore raw

PATCH v2 1/1 ARM: dts: dra7xx: Fix compatible string for PCF8575 chip

The binding definition for the PCF857x GPIO expanders doesn't mention a "ti,pcf8575" compatible string. This is apparently because TI is only a second source - there is no functional difference between PCF8575 chips manufactured by TI and NXP, and the same board might be populated with either depending on availability.

This is not a problem in practice because the I2C core uses of_modalias_node() before matching drivers and this strips the manufacturer name.

Signed-off-by Ben Hutchings <[email protected]>

---
v2: Correct the claim that this is a practical problem.

 arch/arm/boot/dts/dra7-evm.dts  | 2 +-
 arch/arm/boot/dts/dra72-evm.dts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

arch/arm/boot/dts/dra7-evm.dts +1 -1

index cfc24e52244e..3907c9d2c12e 100644
@@ -539,7 +539,7 @@
 	};
 
 	pcf_gpio_21: gpio@21 {
-		compatible = "ti,pcf8575";
+		compatible = "nxp,pcf8575";
 		reg = <0x21>;
 		lines-initial-states = <0x1408>;
 		gpio-controller;

arch/arm/boot/dts/dra72-evm.dts +1 -1

index 00b12002c07c..7ec42bda3afb 100644
@@ -422,7 +422,7 @@
 	};
 
 	pcf_gpio_21: gpio@21 {
-		compatible = "ti,pcf8575";
+		compatible = "nxp,pcf8575";
 		reg = <0x21>;
 		lines-initial-states = <0x1408>;
 		gpio-controller;

Signature · 8 lines

Ben Hutchings
Software Developer, Codethink Ltd.


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

Nishanth Menon

2016-03-16 22:31 UTC #2 lore raw

Quoted 10 lines · Ben Hutchings

The binding definition for the PCF857x GPIO expanders doesn't mention a "ti,pcf8575" compatible string. This is apparently because TI is only a second source - there is no functional difference between PCF8575 chips manufactured by TI and NXP, and the same board might be populated with either depending on availability.
This is not a problem in practice because the I2C core uses of_modalias_node() before matching drivers and this strips the manufacturer name.

Yeah - thanks for catching this.. was planning on fixing this, but anyways.. f56de327b4c4 ARM: dts: dra72-evm: Add extcon nodes for USB 87517d26d888 ARM: dts: dra7-evm: Add extcon nodes for USB

Are the patches that introduce the "ti," binding... Roger: since this is introduced by your patches... Ccying you as well. weird since checkpatch does not complain..

Quoted 29 lines

Signed-off-by Ben Hutchings <[email protected]>

---
v2: Correct the claim that this is a practical problem.

 arch/arm/boot/dts/dra7-evm.dts  | 2 +-
 arch/arm/boot/dts/dra72-evm.dts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

arch/arm/boot/dts/dra7-evm.dts +1 -1

index cfc24e52244e..3907c9d2c12e 100644
@@ -539,7 +539,7 @@
 	};
 
 	pcf_gpio_21: gpio@21 {
-		compatible = "ti,pcf8575";
+		compatible = "nxp,pcf8575";
 		reg = <0x21>;
 		lines-initial-states = <0x1408>;
 		gpio-controller;

arch/arm/boot/dts/dra72-evm.dts +0 -0

index 00b12002c07c..7ec42bda3afb 100644

arch/arm/boot/dts/dra72-evm.dts line 428

Quoted 8 lines

arch/arm/boot/dts/dra72-evm.dts +1 -1

@@ -422,7 +422,7 @@
 	};
 
 	pcf_gpio_21: gpio@21 {
-		compatible = "ti,pcf8575";
+		compatible = "nxp,pcf8575";
 		reg = <0x21>;
 		lines-initial-states = <0x1408>;
 		gpio-controller;

While at it, do you want to fix up (+Seb):
a) Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt which also seems to refer to ti,pcf in example (introduced by df2634f43f51
x86: dtb: Add a device tree for CE4100 )
b) arch/x86/platform/ce4100/falconfalls.dts as well?

Signature · 6 lines

Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

Tony Lindgren

2016-04-12 21:04 UTC #4 lore raw

Quoted 48 lines · Nishanth Menon

Quoted 10 lines · Ben Hutchings
The binding definition for the PCF857x GPIO expanders doesn't mention a "ti,pcf8575" compatible string. This is apparently because TI is only a second source - there is no functional difference between PCF8575 chips manufactured by TI and NXP, and the same board might be populated with either depending on availability.
This is not a problem in practice because the I2C core uses of_modalias_node() before matching drivers and this strips the manufacturer name.
Yeah - thanks for catching this.. was planning on fixing this, but anyways.. f56de327b4c4 ARM: dts: dra72-evm: Add extcon nodes for USB 87517d26d888 ARM: dts: dra7-evm: Add extcon nodes for USB
Are the patches that introduce the "ti," binding... Roger: since this is introduced by your patches... Ccying you as well. weird since checkpatch does not complain..
Quoted 28 lines
Signed-off-by Ben Hutchings <[email protected]>
---
v2: Correct the claim that this is a practical problem.
 arch/arm/boot/dts/dra7-evm.dts  | 2 +-
 arch/arm/boot/dts/dra72-evm.dts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/dra7-evm.dts +1 -1
index cfc24e52244e..3907c9d2c12e 100644
@@ -539,7 +539,7 @@
 	};
 
 	pcf_gpio_21: gpio@21 {
-		compatible = "ti,pcf8575";
+		compatible = "nxp,pcf8575";
 		reg = <0x21>;
 		lines-initial-states = <0x1408>;
 		gpio-controller;
arch/arm/boot/dts/dra72-evm.dts +0 -0
index 00b12002c07c..7ec42bda3afb 100644
@@ -422,7 +422,7 @@
 	};
 

Quoted 16 lines

arch/arm/boot/dts/dra72-evm.dts line 428
Quoted 9 lines
arch/arm/boot/dts/dra72-evm.dts +1 -1
 	pcf_gpio_21: gpio@21 {
-		compatible = "ti,pcf8575";
+		compatible = "nxp,pcf8575";
 		reg = <0x21>;
 		lines-initial-states = <0x1408>;
 		gpio-controller;
While at it, do you want to fix up (+Seb):
a) Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt which also seems to refer to ti,pcf in example (introduced by df2634f43f51
x86: dtb: Add a device tree for CE4100 )
b) arch/x86/platform/ce4100/falconfalls.dts as well?

Applying this one with Roger's ack, seems like those should be additional patches.

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

Sebastian Andrzej Siewior

2016-04-13 06:59 UTC #6 lore raw

Quoted 8 lines · Tony Lindgren

Quoted 5 lines
While at it, do you want to fix up (+Seb):
a) Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt which also seems to refer to ti,pcf in example (introduced by df2634f43f51
x86: dtb: Add a device tree for CE4100 )
b) arch/x86/platform/ce4100/falconfalls.dts as well?
Applying this one with Roger's ack, seems like those should be additional patches.

Okay. I looked it up on the board and it says NXP PCF8575 and not TI. TI's was probably the first hit while I was looking for it (I think CE4100 manual mentioned just PCF8575).

But if it would have a TI branding on it I would keep the TI prefix in front and add the NXP prefix. As of today we might not know a functional difference between those two but this does not mean we might find one in the future.
That said, are you people sure that the DRA7 has a TI or a NXP branding on it?

Quoted 3 lines

Tony

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

Roger Quadros

2016-04-13 07:11 UTC #8 lore raw

Quoted 14 lines · Sebastian Andrzej Siewior

Quoted 8 lines · Tony Lindgren
Quoted 5 lines
While at it, do you want to fix up (+Seb):
a) Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt which also seems to refer to ti,pcf in example (introduced by df2634f43f51
x86: dtb: Add a device tree for CE4100 )
b) arch/x86/platform/ce4100/falconfalls.dts as well?
Applying this one with Roger's ack, seems like those should be additional patches.
Okay. I looked it up on the board and it says NXP PCF8575 and not TI. TI's was probably the first hit while I was looking for it (I think CE4100 manual mentioned just PCF8575).

Quoted 6 lines

But if it would have a TI branding on it I would keep the TI prefix in front and add the NXP prefix. As of today we might not know a functional difference between those two but this does not mean we might find one in the future.
That said, are you people sure that the DRA7 has a TI or a NXP branding on it?

Board has a Texas Instruments part: PCF8575PWR TSSOP24.
http://www.ti.com/product/PCF8575

--
cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

Sebastian Andrzej Siewior

2016-04-13 07:16 UTC #10 lore raw

Quoted 22 lines · Roger Quadros

Quoted 14 lines · Sebastian Andrzej Siewior
Quoted 8 lines · Tony Lindgren
Quoted 5 lines
While at it, do you want to fix up (+Seb):
a) Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt which also seems to refer to ti,pcf in example (introduced by df2634f43f51
x86: dtb: Add a device tree for CE4100 )
b) arch/x86/platform/ce4100/falconfalls.dts as well?
Applying this one with Roger's ack, seems like those should be additional patches.
Okay. I looked it up on the board and it says NXP PCF8575 and not TI. TI's was probably the first hit while I was looking for it (I think CE4100 manual mentioned just PCF8575).
Quoted 6 lines
But if it would have a TI branding on it I would keep the TI prefix in front and add the NXP prefix. As of today we might not know a functional difference between those two but this does not mean we might find one in the future.
That said, are you people sure that the DRA7 has a TI or a NXP branding on it?

Quoted 2 lines

Board has a Texas Instruments part: PCF8575PWR TSSOP24.
http://www.ti.com/product/PCF8575

So this sounds like

	compatible = "ti,pcf8575", "nxp,pcf8575";

then.

Quoted 4 lines

--
cheers,
-roger

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

Roger Quadros

2016-04-13 07:21 UTC #12 lore raw

Quoted 23 lines · Sebastian Andrzej Siewior

Quoted 22 lines · Roger Quadros
Quoted 20 lines · Sebastian Andrzej Siewior
Quoted 8 lines · Tony Lindgren
Quoted 5 lines
While at it, do you want to fix up (+Seb):
a) Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt which also seems to refer to ti,pcf in example (introduced by df2634f43f51
x86: dtb: Add a device tree for CE4100 )
b) arch/x86/platform/ce4100/falconfalls.dts as well?
Applying this one with Roger's ack, seems like those should be additional patches.
Okay. I looked it up on the board and it says NXP PCF8575 and not TI. TI's was probably the first hit while I was looking for it (I think CE4100 manual mentioned just PCF8575).
But if it would have a TI branding on it I would keep the TI prefix in front and add the NXP prefix. As of today we might not know a functional difference between those two but this does not mean we might find one in the future.
That said, are you people sure that the DRA7 has a TI or a NXP branding on it?

Quoted 8 lines

Quoted 2 lines
Board has a Texas Instruments part: PCF8575PWR TSSOP24.
http://www.ti.com/product/PCF8575
So this sounds like
	compatible = "ti,pcf8575", "nxp,pcf8575";
then.

Agree with you.

A message that is not in the archive (sent off-list or not yet received): [email protected]

Tony Lindgren

2016-04-13 15:17 UTC #14 lore raw

Quoted 27 lines · Roger Quadros

Quoted 26 lines · Sebastian Andrzej Siewior
Quoted 24 lines · Roger Quadros
Quoted 14 lines · Sebastian Andrzej Siewior
Quoted 8 lines · Tony Lindgren
Quoted 5 lines
While at it, do you want to fix up (+Seb):
a) Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt which also seems to refer to ti,pcf in example (introduced by df2634f43f51
x86: dtb: Add a device tree for CE4100 )
b) arch/x86/platform/ce4100/falconfalls.dts as well?
Applying this one with Roger's ack, seems like those should be additional patches.
Okay. I looked it up on the board and it says NXP PCF8575 and not TI. TI's was probably the first hit while I was looking for it (I think CE4100 manual mentioned just PCF8575).
Quoted 6 lines
But if it would have a TI branding on it I would keep the TI prefix in front and add the NXP prefix. As of today we might not know a functional difference between those two but this does not mean we might find one in the future.
That said, are you people sure that the DRA7 has a TI or a NXP branding on it?
Board has a Texas Instruments part: PCF8575PWR TSSOP24.
http://www.ti.com/product/PCF8575

Quoted 7 lines

Quoted 5 lines
So this sounds like
	compatible = "ti,pcf8575", "nxp,pcf8575";
then.
Agree with you.

Can you please do an additional patch against omap-for-v4.7/dt for this one please? And also update the related binding documentation.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Roger Quadros

Acked-by

2016-03-18 08:47 UTC #15 lore raw

In reply to a message not in the archive

Quoted 11 lines · Ben Hutchings

The binding definition for the PCF857x GPIO expanders doesn't mention a "ti,pcf8575" compatible string. This is apparently because TI is only a second source - there is no functional difference between PCF8575 chips manufactured by TI and NXP, and the same board might be populated with either depending on availability.
This is not a problem in practice because the I2C core uses of_modalias_node() before matching drivers and this strips the manufacturer name.
Signed-off-by Ben Hutchings <[email protected]>

Acked-by Roger Quadros <[email protected]>

cheers,
-roger

Quoted 28 lines

---
v2: Correct the claim that this is a practical problem.

 arch/arm/boot/dts/dra7-evm.dts  | 2 +-
 arch/arm/boot/dts/dra72-evm.dts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

arch/arm/boot/dts/dra7-evm.dts +1 -1

index cfc24e52244e..3907c9d2c12e 100644
@@ -539,7 +539,7 @@
 	};
 
 	pcf_gpio_21: gpio@21 {
-		compatible = "ti,pcf8575";
+		compatible = "nxp,pcf8575";
 		reg = <0x21>;
 		lines-initial-states = <0x1408>;
 		gpio-controller;

arch/arm/boot/dts/dra72-evm.dts +0 -0

index 00b12002c07c..7ec42bda3afb 100644

arch/arm/boot/dts/dra72-evm.dts line 428

Quoted 8 lines

arch/arm/boot/dts/dra72-evm.dts +1 -1

@@ -422,7 +422,7 @@
 	};
 
 	pcf_gpio_21: gpio@21 {
-		compatible = "ti,pcf8575";
+		compatible = "nxp,pcf8575";
 		reg = <0x21>;
 		lines-initial-states = <0x1408>;
 		gpio-controller;

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html