Why does the driver configure only 2 keys per peer?
For instance:
#define TARGET_10_4_NUM_PEER_KEYS 2
But, there are 4 key-ids, and so the driver can attempt to allocate 3 per peer.
Now, the self-peer probably only has one key ever (and that is blank key),
but that still averages to 5 per vdev (when vdev has 2 peers), and if AP peers can have more than 2 keys, then the average is even worse for them.
In 10.1, I ended up using '4' instead of 2.
I guess I'm about to repeat that change for 10.4 firmware.
But, I'm curious why someone thought 2 was OK to begin with?
Thanks,
Ben
Signature · 8 lines
Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
A message that is not in the archive (sent off-list or not yet received): CAJ-Vmo=C2Y+E4kELzHaAEYtxa3YZyy84cctvo+Rj_ndk1ixznQ@mail.gmail.com
No, the hardware can handle plenty of slots...looks to me like no one actually tested to the configured limits and/or they got lucky while testing. As long as it is possible for user-space to (temporarily?) configure 4 keys per peer, then the firmware can assert. I'll just increase the keys per peer. Uses a bit more firmware memory, but better than crashing.
Thanks,
Ben
Quoted 39 lines · Adrian Chadd
I'm guessing it's because there were customers who er, "needed" more STAs, and there's only a fixed number of hardware slots in the MAC.
-a
Quoted 30 lines · Ben Greear
For instance:
#define
TARGET_10_4_NUM_PEER_KEYS2But, there are 4 key-ids, and so the driver can attempt to allocate 3 per peer.
Now, the self-peer probably only has one key ever (and that is blank key), but that still averages to 5 per vdev (when vdev has 2 peers), and if AP peers can have more than 2
keys, then the average is even worse for them.In 10.1, I ended up using '4' instead of 2.
I guess I'm about to repeat that change for 10.4 firmware.
But, I'm curious why someone thought 2 was OK to begin with?
Thanks,
Ben--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Signature · 7 lines
Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k