Skip to contentSkip to conversation

musb: sunxi-glue: Fix sunxi-musb driver not auto-loading

PATCH New Hans de Goede 3 participants 4 messages Mar 21, 2016 – Mar 22, 2016

Subsystems (3)
USB Arm/Allwinner sunXi SoC support MUSB multipoint high speed dual-role controller
lore
Share & tools
lore

Hans de Goede

author
#0 lore raw

PATCH 1/1 musb: sunxi-glue: Fix sunxi-musb driver not auto-loading

Add a missing MODULE_DEVICE_TABLE() line which was causing the sunxi-musb glue to not auto-load when build as a module.

Signed-off-by Hans de Goede <[email protected]>
---
 drivers/usb/musb/sunxi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/musb/sunxi.c +1 -0
index 4b472b8..9af9431 100644
@@ -756,6 +756,7 @@ static const struct of_device_id sunxi_musb_match[] = {
 	{ .compatible = "allwinner,sun8i-a33-musb", },
 	{}
 };
+MODULE_DEVICE_TABLE(of, sunxi_musb_match);
 
 static struct platform_driver sunxi_musb_driver = {
 	.probe = sunxi_musb_probe,
Signature · 1 line
2.7.3
#2 lore raw

PATCH 1/1 musb: sunxi-glue: Fix sunxi-musb driver not auto-loading

In reply to Hans de Goede

Hi Hans,

Am 21.03.2016 um 23:13 schrieb Hans de Goede:

Quoted 2 lines

Add a missing MODULE_DEVICE_TABLE() line which was causing the sunxi-musb glue to not auto-load when build as a module.

"built"

Quoted 1 line

Should this get a Fixes: header for backporting to stable?

Quoted 10 lines
Signed-off-by Hans de Goede <[email protected]>
---
 drivers/usb/musb/sunxi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/musb/sunxi.c +0 -0
index 4b472b8..9af9431 100644

drivers/usb/musb/sunxi.c static const struct of_device_id sunxi_musb_match[] = { · line 762

Quoted 7 lines
drivers/usb/musb/sunxi.c +1 -0
@@ -756,6 +756,7 @@ static const struct of_device_id sunxi_musb_match[] = {
 	{ .compatible = "allwinner,sun8i-a33-musb", },
 	{}
 };
+MODULE_DEVICE_TABLE(of, sunxi_musb_match);
 
 static struct platform_driver sunxi_musb_driver = {
 	.probe = sunxi_musb_probe,

Has anyone looked into my earlier report about the module filename not having musb-? I did not see any response and haven't rechecked v4.5.0.

Regards,
Andreas

Signature · 2 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N?rnberg)
author
#3 lore raw

Hi,

Quoted 7 lines · Andreas F?rber

Hi Hans,

Am 21.03.2016 um 23:13 schrieb Hans de Goede:

Quoted 2 lines

Add a missing MODULE_DEVICE_TABLE() line which was causing the sunxi-musb glue to not auto-load when build as a module.

"built"

Thanks.

Quoted 1 line

Should this get a Fixes: header for backporting to stable?

Actually while looking for the commit id, it looks like someone else has already beat me to it, and this is already fixes in Linus' tree, so self NACK for this one.

Regards,

Hans

Quoted 25 lines
Quoted 11 lines
Signed-off-by Hans de Goede <[email protected]>
---
  drivers/usb/musb/sunxi.c | 1 +
  1 file changed, 1 insertion(+)
drivers/usb/musb/sunxi.c +0 -0
index 4b472b8..9af9431 100644

drivers/usb/musb/sunxi.c static const struct of_device_id sunxi_musb_match[] = { · line 762

Quoted 7 lines
drivers/usb/musb/sunxi.c +1 -0
@@ -756,6 +756,7 @@ static const struct of_device_id sunxi_musb_match[] = {
  	{ .compatible = "allwinner,sun8i-a33-musb", },
  	{}
  };
+MODULE_DEVICE_TABLE(of, sunxi_musb_match);
 
  static struct platform_driver sunxi_musb_driver = {
  	.probe = sunxi_musb_probe,

Has anyone looked into my earlier report about the module filename not having musb-? I did not see any response and haven't rechecked v4.5.0.

Regards,
Andreas