Skip to contentSkip to conversation

scsi_transport_fc: Unexport scsi_is_fc_vport()

PATCH Applied Bart Van Assche 3 participants 3 messages Mar 28, 2016 – Mar 30, 2016 SCSI

lore
Share & tools
lore

Bart Van Assche

author
#0 lore raw

PATCH 1/1 scsi_transport_fc: Unexport scsi_is_fc_vport()

Running the command "git grep -nHw scsi_is_fc_vport" shows that this function is only called from inside scsi_transport_fc.c. Hence unexport this function.

Signed-off-by Bart Van Assche <[email protected]>
Cc Hannes Reinecke <[email protected]>
Cc James Smart <[email protected]>
---
 drivers/scsi/scsi_transport_fc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/scsi_transport_fc.c +1 -2
index 8a88226..90afe5d 100644
@@ -2027,11 +2027,10 @@ static void fc_vport_dev_release(struct device *dev)
 	kfree(vport);
 }
 
-int scsi_is_fc_vport(const struct device *dev)
+static int scsi_is_fc_vport(const struct device *dev)
 {
 	return dev->release == fc_vport_dev_release;
 }
-EXPORT_SYMBOL(scsi_is_fc_vport);
 
 static int fc_vport_match(struct attribute_container *cont,
 			    struct device *dev)
Signature · 1 line
2.7.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 19 lines · Bart Van Assche

Running the command "git grep -nHw scsi_is_fc_vport" shows that this function is only called from inside scsi_transport_fc.c. Hence unexport this function.

Signed-off-by Bart Van Assche <[email protected]>
Cc Hannes Reinecke <[email protected]>
Cc James Smart <[email protected]>
---
 drivers/scsi/scsi_transport_fc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/scsi_transport_fc.c +0 -0
index 8a88226..90afe5d 100644
@@ -2027,11 +2027,10 @@ static void fc_vport_dev_release(struct device *dev)
 	kfree(vport);
 }

drivers/scsi/scsi_transport_fc.c static void fc_vport_dev_release(struct device *dev) · line 2036

Quoted 10 lines
drivers/scsi/scsi_transport_fc.c +1 -2
 
-int scsi_is_fc_vport(const struct device *dev)
+static int scsi_is_fc_vport(const struct device *dev)
 {
 	return dev->release == fc_vport_dev_release;
 }
-EXPORT_SYMBOL(scsi_is_fc_vport);
 
 static int fc_vport_match(struct attribute_container *cont,
 			    struct device *dev)
Reviewed-by Hannes Reinecke <[email protected]>

Cheers,

Hannes

Signature · 9 lines
Dr. Hannes Reinecke		   Teamlead Storage & Networking
[email protected]			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Applied
#2 lore raw
In reply to Bart Van Assche
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Bart" == Bart Van Assche <[email protected]> writes:

Bart> Running the command "git grep -nHw scsi_is_fc_vport" shows that Bart> this function is only called from inside
Bart> scsi_transport_fc.c. Hence unexport this function.

Applied to 4.7/scsi-queue. Thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering