Skip to contentSkip to conversation

ARM: bcm2835: add CPU node for ARM core

PATCH New Stefan Wahren 4 participants 6 messages Mar 28, 2016 – Mar 30, 2016

Subsystems (3)
Device tree bindings Broadcom BCM2711/BCM2835 Arm architecture Broadcom BCM281XX/BCM11XXX/BCM216XX Arm architecture
lore
Share & tools
lore

Stefan Wahren

author
#0 lore raw

PATCH 1/1 ARM: bcm2835: add CPU node for ARM core

This patch adds the CPU node of the BCM2835 into the DT.

Signed-off-by Stefan Wahren <[email protected]>
---
 arch/arm/boot/dts/bcm2835.dtsi |   11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/bcm2835.dtsi +11 -0
index b83b326..e87aba1 100644
@@ -3,6 +3,17 @@
 / {
 	compatible = "brcm,bcm2835";
 
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cpu at 0 {
+			device_type = "cpu";
+			compatible = "arm,arm1176jzf-s", "arm,arm1176";
+			reg = <0x0>;
+		};
+	};
+
 	soc {
 		ranges = <0x7e000000 0x20000000 0x02000000>;
 		dma-ranges = <0x40000000 0x00000000 0x20000000>;
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: bcm2835: add CPU node for ARM core

Quoted 3 lines · Stefan Wahren

This patch adds the CPU node of the BCM2835 into the DT.

Signed-off-by Stefan Wahren <[email protected]>

This looks good to me, but I'll give others a chance to speak up.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160328/608af1f0/attachment.sig>

#2 lore raw

PATCH 1/1 ARM: bcm2835: add CPU node for ARM core

In reply to Stefan Wahren
Quoted 15 lines · Stefan Wahren

This patch adds the CPU node of the BCM2835 into the DT.

Signed-off-by Stefan Wahren <[email protected]>
---
 arch/arm/boot/dts/bcm2835.dtsi |   11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/bcm2835.dtsi +0 -0
index b83b326..e87aba1 100644
@@ -3,6 +3,17 @@
 / {
 	compatible = "brcm,bcm2835";

arch/arm/boot/dts/bcm2835.dtsi line 15

Quoted 10 lines
arch/arm/boot/dts/bcm2835.dtsi +10 -0
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cpu at 0 {
+			device_type = "cpu";
+			compatible = "arm,arm1176jzf-s", "arm,arm1176";
+			reg = <0x0>;
+		};
+	};

Minor nit: the "arm,arm1176" fallback isn't documented, nor used elsewhere, so it can/should be dropped.

Otherwise, this looks fine per [1]. With the above change, feel free to add my ack.

Mark.

[1] Documentation/devicetree/bindings/arm/cpus.txt

Quoted 7 lines
arch/arm/boot/dts/bcm2835.dtsi +1 -0
+
 	soc {
 		ranges = <0x7e000000 0x20000000 0x02000000>;
 		dma-ranges = <0x40000000 0x00000000 0x20000000>;
Signature · 1 line
1.7.9.5
author
#3 lore raw

PATCH 1/1 ARM: bcm2835: add CPU node for ARM core

Am 29.03.2016 um 11:41 schrieb Mark Rutland:

Quoted 16 lines · Stefan Wahren
Quoted 15 lines

This patch adds the CPU node of the BCM2835 into the DT.

Signed-off-by Stefan Wahren <[email protected]>
---
 arch/arm/boot/dts/bcm2835.dtsi |   11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/bcm2835.dtsi +0 -0
index b83b326..e87aba1 100644
@@ -3,6 +3,17 @@
 / {
 	compatible = "brcm,bcm2835";
Quoted 12 lines

arch/arm/boot/dts/bcm2835.dtsi line 15

Quoted 10 lines
arch/arm/boot/dts/bcm2835.dtsi +10 -0
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cpu at 0 {
+			device_type = "cpu";
+			compatible = "arm,arm1176jzf-s", "arm,arm1176";
+			reg = <0x0>;
+		};
+	};

Minor nit: the "arm,arm1176" fallback isn't documented, nor used elsewhere, so it can/should be dropped.

This fallback came from arch/arm/boot/dts/s3c64xx.dtsi

I will send a V2 without the fallback.

Stefan

Quoted 15 lines

Otherwise, this looks fine per [1]. With the above change, feel free to add my ack.

Mark.

[1] Documentation/devicetree/bindings/arm/cpus.txt

Quoted 7 lines
arch/arm/boot/dts/bcm2835.dtsi +1 -0
+
 	soc {
 		ranges = <0x7e000000 0x20000000 0x02000000>;
 		dma-ranges = <0x40000000 0x00000000 0x20000000>;
Signature · 1 line
1.7.9.5
#4 lore raw

PATCH 1/1 ARM: bcm2835: add CPU node for ARM core

Quoted 30 lines · Stefan Wahren

Am 29.03.2016 um 11:41 schrieb Mark Rutland:

Quoted 16 lines · Stefan Wahren
Quoted 15 lines

This patch adds the CPU node of the BCM2835 into the DT.

Signed-off-by Stefan Wahren <[email protected]>
---
 arch/arm/boot/dts/bcm2835.dtsi |   11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/bcm2835.dtsi +0 -0
index b83b326..e87aba1 100644
@@ -3,6 +3,17 @@
 / {
 	compatible = "brcm,bcm2835";
Quoted 12 lines

arch/arm/boot/dts/bcm2835.dtsi line 15

Quoted 10 lines
arch/arm/boot/dts/bcm2835.dtsi +10 -0
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cpu at 0 {
+			device_type = "cpu";
+			compatible = "arm,arm1176jzf-s", "arm,arm1176";
+			reg = <0x0>;
+		};
+	};

Minor nit: the "arm,arm1176" fallback isn't documented, nor used elsewhere, so it can/should be dropped.

Quoted 1 line

This fallback came from arch/arm/boot/dts/s3c64xx.dtsi

Ah, indeed. I failed to spot that when grepping. For consistency, we should probably clean that up.

Quoted 1 line

I will send a V2 without the fallback.

Cheers!

Mark.