Skip to contentSkip to conversation

configs: ti_armv7_keystone2: make SYS_TEXT_BASE configurable at build time

PATCH In review Vitaly Andrianov 2 participants 4 messages Mar 28, 2016 – Apr 2, 2016

lore
Share & tools
lore

Vitaly Andrianov

author
#0 lore raw

PATCH 1/1 configs: ti_armv7_keystone2: make SYS_TEXT_BASE configurable at build time

U-boot for general purpose KS2 devices is loaded to the beginning of the internal memory (0x0c000000). Secure devices uses this memory and CONFIG_SYS_TEXT_BASE has to be different for those devices.

This commit make this configurable at build time by giving CONFIG_SYS_TEXT_BASE as a command line definition to make command.

Signed-off-by Vitaly Andrianov <[email protected]>
---
 include/configs/ti_armv7_keystone2.h | 2 ++
 1 file changed, 2 insertions(+)
include/configs/ti_armv7_keystone2.h +2 -0
index a7206f4..76b901bf 100644
@@ -20,7 +20,9 @@
 /* SoC Configuration */
 #define CONFIG_ARCH_CPU_INIT
 #define CONFIG_SYS_ARCH_TIMER
+#ifndef CONFIG_SYS_TEXT_BASE
 #define CONFIG_SYS_TEXT_BASE		0x0c000000
+#endif
 #define CONFIG_SPL_TARGET		"u-boot-spi.gph"
 #define CONFIG_SYS_DCACHE_OFF
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 configs: ti_armv7_keystone2: make SYS_TEXT_BASE configurable at build time

Quoted 6 lines · Vitaly Andrianov

U-boot for general purpose KS2 devices is loaded to the beginning of the internal memory (0x0c000000). Secure devices uses this memory and CONFIG_SYS_TEXT_BASE has to be different for those devices.

This commit make this configurable at build time by giving CONFIG_SYS_TEXT_BASE as a command line definition to make command.

I'm interested in getting secure device support going, but it seems like we should need more than that, ie something to keep the chain of trust going. I also don't like that we're just overriding this in the command line, especially as I expect we'll need other changes too once this gets moving forward. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160328/3ce4d0fe/attachment.sig>
author
#2 lore raw

PATCH 1/1 configs: ti_armv7_keystone2: make SYS_TEXT_BASE configurable at build time

Quoted 6 lines · Tom Rini
Quoted 4 lines · Vitaly Andrianov

U-boot for general purpose KS2 devices is loaded to the beginning of the internal memory (0x0c000000). Secure devices uses this memory and CONFIG_SYS_TEXT_BASE has to be different for those devices.

Quoted 9 lines
Quoted 2 lines

This commit make this configurable at build time by giving CONFIG_SYS_TEXT_BASE as a command line definition to make command.

I'm interested in getting secure device support going, but it seems like we should need more than that, ie something to keep the chain of trust going. I also don't like that we're just overriding this in the command line, especially as I expect we'll need other changes too once this gets moving forward. Thanks!

Tom,

I reworked boot-monitor for KS2 secure devices and CONFIG_SYS_TEXT_BASE is only change required to support KS2 secure devices.

Thanks,
Vitaly

#3 lore raw
In reply to Vitaly Andrianov
Quoted 8 lines · Vitaly Andrianov

U-boot for general purpose KS2 devices is loaded to the beginning of the internal memory (0x0c000000). Secure devices uses this memory and CONFIG_SYS_TEXT_BASE has to be different for those devices.

This commit make this configurable at build time by giving CONFIG_SYS_TEXT_BASE as a command line definition to make command.

Signed-off-by Vitaly Andrianov <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160401/99c6e795/attachment.sig>