Skip to contentSkip to conversation

ASoC: intel: make Kconfig selects depend on ACPI

PATCH In review Randy Dunlap 2 participants 3 messages Mar 29, 2016

Subsystems (3)
Sound ASoC Intel ASoC drivers
lore
Share & tools
lore

Randy Dunlap

author
#0 lore raw

PATCH 1/1 ASoC: intel: make Kconfig selects depend on ACPI

From: Randy Dunlap <[email protected]>

Prevent SND_SST_IPC_ACPI from being selected when CONFIG_ACPI is not enabled. This fixes the kconfig warning:

warning: (SND_SOC_INTEL_BYTCR_RT5640_MACH && SND_SOC_INTEL_BYTCR_RT5651_MACH && SND_SOC_INTEL_CHT_BSW_RT5672_MACH && SND_SOC_INTEL_CHT_BSW_RT5645_MACH && SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH) selects SND_SST_IPC_ACPI which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && ACPI)

Signed-off-by Randy Dunlap <[email protected]>
Cc Jie Yang <[email protected]>
Cc [email protected]
---
 sound/soc/intel/Kconfig |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
sound/soc/intel/Kconfig +5 -5
@@ -100,7 +100,7 @@ config SND_SOC_INTEL_BYTCR_RT5640_MACH
 	depends on X86 && I2C
 	select SND_SOC_RT5640
 	select SND_SST_MFLD_PLATFORM
-	select SND_SST_IPC_ACPI
+	select SND_SST_IPC_ACPI if ACPI
 	select SND_SOC_INTEL_SST_MATCH if ACPI
 	help
           This adds support for ASoC machine driver for Intel(R) Baytrail and Baytrail-CR

@@ -113,7 +113,7 @@ config SND_SOC_INTEL_BYTCR_RT5651_MACH
 	depends on X86 && I2C
 	select SND_SOC_RT5651
 	select SND_SST_MFLD_PLATFORM
-	select SND_SST_IPC_ACPI
+	select SND_SST_IPC_ACPI if ACPI
 	select SND_SOC_INTEL_SST_MATCH if ACPI
 	help
           This adds support for ASoC machine driver for Intel(R) Baytrail and Baytrail-CR

@@ -126,7 +126,7 @@ config SND_SOC_INTEL_CHT_BSW_RT5672_MACH
         depends on X86_INTEL_LPSS && I2C
         select SND_SOC_RT5670
         select SND_SST_MFLD_PLATFORM
-        select SND_SST_IPC_ACPI
+        select SND_SST_IPC_ACPI if ACPI
 	select SND_SOC_INTEL_SST_MATCH if ACPI
         help
           This adds support for ASoC machine driver for Intel(R) Cherrytrail & Braswell

@@ -139,7 +139,7 @@ config SND_SOC_INTEL_CHT_BSW_RT5645_MACH
 	depends on X86_INTEL_LPSS && I2C
 	select SND_SOC_RT5645
 	select SND_SST_MFLD_PLATFORM
-	select SND_SST_IPC_ACPI
+	select SND_SST_IPC_ACPI if ACPI
 	select SND_SOC_INTEL_SST_MATCH if ACPI
 	help
 	  This adds support for ASoC machine driver for Intel(R) Cherrytrail & Braswell

@@ -152,7 +152,7 @@ config SND_SOC_INTEL_CHT_BSW_MAX98090_TI
 	select SND_SOC_MAX98090
 	select SND_SOC_TS3A227E
 	select SND_SST_MFLD_PLATFORM
-	select SND_SST_IPC_ACPI
+	select SND_SST_IPC_ACPI if ACPI
 	select SND_SOC_INTEL_SST_MATCH if ACPI
 	help
       This adds support for ASoC machine driver for Intel(R) Cherrytrail & Braswell
maintainer
#1 lore raw
Quoted 4 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Prevent SND_SST_IPC_ACPI from being selected when CONFIG_ACPI is not enabled. This fixes the kconfig warning:

These are drivers which can't be instantiated without ACPI...

author
#2 lore raw
Quoted 8 lines · Mark Brown
Quoted 4 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Prevent SND_SST_IPC_ACPI from being selected when CONFIG_ACPI is not enabled. This fixes the kconfig warning:

These are drivers which can't be instantiated without ACPI...

so it sounds like they should depend on ACPI...?

Signature · 1 line
~Randy