Skip to contentSkip to conversation

pinctrl: bcm2835: Implement get_direction callback

PATCH New Stefan Wahren 4 participants 4 messages Mar 28, 2016 – Apr 1, 2016

Subsystems (4)
GPIO Pin control Broadcom BCM2711/BCM2835 Arm architecture Broadcom BCM281XX/BCM11XXX/BCM216XX Arm architecture
lore
Share & tools
lore

Stefan Wahren

author
#0 lore raw

PATCH 1/1 pinctrl: bcm2835: Implement get_direction callback

Implement gpio_chip's get_direction() callback, that lets other drivers get particular GPIOs direction using gpiod_get_direction().

Signed-off-by Stefan Wahren <[email protected]>
---
 drivers/pinctrl/bcm/pinctrl-bcm2835.c |   13 +++++++++++++
 1 file changed, 13 insertions(+)
drivers/pinctrl/bcm/pinctrl-bcm2835.c +13 -0
index 08b1d93..dd8b174 100644
@@ -342,6 +342,18 @@ static int bcm2835_gpio_get(struct gpio_chip *chip, unsigned offset)
 	return bcm2835_gpio_get_bit(pc, GPLEV0, offset);
 }
 
+static int bcm2835_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
+{
+	struct bcm2835_pinctrl *pc = gpiochip_get_data(chip);
+	enum bcm2835_fsel fsel = bcm2835_pinctrl_fsel_get(pc, offset);
+
+	/* Alternative function doesn't clearly provide a direction */
+	if (fsel > BCM2835_FSEL_GPIO_OUT)
+		return -EINVAL;
+
+	return (fsel == BCM2835_FSEL_GPIO_IN);
+}
+
 static void bcm2835_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
 {
 	struct bcm2835_pinctrl *pc = gpiochip_get_data(chip);

@@ -370,6 +382,7 @@ static struct gpio_chip bcm2835_gpio_chip = {
 	.free = gpiochip_generic_free,
 	.direction_input = bcm2835_gpio_direction_input,
 	.direction_output = bcm2835_gpio_direction_output,
+	.get_direction = bcm2835_gpio_get_direction,
 	.get = bcm2835_gpio_get,
 	.set = bcm2835_gpio_set,
 	.to_irq = bcm2835_gpio_to_irq,
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 pinctrl: bcm2835: Implement get_direction callback

Quoted 2 lines · Stefan Wahren

Implement gpio_chip's get_direction() callback, that lets other drivers get particular GPIOs direction using gpiod_get_direction().

Reviewed-by Eric Anholt <[email protected]>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160328/e2b2a259/attachment.sig>