Skip to contentSkip to conversation

e1000: Support e1000 OEMed onto Aculab cards

PATCH In review Mark Brown 2 participants 2 messages Feb 27, 2006 – Feb 28, 2006

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 e1000: Support e1000 OEMed onto Aculab cards

Add PCI IDs for chips OEMed onto some Aculab cards to the e1000 driver.

drivers/net/e1000/e1000.h +3 -0
Index: e1000-queue/drivers/net/e1000/e1000.h
===================================================================
@@ -84,6 +84,9 @@
 #define INTEL_E1000_ETHERNET_DEVICE(device_id) {\
 	PCI_DEVICE(PCI_VENDOR_ID_INTEL, device_id)}
 
+#define ACULAB_E1000_ETHERNET_DEVICE(device_id) {\
+	PCI_DEVICE(PCI_VENDOR_ID_ACULAB, device_id)}
+
 struct e1000_adapter;
 
 #include "e1000_hw.h"
drivers/net/e1000/e1000_main.c +1 -0
Index: e1000-queue/drivers/net/e1000/e1000_main.c
===================================================================
@@ -98,6 +98,7 @@ static struct pci_device_id e1000_pci_tb
 	INTEL_E1000_ETHERNET_DEVICE(0x108B),
 	INTEL_E1000_ETHERNET_DEVICE(0x108C),
 	INTEL_E1000_ETHERNET_DEVICE(0x109A),
+	ACULAB_E1000_ETHERNET_DEVICE(0x1078),
 	/* required last entry */
 	{0,}
 };
include/linux/pci_ids.h +2 -0
Index: e1000-queue/include/linux/pci_ids.h
===================================================================
@@ -1572,6 +1572,8 @@
 #define PCI_VENDOR_ID_NVIDIA_SGS	0x12d2
 #define PCI_DEVICE_ID_NVIDIA_SGS_RIVA128 0x0018
 
+#define PCI_VENDOR_ID_ACULAB 0x12d9
+
 #define PCI_SUBVENDOR_ID_CHASE_PCIFAST		0x12E0
 #define PCI_SUBDEVICE_ID_CHASE_PCIFAST4		0x0031
 #define PCI_SUBDEVICE_ID_CHASE_PCIFAST8		0x0021
Signature · 1 line
"You grabbed my hand and we fell into it, like a daydream - or a fever."
#1 lore raw

Please don't apply this patch. We have taken this offline at the moment to work this out with the OEM, Aculab. They have made modification to how the Intel controller operates which may make it have problems with the normal e1000 driver. We are in contact with both Mark and Aculab about this offline. The last thing Aculab talked to us about was to make sure that the normal Intel e1000 drivers did _not_ work with their hardware, hence the device ID change. We'll continue this on this thread if this turns out not to be the case. We (Intel) also don't know exactly how they changed the behavior of the hardware which is another topic for us to talk about.

Thanks.
--
Cheers,
John