Skip to contentSkip to conversation

needs_root: Add setting of needs_root

PATCH zhaogongyi via ltp 2 participants 2 messages Oct 13, 2022

lore
Share & tools
lore
#0 lore raw

Hi Petr,

Quoted 13 lines
Quoted 8 lines

Hi Petr,

It is failed on my system:

sh-4.4$ ./msgget03
tst_test.c:1535: TINFO: Timeout per run is 0h 00m 30s msgget03.c:42: TINFO: Current environment 0 message queues are

already

Quoted 3 lines

in use
msgget03.c:45: TBROK: Failed to open FILE '/proc/sys/kernel/msgmni' for writing: EACCES (13)

Quoted 5 lines

Ah, b740bfac5 ("msgget03: Set custom queue limit") causes the need for root. IMHO this one is valid.

I'd suggest to remove needs_root for needs_device and mount_device now (i.e. send v2).

Just remove the patch 1 and keep adding needs_root in patch 2?

Quoted 5 lines

nit: FYI most of the people use bottom posting on mailing lists, you use top posting. Combine both makes it hard to follow.

https://en.wikipedia.org/wiki/Posting_style

Thanks for your reminder, I will reply to emails according to the posting_style.

Quoted 13 lines

Kind regards,
Petr

Quoted 7 lines

Summary:

passed   0
failed   0
broken   1
skipped  0

warnings 0
tst_sys_conf.c:118: TWARN: Failed to open FILE

'/proc/sys/kernel/msgmni'

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw
Quoted 15 lines

Hi Petr,

Quoted 11 lines
Quoted 7 lines

Hi Petr,

It is failed on my system:

sh-4.4$ ./msgget03
tst_test.c:1535: TINFO: Timeout per run is 0h 00m 30s msgget03.c:42: TINFO: Current environment 0 message queues are

already

Quoted 3 lines

in use
msgget03.c:45: TBROK: Failed to open FILE '/proc/sys/kernel/msgmni' for writing: EACCES (13)

Quoted 7 lines
Quoted 5 lines

Ah, b740bfac5 ("msgget03: Set custom queue limit") causes the need for root. IMHO this one is valid.

I'd suggest to remove needs_root for needs_device and mount_device now (i.e. send v2).

Just remove the patch 1 and keep adding needs_root in patch 2?

If you haven't added it to any test which would have needs_device or mount_device, then v2 can be kept.

But process_vm_readv02 works for me (on master, on Debian) without root:

$ ./process_vm_readv02
tst_test.c:1526: TINFO: Timeout per run is 0h 00m 30s
process_vm_readv02.c:32: TINFO: child 0: memory allocated and initialized
process_vm_readv02.c:49: TINFO: child 1: reading string from same memory location
process_vm_readv02.c:61: TPASS: expected string received

Summary:

passed   1
failed   0
broken   0
skipped  0

warnings 0

Also process_vm_readv03, process_vm_writev02 (I stopped checking now).

Why you need it?

Kind regards,
Petr

Quoted 6 lines
Quoted 4 lines

nit: FYI most of the people use bottom posting on mailing lists, you use top posting. Combine both makes it hard to follow.

https://en.wikipedia.org/wiki/Posting_style

Thanks for your reminder, I will reply to emails according to the posting_style.

Thank you!

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp