Skip to contentSkip to conversation

drm/i915: Allow dead vm to unbind vma's without lock.

PATCH In review Maarten Lankhorst 3 participants 5 messages Jan 28, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Allow dead vm to unbind vma's without lock.

i915_gem_vm_close may take the lock, and we currently have no better way of handling this. At least for now, allow a path in which holding vm->mutex is sufficient. This is the case, because the object destroy path will forcefully take vm->mutex now.

---
 drivers/gpu/drm/i915/i915_vma.c | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_vma.c +13 -2
index b959e904c4d3..14a301c4069f 100644
@@ -40,6 +40,17 @@
 #include "i915_vma.h"
 #include "i915_vma_resource.h"
 
+static inline void assert_vma_held_evict(const struct i915_vma *vma)
+{
+	/*
+	 * We may be forced to unbind when the vm is dead, to clean it up.
+	 * This is the only exception to the requirement of the object lock
+	 * being held.
+	 */
+	if (atomic_read(&vma->vm->open))
+		assert_object_held_shared(vma->obj);
+}
+
 static struct kmem_cache *slab_vmas;
 
 static struct i915_vma *i915_vma_alloc(void)
@@ -1779,7 +1790,7 @@ struct dma_fence *__i915_vma_evict(struct i915_vma *vma, bool async)
 	struct dma_fence *unbind_fence;
 
 	GEM_BUG_ON(i915_vma_is_pinned(vma));
-	assert_object_held_shared(vma->obj);
+	assert_vma_held_evict(vma);
 
 	if (i915_vma_is_map_and_fenceable(vma)) {
 		/* Force a pagefault for domain tracking on next user access */
@@ -1846,7 +1857,7 @@ int __i915_vma_unbind(struct i915_vma *vma)
 	int ret;
 
 	lockdep_assert_held(&vma->vm->mutex);
-	assert_object_held_shared(vma->obj);
+	assert_vma_held_evict(vma);
 
 	if (!drm_mm_node_allocated(&vma->node))
 		return 0;
Signature · 1 line
2.34.1
#1 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Allow dead vm to unbind vma's without lock.

== Series Details ==

== Series Details ==

Series: drm/i915: Allow dead vm to unbind vma's without lock.
URL : https://patchwork.freedesktop.org/series/99471/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11157 -> Patchwork_22135
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/index.html

Participating hosts (43 -> 41)
------------------------------

Additional (1): fi-icl-u2
Missing (3): fi-bsw-cyan fi-bdw-samus fi-kbl-8809g

Known issues
------------

Here are the changes found in Patchwork_22135 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_cs_nop@fork-gfx0:
- fi-icl-u2: NOTRUN -> [SKIP][1] ([fdo#109315]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/fi-icl-u2/igt@amdgpu/[email protected]

* igt@amdgpu/amd_prime@amd-to-i915:
- fi-pnv-d510: NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/fi-pnv-d510/igt@amdgpu/[email protected]

* igt@gem_flink_basic@bad-flink:
- fi-skl-6600u: [PASS][3] -> [FAIL][4] ([i915#4547])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/fi-skl-6600u/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/fi-skl-6600u/igt@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-icl-u2: NOTRUN -> [SKIP][5] ([i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/fi-icl-u2/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/fi-icl-u2/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- fi-ivb-3770: [PASS][7] -> [INCOMPLETE][8] ([i915#3303])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/fi-ivb-3770/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/fi-ivb-3770/igt@i915_selftest@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][9] ([fdo#111827]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/fi-icl-u2/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: NOTRUN -> [SKIP][10] ([fdo#109278]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/fi-icl-u2/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][11] ([fdo#109285])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/fi-icl-u2/igt@[email protected]

* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][12] ([i915#3301])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/fi-icl-u2/igt@[email protected]

* igt@runner@aborted:
- fi-skl-6600u: NOTRUN -> [FAIL][13] ([i915#4312])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/fi-skl-6600u/igt@[email protected]
- fi-ivb-3770: NOTRUN -> [FAIL][14] ([fdo#109271] / [i915#4312])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/fi-ivb-3770/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][15] ([i915#2927]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/fi-pnv-d510/igt@i915_selftest@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/fi-pnv-d510/igt@i915_selftest@[email protected]

* igt@kms_busy@basic@flip:
- {bat-adlp-6}: [DMESG-WARN][17] ([i915#4955]) -> [PASS][18] +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/bat-adlp-6/igt@kms_busy@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/bat-adlp-6/igt@kms_busy@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: [DMESG-WARN][19] ([i915#295]) -> [PASS][20] +12 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/fi-cfl-8109u/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/fi-cfl-8109u/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4955]: https://gitlab.freedesktop.org/drm/intel/issues/4955

Build changes
-------------

* Linux: CI_DRM_11157 -> Patchwork_22135

CI-20190529: 20190529
CI_DRM_11157: df832f248a682d4eb6a0b649da9e30b340bd718e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6336: ae2eb9e18bc58a4c45f28cfd80962938198dec3c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22135: c7d9c8b94db9f6ffbb963a7472dadb959c6e4921 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

c7d9c8b94db9 drm/i915: Allow dead vm to unbind vma's without lock.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/index.html

Reviewed-by Thomas Hellstrom on v1 1/1
#2 lore raw
In reply to Maarten Lankhorst
Quoted 6 lines · Maarten Lankhorst

i915_gem_vm_close may take the lock, and we currently have no better way of handling this. At least for now, allow a path in which holding vm->mutex is sufficient. This is the case, because the object destroy path will forcefully take vm->mutex now.

Quoted 44 lines
---
  drivers/gpu/drm/i915/i915_vma.c | 15 +++++++++++++--
  1 file changed, 13 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_vma.c +13 -2
index b959e904c4d3..14a301c4069f 100644
@@ -40,6 +40,17 @@
  #include "i915_vma.h"
  #include "i915_vma_resource.h"
 
+static inline void assert_vma_held_evict(const struct i915_vma *vma)
+{
+	/*
+	 * We may be forced to unbind when the vm is dead, to clean it up.
+	 * This is the only exception to the requirement of the object lock
+	 * being held.
+	 */
+	if (atomic_read(&vma->vm->open))
+		assert_object_held_shared(vma->obj);
+}
+
  static struct kmem_cache *slab_vmas;
 
  static struct i915_vma *i915_vma_alloc(void)
@@ -1779,7 +1790,7 @@ struct dma_fence *__i915_vma_evict(struct i915_vma *vma, bool async)
  	struct dma_fence *unbind_fence;
 
  	GEM_BUG_ON(i915_vma_is_pinned(vma));
-	assert_object_held_shared(vma->obj);
+	assert_vma_held_evict(vma);
 
  	if (i915_vma_is_map_and_fenceable(vma)) {
  		/* Force a pagefault for domain tracking on next user access */
@@ -1846,7 +1857,7 @@ int __i915_vma_unbind(struct i915_vma *vma)
  	int ret;
 
  	lockdep_assert_held(&vma->vm->mutex);
-	assert_object_held_shared(vma->obj);
+	assert_vma_held_evict(vma);
 
  	if (!drm_mm_node_allocated(&vma->node))
  		return 0;
#3 lore raw

Op 28-01-2022 om 12:02 schreef Thomas Hellström (Intel):

Quoted 42 lines · Maarten Lankhorst
Quoted 6 lines

i915_gem_vm_close may take the lock, and we currently have no better way of handling this. At least for now, allow a path in which holding vm->mutex is sufficient. This is the case, because the object destroy path will forcefully take vm->mutex now.

Quoted 30 lines

---
  drivers/gpu/drm/i915/i915_vma.c | 15 +++++++++++++--

  1 file changed, 13 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_vma.c +11 -1
index b959e904c4d3..14a301c4069f 100644
@@ -40,6 +40,17 @@
   #include "i915_vma.h"
   #include "i915_vma_resource.h"
   +static inline void assert_vma_held_evict(const struct i915_vma *vma)
+{
+    /*
+     * We may be forced to unbind when the vm is dead, to clean it up.
+     * This is the only exception to the requirement of the object lock
+     * being held.
+     */
+    if (atomic_read(&vma->vm->open))
+        assert_object_held_shared(vma->obj);
+}
+
   static struct kmem_cache *slab_vmas;
     static struct i915_vma *i915_vma_alloc(void)
@@ -1779,7 +1790,7 @@ struct dma_fence *__i915_vma_evict(struct i915_vma *vma, bool async)
       struct dma_fence *unbind_fence;
         GEM_BUG_ON(i915_vma_is_pinned(vma));
-    assert_object_held_shared(vma->obj);
+    assert_vma_held_evict(vma);
         if (i915_vma_is_map_and_fenceable(vma)) {
Quoted 8 lines

drivers/gpu/drm/i915/i915_vma.c int __i915_vma_unbind(struct i915_vma *vma) · line 1861

Quoted 8 lines
drivers/gpu/drm/i915/i915_vma.c +1 -1
           /* Force a pagefault for domain tracking on next user access */
@@ -1846,7 +1857,7 @@ int __i915_vma_unbind(struct i915_vma *vma)
       int ret;
         lockdep_assert_held(&vma->vm->mutex);
-    assert_object_held_shared(vma->obj);
+    assert_vma_held_evict(vma);
         if (!drm_mm_node_allocated(&vma->node))
           return 0;

Thanks, pushed. Should fix alderlake DPT.

#4 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Allow dead vm to unbind vma's without lock.

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: drm/i915: Allow dead vm to unbind vma's without lock.
URL : https://patchwork.freedesktop.org/series/99471/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11157_full -> Patchwork_22135_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (10 -> 10)
------------------------------

No changes in participating hosts

Known issues
------------

Here are the changes found in Patchwork_22135_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][1] -> [FAIL][2] ([i915#232]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-tglb6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-tglb3/igt@[email protected]

* igt@gem_exec_capture@pi@rcs0:
- shard-skl: [PASS][3] -> [INCOMPLETE][4] ([i915#4547])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-skl1/igt@gem_exec_capture@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-skl1/igt@gem_exec_capture@[email protected]

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][5] -> [FAIL][6] ([i915#2842]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-tglb8/igt@gem_exec_fair@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-tglb5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-iclb8/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-iclb8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][9] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-iclb4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-kbl: [PASS][10] -> [FAIL][11] ([i915#2842]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-kbl6/igt@gem_exec_fair@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-kbl7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_whisper@basic-fds-forked:
- shard-glk: [PASS][12] -> [DMESG-WARN][13] ([i915#118]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-glk7/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-glk3/igt@[email protected]

* igt@gem_spin_batch@legacy-resubmit@vebox:
- shard-skl: [PASS][14] -> [DMESG-WARN][15] ([i915#1982])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-skl9/igt@gem_spin_batch@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-skl10/igt@gem_spin_batch@[email protected]

* igt@gem_userptr_blits@vma-merge:
- shard-apl: NOTRUN -> [FAIL][16] ([i915#3318])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-apl1/igt@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-glk: [PASS][17] -> [DMESG-WARN][18] ([i915#1436] / [i915#716])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-glk8/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-glk1/igt@[email protected]

* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [PASS][19] -> [FAIL][20] ([i915#2521])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-skl6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-skl9/igt@[email protected]

* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#3886])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-apl1/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#3886]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-kbl7/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][23] ([fdo#109271]) +13 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-skl8/igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_chamelium@dp-crc-single:
- shard-iclb: NOTRUN -> [SKIP][24] ([fdo#109284] / [fdo#111827])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-iclb2/igt@[email protected]

* igt@kms_chamelium@dp-edid-read:
- shard-skl: NOTRUN -> [SKIP][25] ([fdo#109271] / [fdo#111827])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-skl8/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-for-each-pipe:
- shard-kbl: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-kbl7/igt@[email protected]

* igt@kms_color_chamelium@pipe-b-ctm-0-5:
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-apl1/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-32x32-random:
- shard-iclb: NOTRUN -> [SKIP][28] ([fdo#109278])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-iclb2/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [PASS][29] -> [DMESG-WARN][30] ([i915#180]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-apl1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-apl7/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
- shard-skl: [PASS][31] -> [FAIL][32] ([i915#2346]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-skl1/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-skl1/igt@[email protected]

* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: NOTRUN -> [DMESG-WARN][33] ([i915#180]) +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-kbl7/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [PASS][34] -> [FAIL][35] ([i915#2122]) +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-skl6/igt@kms_flip@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-skl9/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling:
- shard-iclb: [PASS][36] -> [SKIP][37] ([i915#3701])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
- shard-glk: [PASS][38] -> [FAIL][39] ([i915#3671])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-glk1/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-glk4/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-kbl: NOTRUN -> [FAIL][40] ([fdo#108145] / [i915#265])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-kbl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-apl: NOTRUN -> [FAIL][41] ([fdo#108145] / [i915#265])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-apl1/igt@[email protected]

* igt@kms_plane_cursor@pipe-d-viewport-size-128:
- shard-apl: NOTRUN -> [SKIP][42] ([fdo#109271]) +30 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-apl1/igt@[email protected]

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][43] -> [SKIP][44] ([fdo#109441]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html

* igt@kms_sysfs_edid_timing:
- shard-skl: NOTRUN -> [FAIL][45] ([IGT#2])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-skl8/igt@kms_sysfs_edid_timing.html

* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [PASS][46] -> [DMESG-WARN][47] ([i915#180] / [i915#295])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-apl1/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-apl2/igt@[email protected]

* igt@perf@polling-small-buf:
- shard-skl: [PASS][48] -> [FAIL][49] ([i915#1722])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-skl4/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-skl8/igt@[email protected]

* igt@tools_test@sysfs_l3_parity:
- shard-kbl: NOTRUN -> [SKIP][50] ([fdo#109271]) +26 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-kbl7/igt@tools_test@sysfs_l3_parity.html

#### Possible fixes ####

* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][51] ([i915#658]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-iclb4/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-iclb2/igt@[email protected]

* igt@gem_exec_balancer@parallel:
- shard-iclb: [SKIP][53] ([i915#4525]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-iclb5/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-iclb1/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][55] ([i915#2846]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-kbl6/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-kbl7/igt@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][57] ([i915#2842]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-glk3/igt@gem_exec_fair@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-glk2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [FAIL][59] ([i915#2842]) -> [PASS][60] +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-kbl7/igt@gem_exec_fair@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-kbl1/igt@gem_exec_fair@[email protected]

* igt@gem_softpin@noreloc-s3:
- shard-kbl: [DMESG-WARN][61] ([i915#180]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-kbl7/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-kbl6/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][63] ([i915#454]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-iclb4/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-iclb5/igt@[email protected]

* igt@i915_suspend@forcewake:
- shard-snb: [FAIL][65] ([fdo#103375]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-snb5/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-snb6/igt@[email protected]
- shard-skl: [INCOMPLETE][67] ([i915#636]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-skl6/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-skl8/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][69] ([i915#79]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-glk8/igt@kms_flip@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-glk9/igt@kms_flip@[email protected]

* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][71] ([i915#2122]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-glk6/igt@kms_flip@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-glk6/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [DMESG-WARN][73] ([i915#180]) -> [PASS][74] +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-apl8/igt@kms_flip@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-apl1/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-ts-check-interruptible@a-edp1:
- shard-skl: [FAIL][75] ([i915#2122]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-skl7/igt@kms_flip@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-skl10/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling:
- shard-glk: [FAIL][77] ([i915#4911]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-glk6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html

* igt@kms_hdr@bpc-switch:
- shard-skl: [FAIL][79] ([i915#1188]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-skl4/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-skl6/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-glk: [SKIP][81] ([fdo#109271]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-glk8/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-glk9/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][83] ([fdo#108145] / [i915#265]) -> [PASS][84] +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-skl7/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-skl4/igt@[email protected]

* igt@kms_setmode@basic:
- shard-glk: [FAIL][85] ([i915#31]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-glk9/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-glk5/igt@[email protected]

* igt@perf@polling-parameterized:
- shard-skl: [FAIL][87] ([i915#1542]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-skl9/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-skl10/igt@[email protected]

* igt@perf_pmu@rc6-suspend:
- shard-kbl: [INCOMPLETE][89] ([i915#180] / [i915#794]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-kbl7/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-kbl7/igt@[email protected]

#### Warnings ####

* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [SKIP][91] ([i915#4525]) -> [FAIL][92] ([i915#4916])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-iclb5/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-iclb1/igt@[email protected]

* igt@kms_psr2_su@page_flip-nv12:
- shard-iclb: [FAIL][93] ([i915#4148]) -> [SKIP][94] ([fdo#109642] / [fdo#111068] / [i915#658])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-iclb2/igt@kms_psr2_su@page_flip-nv12.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-iclb5/igt@kms_psr2_su@page_flip-nv12.html

* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: [SKIP][95] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [FAIL][96] ([i915#4148])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-iclb3/igt@kms_psr2_su@page_flip-xrgb8888.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-iclb2/igt@kms_psr2_su@page_flip-xrgb8888.html

* igt@runner@aborted:
- shard-skl: ([FAIL][97], [FAIL][98], [FAIL][99]) ([i915#3002] / [i915#4312]) -> ([FAIL][100], [FAIL][101], [FAIL][102], [FAIL][103]) ([i915#2029] / [i915#3002] / [i915#4312])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-skl1/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-skl10/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11157/shard-skl7/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-skl8/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-skl6/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-skl10/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/shard-skl1/igt@[email protected]

[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#232]: https://gitlab.freedesktop.org/drm/intel/issues/232
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3671]: https://gitlab.freedesktop.org/drm/intel/issues/3671
[i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4148]: https://gitlab.freedesktop.org/drm/intel/issues/4148
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4911]: https://gitlab.freedesktop.org/drm/intel/issues/4911
[i915#4916]: https://gitlab.freedesktop.org/drm/intel/issues/4916
[i915#636]: https://gitlab.freedesktop.org/drm/intel/issues/636
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#794]: https://gitlab.freedesktop.org/drm/intel/issues/794

Build changes
-------------

* Linux: CI_DRM_11157 -> Patchwork_22135

CI-20190529: 20190529
CI_DRM_11157: df832f248a682d4eb6a0b649da9e30b340bd718e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6336: ae2eb9e18bc58a4c45f28cfd80962938198dec3c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22135: c7d9c8b94db9f6ffbb963a7472dadb959c6e4921 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22135/index.html