Skip to contentSkip to conversation

io_uring: Remove unused function req_ref_put

PATCH In review Jiapeng Chong 2 participants 2 messages Jan 13, 2022

Subsystems (2)
VFS io_uring
lore
Share & tools
lore

Jiapeng Chong

author
#0 lore raw

PATCH 1/1 io_uring: Remove unused function req_ref_put

Fix the following clang warnings:

fs/io_uring.c:1195:20: warning: unused function 'req_ref_put' [-Wunused-function].

Reported-by Abaci Robot <[email protected]>
Signed-off-by Jiapeng Chong <[email protected]>
---
 fs/io_uring.c | 6 ------
 1 file changed, 6 deletions(-)
fs/io_uring.c +0 -6
index de9c9de90655..fa3277844d2e 100644
@@ -1192,12 +1192,6 @@ static inline bool req_ref_put_and_test(struct io_kiocb *req)
 	return atomic_dec_and_test(&req->refs);
 }
 
-static inline void req_ref_put(struct io_kiocb *req)
-{
-	WARN_ON_ONCE(!(req->flags & REQ_F_REFCOUNT));
-	WARN_ON_ONCE(req_ref_put_and_test(req));
-}
-
 static inline void req_ref_get(struct io_kiocb *req)
 {
 	WARN_ON_ONCE(!(req->flags & REQ_F_REFCOUNT));
Signature · 1 line
2.20.1.7.g153144c
maintainer
#1 lore raw
Quoted 7 lines · Jiapeng Chong

Fix the following clang warnings:

fs/io_uring.c:1195:20: warning: unused function 'req_ref_put' [-Wunused-function].

Reported-by Abaci Robot <[email protected]>
Signed-off-by Jiapeng Chong <[email protected]>

This was introduced by:

aa43477b0402 ("io_uring: poll rework")

so I added a Fixes line for that. Applied, thanks.

Signature · 1 line
Jens Axboe