Skip to contentSkip to conversation

mx6sabresd: Remove unneeded enable_lvds() function

PATCH New Fabio Estevam 2 participants 2 messages Mar 25, 2016 – Apr 3, 2016

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 mx6sabresd: Remove unneeded enable_lvds() function

From: Fabio Estevam <[email protected]>

enable_lvds() function only set bits IOMUXC_GPR2_DATA_WIDTH_CH0_18BIT and IOMUXC_GPR2_DATA_WIDTH_CH1_18BIT, but these bits were already set previously inside setup_display().

We can safely remove enable_lvds() then.

Signed-off-by Fabio Estevam <[email protected]>
---
 board/freescale/mx6sabresd/mx6sabresd.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
board/freescale/mx6sabresd/mx6sabresd.c +1 -11
index 727334a..2319354 100644
@@ -365,22 +365,12 @@ static void do_enable_hdmi(struct display_info_t const *dev)
 	imx_enable_hdmi_phy();
 }
 
-static void enable_lvds(struct display_info_t const *dev)
-{
-	struct iomuxc *iomux = (struct iomuxc *)
-				IOMUXC_BASE_ADDR;
-	u32 reg = readl(&iomux->gpr[2]);
-	reg |= IOMUXC_GPR2_DATA_WIDTH_CH0_18BIT |
-	       IOMUXC_GPR2_DATA_WIDTH_CH1_18BIT;
-	writel(reg, &iomux->gpr[2]);
-}
-
 struct display_info_t const displays[] = {{
 	.bus	= -1,
 	.addr	= 0,
 	.pixfmt	= IPU_PIX_FMT_RGB666,
 	.detect	= NULL,
-	.enable	= enable_lvds,
+	.enable	= NULL,
 	.mode	= {
 		.name           = "Hannstar-XGA",
 		.refresh        = 60,
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 mx6sabresd: Remove unneeded enable_lvds() function

Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

enable_lvds() function only set bits IOMUXC_GPR2_DATA_WIDTH_CH0_18BIT and IOMUXC_GPR2_DATA_WIDTH_CH1_18BIT, but these bits were already set previously inside setup_display().

We can safely remove enable_lvds() then.

Signed-off-by Fabio Estevam <[email protected]>

---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================