Skip to contentSkip to conversation

warp7: Pass the UART base definition

PATCH New Fabio Estevam 2 participants 4 messages Mar 26, 2016 – Apr 3, 2016

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/2 warp7: Pass the UART base definition

From: Fabio Estevam <[email protected]>

Since commit 5d69269deed0 ("mx7dsabresd: Define serial port locally") we need to specify the UART base address in each board config file, so do this to avoid a build error.

Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/warp7.h | 2 ++
 1 file changed, 2 insertions(+)
include/configs/warp7.h +2 -0
index 0798671..5ea5512 100644
@@ -14,6 +14,8 @@
 
 #define PHYS_SDRAM_SIZE			SZ_512M
 
+#define CONFIG_MXC_UART_BASE		UART1_IPS_BASE_ADDR
+
 #define CONFIG_BOARD_EARLY_INIT_F
 
 /* MMC Config*/
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/2 mx7_common: Define CONFIG_SYS_MALLOC_LEN in the board file

From: Fabio Estevam <[email protected]>

Having CONFIG_SYS_MALLOC_LEN in mx7_common.h is not a good idea, because the malloc() pool size is board dependent.

For example: if a certain board has support for splashscreen or DFU, it may be necessary to adjust CONFIG_SYS_MALLOC_LEN to a larger value.

So define CONFIG_SYS_MALLOC_LEN in each board config file.

Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx7_common.h  | 3 ---
 include/configs/mx7dsabresd.h | 3 +++
 include/configs/warp7.h       | 4 ++++
 3 files changed, 7 insertions(+), 3 deletions(-)
include/configs/mx7_common.h +0 -3
index 5034464..9bd6114 100644
@@ -28,9 +28,6 @@
 /* Enable iomux-lpsr support */
 #define CONFIG_IOMUX_LPSR
 
-/* Size of malloc() pool */
-#define CONFIG_SYS_MALLOC_LEN           (32 * SZ_1M)
-
 #define CONFIG_DISPLAY_CPUINFO
 #define CONFIG_DISPLAY_BOARDINFO
include/configs/mx7dsabresd.h +3 -0
index 988d363..25ed29d 100644
@@ -16,6 +16,9 @@
 
 #define CONFIG_MXC_UART_BASE            UART1_IPS_BASE_ADDR
 
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN		(32 * SZ_1M)
+
 #define CONFIG_BOARD_EARLY_INIT_F
 #define CONFIG_BOARD_LATE_INIT
include/configs/warp7.h +4 -0
index 5ea5512..d1404b2 100644
@@ -16,6 +16,10 @@
 
 #define CONFIG_MXC_UART_BASE		UART1_IPS_BASE_ADDR
 
+
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN		(32 * SZ_1M)
+
 #define CONFIG_BOARD_EARLY_INIT_F
 
 /* MMC Config*/
Signature · 1 line
1.9.1
#2 lore raw

PATCH 2/2 mx7_common: Define CONFIG_SYS_MALLOC_LEN in the board file

Quoted 51 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Having CONFIG_SYS_MALLOC_LEN in mx7_common.h is not a good idea, because the malloc() pool size is board dependent.

For example: if a certain board has support for splashscreen or DFU, it may be necessary to adjust CONFIG_SYS_MALLOC_LEN to a larger value.

So define CONFIG_SYS_MALLOC_LEN in each board config file.

Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx7_common.h  | 3 ---
 include/configs/mx7dsabresd.h | 3 +++
 include/configs/warp7.h       | 4 ++++
 3 files changed, 7 insertions(+), 3 deletions(-)
include/configs/mx7_common.h +0 -3
index 5034464..9bd6114 100644
@@ -28,9 +28,6 @@
 /* Enable iomux-lpsr support */
 #define CONFIG_IOMUX_LPSR
 
-/* Size of malloc() pool */
-#define CONFIG_SYS_MALLOC_LEN           (32 * SZ_1M)
-
 #define CONFIG_DISPLAY_CPUINFO
 #define CONFIG_DISPLAY_BOARDINFO
include/configs/mx7dsabresd.h +3 -0
index 988d363..25ed29d 100644
@@ -16,6 +16,9 @@
 
 #define CONFIG_MXC_UART_BASE            UART1_IPS_BASE_ADDR
 
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN		(32 * SZ_1M)
+
 #define CONFIG_BOARD_EARLY_INIT_F
 #define CONFIG_BOARD_LATE_INIT
include/configs/warp7.h +0 -0
index 5ea5512..d1404b2 100644

include/configs/warp7.h line 25

Quoted 10 lines
include/configs/warp7.h +4 -0
@@ -16,6 +16,10 @@
 
 #define CONFIG_MXC_UART_BASE		UART1_IPS_BASE_ADDR
 
+
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN		(32 * SZ_1M)
+
 #define CONFIG_BOARD_EARLY_INIT_F
 
 /* MMC Config*/

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH 1/2 warp7: Pass the UART base definition

In reply to Fabio Estevam
Quoted 17 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Since commit 5d69269deed0 ("mx7dsabresd: Define serial port locally") we need to specify the UART base address in each board config file, so do this to avoid a build error.

Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/warp7.h | 2 ++
 1 file changed, 2 insertions(+)
include/configs/warp7.h +0 -0
index 0798671..5ea5512 100644

include/configs/warp7.h line 21

Quoted 8 lines
include/configs/warp7.h +2 -0
@@ -14,6 +14,8 @@
 
 #define PHYS_SDRAM_SIZE			SZ_512M
 
+#define CONFIG_MXC_UART_BASE		UART1_IPS_BASE_ADDR
+
 #define CONFIG_BOARD_EARLY_INIT_F
 
 /* MMC Config*/

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================