Skip to contentSkip to conversation

comment for a long #ifdef

PATCH In review Ivan Pozdeev 3 participants 4 messages Jun 16, 2016

lore
Share & tools
lore

Ivan Pozdeev

author
#0 lore raw

PATCH 1/1 comment for a long #ifdef

---
compat/poll/poll.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
compat/poll/poll.c +0 -0
index db4e03e..5eb0280 100644
@@ -441,7 +441,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)

}

return rc;
-#else
+#else /* #ifndef WIN32_NATIVE */
static struct timeval tv0;
static HANDLE hEvent;
WSANETWORKEVENTS ev;
@@ -622,5 +622,5 @@ restart:
}

return rc;
-#endif
+#endif /* #ifndef WIN32_NATIVE */
}

Signature · 6 lines
1.9.5.msysgit.1


-- 
Regards,
Ivan
#1 lore raw
Quoted 1 line · Ivan Pozdeev

---

Missing sign-off. See Documentation/SubmittingPatches.

Quoted 23 lines

compat/poll/poll.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
compat/poll/poll.c +2 -2
index db4e03e..5eb0280 100644
@@ -441,7 +441,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)
 }
 
 return rc;
-#else
+#else /* #ifndef WIN32_NATIVE */
 static struct timeval tv0;
 static HANDLE hEvent;
 WSANETWORKEVENTS ev;

@@ -622,5 +622,5 @@ restart:
 }
 
 return rc;
-#endif
+#endif /* #ifndef WIN32_NATIVE */
 }
author
#2 lore raw
Signed-off-by Ivan Pozdeev

---
compat/poll/poll.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
compat/poll/poll.c +0 -0
index db4e03e..5eb0280 100644
@@ -441,7 +441,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)

}

return rc;
-#else
+#else /* #ifndef WIN32_NATIVE */
static struct timeval tv0;
static HANDLE hEvent;
WSANETWORKEVENTS ev;
@@ -622,5 +622,5 @@ restart:
}

return rc;
-#endif
+#endif /* #ifndef WIN32_NATIVE */
}

Signature · 6 lines
1.9.5.msysgit.1


-- 
Regards,
Ivan
#3 lore raw
In reply to Ivan Pozdeev
Quoted 3 lines · Ivan Pozdeev

---
compat/poll/poll.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)

As Eric pointed out, please sign-off your patch.

Quoted 22 lines
compat/poll/poll.c +2 -2
index db4e03e..5eb0280 100644
@@ -441,7 +441,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)
 }
 
 return rc;
-#else
+#else /* #ifndef WIN32_NATIVE */
 static struct timeval tv0;
 static HANDLE hEvent;
 WSANETWORKEVENTS ev;

@@ -622,5 +622,5 @@ restart:
 }
 
 return rc;
-#endif
+#endif /* #ifndef WIN32_NATIVE */
 }
Signature · 1 line
1.9.5.msysgit.1

There also is an #ifndef/#else/#endif in abspath.c that is larger than a typical patch context; could you include a fix for that, too?