usb: bcm_udc_otg: enable clocks

PATCH New Steve Rae 4 participants 10 messages Apr 4, 2016 – Apr 21, 2016

Subsystems (3)

USB Broadcom BCM2711/BCM2835 Arm architecture Broadcom BCM281XX/BCM11XXX/BCM216XX Arm architecture

lore

Share & tools

lore

Steve Rae

author

2016-04-04 19:59 UTC #0 lore raw

PATCH 1/3 usb: bcm_udc_otg: enable clocks

Turn on the USB OTG clocks.

Signed-off-by Steve Rae <[email protected]>

---

 drivers/usb/gadget/bcm_udc_otg_phy.c | 4 ++++
 1 file changed, 4 insertions(+)

drivers/usb/gadget/bcm_udc_otg_phy.c +4 -0

index 10b2e13..877f162 100644
@@ -8,12 +8,16 @@
 #include <common.h>
 #include <asm/io.h>
 #include <asm/arch/sysmap.h>
+#include <asm/kona-common/clk.h>
 
 #include "dwc2_udc_otg_priv.h"
 #include "bcm_udc_otg.h"
 
 void otg_phy_init(struct dwc2_udc *dev)
 {
+	/* turn on the USB OTG clocks */
+	clk_usb_otg_enable((void *)HSOTG_BASE_ADDR);
+
 	/* set Phy to driving mode */
 	wfld_clear(HSOTG_CTRL_BASE_ADDR + HSOTG_CTRL_PHY_P1CTL_OFFSET,
 		   HSOTG_CTRL_PHY_P1CTL_NON_DRIVING_MASK);

Signature · 1 line

1.8.5

Steve Rae

author

2016-04-04 19:59 UTC #1 lore raw

PATCH 2/3 bcm281xx: enable CONFIG_OF_LIBFDT

set the Kconfig parameter: CONFIG_OF_LIBFDT

Signed-off-by Steve Rae <[email protected]>

---

 configs/bcm28155_ap_defconfig | 1 +
 1 file changed, 1 insertion(+)

configs/bcm28155_ap_defconfig +1 -0

index ba57944..538647d 100644
@@ -9,3 +9,4 @@ CONFIG_CMD_GPIO=y
 CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_GADGET=y
+CONFIG_OF_LIBFDT=y

Signature · 1 line

1.8.5

Tom Rini

2016-04-21 11:20 UTC #2 lore raw

PATCH 2/3 bcm281xx: enable CONFIG_OF_LIBFDT

Quoted 3 lines · Steve Rae

set the Kconfig parameter: CONFIG_OF_LIBFDT
Signed-off-by Steve Rae <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160421/b94a743c/attachment.sig>

Steve Rae

author

2016-04-04 19:59 UTC #3 lore raw

PATCH 3/3 bcm281xx: save ENV to MMC

In reply to Steve Rae

Enable saving ENV to MMC for the bcm281xx boards.

Signed-off-by Steve Rae <[email protected]>

---

 include/configs/bcm28155_ap.h | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

include/configs/bcm28155_ap.h +5 -2

index f1e8ed1..2b8e324 100644
@@ -88,8 +88,11 @@
 
 #define CONFIG_BAUDRATE			115200
 
-#define CONFIG_ENV_SIZE			0x10000
-#define CONFIG_ENV_IS_NOWHERE
+/* must fit into GPT:u-boot-env partition */
+#define CONFIG_ENV_IS_IN_MMC
+#define CONFIG_SYS_MMC_ENV_DEV		0
+#define CONFIG_ENV_OFFSET		(0x00011a00 * 512)
+#define CONFIG_ENV_SIZE			(8 * 512)
 
 #define CONFIG_SYS_NO_FLASH	/* Not using NAND/NOR unmanaged flash */

Signature · 1 line

1.8.5

Tom Rini

2016-04-21 11:20 UTC #4 lore raw

PATCH 3/3 bcm281xx: save ENV to MMC

Quoted 3 lines · Steve Rae

Enable saving ENV to MMC for the bcm281xx boards.
Signed-off-by Steve Rae <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160421/c56b9dcf/attachment.sig>

Marek Vasut

2016-04-04 20:02 UTC #5 lore raw

PATCH 1/3 usb: bcm_udc_otg: enable clocks

In reply to Steve Rae

Quoted 15 lines · Steve Rae

Turn on the USB OTG clocks.
Signed-off-by Steve Rae <[email protected]>
---
 drivers/usb/gadget/bcm_udc_otg_phy.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/usb/gadget/bcm_udc_otg_phy.c +0 -0
index 10b2e13..877f162 100644
@@ -8,12 +8,16 @@
 #include <common.h>
 #include <asm/io.h>

drivers/usb/gadget/bcm_udc_otg_phy.c line 19

Quoted 10 lines

drivers/usb/gadget/bcm_udc_otg_phy.c +3 -0

 #include <asm/arch/sysmap.h>
+#include <asm/kona-common/clk.h>
 
 #include "dwc2_udc_otg_priv.h"
 #include "bcm_udc_otg.h"
 
 void otg_phy_init(struct dwc2_udc *dev)
 {
+	/* turn on the USB OTG clocks */
+	clk_usb_otg_enable((void *)HSOTG_BASE_ADDR);

I _think_ this driver is used on RPi too, did you compile test it there?

Quoted 4 lines

drivers/usb/gadget/bcm_udc_otg_phy.c +0 -0

 	/* set Phy to driving mode */
 	wfld_clear(HSOTG_CTRL_BASE_ADDR + HSOTG_CTRL_PHY_P1CTL_OFFSET,
 		   HSOTG_CTRL_PHY_P1CTL_NON_DRIVING_MASK);

Signature · 2 lines

Best regards,
Marek Vasut

Steve Rae

2016-04-04 20:30 UTC #6 lore raw

PATCH 1/3 usb: bcm_udc_otg: enable clocks

Hi Marek,

Quoted 23 lines · Marek Vasut

Quoted 21 lines · Steve Rae

Turn on the USB OTG clocks.

Signed-off-by Steve Rae <[email protected]>

---

 drivers/usb/gadget/bcm_udc_otg_phy.c | 4 ++++
 1 file changed, 4 insertions(+)

drivers/usb/gadget/bcm_udc_otg_phy.c +1 -0

index 10b2e13..877f162 100644
@@ -8,12 +8,16 @@
 #include <common.h>
 #include <asm/io.h>
 #include <asm/arch/sysmap.h>
+#include <asm/kona-common/clk.h>
 
 #include "dwc2_udc_otg_priv.h"
 #include "bcm_udc_otg.h"

Quoted 6 lines

drivers/usb/gadget/bcm_udc_otg_phy.c line 19
Quoted 4 lines
drivers/usb/gadget/bcm_udc_otg_phy.c +2 -0
 void otg_phy_init(struct dwc2_udc *dev)
 {
+     /* turn on the USB OTG clocks */
+     clk_usb_otg_enable((void *)HSOTG_BASE_ADDR);
I _think_ this driver is used on RPi too, did you compile test it there?

no, it is not - the only place this is used is:

    drivers/usb/gadget/Makefile:obj-$(CONFIG_USB_GADGET_BCM_UDC_OTG_PHY)

+= bcm_udc_otg_phy.o
include/configs/bcm28155_ap.h:#define CONFIG_USB_GADGET_BCM_UDC_OTG_PHY

Thanks, Steve
PS.
"rpi" and "rpi_2" both build successfully....

Quoted 11 lines

drivers/usb/gadget/bcm_udc_otg_phy.c line 23
Quoted 6 lines
drivers/usb/gadget/bcm_udc_otg_phy.c +0 -0
      /* set Phy to driving mode */
      wfld_clear(HSOTG_CTRL_BASE_ADDR + HSOTG_CTRL_PHY_P1CTL_OFFSET,
                 HSOTG_CTRL_PHY_P1CTL_NON_DRIVING_MASK);
--
Best regards,
Marek Vasut

Marek Vasut

2016-04-05 22:07 UTC #7 lore raw

PATCH 1/3 usb: bcm_udc_otg: enable clocks

Quoted 33 lines · Steve Rae

Hi Marek,
Quoted 23 lines · Marek Vasut
Quoted 21 lines · Steve Rae
Turn on the USB OTG clocks.
Signed-off-by Steve Rae <[email protected]>
---
 drivers/usb/gadget/bcm_udc_otg_phy.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/usb/gadget/bcm_udc_otg_phy.c +1 -0
index 10b2e13..877f162 100644
@@ -8,12 +8,16 @@
 #include <common.h>
 #include <asm/io.h>
 #include <asm/arch/sysmap.h>
+#include <asm/kona-common/clk.h>
 
 #include "dwc2_udc_otg_priv.h"
 #include "bcm_udc_otg.h"
 
Quoted 6 lines
drivers/usb/gadget/bcm_udc_otg_phy.c line 19
Quoted 4 lines
drivers/usb/gadget/bcm_udc_otg_phy.c +2 -0
 void otg_phy_init(struct dwc2_udc *dev)
 {
+     /* turn on the USB OTG clocks */
+     clk_usb_otg_enable((void *)HSOTG_BASE_ADDR);
I _think_ this driver is used on RPi too, did you compile test it there?

Quoted 4 lines

no, it is not - the only place this is used is:
    drivers/usb/gadget/Makefile:obj-$(CONFIG_USB_GADGET_BCM_UDC_OTG_PHY)
+= bcm_udc_otg_phy.o
include/configs/bcm28155_ap.h:#define CONFIG_USB_GADGET_BCM_UDC_OTG_PHY

Got it, thanks for checking.

Do you want me to pick this up via u-boot-usb or shall this go via some other tree as a series ?

Quoted 15 lines

Thanks, Steve
PS.
"rpi" and "rpi_2" both build successfully....
Quoted 11 lines
drivers/usb/gadget/bcm_udc_otg_phy.c line 23
Quoted 6 lines
drivers/usb/gadget/bcm_udc_otg_phy.c +0 -0
      /* set Phy to driving mode */
      wfld_clear(HSOTG_CTRL_BASE_ADDR + HSOTG_CTRL_PHY_P1CTL_OFFSET,
                 HSOTG_CTRL_PHY_P1CTL_NON_DRIVING_MASK);
--
Best regards,
Marek Vasut

Signature · 2 lines

Best regards,
Marek Vasut

Steve Rae

2016-04-06 05:20 UTC #8 lore raw

PATCH 1/3 usb: bcm_udc_otg: enable clocks

Quoted 9 lines · Marek Vasut

Quoted 7 lines · Steve Rae
Hi Marek,
Quoted 4 lines · Marek Vasut
Quoted 2 lines · Steve Rae
Turn on the USB OTG clocks.

Quoted 7 lines

Quoted 7 lines
Quoted 7 lines
Review
Quoted 7 lines
Signed-off-by Steve Rae <[email protected]>
---
 drivers/usb/gadget/bcm_udc_otg_phy.c | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

b/drivers/usb/gadget/bcm_udc_otg_phy.c

Quoted 12 lines

Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
index 10b2e13..877f162 100644
drivers/usb/gadget/bcm_udc_otg_phy.c +1 -0
@@ -8,12 +8,16 @@
 #include <common.h>
 #include <asm/io.h>
 #include <asm/arch/sysmap.h>
+#include <asm/kona-common/clk.h>
 
 #include "dwc2_udc_otg_priv.h"
 #include "bcm_udc_otg.h"
 

Quoted 6 lines

Quoted 6 lines
Quoted 6 lines
drivers/usb/gadget/bcm_udc_otg_phy.c line 19
Quoted 4 lines
drivers/usb/gadget/bcm_udc_otg_phy.c +2 -0
 void otg_phy_init(struct dwc2_udc *dev)
 {
+     /* turn on the USB OTG clocks */
+     clk_usb_otg_enable((void *)HSOTG_BASE_ADDR);
I _think_ this driver is used on RPi too, did you compile test it

there?

Quoted 5 lines

no, it is not - the only place this is used is:

    drivers/usb/gadget/Makefile:obj-$(CONFIG_USB_GADGET_BCM_UDC_OTG_PHY)
+= bcm_udc_otg_phy.o
    include/configs/bcm28155_ap.h:#define

CONFIG_USB_GADGET_BCM_UDC_OTG_PHY

Quoted 6 lines

Got it, thanks for checking.
Do you want me to pick this up via u-boot-usb or shall this go via some other tree as a series ?

I don't have any preference - what is the best way to get my outstanding patches applied?
Thanks, Steve

Quoted 20 lines

Quoted 15 lines
Thanks, Steve
PS.
"rpi" and "rpi_2" both build successfully....
Quoted 11 lines
drivers/usb/gadget/bcm_udc_otg_phy.c line 23
Quoted 6 lines
drivers/usb/gadget/bcm_udc_otg_phy.c +0 -0
      /* set Phy to driving mode */
      wfld_clear(HSOTG_CTRL_BASE_ADDR + HSOTG_CTRL_PHY_P1CTL_OFFSET,
                 HSOTG_CTRL_PHY_P1CTL_NON_DRIVING_MASK);
--
Best regards,
Marek Vasut
--
Best regards,
Marek Vasut

Marek Vasut

2016-04-06 10:52 UTC #9 lore raw

PATCH 1/3 usb: bcm_udc_otg: enable clocks

Quoted 48 lines · Steve Rae

Quoted 5 lines · On Apr 5, 2016 3:08 PM, "Marek Vasut" <[email protected] <mailto:[email protected]>>…
Quoted 3 lines · Steve Rae
Hi Marek,
On Mon, Apr 4, 2016 at 1:02 PM, Marek Vasut <[email protected]
Quoted 5 lines · <mailto:[email protected]>> wrote:
Quoted 5 lines
Quoted 5 lines · Steve Rae
Quoted 3 lines
Turn on the USB OTG clocks.
Signed-off-by Steve Rae <[email protected]
<mailto:[email protected]>>
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Review
Quoted 6 lines
---
 drivers/usb/gadget/bcm_udc_otg_phy.c | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0
b/drivers/usb/gadget/bcm_udc_otg_phy.c
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
index 10b2e13..877f162 100644
drivers/usb/gadget/bcm_udc_otg_phy.c +1 -0
@@ -8,12 +8,16 @@
 #include <common.h>
 #include <asm/io.h>
 #include <asm/arch/sysmap.h>
+#include <asm/kona-common/clk.h>
 
 #include "dwc2_udc_otg_priv.h"
 #include "bcm_udc_otg.h"
 
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
drivers/usb/gadget/bcm_udc_otg_phy.c line 19
Quoted 4 lines
drivers/usb/gadget/bcm_udc_otg_phy.c +2 -0
 void otg_phy_init(struct dwc2_udc *dev)
 {
+     /* turn on the USB OTG clocks */
+     clk_usb_otg_enable((void *)HSOTG_BASE_ADDR);
I _think_ this driver is used on RPi too, did you compile test it
there?
Quoted 5 lines
Quoted 5 lines
no, it is not - the only place this is used is:
    drivers/usb/gadget/Makefile:obj-$(CONFIG_USB_GADGET_BCM_UDC_OTG_PHY)
+= bcm_udc_otg_phy.o
    include/configs/bcm28155_ap.h:#define
CONFIG_USB_GADGET_BCM_UDC_OTG_PHY
Quoted 1 line

Quoted 7 lines

Quoted 5 lines
Got it, thanks for checking.
Do you want me to pick this up via u-boot-usb or shall this go via some other tree as a series ?
I don't have any preference - what is the best way to get my outstanding patches applied?

Since the other two patches are quite unrelated, I will just pick this one and let the bcm maintainer pick the rest.

Best regards,
Marek Vasut