Skip to contentSkip to conversation

ixgbe: Fix flag issue in generic CSUM patch

PATCH New Alexander Duyck 2 participants 2 messages Apr 4, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ixgbe: Fix flag issue in generic CSUM patch

This patch fixes a minor flags issue where we had lost NETIF_F_HW_TC and were setting NETIF_F_SCTP_CRC in two different spots when we only wanted to enable it in the if statement.

---

This should fix both the one issue I saw and the NETIF_F_HW_TC issue that Sridar saw with the generic CSUM patch.

 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +2 -2
index 51ce426ce510..30903c5517af 100644
@@ -9214,7 +9214,6 @@ skip_sriov:
 			   NETIF_F_RXHASH |
 			   NETIF_F_RXCSUM |
 			   NETIF_F_HW_CSUM |
-			   NETIF_F_SCTP_CRC |
 			   NETIF_F_HW_VLAN_CTAG_TX |
 			   NETIF_F_HW_VLAN_CTAG_RX |
 			   NETIF_F_HW_VLAN_CTAG_FILTER;
@@ -9228,7 +9227,8 @@ skip_sriov:
 			       NETIF_F_HW_L2FW_DOFFLOAD;
 
 	if (hw->mac.type >= ixgbe_mac_82599EB)
-		netdev->hw_features |= NETIF_F_NTUPLE;
+		netdev->hw_features |= NETIF_F_NTUPLE |
+				       NETIF_F_HW_TC;
 
 	netdev->vlan_features |= NETIF_F_SG |
 				 NETIF_F_TSO |
#1 lore raw

PATCH 1/1 ixgbe: Fix flag issue in generic CSUM patch

Quoted 5 lines · Alexander Duyck

This patch fixes a minor flags issue where we had lost NETIF_F_HW_TC and were setting NETIF_F_SCTP_CRC in two different spots when we only wanted to enable it in the if statement.

Quoted 31 lines

---

This should fix both the one issue I saw and the NETIF_F_HW_TC issue that Sridar saw with the generic CSUM patch.

  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +2 -2
index 51ce426ce510..30903c5517af 100644
@@ -9214,7 +9214,6 @@ skip_sriov:
  			   NETIF_F_RXHASH |
  			   NETIF_F_RXCSUM |
  			   NETIF_F_HW_CSUM |
-			   NETIF_F_SCTP_CRC |
  			   NETIF_F_HW_VLAN_CTAG_TX |
  			   NETIF_F_HW_VLAN_CTAG_RX |
  			   NETIF_F_HW_VLAN_CTAG_FILTER;
@@ -9228,7 +9227,8 @@ skip_sriov:
  			       NETIF_F_HW_L2FW_DOFFLOAD;
 
  	if (hw->mac.type >= ixgbe_mac_82599EB)
-		netdev->hw_features |= NETIF_F_NTUPLE;
+		netdev->hw_features |= NETIF_F_NTUPLE |
+				       NETIF_F_HW_TC;
 
  	netdev->vlan_features |= NETIF_F_SG |
  				 NETIF_F_TSO |