Skip to contentSkip to conversation

new package: alsacap

PATCH New Wojciech Nizinski 5 participants 8 messages Apr 6, 2016 – Jul 3, 2016

lore
Share & tools
lore

Wojciech Nizinski

author
#0 lore raw

PATCH 1/1 new package: alsacap

Alsa capability tool displays the capabilities of your sound card and its ALSA driver

Signed-off-by Wojciech Nizinski <[email protected]>
---
 package/Config.in          |  1 +
 package/alsacap/Config.in  |  5 +++++
 package/alsacap/alsacap.mk | 22 ++++++++++++++++++++++
 3 files changed, 28 insertions(+)
 create mode 100644 package/alsacap/Config.in
 create mode 100644 package/alsacap/alsacap.mk
package/Config.in +1 -0
index bdc3063..dd6c1d9 100644
@@ -5,6 +5,7 @@ menu "Target packages"
 
 menu "Audio and video applications"
 	source "package/alsa-utils/Config.in"
+	source "package/alsacap/Config.in"
 	source "package/aumix/Config.in"
 	source "package/bellagio/Config.in"
 	source "package/dvblast/Config.in"
package/alsacap/Config.in new file +5 -0
new file mode 100644
index 0000000..d472973
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_ALSACAP
+	bool "alsacap"
+	depends on BR2_PACKAGE_ALSA_LIB
+	help 
+	    Alsa capability tool displays the capabilities of your sound card and its ALSA driver.
package/alsacap/alsacap.mk new file +22 -0
new file mode 100644
index 0000000..391947c
@@ -0,0 +1,22 @@
+################################################################################
+#
+# alsacap
+#
+################################################################################
+ALSACAP_VERSION = 05968d33bd42b9550ac0892c0214edc956d09d8d
+ALSACAP_SITE = $(call github,bubbapizza,alsacap,$(ALSACAP_VERSION))
+
+ALSACAP_LICENSE = ISC licence
+ALSACAP_LICENSE_FILES = COPYING
+
+ALSACAP_DEPENDENCIES = alsa-lib
+
+define ALSACAP_BOOTSTRAP
+    cd $(@D) && ./bootstrap
+endef
+
+ALSACAP_PRE_CONFIGURE_HOOKS += ALSACAP_BOOTSTRAP
+
+$(eval $(autotools-package))
+
+
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 new package: alsacap

Hi Wojciech ,

Quoted 8 lines · Wojciech Nizinski

Alsa capability tool displays the capabilities of your sound card and its ALSA driver

Signed-off-by Wojciech Nizinski <[email protected]>
---
 package/Config.in          |  1 +
 package/alsacap/Config.in  |  5 +++++
 package/alsacap/alsacap.mk | 22 ++++++++++++++++++++++

hash file is missing

Quoted 33 lines
 3 files changed, 28 insertions(+)
 create mode 100644 package/alsacap/Config.in
 create mode 100644 package/alsacap/alsacap.mk
package/Config.in +1 -0
index bdc3063..dd6c1d9 100644
@@ -5,6 +5,7 @@ menu "Target packages"
 
 menu "Audio and video applications"
        source "package/alsa-utils/Config.in"
+       source "package/alsacap/Config.in"
        source "package/aumix/Config.in"
        source "package/bellagio/Config.in"
        source "package/dvblast/Config.in"
package/alsacap/Config.in new file +5 -0
new file mode 100644
index 0000000..d472973
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_ALSACAP
+       bool "alsacap"
+       depends on BR2_PACKAGE_ALSA_LIB
+       help
+           Alsa capability tool displays the capabilities of your sound card and its ALSA driver.
package/alsacap/alsacap.mk new file +0 -0
new file mode 100644
index 0000000..391947c

package/alsacap/alsacap.mk line 9

Quoted 9 lines
package/alsacap/alsacap.mk new file +9 -0
@@ -0,0 +1,22 @@
+################################################################################
+#
+# alsacap
+#
+################################################################################
+ALSACAP_VERSION = 05968d33bd42b9550ac0892c0214edc956d09d8d
+ALSACAP_SITE = $(call github,bubbapizza,alsacap,$(ALSACAP_VERSION))
+
+ALSACAP_LICENSE = ISC licence

this should be just "ISC" and not "ISC licence"

package/alsacap/alsacap.mk line 16

Quoted 7 lines
package/alsacap/alsacap.mk new file +7 -0
+ALSACAP_LICENSE_FILES = COPYING
+
+ALSACAP_DEPENDENCIES = alsa-lib
+
+define ALSACAP_BOOTSTRAP
+    cd $(@D) && ./bootstrap
+endef

have you tried specifying "ALSACAP_AUTORECONF =YES" instead of making own boostrap hook?

See http://nightly.buildroot.org/manual.html#_infrastructure_for_autotools_based_packages
for reference.

Yegor

Quoted 13 lines
package/alsacap/alsacap.mk new file +6 -1
+
+ALSACAP_PRE_CONFIGURE_HOOKS += ALSACAP_BOOTSTRAP
+
+$(eval $(autotools-package))
+
+
--

2.1.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

author
#2 lore raw

PATCH 1/1 new package: alsacap

Hello!
Corrected patch below.
Hash file added, but hash is not used, because source comes from git repository.

Alsa capability tool displays the capabilities of your sound card and its ALSA driver

Signed-off-by Wojciech Nizinski <[email protected]>
---
  package/Config.in            |  1 +
  package/alsacap/Config.in    |  5 +++++
  package/alsacap/alsacap.hash |  2 ++
  package/alsacap/alsacap.mk   | 18 ++++++++++++++++++
  4 files changed, 26 insertions(+)

create mode 100644 package/alsacap/Config.in
create mode 100644 package/alsacap/alsacap.hash
create mode 100644 package/alsacap/alsacap.mk

package/Config.in +1 -0
index 64822bf..29045b2 100644
@@ -5,6 +5,7 @@ menu "Target packages"
 
  menu "Audio and video applications"
  	source "package/alsa-utils/Config.in"
+	source "package/alsacap/Config.in"
  	source "package/aumix/Config.in"
  	source "package/bellagio/Config.in"
  	source "package/dvblast/Config.in"
package/alsacap/Config.in new file +5 -0
new file mode 100644
index 0000000..d472973
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_ALSACAP
+	bool "alsacap"
+	depends on BR2_PACKAGE_ALSA_LIB
+	help
+	    Alsa capability tool displays the capabilities of your sound card

and its ALSA driver.

package/alsacap/alsacap.hash new file +2 -0
new file mode 100644
index 0000000..293df28
@@ -0,0 +1,2 @@
+none   xxx  alsacap-05968d33bd42b9550ac0892c0214edc956d09d8d.tar.gz
+
package/alsacap/alsacap.mk new file +18 -0
new file mode 100644
index 0000000..135ab87
@@ -0,0 +1,18 @@
+################################################################################
+#
+# alsacap
+#
+################################################################################
+ALSACAP_VERSION = 05968d33bd42b9550ac0892c0214edc956d09d8d
+ALSACAP_SITE = $(call github,bubbapizza,alsacap,$(ALSACAP_VERSION))
+
+ALSACAP_LICENSE = ISC
+ALSACAP_LICENSE_FILES = COPYING
+
+ALSACAP_DEPENDENCIES = alsa-lib
+
+ALSACAP_AUTORECONF = YES
+
+$(eval $(autotools-package))
+
+
Signature · 1 line
2.1.4
Quoted 91 lines · Yegor Yefremov

Hi Wojciech ,

Quoted 8 lines · Wojciech Nizinski

Alsa capability tool displays the capabilities of your sound card and its ALSA driver

Signed-off-by Wojciech Nizinski <[email protected]>
---
 package/Config.in          |  1 +
 package/alsacap/Config.in  |  5 +++++
 package/alsacap/alsacap.mk | 22 ++++++++++++++++++++++

hash file is missing

Quoted 34 lines
 3 files changed, 28 insertions(+)
 create mode 100644 package/alsacap/Config.in
 create mode 100644 package/alsacap/alsacap.mk
package/Config.in +1 -0
index bdc3063..dd6c1d9 100644
@@ -5,6 +5,7 @@ menu "Target packages"
 
 menu "Audio and video applications"
        source "package/alsa-utils/Config.in"
+       source "package/alsacap/Config.in"
        source "package/aumix/Config.in"
        source "package/bellagio/Config.in"
        source "package/dvblast/Config.in"
package/alsacap/Config.in new file +5 -0
new file mode 100644
index 0000000..d472973
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_ALSACAP
+       bool "alsacap"
+       depends on BR2_PACKAGE_ALSA_LIB
+       help
+           Alsa capability tool displays the capabilities of your

sound card and its ALSA driver.

package/alsacap/alsacap.mk new file +0 -0
new file mode 100644
index 0000000..391947c

package/alsacap/alsacap.mk line 9

Quoted 9 lines
package/alsacap/alsacap.mk new file +9 -0
@@ -0,0 +1,22 @@
+################################################################################
+#
+# alsacap
+#
+################################################################################
+ALSACAP_VERSION = 05968d33bd42b9550ac0892c0214edc956d09d8d
+ALSACAP_SITE = $(call github,bubbapizza,alsacap,$(ALSACAP_VERSION))
+
+ALSACAP_LICENSE = ISC licence

this should be just "ISC" and not "ISC licence"

package/alsacap/alsacap.mk line 16

Quoted 7 lines
package/alsacap/alsacap.mk new file +7 -0
+ALSACAP_LICENSE_FILES = COPYING
+
+ALSACAP_DEPENDENCIES = alsa-lib
+
+define ALSACAP_BOOTSTRAP
+    cd $(@D) && ./bootstrap
+endef

have you tried specifying "ALSACAP_AUTORECONF =YES" instead of making own boostrap hook?

See
http://nightly.buildroot.org/manual.html#_infrastructure_for_autotools_based_packages
for reference.

Yegor

Quoted 13 lines
package/alsacap/alsacap.mk new file +6 -1
+
+ALSACAP_PRE_CONFIGURE_HOOKS += ALSACAP_BOOTSTRAP
+
+$(eval $(autotools-package))
+
+
--

2.1.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#3 lore raw

PATCH 1/1 new package: alsacap

Hi Wojciech,

In addition to the previous comments...

Quoted 59 lines

Hello!
Corrected patch below.
Hash file added, but hash is not used, because source comes from git repository.

Alsa capability tool displays the capabilities of your sound card and its ALSA driver

Signed-off-by Wojciech Nizinski <[email protected]>
---
 package/Config.in            |  1 +
 package/alsacap/Config.in    |  5 +++++
 package/alsacap/alsacap.hash |  2 ++
 package/alsacap/alsacap.mk   | 18 ++++++++++++++++++
 4 files changed, 26 insertions(+)
 create mode 100644 package/alsacap/Config.in
 create mode 100644 package/alsacap/alsacap.hash
 create mode 100644 package/alsacap/alsacap.mk
package/Config.in +1 -0
index 64822bf..29045b2 100644
@@ -5,6 +5,7 @@ menu "Target packages"
 
 menu "Audio and video applications"
     source "package/alsa-utils/Config.in"
+    source "package/alsacap/Config.in"
     source "package/aumix/Config.in"
     source "package/bellagio/Config.in"
     source "package/dvblast/Config.in"
package/alsacap/Config.in new file +5 -0
new file mode 100644
index 0000000..d472973
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_ALSACAP
+    bool "alsacap"
+    depends on BR2_PACKAGE_ALSA_LIB
+    help
+        Alsa capability tool displays the capabilities of your sound

card and its ALSA driver.

package/alsacap/alsacap.hash new file +2 -0
new file mode 100644
index 0000000..293df28
@@ -0,0 +1,2 @@
+none   xxx alsacap-05968d33bd42b9550ac0892c0214edc956d09d8d.tar.gz
+
package/alsacap/alsacap.mk new file +0 -0
new file mode 100644
index 0000000..135ab87

package/alsacap/alsacap.mk line 5

Quoted 6 lines
package/alsacap/alsacap.mk new file +5 -0
@@ -0,0 +1,18 @@
+################################################################################ 
 
+#
+# alsacap
+#
+################################################################################

Add empty line here.

package/alsacap/alsacap.mk line 18

Quoted 13 lines
package/alsacap/alsacap.mk new file +13 -0
+ALSACAP_VERSION = 05968d33bd42b9550ac0892c0214edc956d09d8d
+ALSACAP_SITE = $(call github,bubbapizza,alsacap,$(ALSACAP_VERSION))
+
+ALSACAP_LICENSE = ISC
+ALSACAP_LICENSE_FILES = COPYING
+
+ALSACAP_DEPENDENCIES = alsa-lib
+
+ALSACAP_AUTORECONF = YES
+
+$(eval $(autotools-package))
+
+

These two empty lines are redundant.

Regards,
Jerzy

#4 lore raw

PATCH 1/1 new package: alsacap

In reply to Wojciech Niziński
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Wojciech" == Wojciech Nizi?ski <[email protected]> writes:

Hello!
Corrected patch below.
Hash file added, but hash is not used, because source comes from git repository.

Alsa capability tool displays the capabilities of your sound card and its ALSA driver

Signed-off-by Wojciech Nizinski <[email protected]>

Care to send an updated patch with the fixes suggested by Arnout and Jerzy? Also please add a locally calculated sha256 for the .hash file.

Looking at the upstream code I see it will need to be fixed for static linking. Right now it is simply hardcoded to link with -lasound. Alsa-lib provides a .pc files, so ideally it should use pkg-config to get the right linker/compiler flags.

In the mean time I will mark this patch as changes requested in patchwork.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 1/1 new package: alsacap

In reply to Wojciech Nizinski

In addition to Yegor's comments...

Quoted 30 lines · Wojciech Nizinski

Alsa capability tool displays the capabilities of your sound card and its ALSA driver

Signed-off-by Wojciech Nizinski <[email protected]>
---
  package/Config.in          |  1 +
  package/alsacap/Config.in  |  5 +++++
  package/alsacap/alsacap.mk | 22 ++++++++++++++++++++++
  3 files changed, 28 insertions(+)

create mode 100644 package/alsacap/Config.in
create mode 100644 package/alsacap/alsacap.mk

package/Config.in +1 -0
index bdc3063..dd6c1d9 100644
@@ -5,6 +5,7 @@ menu "Target packages"
 
  menu "Audio and video applications"
  	source "package/alsa-utils/Config.in"
+	source "package/alsacap/Config.in"
  	source "package/aumix/Config.in"
  	source "package/bellagio/Config.in"
  	source "package/dvblast/Config.in"
package/alsacap/Config.in new file +0 -0
new file mode 100644
index 0000000..d472973

package/alsacap/Config.in line 3

Quoted 3 lines
package/alsacap/Config.in new file +3 -0
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_ALSACAP
+	bool "alsacap"
+	depends on BR2_PACKAGE_ALSA_LIB

Use select instead of depends:

depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib select BR2_PACKAGE_ALSA_LIB

Because there is a dependency on threads, you also need to add a comment to
clarify that (cfr. the manual).

package/alsacap/Config.in line 5

Quoted 2 lines
package/alsacap/Config.in new file +2 -0
+	help
+	    Alsa capability tool displays the capabilities of your sound card and its ALSA driver.

Indentation should be 1 tab + 2 spaces, and wrap at 72 columns (where tab
counts for 8, so 62 characters).

Quoted 6 lines
package/alsacap/alsacap.mk new file +0 -0
new file mode 100644
index 0000000..391947c

package/alsacap/alsacap.mk line 8

Quoted 8 lines
package/alsacap/alsacap.mk new file +8 -0
@@ -0,0 +1,22 @@
+################################################################################
+#
+# alsacap
+#
+################################################################################
+ALSACAP_VERSION = 05968d33bd42b9550ac0892c0214edc956d09d8d
+ALSACAP_SITE = $(call github,bubbapizza,alsacap,$(ALSACAP_VERSION))
+

Remove this empty line.

package/alsacap/alsacap.mk line 11

Quoted 3 lines
package/alsacap/alsacap.mk new file +3 -0
+ALSACAP_LICENSE = ISC licence
+ALSACAP_LICENSE_FILES = COPYING
+

Here as well.

Regards,
Arnout

Quoted 12 lines
package/alsacap/alsacap.mk new file +11 -0
+ALSACAP_DEPENDENCIES = alsa-lib
+
+define ALSACAP_BOOTSTRAP
+    cd $(@D) && ./bootstrap
+endef
+
+ALSACAP_PRE_CONFIGURE_HOOKS += ALSACAP_BOOTSTRAP
+
+$(eval $(autotools-package))
+
+
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
author
#6 lore raw

PATCH 1/1 new package: alsacap

Is any tool available to check format of BR files (something like vera++) ?

Quoted 95 lines · Arnout Vandecappelle

In addition to Yegor's comments...

Quoted 30 lines · Wojciech Nizinski

Alsa capability tool displays the capabilities of your sound card and its ALSA driver

Signed-off-by Wojciech Nizinski <[email protected]>
---
  package/Config.in          |  1 +
  package/alsacap/Config.in  |  5 +++++
  package/alsacap/alsacap.mk | 22 ++++++++++++++++++++++
  3 files changed, 28 insertions(+)

create mode 100644 package/alsacap/Config.in
create mode 100644 package/alsacap/alsacap.mk

package/Config.in +1 -0
index bdc3063..dd6c1d9 100644
@@ -5,6 +5,7 @@ menu "Target packages"
 
  menu "Audio and video applications"
      source "package/alsa-utils/Config.in"
+    source "package/alsacap/Config.in"
      source "package/aumix/Config.in"
      source "package/bellagio/Config.in"
      source "package/dvblast/Config.in"
package/alsacap/Config.in new file +0 -0
new file mode 100644
index 0000000..d472973

package/alsacap/Config.in line 3

Quoted 3 lines
package/alsacap/Config.in new file +3 -0
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_ALSACAP
+    bool "alsacap"
+    depends on BR2_PACKAGE_ALSA_LIB

Use select instead of depends:

depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib select BR2_PACKAGE_ALSA_LIB

Because there is a dependency on threads, you also need to add a
comment to clarify that (cfr. the manual).

Quoted 3 lines
package/alsacap/Config.in new file +2 -0
+    help
+        Alsa capability tool displays the capabilities of your sound

card and its ALSA driver.

Indentation should be 1 tab + 2 spaces, and wrap at 72 columns (where
tab counts for 8, so 62 characters).

Quoted 6 lines
package/alsacap/alsacap.mk new file +0 -0
new file mode 100644
index 0000000..391947c

package/alsacap/alsacap.mk line 8

Quoted 10 lines
package/alsacap/alsacap.mk new file +8 -0
@@ -0,0 +1,22 @@
+################################################################################ 
 
+#
+# alsacap
+#
+################################################################################ 
 
+ALSACAP_VERSION = 05968d33bd42b9550ac0892c0214edc956d09d8d
+ALSACAP_SITE = $(call github,bubbapizza,alsacap,$(ALSACAP_VERSION))
+

Remove this empty line.

package/alsacap/alsacap.mk line 11

Quoted 3 lines
package/alsacap/alsacap.mk new file +3 -0
+ALSACAP_LICENSE = ISC licence
+ALSACAP_LICENSE_FILES = COPYING
+

Here as well.

Regards,
Arnout

Quoted 12 lines
package/alsacap/alsacap.mk new file +11 -0
+ALSACAP_DEPENDENCIES = alsa-lib
+
+define ALSACAP_BOOTSTRAP
+    cd $(@D) && ./bootstrap
+endef
+
+ALSACAP_PRE_CONFIGURE_HOOKS += ALSACAP_BOOTSTRAP
+
+$(eval $(autotools-package))
+
+
#7 lore raw

PATCH 1/1 new package: alsacap

Quoted 1 line · Wojciech Nizinski

Is any tool available to check format of BR files (something like vera++) ?

Unfortunately, not at the moment. I started on something [1] but never
finished it to a level that it actually did something useful.

Regards,
Arnout

[snip]

[1] git fetch https://github.com/arnout/buildroot.git checkpackage

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF