Skip to contentSkip to conversation

ARM: DTS: da850: fixed missing #gpio-cells in gpio node

PATCH New Petr Kulhavy 2 participants 2 messages Apr 5, 2016 – Apr 7, 2016 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: DTS: da850: fixed missing #gpio-cells in gpio node

The gpio node was missing the mandatory property #gpio-cells, which was causing runtime errors when using GPIOs e.g. with gpio-leds or gpio-keys:

"could not get #gpio-cells for /soc/gpio at 1e26000"

This fixes the problem and adds the missing parameter. The value is 2 according to the gpio-davinci.txt binding.

---
 arch/arm/boot/dts/da850.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/da850.dtsi +1 -0
index 226cda76e77c..b0e3a4c833c3 100644
@@ -312,6 +312,7 @@
 		gpio: gpio at 1e26000 {
 			compatible = "ti,dm6441-gpio";
 			gpio-controller;
+			#gpio-cells = <2>;
 			reg = <0x226000 0x1000>;
 			interrupts = <42 IRQ_TYPE_EDGE_BOTH
 				43 IRQ_TYPE_EDGE_BOTH 44 IRQ_TYPE_EDGE_BOTH
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ARM: DTS: da850: fixed missing #gpio-cells in gpio node

Hi Petr,

Quoted 9 lines · Petr Kulhavy

The gpio node was missing the mandatory property #gpio-cells, which was causing runtime errors when using GPIOs e.g. with gpio-leds or gpio-keys:

"could not get #gpio-cells for /soc/gpio at 1e26000"

This fixes the problem and adds the missing parameter. The value is 2 according to the gpio-davinci.txt binding.

Thanks for the patch. Queuing this for v4.7 since it has been this way since beginning and there seem to be no in-kernel device-tree files with a gpio consumerm, so no one seems to be immediately affected.

Thanks,
Sekhar