Skip to contentSkip to conversation

ocfs2/dlm: return zero if deref_done message is successfully handled

PATCH Superseded xuejiufei 2 participants 2 messages Apr 7, 2016 – Apr 8, 2016 OCFS2

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

xuejiufei

author
#0 lore raw

PATCH v2 1/1 ocfs2/dlm: return zero if deref_done message is successfully handled

Function dlm_deref_lockres_done_handler() should return zero if the message is successfully handled.

---
 fs/ocfs2/dlm/dlmmaster.c | 2 ++
 1 file changed, 2 insertions(+)
fs/ocfs2/dlm/dlmmaster.c +2 -0
index 9aed6e2..13719d3 100644
@@ -2455,6 +2455,8 @@ int dlm_deref_lockres_done_handler(struct o2net_msg *msg, u32 len, void *data,
 
 	spin_unlock(&dlm->spinlock);
 
+	ret = 0;
+
 done:
 	dlm_put(dlm);
 	return ret;
Signature · 1 line
1.8.4.3
#1 lore raw

PATCH v2 1/1 ocfs2/dlm: return zero if deref_done message is successfully handled

Thanks, Jiufei.
We'd better add:

Fixes 60d663cb5273("ocfs2/dlm: add DEREF_DONE message")

Others looks good to me.

Quoted 22 lines · xuejiufei

Function dlm_deref_lockres_done_handler() should return zero if the message is successfully handled.

---
 fs/ocfs2/dlm/dlmmaster.c | 2 ++
 1 file changed, 2 insertions(+)
fs/ocfs2/dlm/dlmmaster.c +2 -0
index 9aed6e2..13719d3 100644
@@ -2455,6 +2455,8 @@ int dlm_deref_lockres_done_handler(struct o2net_msg *msg, u32 len, void *data,
 
 	spin_unlock(&dlm->spinlock);
 
+	ret = 0;
+
 done:
 	dlm_put(dlm);
 	return ret;