Skip to contentSkip to conversation

advsync: Another fix to use latex reference feature consistently

PATCH Applied Akira Yokosawa 3 participants 5 messages Apr 9, 2016 – Apr 12, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 advsync: Another fix to use latex reference feature consistently

Hello,

This is the first time I submit a patch.
I'm not sure the format below is acceptable or not, but just trying. If there is any issue, please advise me.

Regards,

Akira Yokosawa <[email protected]>

-- >8 --
Subject: [PATCH] advsync: Another fix to use latex reference feature consistently

In commit 91bde6aa87c2884f19d2a83534236cdbb319d625, SeongJae Park has made changes to enforce latex reference feature to the references in the Advanced Synchronization chapter. However one of section name direct citations is left unchanged in the commit. This commit fixes the remaining one.

---
 advsync/memorybarriers.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
advsync/memorybarriers.tex +1 -1
index 12771ec..e527def 100644
@@ -1508,7 +1508,7 @@ Read memory barriers imply data dependency barriers, and so can substitute
 for them.
 
 $\dagger$ Note that read barriers should normally be paired with write barriers;
-see the ``SMP barrier pairing'' subsection.
+see Secton~\ref{sec:advsync:SMP Barrier Pairing}.
 
 \paragraph{General Memory Barriers}
 
Signature · 1 line
1.9.1
Acked-by on v1 1/1
#1 lore raw

Hello,

The patch looks good to me. Just FYI, however, I think it would be better to use git format-patch for patch creation because a patch that made with the command can be merged in git repository more easily.

Quoted 41 lines · Akira Yokosawa

Hello,

This is the first time I submit a patch.
I'm not sure the format below is acceptable or not, but just trying. If there is any issue, please advise me.

Regards,

Akira Yokosawa <[email protected]>

-- >8 --
Subject: [PATCH] advsync: Another fix to use latex reference feature consistently

In commit 91bde6aa87c2884f19d2a83534236cdbb319d625, SeongJae Park has made changes to enforce latex reference feature to the references in the Advanced Synchronization chapter. However one of section name direct citations is left unchanged in the commit. This commit fixes the remaining one.

---
advsync/memorybarriers.tex | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
advsync/memorybarriers.tex +0 -0
index 12771ec..e527def 100644
@@ -1508,7 +1508,7 @@ Read memory barriers imply data dependency barriers, and so can substitute

for them.

$\dagger$ Note that read barriers should normally be paired with write barriers;

advsync/memorybarriers.tex +1 -1
-see the ``SMP barrier pairing'' subsection.
+see Secton~\ref{sec:advsync:SMP Barrier Pairing}.

\paragraph{General Memory Barriers}

Signature · 1 line
1.9.1
Acked-by SeongJae Park Applied
#2 lore raw
Quoted 7 lines · SeongJae Park

Hello,

The patch looks good to me. Just FYI, however, I think it would be better to use git format-patch for patch creation because a patch that made with the command can be merged in git repository more easily.

Queued with SeongJae's Acked-by, thank you both.

Akira, in the future, please do use "git format-patch" and also please use the Linux-kernel preferred format for referencing commits, as shown in the updated commit below. The idea is to use the first 12 digits of the SHA-1 commit ID, followed by the subject line in both quotes and parentheses.

Thanx, Paul

Quoted 33 lines · Akira Yokosawa
Quoted 32 lines

Hello,

This is the first time I submit a patch.
I'm not sure the format below is acceptable or not, but just trying. If there is any issue, please advise me.

Regards,

Akira Yokosawa <[email protected]>

-- >8 --
Subject: [PATCH] advsync: Another fix to use latex reference feature consistently

In commit 91bde6aa87c2884f19d2a83534236cdbb319d625, SeongJae Park has made changes to enforce latex reference feature to the references in the Advanced Synchronization chapter. However one of section name direct citations is left unchanged in the commit. This commit fixes the remaining one.

---
advsync/memorybarriers.tex | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
advsync/memorybarriers.tex +0 -0
index 12771ec..e527def 100644
@@ -1508,7 +1508,7 @@ Read memory barriers imply data dependency barriers, and so can substitute

for them.

Quoted 8 lines
Quoted 8 lines

$\dagger$ Note that read barriers should normally be paired with write barriers;

advsync/memorybarriers.tex +1 -1
-see the ``SMP barrier pairing'' subsection.
+see Secton~\ref{sec:advsync:SMP Barrier Pairing}.

\paragraph{General Memory Barriers}

Signature · 1 line
1.9.1

------------------------------------------------------------------------

commit 5795796caa89e7a5720b74a05886ba7c7f897725

Author: Akira Yokosawa <[email protected]>
Date:   Tue Apr 12 08:56:45 2016 -0700

advsync: Another fix to use latex reference feature consistently

In commit 91bde6aa87c2 ("advsync: Use latex reference feature consistently"), SeongJae Park has made changes to enforce latex reference feature to the references in the Advanced Synchronization chapter. However one of section name direct citations is left unchanged in the commit. This commit fixes the remaining one.

advsync/memorybarriers.tex +1 -1
index 12771ec38bee..e527def5b2ea 100644
@@ -1508,7 +1508,7 @@ Read memory barriers imply data dependency barriers, and so can substitute
 for them.
 
 $\dagger$ Note that read barriers should normally be paired with write barriers;
-see the ``SMP barrier pairing'' subsection.
+see Secton~\ref{sec:advsync:SMP Barrier Pairing}.
 
 \paragraph{General Memory Barriers}
 
#3 lore raw

Hi, Paul,

Quoted 5 lines · Paul E. McKenney

Akira, in the future, please do use "git format-patch" and also please use the Linux-kernel preferred format for referencing commits, as shown in the updated commit below. The idea is to use the first 12 digits of the SHA-1 commit ID, followed by the subject line in both quotes and parentheses.

I see. I'll do so in the future.
In fact, I *did* use "git format-patch", but copy & pasted part of the output. I also edited the commit message just before sending it out. I won't do that.

BTW, are you interested in a cosmetic patch which would make Section 14.2.9 "Guarantees" looks much denser by reducing vertical spaces above and below code examples?

If it's worth doing, I'll try tuning them this weekend.

Thanks,

Signature · 1 line
Akira Yokosawa <[email protected]>
#4 lore raw
Quoted 14 lines · Akira Yokosawa

Hi, Paul,

Quoted 5 lines · Paul E. McKenney

Akira, in the future, please do use "git format-patch" and also please use the Linux-kernel preferred format for referencing commits, as shown in the updated commit below. The idea is to use the first 12 digits of the SHA-1 commit ID, followed by the subject line in both quotes and parentheses.

I see. I'll do so in the future.
In fact, I *did* use "git format-patch", but copy & pasted part of the output. I also edited the commit message just before sending it out. I won't do that.

Quoted 5 lines

BTW, are you interested in a cosmetic patch which would make Section 14.2.9 "Guarantees" looks much denser by reducing vertical spaces above and below code examples?

If it's worth doing, I'll try tuning them this weekend.

Please do!

Thanx, Paul