Skip to contentSkip to conversation

iio: mxs-lradc: Move binding document out of staging as well

PATCH In review Harald Geyer 5 participants 7 messages Apr 10, 2016 – Apr 17, 2016 2 messages not in the archive

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: mxs-lradc: Move binding document out of staging as well

commit f836c45922446df872250a12dd08e48978aceb2f moved mxs-lradc driver out of staging. However the binding document was left in the old place.

---
 .../devicetree/bindings/iio/adc/mxs-lradc.txt      | 47 ++++++++++++++++++++++
 .../bindings/staging/iio/adc/mxs-lradc.txt         | 47 ----------------------
 2 files changed, 47 insertions(+), 47 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt
 delete mode 100644 Documentation/devicetree/bindings/staging/iio/adc/mxs-lradc.txt
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +47 -0
new file mode 100644
index 0000000..555fb11
@@ -0,0 +1,47 @@
+* Freescale MXS LRADC device driver
+
+Required properties:
+- compatible: Should be "fsl,imx23-lradc" for i.MX23 SoC and "fsl,imx28-lradc"
+              for i.MX28 SoC
+- reg: Address and length of the register set for the device
+- interrupts: Should contain the LRADC interrupts
+
+Optional properties:
+- fsl,lradc-touchscreen-wires: Number of wires used to connect the touchscreen
+                               to LRADC. Valid value is either 4 or 5. If this
+                               property is not present, then the touchscreen is
+                               disabled. 5 wires is valid for i.MX28 SoC only.
+- fsl,ave-ctrl: number of samples per direction to calculate an average value.
+                Allowed value is 1 ... 32, default is 4
+- fsl,ave-delay: delay between consecutive samples. Allowed value is
+                 2 ... 2048. It is used if 'fsl,ave-ctrl' > 1, counts at
+                 2 kHz and its default is 2 (= 1 ms)
+- fsl,settling: delay between plate switch to next sample. Allowed value is
+                1 ... 2047. It counts at 2 kHz and its default is
+                10 (= 5 ms)
+
+Example for i.MX23 SoC:
+
+	lradc@80050000 {
+		compatible = "fsl,imx23-lradc";
+		reg = <0x80050000 0x2000>;
+		interrupts = <36 37 38 39 40 41 42 43 44>;
+		status = "okay";
+		fsl,lradc-touchscreen-wires = <4>;
+		fsl,ave-ctrl = <4>;
+		fsl,ave-delay = <2>;
+		fsl,settling = <10>;
+	};
+
+Example for i.MX28 SoC:
+
+	lradc@80050000 {
+		compatible = "fsl,imx28-lradc";
+		reg = <0x80050000 0x2000>;
+		interrupts = <10 14 15 16 17 18 19 20 21 22 23 24 25>;
+		status = "okay";
+		fsl,lradc-touchscreen-wires = <5>;
+		fsl,ave-ctrl = <4>;
+		fsl,ave-delay = <2>;
+		fsl,settling = <10>;
+	};
Documentation/devicetree/bindings/staging/iio/adc/mxs-lradc.txt deleted +0 -47

47 lines not on this page · raw message

Signature · 1 line
2.1.4

A message that is not in the archive (sent off-list or not yet received): 1460293398-23654-1-git-send-email-harald-95f8Dae0BrPYtjvyW6yDsg@public.gmane.org

#2 lore raw
Quoted 4 lines · Harald Geyer

commit f836c45922446df872250a12dd08e48978aceb2f moved mxs-lradc driver out of staging. However the binding document was left in the old place.

Oops and thanks!

Applied to the togreg branch of iio.git - initially pushed out as testing so the autobuilders can completely ignore this patch.

Jonathan

Quoted 114 lines
---
 .../devicetree/bindings/iio/adc/mxs-lradc.txt      | 47 ++++++++++++++++++++++
 .../bindings/staging/iio/adc/mxs-lradc.txt         | 47 ----------------------
 2 files changed, 47 insertions(+), 47 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt
 delete mode 100644 Documentation/devicetree/bindings/staging/iio/adc/mxs-lradc.txt
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +47 -0
new file mode 100644
index 0000000..555fb11
@@ -0,0 +1,47 @@
+* Freescale MXS LRADC device driver
+
+Required properties:
+- compatible: Should be "fsl,imx23-lradc" for i.MX23 SoC and "fsl,imx28-lradc"
+              for i.MX28 SoC
+- reg: Address and length of the register set for the device
+- interrupts: Should contain the LRADC interrupts
+
+Optional properties:
+- fsl,lradc-touchscreen-wires: Number of wires used to connect the touchscreen
+                               to LRADC. Valid value is either 4 or 5. If this
+                               property is not present, then the touchscreen is
+                               disabled. 5 wires is valid for i.MX28 SoC only.
+- fsl,ave-ctrl: number of samples per direction to calculate an average value.
+                Allowed value is 1 ... 32, default is 4
+- fsl,ave-delay: delay between consecutive samples. Allowed value is
+                 2 ... 2048. It is used if 'fsl,ave-ctrl' > 1, counts at
+                 2 kHz and its default is 2 (= 1 ms)
+- fsl,settling: delay between plate switch to next sample. Allowed value is
+                1 ... 2047. It counts at 2 kHz and its default is
+                10 (= 5 ms)
+
+Example for i.MX23 SoC:
+
+	lradc@80050000 {
+		compatible = "fsl,imx23-lradc";
+		reg = <0x80050000 0x2000>;
+		interrupts = <36 37 38 39 40 41 42 43 44>;
+		status = "okay";
+		fsl,lradc-touchscreen-wires = <4>;
+		fsl,ave-ctrl = <4>;
+		fsl,ave-delay = <2>;
+		fsl,settling = <10>;
+	};
+
+Example for i.MX28 SoC:
+
+	lradc@80050000 {
+		compatible = "fsl,imx28-lradc";
+		reg = <0x80050000 0x2000>;
+		interrupts = <10 14 15 16 17 18 19 20 21 22 23 24 25>;
+		status = "okay";
+		fsl,lradc-touchscreen-wires = <5>;
+		fsl,ave-ctrl = <4>;
+		fsl,ave-delay = <2>;
+		fsl,settling = <10>;
+	};
Documentation/devicetree/bindings/staging/iio/adc/mxs-lradc.txt deleted +0 -47
deleted file mode 100644
index 555fb11..0000000
@@ -1,47 +0,0 @@
-* Freescale MXS LRADC device driver
-
-Required properties:
-- compatible: Should be "fsl,imx23-lradc" for i.MX23 SoC and "fsl,imx28-lradc"
-              for i.MX28 SoC
-- reg: Address and length of the register set for the device
-- interrupts: Should contain the LRADC interrupts
-
-Optional properties:
-- fsl,lradc-touchscreen-wires: Number of wires used to connect the touchscreen
-                               to LRADC. Valid value is either 4 or 5. If this
-                               property is not present, then the touchscreen is
-                               disabled. 5 wires is valid for i.MX28 SoC only.
-- fsl,ave-ctrl: number of samples per direction to calculate an average value.
-                Allowed value is 1 ... 32, default is 4
-- fsl,ave-delay: delay between consecutive samples. Allowed value is
-                 2 ... 2048. It is used if 'fsl,ave-ctrl' > 1, counts at
-                 2 kHz and its default is 2 (= 1 ms)
-- fsl,settling: delay between plate switch to next sample. Allowed value is
-                1 ... 2047. It counts at 2 kHz and its default is
-                10 (= 5 ms)
-
-Example for i.MX23 SoC:
-
-	lradc@80050000 {
-		compatible = "fsl,imx23-lradc";
-		reg = <0x80050000 0x2000>;
-		interrupts = <36 37 38 39 40 41 42 43 44>;
-		status = "okay";
-		fsl,lradc-touchscreen-wires = <4>;
-		fsl,ave-ctrl = <4>;
-		fsl,ave-delay = <2>;
-		fsl,settling = <10>;
-	};
-
-Example for i.MX28 SoC:
-
-	lradc@80050000 {
-		compatible = "fsl,imx28-lradc";
-		reg = <0x80050000 0x2000>;
-		interrupts = <10 14 15 16 17 18 19 20 21 22 23 24 25>;
-		status = "okay";
-		fsl,lradc-touchscreen-wires = <5>;
-		fsl,ave-ctrl = <4>;
-		fsl,ave-delay = <2>;
-		fsl,settling = <10>;
-	};
#3 lore raw
In reply to a message not in the archive
Quoted 2 lines · Harald Geyer

commit f836c45922446df872250a12dd08e48978aceb2f moved mxs-lradc driver out of staging. However the binding document was left in the old place.

A move out of staging should probably imply a review. Though we don't have clear rules around that for bindings.

Quoted 18 lines
---
 .../devicetree/bindings/iio/adc/mxs-lradc.txt      | 47 ++++++++++++++++++++++
 .../bindings/staging/iio/adc/mxs-lradc.txt         | 47 ----------------------
 2 files changed, 47 insertions(+), 47 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt
 delete mode 100644 Documentation/devicetree/bindings/staging/iio/adc/mxs-lradc.txt
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +3 -0
new file mode 100644
index 0000000..555fb11
@@ -0,0 +1,47 @@
+* Freescale MXS LRADC device driver
+
+Required properties:

Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt line 13

Quoted 10 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +10 -0
+- compatible: Should be "fsl,imx23-lradc" for i.MX23 SoC and "fsl,imx28-lradc"
+              for i.MX28 SoC
+- reg: Address and length of the register set for the device
+- interrupts: Should contain the LRADC interrupts
+
+Optional properties:
+- fsl,lradc-touchscreen-wires: Number of wires used to connect the touchscreen
+                               to LRADC. Valid value is either 4 or 5. If this
+                               property is not present, then the touchscreen is
+                               disabled. 5 wires is valid for i.MX28 SoC only.

Standard touchscreen property?

Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt line 18

Quoted 5 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +5 -0
+- fsl,ave-ctrl: number of samples per direction to calculate an average value.
+                Allowed value is 1 ... 32, default is 4
+- fsl,ave-delay: delay between consecutive samples. Allowed value is
+                 2 ... 2048. It is used if 'fsl,ave-ctrl' > 1, counts at
+                 2 kHz and its default is 2 (= 1 ms)

ditto.

If not, it should have units.

Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt line 21

Quoted 3 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +3 -0
+- fsl,settling: delay between plate switch to next sample. Allowed value is
+                1 ... 2047. It counts at 2 kHz and its default is
+                10 (= 5 ms)

ditto.

Quoted 26 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +26 -0
+
+Example for i.MX23 SoC:
+
+	lradc@80050000 {
+		compatible = "fsl,imx23-lradc";
+		reg = <0x80050000 0x2000>;
+		interrupts = <36 37 38 39 40 41 42 43 44>;
+		status = "okay";
+		fsl,lradc-touchscreen-wires = <4>;
+		fsl,ave-ctrl = <4>;
+		fsl,ave-delay = <2>;
+		fsl,settling = <10>;
+	};
+
+Example for i.MX28 SoC:
+
+	lradc@80050000 {
+		compatible = "fsl,imx28-lradc";
+		reg = <0x80050000 0x2000>;
+		interrupts = <10 14 15 16 17 18 19 20 21 22 23 24 25>;
+		status = "okay";
+		fsl,lradc-touchscreen-wires = <5>;
+		fsl,ave-ctrl = <4>;
+		fsl,ave-delay = <2>;
+		fsl,settling = <10>;
+	};
#4 lore raw

PATCH 1/1 iio: mxs-lradc: Move binding document out of staging as well

Hi,

[added Fabio, Marek and linux-arm-kernel]

Quoted 29 lines · Harald Geyer
Quoted 2 lines

commit f836c45922446df872250a12dd08e48978aceb2f moved mxs-lradc driver out of staging. However the binding document was left in the old place.

A move out of staging should probably imply a review. Though we don't have clear rules around that for bindings.

Quoted 22 lines
---
 .../devicetree/bindings/iio/adc/mxs-lradc.txt      | 47 ++++++++++++++++++++++
 .../bindings/staging/iio/adc/mxs-lradc.txt         | 47 ----------------------
 2 files changed, 47 insertions(+), 47 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt
 delete mode 100644 Documentation/devicetree/bindings/staging/iio/adc/mxs-lradc.txt
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +7 -0
new file mode 100644
index 0000000..555fb11
@@ -0,0 +1,47 @@
+* Freescale MXS LRADC device driver
+
+Required properties:
+- compatible: Should be "fsl,imx23-lradc" for i.MX23 SoC and "fsl,imx28-lradc"
+              for i.MX28 SoC
+- reg: Address and length of the register set for the device
+- interrupts: Should contain the LRADC interrupts
Quoted 8 lines

Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt line 13

Quoted 6 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +6 -0
+
+Optional properties:
+- fsl,lradc-touchscreen-wires: Number of wires used to connect the touchscreen
+                               to LRADC. Valid value is either 4 or 5. If this
+                               property is not present, then the touchscreen is
+                               disabled. 5 wires is valid for i.MX28 SoC only.

Standard touchscreen property?

There is a similiar one in input/touchscreen/ti-tsc-adc.txt with the name ti,wires. But i'm not sure about the others.

Stefan

Quoted 43 lines

Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt line 18

Quoted 6 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +5 -0
+- fsl,ave-ctrl: number of samples per direction to calculate an average value.
+                Allowed value is 1 ... 32, default is 4
+- fsl,ave-delay: delay between consecutive samples. Allowed value is
+                 2 ... 2048. It is used if 'fsl,ave-ctrl' > 1, counts at
+                 2 kHz and its default is 2 (= 1 ms)

ditto.

If not, it should have units.

Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt line 21

Quoted 3 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +3 -0
+- fsl,settling: delay between plate switch to next sample. Allowed value is
+                1 ... 2047. It counts at 2 kHz and its default is
+                10 (= 5 ms)

ditto.

Quoted 26 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +26 -0
+
+Example for i.MX23 SoC:
+
+	lradc at 80050000 {
+		compatible = "fsl,imx23-lradc";
+		reg = <0x80050000 0x2000>;
+		interrupts = <36 37 38 39 40 41 42 43 44>;
+		status = "okay";
+		fsl,lradc-touchscreen-wires = <4>;
+		fsl,ave-ctrl = <4>;
+		fsl,ave-delay = <2>;
+		fsl,settling = <10>;
+	};
+
+Example for i.MX28 SoC:
+
+	lradc at 80050000 {
+		compatible = "fsl,imx28-lradc";
+		reg = <0x80050000 0x2000>;
+		interrupts = <10 14 15 16 17 18 19 20 21 22 23 24 25>;
+		status = "okay";
+		fsl,lradc-touchscreen-wires = <5>;
+		fsl,ave-ctrl = <4>;
+		fsl,ave-delay = <2>;
+		fsl,settling = <10>;
+	};
#5 lore raw
In reply to Rob Herring
Quoted 29 lines · Rob Herring
Quoted 2 lines · Harald Geyer

commit f836c45922446df872250a12dd08e48978aceb2f moved mxs-lradc driver out of staging. However the binding document was left in the old place.

A move out of staging should probably imply a review. Though we don't have clear rules around that for bindings.

Quoted 22 lines
---
 .../devicetree/bindings/iio/adc/mxs-lradc.txt      | 47 ++++++++++++++++++++++
 .../bindings/staging/iio/adc/mxs-lradc.txt         | 47 ----------------------
 2 files changed, 47 insertions(+), 47 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt
 delete mode 100644 Documentation/devicetree/bindings/staging/iio/adc/mxs-lradc.txt
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +7 -0
new file mode 100644
index 0000000..555fb11
@@ -0,0 +1,47 @@
+* Freescale MXS LRADC device driver
+
+Required properties:
+- compatible: Should be "fsl,imx23-lradc" for i.MX23 SoC and "fsl,imx28-lradc"
+              for i.MX28 SoC
+- reg: Address and length of the register set for the device
+- interrupts: Should contain the LRADC interrupts
Quoted 8 lines

Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt line 13

Quoted 6 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +6 -0
+
+Optional properties:
+- fsl,lradc-touchscreen-wires: Number of wires used to connect the touchscreen
+                               to LRADC. Valid value is either 4 or 5. If this
+                               property is not present, then the touchscreen is
+                               disabled. 5 wires is valid for i.MX28 SoC only.

Standard touchscreen property?

Looks quite standard-ish to me indeed. It is my fault for bringing this baggage in back when I wrote the driver, but now that we're moving the driver out of staging, it would make sense to deprecate such properties and use standard ones (if they got fleshed out during that time).

We now have "atmel,adc-ts-wires" , "ti,wires" , "fsl,lradc-touchscreen-wires" , so some sort of pattern is developing here.

Quoted 9 lines

Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt line 18

Quoted 5 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +5 -0
+- fsl,ave-ctrl: number of samples per direction to calculate an average value.
+                Allowed value is 1 ... 32, default is 4
+- fsl,ave-delay: delay between consecutive samples. Allowed value is
+                 2 ... 2048. It is used if 'fsl,ave-ctrl' > 1, counts at
+                 2 kHz and its default is 2 (= 1 ms)

ditto.

If not, it should have units.

Agreed, this is standard ADC sampling frequency I think.

Quoted 37 lines

Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt line 21

Quoted 3 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +3 -0
+- fsl,settling: delay between plate switch to next sample. Allowed value is
+                1 ... 2047. It counts at 2 kHz and its default is
+                10 (= 5 ms)

ditto.

Quoted 16 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +16 -0
+
+Example for i.MX23 SoC:
+
+	lradc@80050000 {
+		compatible = "fsl,imx23-lradc";
+		reg = <0x80050000 0x2000>;
+		interrupts = <36 37 38 39 40 41 42 43 44>;
+		status = "okay";
+		fsl,lradc-touchscreen-wires = <4>;
+		fsl,ave-ctrl = <4>;
+		fsl,ave-delay = <2>;
+		fsl,settling = <10>;
+	};
+
+Example for i.MX28 SoC:
+

Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt line 47

Quoted 10 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +10 -0
+	lradc@80050000 {
+		compatible = "fsl,imx28-lradc";
+		reg = <0x80050000 0x2000>;
+		interrupts = <10 14 15 16 17 18 19 20 21 22 23 24 25>;
+		status = "okay";
+		fsl,lradc-touchscreen-wires = <5>;
+		fsl,ave-ctrl = <4>;
+		fsl,ave-delay = <2>;
+		fsl,settling = <10>;
+	};

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 6 lines
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#7 lore raw
Quoted 10 lines · Marek Vasut
Quoted 9 lines · Rob Herring
Quoted 2 lines · Harald Geyer

commit f836c45922446df872250a12dd08e48978aceb2f moved mxs-lradc driver out of staging. However the binding document was left in the old place.

A move out of staging should probably imply a review. Though we don't have clear rules around that for bindings.

Quoted 2 lines

cc'ing Dmitry and linux-input.

Quoted 43 lines
Quoted 20 lines
Quoted 20 lines
---
 .../devicetree/bindings/iio/adc/mxs-lradc.txt      | 47 ++++++++++++++++++++++
 .../bindings/staging/iio/adc/mxs-lradc.txt         | 47 ----------------------
 2 files changed, 47 insertions(+), 47 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt
 delete mode 100644 Documentation/devicetree/bindings/staging/iio/adc/mxs-lradc.txt
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +7 -0
new file mode 100644
index 0000000..555fb11
@@ -0,0 +1,47 @@
+* Freescale MXS LRADC device driver
+
+Required properties:
+- compatible: Should be "fsl,imx23-lradc" for i.MX23 SoC and "fsl,imx28-lradc"
+              for i.MX28 SoC
+- reg: Address and length of the register set for the device
+- interrupts: Should contain the LRADC interrupts
Quoted 8 lines

Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt line 13

Quoted 6 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +6 -0
+
+Optional properties:
+- fsl,lradc-touchscreen-wires: Number of wires used to connect the touchscreen
+                               to LRADC. Valid value is either 4 or 5. If this
+                               property is not present, then the touchscreen is
+                               disabled. 5 wires is valid for i.MX28 SoC only.

Standard touchscreen property?

Looks quite standard-ish to me indeed. It is my fault for bringing this baggage in back when I wrote the driver, but now that we're moving the driver out of staging, it would make sense to deprecate such properties and use standard ones (if they got fleshed out during that time).

We now have "atmel,adc-ts-wires" , "ti,wires" , "fsl,lradc-touchscreen-wires" , so some sort of pattern is developing here.

Quoted 6 lines
Quoted 5 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +5 -0
+- fsl,ave-ctrl: number of samples per direction to calculate an average value.
+                Allowed value is 1 ... 32, default is 4
+- fsl,ave-delay: delay between consecutive samples. Allowed value is
+                 2 ... 2048. It is used if 'fsl,ave-ctrl' > 1, counts at
+                 2 kHz and its default is 2 (= 1 ms)
Quoted 45 lines
Quoted 3 lines

ditto.

If not, it should have units.

Agreed, this is standard ADC sampling frequency I think.

Quoted 37 lines

Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt line 21

Quoted 3 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +3 -0
+- fsl,settling: delay between plate switch to next sample. Allowed value is
+                1 ... 2047. It counts at 2 kHz and its default is
+                10 (= 5 ms)

ditto.

Quoted 16 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +16 -0
+
+Example for i.MX23 SoC:
+
+	lradc@80050000 {
+		compatible = "fsl,imx23-lradc";
+		reg = <0x80050000 0x2000>;
+		interrupts = <36 37 38 39 40 41 42 43 44>;
+		status = "okay";
+		fsl,lradc-touchscreen-wires = <4>;
+		fsl,ave-ctrl = <4>;
+		fsl,ave-delay = <2>;
+		fsl,settling = <10>;
+	};
+
+Example for i.MX28 SoC:
+

Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt line 47

Quoted 10 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +10 -0
+	lradc@80050000 {
+		compatible = "fsl,imx28-lradc";
+		reg = <0x80050000 0x2000>;
+		interrupts = <10 14 15 16 17 18 19 20 21 22 23 24 25>;
+		status = "okay";
+		fsl,lradc-touchscreen-wires = <5>;
+		fsl,ave-ctrl = <4>;
+		fsl,ave-delay = <2>;
+		fsl,settling = <10>;
+	};

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#8 lore raw
In reply to Rob Herring
Quoted 6 lines · Rob Herring
Quoted 2 lines · Harald Geyer

commit f836c45922446df872250a12dd08e48978aceb2f moved mxs-lradc driver out of staging. However the binding document was left in the old place.

A move out of staging should probably imply a review. Though we don't have clear rules around that for bindings.

Sorry, my bad. We kind of forgot this even had bindings during the review. It sat in staging a long time on the basis we ideally were going to split the touchscreen and IIO bits round an mfd. Eventually it became clear no one was going to work on it so we agreed with Dmitry that it could go out of staging as is. Original bindings were back in 2012 so before the whole devicetree binding maintainership really got going (IIRC).

Will make sure to insist on a device tree binding review opportunity at
least in future! We'll have to keep what is here as there are doubtless
a number of device trees out there using it, but we can of course deprecate them and add additional new bindings.

Jonathan

Quoted 70 lines
Quoted 19 lines
---
 .../devicetree/bindings/iio/adc/mxs-lradc.txt      | 47 ++++++++++++++++++++++
 .../bindings/staging/iio/adc/mxs-lradc.txt         | 47 ----------------------
 2 files changed, 47 insertions(+), 47 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt
 delete mode 100644 Documentation/devicetree/bindings/staging/iio/adc/mxs-lradc.txt
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +3 -0
new file mode 100644
index 0000000..555fb11
@@ -0,0 +1,47 @@
+* Freescale MXS LRADC device driver
+
+Required properties:

Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt line 13

Quoted 10 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +10 -0
+- compatible: Should be "fsl,imx23-lradc" for i.MX23 SoC and "fsl,imx28-lradc"
+              for i.MX28 SoC
+- reg: Address and length of the register set for the device
+- interrupts: Should contain the LRADC interrupts
+
+Optional properties:
+- fsl,lradc-touchscreen-wires: Number of wires used to connect the touchscreen
+                               to LRADC. Valid value is either 4 or 5. If this
+                               property is not present, then the touchscreen is
+                               disabled. 5 wires is valid for i.MX28 SoC only.

Standard touchscreen property?

Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt line 18

Quoted 5 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +5 -0
+- fsl,ave-ctrl: number of samples per direction to calculate an average value.
+                Allowed value is 1 ... 32, default is 4
+- fsl,ave-delay: delay between consecutive samples. Allowed value is
+                 2 ... 2048. It is used if 'fsl,ave-ctrl' > 1, counts at
+                 2 kHz and its default is 2 (= 1 ms)

ditto.

If not, it should have units.

Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt line 21

Quoted 3 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +3 -0
+- fsl,settling: delay between plate switch to next sample. Allowed value is
+                1 ... 2047. It counts at 2 kHz and its default is
+                10 (= 5 ms)

ditto.

Quoted 22 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +22 -0
+
+Example for i.MX23 SoC:
+
+	lradc@80050000 {
+		compatible = "fsl,imx23-lradc";
+		reg = <0x80050000 0x2000>;
+		interrupts = <36 37 38 39 40 41 42 43 44>;
+		status = "okay";
+		fsl,lradc-touchscreen-wires = <4>;
+		fsl,ave-ctrl = <4>;
+		fsl,ave-delay = <2>;
+		fsl,settling = <10>;
+	};
+
+Example for i.MX28 SoC:
+
+	lradc@80050000 {
+		compatible = "fsl,imx28-lradc";
+		reg = <0x80050000 0x2000>;
+		interrupts = <10 14 15 16 17 18 19 20 21 22 23 24 25>;
+		status = "okay";
+		fsl,lradc-touchscreen-wires = <5>;
Quoted 9 lines

Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt line 34

Quoted 4 lines
Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt new file +4 -0
+		fsl,ave-ctrl = <4>;
+		fsl,ave-delay = <2>;
+		fsl,settling = <10>;
+	};

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html